xzel23 commented on PR #690:
URL: https://github.com/apache/poi/pull/690#issuecomment-2343018665
I think we should wait for log4j 2.24.1 which will probably released two
weeks from now since 2.24.0 breaks modularized applications. See
https://github.com/apache/logging-log4j2/issues/2929 for
dependabot[bot] opened a new pull request, #690:
URL: https://github.com/apache/poi/pull/690
Bumps `log4jVersion` from 2.23.1 to 2.24.0.
Updates `org.apache.logging.log4j:log4j-core` from 2.23.1 to 2.24.0
Updates `org.apache.logging.log4j:log4j-api` from 2.23.1 to 2.24.0
Upda
dependabot[bot] commented on PR #689:
URL: https://github.com/apache/poi/pull/689#issuecomment-2332174154
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
asfgit closed pull request #689: Bump com.github.spotbugs from 6.0.19 to 6.0.22
URL: https://github.com/apache/poi/pull/689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dependabot[bot] closed pull request #688: Bump com.github.spotbugs from 6.0.19
to 6.0.21
URL: https://github.com/apache/poi/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dependabot[bot] opened a new pull request, #688:
URL: https://github.com/apache/poi/pull/688
Bumps com.github.spotbugs from 6.0.19 to 6.0.21.
[ from
1.15.0 to 1.15.1.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-bud
dependabot[bot] opened a new pull request, #686:
URL: https://github.com/apache/poi/pull/686
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.15.0 to 1.15.1.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:by
dependabot[bot] opened a new pull request, #685:
URL: https://github.com/apache/poi/pull/685
Bumps org.apache.ant:ant from 1.10.14 to 1.10.15.
[ from
4.11.0 to 5.13.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core
pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2313307233
Thanks @str4danya - I merged most of what was in your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #681:
URL: https://github.com/apache/poi/pull/681#issuecomment-2313255793
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #680:
URL: https://github.com/apache/poi/pull/680#issuecomment-2313255802
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
asfgit closed pull request #681: Bump net.bytebuddy:byte-buddy from 1.14.19 to
1.15.0
URL: https://github.com/apache/poi/pull/681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
asfgit closed pull request #680: Bump net.bytebuddy:byte-buddy-agent from
1.14.19 to 1.15.0
URL: https://github.com/apache/poi/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
asfgit closed pull request #682: CellUtil constants to enum - CellPropertyType
URL: https://github.com/apache/poi/pull/682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733325952
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733325366
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733278057
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -461,70 +611,93 @@ private static boolean styleMapsMatch(final Map newProps,
* same style.
*
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733276730
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -381,31 +498,64 @@ public static void setFont(Cell cell, Font font) {
*
*
* @param cell
str4danya commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733276465
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
str4danya commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733275169
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733275138
##
poi/src/main/java/org/apache/poi/ss/usermodel/CellPropertyType.java:
##
@@ -0,0 +1,63 @@
+/*
+ Lic
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733274823
##
poi/src/main/java/org/apache/poi/ss/usermodel/CellPropertyCategory.java:
##
@@ -0,0 +1,30 @@
+/*
+
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733273831
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733273063
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733161230
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -850,22 +1019,22 @@ public static Cell translateUnicodeValues(Cell cell) {
}
static {
-
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733159282
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -302,40 +398,38 @@ public static void copyCell(Cell srcCell, Cell destCell,
CellCopyPolicy policy,
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733157631
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -302,40 +398,38 @@ public static void copyCell(Cell srcCell, Cell destCell,
CellCopyPolicy policy,
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733154710
##
poi-ooxml/src/test/java/org/apache/poi/ss/tests/util/TestXSSFCellUtil.java:
##
@@ -90,6 +127,42 @@ public void testSetForegroundColorCellStylePropertyToNull()
throws IO
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733152647
##
poi-ooxml/src/test/java/org/apache/poi/ss/tests/util/TestXSSFCellUtil.java:
##
@@ -19,22 +19,15 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312953033
Ok - thanks. I'll look at this again but for now, if type erasure stops you
adding overloading methods - then create methods with slightly different names
for the cases where you want to use
str4danya commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312921004
Hello, I hadn't thought of that.
I have reverted the support for CellUtils constants. The tests have also
been edited, duplicating the tests for CellUtils and CellPropertyType.
Look at
pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312065256
Thanks but we could not accept this PR in its current form. In Apache POI,
we never remove code without first deprecating it. You have removed lots of
CellUtil code. This would need to be ret
str4danya opened a new pull request, #682:
URL: https://github.com/apache/poi/pull/682
CellUtil class constants have been replaced by Enum. Added CellUtilProperty
enum, changed all references from CellUtil constants to CellUtilProperty enums.
Reason: comment “FIXME: Move these constants t
dependabot[bot] opened a new pull request, #681:
URL: https://github.com/apache/poi/pull/681
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.14.19 to 1.15.0.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-bu
dependabot[bot] opened a new pull request, #680:
URL: https://github.com/apache/poi/pull/680
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.14.19 to 1.15.0.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b
pjfanning commented on PR #657:
URL: https://github.com/apache/poi/pull/657#issuecomment-2301835846
merged with
https://github.com/apache/poi/commit/41453f3916fefd469cfa554dcb5ca069d221b331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
pjfanning closed pull request #657: SXSSF: support setting an arbitrary extra
width value for column widths
URL: https://github.com/apache/poi/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dependabot[bot] commented on PR #678:
URL: https://github.com/apache/poi/pull/678#issuecomment-2299268930
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #675:
URL: https://github.com/apache/poi/pull/675#issuecomment-2299268885
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #676:
URL: https://github.com/apache/poi/pull/676#issuecomment-2299268873
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #679:
URL: https://github.com/apache/poi/pull/679#issuecomment-2299268909
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #677:
URL: https://github.com/apache/poi/pull/677#issuecomment-2299268851
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
asfgit closed pull request #678: Bump org.cyclonedx.bom from 1.9.0 to 1.10.0
URL: https://github.com/apache/poi/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
asfgit closed pull request #679: Bump org.apache.commons:commons-compress from
1.27.0 to 1.27.1
URL: https://github.com/apache/poi/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
asfgit closed pull request #676: Bump net.bytebuddy:byte-buddy from 1.14.18 to
1.14.19
URL: https://github.com/apache/poi/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
asfgit closed pull request #677: Bump com.google.guava:guava from 33.2.1-jre to
33.3.0-jre
URL: https://github.com/apache/poi/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
asfgit closed pull request #675: Bump net.bytebuddy:byte-buddy-agent from
1.14.18 to 1.14.19
URL: https://github.com/apache/poi/pull/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #679:
URL: https://github.com/apache/poi/pull/679
Bumps org.apache.commons:commons-compress from 1.27.0 to 1.27.1.
[ from
33.2.1-jre to 33.3.0-jre.
Release notes
Sourced from https://github.com/google/guava/releases";>com.google.guava:guava's
dependabot[bot] opened a new pull request, #676:
URL: https://github.com/apache/poi/pull/676
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.14.18 to 1.14.19.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-b
dependabot[bot] opened a new pull request, #675:
URL: https://github.com/apache/poi/pull/675
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.14.18 to 1.14.19.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:
asfgit closed pull request #673: XWPF: generate classes for word10 xsds
URL: https://github.com/apache/poi/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
fangd1997 commented on code in PR #673:
URL: https://github.com/apache/poi/pull/673#discussion_r1719701417
##
poi-ooxml-full/src/main/xmlschema/org/apache/poi/schemas/OfficeOpenXML-XMLSchema-Transitional.zip:
##
Review Comment:
I did not remove this file, I just modified wm
fangd1997 commented on code in PR #673:
URL: https://github.com/apache/poi/pull/673#discussion_r1719701417
##
poi-ooxml-full/src/main/xmlschema/org/apache/poi/schemas/OfficeOpenXML-XMLSchema-Transitional.zip:
##
Review Comment:
I did not remove this file, I modified wml.xsd
fangd1997 commented on PR #674:
URL: https://github.com/apache/poi/pull/674#issuecomment-2293305314
Okay, I will close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
fangd1997 closed pull request #674: XWPF: improve XWPFSDT
URL: https://github.com/apache/poi/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
pjfanning commented on code in PR #673:
URL: https://github.com/apache/poi/pull/673#discussion_r1719674628
##
poi-ooxml-full/src/main/xmlschema/org/apache/poi/schemas/OfficeOpenXML-XMLSchema-Transitional.zip:
##
Review Comment:
why is this being removed?
--
This is an a
pjfanning commented on PR #674:
URL: https://github.com/apache/poi/pull/674#issuecomment-2293265756
This breaks backward compatibility. I can not consider merging this without
a detailed description of why we need to break compatibility.
This approach of raising loads of PRs but not r
pjfanning commented on PR #672:
URL: https://github.com/apache/poi/pull/672#issuecomment-2292071072
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
asfgit closed pull request #672: XWPF: support removing style by pos and
getting all XWPFStyle list
URL: https://github.com/apache/poi/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
fangd1997 opened a new pull request, #673:
URL: https://github.com/apache/poi/pull/673
@pjfanning
support http://schemas.microsoft.com/office/word/2010/wordml
FYI：https://learn.microsoft.com/en-us/openspecs/office_standards/ms-docx/9704b59f-bc49-4618-ac66-41beb82a0d7f
modified wml.
fangd1997 opened a new pull request, #672:
URL: https://github.com/apache/poi/pull/672
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pjfanning commented on PR #670:
URL: https://github.com/apache/poi/pull/670#issuecomment-2289446914
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
dependabot[bot] commented on PR #671:
URL: https://github.com/apache/poi/pull/671#issuecomment-2289428912
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by addin
asfgit closed pull request #671: Bump junitVersion from 5.10.3 to 5.11.0
URL: https://github.com/apache/poi/pull/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
asfgit closed pull request #670: XWPF: fix _getText in XWPFRun(ignore
w:delInstrText, convert w:noBreakHyphen to "‑")
URL: https://github.com/apache/poi/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dependabot[bot] opened a new pull request, #671:
URL: https://github.com/apache/poi/pull/671
Bumps `junitVersion` from 5.10.3 to 5.11.0.
Updates `org.junit.jupiter:junit-jupiter` from 5.10.3 to 5.11.0
Release notes
Sourced from https://github.com/junit-team/junit5/releases";>org.
fangd1997 commented on code in PR #670:
URL: https://github.com/apache/poi/pull/670#discussion_r1716995491
##
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java:
##
@@ -1564,6 +1564,9 @@ private void _getText(XmlObject o, StringBuilder text) {
final
pjfanning commented on code in PR #670:
URL: https://github.com/apache/poi/pull/670#discussion_r1716877850
##
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java:
##
@@ -1564,6 +1564,9 @@ private void _getText(XmlObject o, StringBuilder text) {
final
fangd1997 commented on PR #670:
URL: https://github.com/apache/poi/pull/670#issuecomment-2285123652
[TestNoBreakHyphenAndDelInstrText.docx](https://github.com/user-attachments/files/16592924/TestNoBreakHyphenAndDelInstrText.docx)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asfgit closed pull request #667: Bump org.apache.commons:commons-compress from
1.26.2 to 1.27.0
URL: https://github.com/apache/poi/pull/667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] commented on PR #669:
URL: https://github.com/apache/poi/pull/669#issuecomment-2278272457
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #667:
URL: https://github.com/apache/poi/pull/667#issuecomment-2278272441
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #668:
URL: https://github.com/apache/poi/pull/668#issuecomment-2278272419
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
asfgit closed pull request #669: Bump org.apache.pdfbox:pdfbox from 3.0.2 to
3.0.3
URL: https://github.com/apache/poi/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit closed pull request #668: Bump com.github.spotbugs from 6.0.19 to 6.0.20
URL: https://github.com/apache/poi/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dependabot[bot] opened a new pull request, #669:
URL: https://github.com/apache/poi/pull/669
Bumps org.apache.pdfbox:pdfbox from 3.0.2 to 3.0.3.
[