Review Request 60061: Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.

2017-06-13 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60061/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige

[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.

2017-06-13 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Attachment: 0001-RANGER-1641-Like-security-admin-and-usersync-the-kms.patch > Like security admin a

[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.

2017-06-13 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Summary: Like security admin and usersync, the kms installer should chech whether the user group ex

[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.

2017-06-13 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Description: Like security admin and usersync, the kms installer should chech whether the user grou

[jira] [Created] (RANGER-1641) Like security admin, the kms installer should chech whether the user group exists before creating the user group.

2017-06-13 Thread Qiang Zhang (JIRA)
Qiang Zhang created RANGER-1641: --- Summary: Like security admin, the kms installer should chech whether the user group exists before creating the user group. Key: RANGER-1641 URL: https://issues.apache.org/jira/brows

[jira] [Resolved] (RANGER-1636) Remove the pmd check error

2017-06-13 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1636. - Resolution: Fixed Fix Version/s: 1.0.0 > Remove the pmd check error >

Re: Review Request 60032: Remove the pmd check error

2017-06-13 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60032/#review177858 --- Ship it! Ship It! - Qiang Zhang On 六月 13, 2017, 4:36 a.m., p

Re: Review Request 60046: RANGER-1640 - HBase Test Connection does not work when creating a service

2017-06-13 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60046/#review177857 --- Ship it! Ship It! - Qiang Zhang On 六月 13, 2017, 12:10 p.m.,

[jira] [Commented] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047800#comment-16047800 ] Ankita Sinha commented on RANGER-1582: -- Committed to ranger-0.7 : https://github.co

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote: > > Ship It! Actually, is it feasible to add some unit tests for this? - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177731 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 12

[jira] [Commented] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047786#comment-16047786 ] Ankita Sinha commented on RANGER-1582: -- Committed to master : https://github.com/ap

Review Request 60046: RANGER-1640 - HBase Test Connection does not work when creating a service

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60046/ --- Review request for ranger. Bugs: RANGER-1640 https://issues.apache.org/jira

[jira] [Updated] (RANGER-1640) HBase Test Connection does not work when creating a service

2017-06-13 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1640: Attachment: 0001-RANGER-1640-HBase-Test-Connection-does-not-work-when.patch > HBase

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- (Updated June 13, 2017, 12:06 p.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
- Ankita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > >

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
> On June 13, 2017, 10:31 a.m., Colm O hEigeartaigh wrote: > > Instead of calling Pattern.compile for each check, it's better to make the > > Pattern static + call Pattern.compile once, as the regex itself is static > > and doesn't change. Thanks, Updated the review request. - Ankita -

[jira] [Created] (RANGER-1640) HBase Test Connection does not work when creating a service

2017-06-13 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created RANGER-1640: --- Summary: HBase Test Connection does not work when creating a service Key: RANGER-1640 URL: https://issues.apache.org/jira/browse/RANGER-1640 Project: Ra

[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: RANGER-1639.patch > Ranger KMS should validate key name before importing into DB > --

[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: (was: RANGER-1639.patch) > Ranger KMS should validate key name before importing i

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177727 --- Ship it! Ship It! - Velmurugan Periasamy On June 13, 2017, 9

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177726 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 9:

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- Instead of calling Pattern.compile for each check, it's better to

Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: RANGER-1639.patch > Ranger KMS should validate key name before importing into DB > --

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha
> On June 13, 2017, 8:49 a.m., Colm O hEigeartaigh wrote: > > Please put curly brackets around the two one-line if statements: > > if(LOG.isDebugEnabled()) Thanks, updated with the suggested changes. - Ankita --- This is an automatical

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/ --- (Updated June 13, 2017, 9:55 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 60032: Remove the pmd check error

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60032/#review177717 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 4:

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1582: - Attachment: RANGER-1582.patch > Support KNOX SSO Token based authentication on Ranger REST API ca

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1582: - Attachment: (was: RANGER-1582.patch) > Support KNOX SSO Token based authentication on Ranger

[jira] [Created] (RANGER-1639) Ranger KMS should validate key name before importing into DB

2017-06-13 Thread Ankita Sinha (JIRA)
Ankita Sinha created RANGER-1639: Summary: Ranger KMS should validate key name before importing into DB Key: RANGER-1639 URL: https://issues.apache.org/jira/browse/RANGER-1639 Project: Ranger

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177715 --- Please put curly brackets around the two one-line if statements:

Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan