On 17 July 2014 17:43, Igor Vaynberg wrote:
> On Thu, Jul 17, 2014 at 9:08 AM, Garret Wilson
> wrote:
> > On 7/17/2014 8:25 AM, Martin Grigorov wrote:
> >>
> >> ...
> >>
> >> For some reason this feature doesn't seem that usable to me...
> >
> >
> > Could you be more specific about why you don't
Sweet! I hope you share your slides (and maybe even recorded video?) with
the world!
On Thu, Jul 17, 2014 at 4:53 PM, Martijn Dashorst <
martijn.dasho...@gmail.com> wrote:
> All,
>
> I was just notified that my 3 proposals for presentations about Wicket
> were accepted. Apparently I have some wo
All,
I was just notified that my 3 proposals for presentations about Wicket
were accepted. Apparently I have some work to do...
My proposals are below.
Hope to see you there!
Martijn
Apache Wicket: 10 years and beyond
With the Tenth Anniversary of Wicket behind us, Wicket is still one of
the
On Thu, Jul 17, 2014 at 9:08 AM, Garret Wilson wrote:
> On 7/17/2014 8:25 AM, Martin Grigorov wrote:
>>
>> ...
>>
>> For some reason this feature doesn't seem that usable to me...
>
>
> Could you be more specific about why you don't find this feature doesn't
> seem useful? None of your comments be
On 7/17/2014 8:25 AM, Martin Grigorov wrote:
...
For some reason this feature doesn't seem that usable to me...
Could you be more specific about why you don't find this feature doesn't
seem useful? None of your comments below were about the feature
itself---they were about ancillary implement
Hi,
IMHO this proposal is very easy to implement and use by specialized
projects (e.g. wicket-pure-css).
I don't see how Wicket itself would benefit from the code:
It's just IComponentInstantiationListeners - anything more probably
won't work for all use-cases anyway.
Regards
Sven
On 07/1
You spotted me :)! I could also use pmd rules to make it clear from the
start:
http://pmd.sourceforge.net/pmd-4.3/rules/design.html#AvoidDeeplyNestedIfStmts
You just removed two pairs of curly braces (to turn 'else { if {} }'
into 'else if {}') and re-indented the code?
“The truth is rarely p
You just removed two pairs of curly braces (to turn 'else { if {} }'
into 'else if {}') and re-indented the code?
“The truth is rarely pure and never simple.” ― Oscar Wilde
On Thu, Jul 17, 2014 at 11:53 AM, Andrea Del Bene wrote:
> I admit I've changed a very sensible part of the code :), howeve
OK. Thanks!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Jul 17, 2014 at 5:53 PM, Andrea Del Bene
wrote:
> I admit I've changed a very sensible part of the code :), however after
> working with it I realized that we could reduce its complexity removing
I admit I've changed a very sensible part of the code :), however after
working with it I realized that we could reduce its complexity removing
a couple of nesting levels "merging" them in the outer if...else block.
I think this improve code quality and its readability. Let me explain
you what
what is/was useless ?
now I am even more confused what your "beautification" did with this really
important and fragile part of Wicket code :-)
I'm not saying that the new code is badly formatted. I was asking whether
"beautification" really means "code formatting"
Martin Grigorov
Wicket Training
Method respond had high level of "if...else" nesting, a couple of them
useless. in which way the new code doesn't respect Wicket's code format?
Maybe my IDE did something wrong.
Hi Andrea,
On Wed, Jul 16, 2014 at 8:33 PM, wrote:
Repository: wicket
Updated Branches:
refs/heads/master c24
Hi,
For some reason this feature doesn't seem that usable to me... Maybe other
devs and users will like it...
See some comments from me inline:
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sun, Jul 13, 2014 at 3:21 AM, Garret Wilson
wrote:
> On 7/12/2014 3
On Thu, Jul 17, 2014 at 1:09 PM, Martin Grigorov wrote:
> The main problem I see with this is that we cannot cover all possible names.
> 1) It is possible to create custom HTML elements in JavaScript. So the list
> of names should be easy to extend
+1
> 2) with Web Components standard custom nam
Not a Java or Wicket article, but interesting nonetheless:
http://inessential.com/2014/07/14/string_constants
I'm not a big fan of putting everything in constants in a central
location. We won't be changing an anchor tag from a to anchor across
all code in Wicket, ever.
There has to be a benefit
Hi Andrea,
On Wed, Jul 16, 2014 at 8:33 PM, wrote:
> Repository: wicket
> Updated Branches:
> refs/heads/master c24d830cd -> bb9c1044e
>
>
> Code beautifying: method WebPageRenderer.respond
>
What exactly "beautifying" means ?
It is a bit hard to see what is the actual change. It doesn't look
Hi,
The main problem I see with this is that we cannot cover all possible names.
1) It is possible to create custom HTML elements in JavaScript. So the list
of names should be easy to extend
2) with Web Components standard custom names are used even more often
3) and yes, some users use Wicket to
Hi Peter,
I'm glad to see you again here!
Are you sure that Clirr has problems ?
BuildBot has failed with the JS tests because we use hardcoded value of the
port where NodeJS's connect server binds to.
master branch acquired the port and wicket-6.x failed to bind it.
I think your change is OK but
The build passes here.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Jul 17, 2014 at 1:49 PM, Martin Grigorov
wrote:
> Hi Peter,
> I'm glad to see you again here!
>
> Are you sure that Clirr has problems ?
> BuildBot has failed with the JS tests because
19 matches
Mail list logo
