Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-19 Thread Martin Grigorov
Thanks! I've created https://issues.apache.org/jira/browse/WICKET-6229 to track it! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Aug 19, 2016 at 8:06 AM, Pedro Santos wrote: > +1 > > Pedro Santos > > On Thu, Aug 18, 2016 at 7:56

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-19 Thread Pedro Santos
+1 Pedro Santos On Thu, Aug 18, 2016 at 7:56 AM, Andrea Del Bene wrote: > +1 for me too > > > > On 18/08/2016 00:47, Martijn Dashorst wrote: > >> Sounds good to me >> >> Martijn >> >> On Wednesday, 17 August 2016, Martin Grigorov >> wrote: >> >> Hi,

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-18 Thread Andrea Del Bene
+1 for me too On 18/08/2016 00:47, Martijn Dashorst wrote: Sounds good to me Martijn On Wednesday, 17 August 2016, Martin Grigorov wrote: Hi, What do you think on adding a new setting to ExceptionSettings that says whether to log a WARN (default, as it does now) or

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Martijn Dashorst
Sounds good to me Martijn On Wednesday, 17 August 2016, Martin Grigorov wrote: > Hi, > > What do you think on adding a new setting to ExceptionSettings that says > whether to log a WARN (default, as it does now) or to throw exception when >

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Sebastien
+1 too On Aug 17, 2016 21:24, "Carl-Eric Menzel" wrote: > +1 for that. > > On Wed, 17 Aug 2016 14:59:03 +0700 > Maxim Solodovnik wrote: > > > +1 for "throw an exception in DEV mode and log a WARN in PROD mode" > > > > On Wed, Aug 17, 2016 at 2:56

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Carl-Eric Menzel
+1 for that. On Wed, 17 Aug 2016 14:59:03 +0700 Maxim Solodovnik wrote: > +1 for "throw an exception in DEV mode and log a WARN in PROD mode" > > On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov > wrote: > > > Hi, > > > > What do you think on

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Sven Meier
+1 Sven On 17.08.2016 09:59, Maxim Solodovnik wrote: +1 for "throw an exception in DEV mode and log a WARN in PROD mode" On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov wrote: Hi, What do you think on adding a new setting to ExceptionSettings that says whether to

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Maxim Solodovnik
+1 for "throw an exception in DEV mode and log a WARN in PROD mode" On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov wrote: > Hi, > > What do you think on adding a new setting to ExceptionSettings that says > whether to log a WARN (default, as it does now) or to throw

Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Martin Grigorov
Hi, What do you think on adding a new setting to ExceptionSettings that says whether to log a WARN (default, as it does now) or to throw exception when setOutputMarkupId/setOutputMarkupPlaceholderTag() are used on component with #setRenderBodyOnly(true) or attached to ? I've had few occasions