Failed: ZOOKEEPER- PreCommit Build #50

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/50/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 120 lines...] [exec] ===

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646614#comment-15646614 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user hanm commented on t

[GitHub] zookeeper issue #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/102 Updated PR to address review comments from @breed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

ZooKeeper-trunk-WinVS2008 - Build # 2318 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2318/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78 lines...] ivy-retrieve: [ivy:retrieve] :: Apa

[jira] [Commented] (ZOOKEEPER-1816) ClientCnxn.close() should block until threads have died

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646422#comment-15646422 ] Hadoop QA commented on ZOOKEEPER-1816: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-1816 PreCommit Build #3529

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1816 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3529/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Updated] (ZOOKEEPER-1816) ClientCnxn.close() should block until threads have died

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wu wen updated ZOOKEEPER-1816: -- Attachment: ZOOKEEPER-1816.patch > ClientCnxn.close() should block until threads have died > ---

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646038#comment-15646038 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user hanm commented on a

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86905174 --- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java --- @@ -93,6 +93,14 @@ public static void generateFile(File outputDir, Version version,

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646036#comment-15646036 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user hanm commented on a

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86905102 --- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java --- @@ -61,70 +61,88 @@ void genCode() throws IOException { + out

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86903124 --- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java --- @@ -93,6 +93,14 @@ public static void generateFile(File outputDir, Version version,

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646022#comment-15646022 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user breed commented on

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86902626 --- Diff: src/java/main/org/apache/zookeeper/cli/DeleteCommand.java --- @@ -59,11 +59,6 @@ private void retainCompatibility(String[] cmdArgs) throws CliParse

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646023#comment-15646023 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user breed commented on

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86902396 --- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java --- @@ -61,70 +61,88 @@ void genCode() throws IOException { + ou

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646021#comment-15646021 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2462) force authentication/authorization

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646005#comment-15646005 ] Michael Han commented on ZOOKEEPER-2462: I think this and ZOOKEEPER-1634 is tr

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646001#comment-15646001 ] Hadoop QA commented on ZOOKEEPER-2549: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2549 PreCommit Build #3528

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2549 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3528/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645990#comment-15645990 ] Michael Han commented on ZOOKEEPER-2014: [~breed] We were previously waiting f

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645962#comment-15645962 ] Benjamin Reed commented on ZOOKEEPER-2014: -- shall i commit it or are we waiti

[jira] [Updated] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuliya Feldman updated ZOOKEEPER-2549: -- Attachment: ZOOKEEPER-2549-4.patch Latest patch with addressed review comments > As

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645913#comment-15645913 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user yufeldman commented

[GitHub] zookeeper issue #99: ZOOKEEPER-2549 Add exception handling to sendResponse

Github user yufeldman commented on the issue: https://github.com/apache/zookeeper/pull/99 Addressed review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

ZooKeeper_branch34 - Build # 1713 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34/1713/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1471 lines...] [mkdir] Created dir: /home/jenkins/j

Failed: ZOOKEEPER- PreCommit Build #49

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/49/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 120 lines...] [exec] ===

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645695#comment-15645695 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- Github user hanm commented on a

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/102#discussion_r86885871 --- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java --- @@ -61,70 +61,88 @@ void genCode() throws IOException { + out

Re: Jenkins issue

Thanks Eddie for your analysis. Created PR 102 just now that fixes all but the ZooDefs warnings. We can start from there and decide what to do with ZooDefs warnings. On Mon, Nov 7, 2016 at 11:02 AM, Edward Ribeiro wrote: > Hi folks, > > A cursory lo

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645632#comment-15645632 ] ASF GitHub Bot commented on ZOOKEEPER-2628: --- GitHub user hanm opened a pull

Failed: ZOOKEEPER- PreCommit Build #48

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/48/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 120 lines...] [exec] [exec]

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

GitHub user hanm opened a pull request: https://github.com/apache/zookeeper/pull/102 ZOOKEEPER-2628: Fix findbug warnings. This PR fixed 19 find bug warnings except this one, which might require interface change that potentially could break client side apps. Malicious code

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645446#comment-15645446 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86868035 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (

Failed: ZOOKEEPER- PreCommit Build #47

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/47/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 120 lines...] [exec] [exec]

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645292#comment-15645292 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user lvfangmin commented

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86857366 --- Diff: src/java/main/org/apache/zookeeper/server/auth/KeyAuthenticationProvider.java --- @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Sof

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86823972 --- Diff: src/java/main/org/apache/zookeeper/server/auth/AuthenticationProvider.java --- @@ -20,6 +20,9 @@ import org.apache.zookeeper.KeeperEx

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86824520 --- Diff: src/java/main/org/apache/zookeeper/server/auth/KeyAuthenticationProvider.java --- @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Sof

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645290#comment-15645290 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user lvfangmin commented

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645291#comment-15645291 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user lvfangmin commented

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645293#comment-15645293 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user lvfangmin commented

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86824750 --- Diff: src/java/main/org/apache/zookeeper/server/auth/KeyAuthenticationProvider.java --- @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Sof

ZooKeeper-trunk-openjdk7 - Build # 1231 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1231/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment variable

Re: Jenkins issue

Hi folks, A cursory look at the new Findbug issues highlighted mostly trivial, and a subtle but drastic change (IMHO): 1. Dodgy code warnings * 3/4 of the cases spotted are due to the File.listFiles() method that could return null if the abstract pathname does not denote a directory or if an I/

Re: [DISCUSS] QA github pre-commit queue

+1 for disabling jira qa and only support pull request for code change contributions. Besides making support easier this approach is also aligned with what Spark and Kafka is doing, and being consistent across Apache projects regarding how to use PR seems a good thing to do. >> have the tool uploa

Re: How to contribute with pull requests

Hi Flavio, I fixed made two small typos on the HowToContribute link, please see if you agree. Also, as the Github mirror is in sync with the Apache git repo, wouldn't it be the case of non-committers to use the Github URL instead of the official Apache one? A genuine question, I don't know what i

Re: [DISCUSS] QA github pre-commit queue

I am +1 about having patches submitted via PRs. IMHO, we should disable the Jira QA altogether, but have the tool upload the *.patch file to Jira for archiving purposes. On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés wrote: > On 6 November 2016 at 11:54, Flavio Junqueira wrote: > > > ZO

ZooKeeper_branch35_jdk8 - Build # 292 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/292/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 458503 lines...] [junit] 2016-11-07 12:09:30,732

ZooKeeper_branch35_openjdk7 - Build # 289 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/289/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment variab

How to contribute with pull requests

I have started a section in the "How to Contribute" doc to start documenting the process to contribute with pull requests: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute The only constraint we currently have is that the title needs to match the jira title because we u

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643583#comment-15643583 ] Hadoop QA commented on ZOOKEEPER-2383: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #46

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/46/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 97 lines...] [exec]

ZooKeeper-trunk-solaris - Build # 1376 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1376/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 450749 lines...] [junit] 2016-11-07 08:45:23,35

Failed: ZOOKEEPER- PreCommit Build #45

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/45/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 97 lines...] [exec]