Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

> > Subject: Re: [edk2-devel] [PATCH v2] > > > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > > > > > External email: Use caution opening links or attachments > > > > > > > > > On Fri, 5 Aug 2022 at 18:56, Jeff Br

Re: [edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

Thanks will fix those in v5. Will see if Sami has any other comments before pushing these. -Jeff > -Original Message- > From: Pierre Gondois > Sent: Tuesday, September 20, 2022 8:54 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com;

[edk2-devel] [PATCH v4 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 133 +- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v4 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 -

[edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v4 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 60 ++---

[edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v3 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 -

[edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 148 --

[edk2-devel] [PATCH v2 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 148 --

[edk2-devel] [PATCH v2 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v2 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. Jeff

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

CH v2] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > External email: Use caution opening links or attachments > > > On Fri, 5 Aug 2022 at 18:56, Jeff Brasen via groups.io > wrote: > > > > > > > > > -Original Message- >

Re: [edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 10:16 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; ardb+tianoc...@kernel.org; > abner.ch...@amd.com; g...@danielschaefer.me; quic_llind...@quicinc.com > Subject: Re: [PATCH v2]

[edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

Update check for enough space to occur prior to alignment offset modification. This prevents a case where EfiFreeMemoryTop could be less than EfiFreeMemoryBottom Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 53 +++ 1 file changed, 30

[edk2-devel] [PATCH 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Jeff Brasen (3): DynamicTablesPkg: Add CM_ARM_CPC_INFO object DynamicTablesPkg: AML Code generation to add _CPC entries

[edk2-devel] [PATCH 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 211 +- 1 file changed, 206 insertions(+), 5 deletions(-) diff --git

[edk2-devel] [PATCH 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 146 --

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

I'll post another version to fix the formatting issue in a bit, but before the patch the issue was we applied the alignment offset before we did a space check. -Jeff > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 2:34 AM > To: Jeff Brasen > Cc:

[edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

Add support for selecting to use index or segment number as UID and name. This allows the path of the nodes to be well known. For example, if the PCIe node needs to be notified from by an interrupt for a Generic Event Device Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports Name (_DSD, Package () {

[edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v2] DynamicTablesPkg: Fix nested processor containers

Current code will generate duplicate UID if there are nested processor containers in the topology. For example if there is a socket/cluster/core layout. Change references to processor container from cluster to be more accurate on what is being created. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v3] DynamicTablesPkg: Add support to build _DSD

Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 60 +

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Correct cluster index

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, August 17, 2022 1:01 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; sami.muja...@arm.com; > alexei.fedo...@arm.com > Subject: Re: [PATCH] DynamicTablesPkg: Correct

[edk2-devel] [PATCH] DynamicTablesPkg: Correct cluster index

Current code will generate duplicate UID if there are nested clusters in the topology. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 22 --- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [PATCH v2] DynamicTablesPkg: Add support to build _DSD

Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 55

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, August 2, 2022 10:51 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com; > quic_llind...@quicinc.com; ardb+tianoc...@kernel.org > Subject: Re: [PATCH v2]

[edk2-devel] [PATCH] DynamicTablesPkg: Add support to build _DSD

Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 50

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

> -Original Message- > From: Ard Biesheuvel > Sent: Friday, July 29, 2022 9:48 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com; > quic_llind...@quicinc.com; ardb+tianoc...@kernel.org > Subject: Re: [PATCH v2]

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Adding Leif/Ard to CC incase they have any comments on this patch. Thanks Jeff > -Original Message- > From: Jeff Brasen > Sent: Friday, June 17, 2022 9:39 AM > To: devel@edk2.groups.io > Cc: hao.a...@intel.com; ray...@intel.com > Subject: RE: [PATCH v2]

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

the same rule to SCSI. Does UFS follows > SCSI spec? > > Thanks > Liming > > -----邮件原件- > > 发件人: devel@edk2.groups.io 代表 Jeff Brasen > via > > groups.io > > 发送时间: 2022年6月15日 1:54 > > 收件人: devel@edk2.groups.io > > 抄送: jian.j.w...@intel.com; gaol

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

Yes we have systems where we will have more than 16 controllers/segments. > -Original Message- > From: Pierre Gondois > Sent: Monday, July 11, 2022 11:15 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: sami.muja...@arm.com; alexei.fedo...@arm.com > Subject: Re: [PATCH 4/4]

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

We also on some PCIe devices add a device entry under DOO_ w/ it's own _RST and _DSD. If you see the v3 version of the patch where I add a support library that we can override allows us to customize the device as we need. -Jeff > -Original Message- > From: Pierre Gondois > Sent:

[edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

Add support for PCIe devices with UID > 0xF. This is done by using the next value in the name so PCI5, PC26, etc Signed-off-by: Jeff Brasen --- .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 - .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 2 +- 2 files

[edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library

Add support library to allow for customization of _OSC and slot info. The functions in the library are unchanged, with the exception of adding PciInfo pointer to the APIs. Signed-off-by: Jeff Brasen --- .../Include/Library/SsdtPcieSupportLib.h | 73 +++

[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

The translation value in ACPI should be the difference between the CPU and PCIe address. Signed-off-by: Jeff Brasen --- .../Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v3 0/3] DynamicTablesPkg: Pcie generation updates

Add fixes/features to dynamic PCIe support - Correct issue with translation in generated ACPI tables. - Allow for more than 16 controllers to be generated. - Add support library to allow for override of _OSC and slot info. Updates: v3 - Remove segment as UID patch, convert override to

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

I think this would work. Instead of GeneratePciDeviceInfo the function we would want to break out would be GeneratePciSlots. I'll work on changing my patch series to this. Unless you have a better name will call this library SsdtPciSupportLib and place in under Library/Common Going to also

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

So to detail the use case we have an embedded device on a known controller (we know the segment number) by forcing the autogeneration to the segment number we could in another SSDT create the subdevice node right. With just \SB\PCI9\D0x as the scope right? If we had a callback I suppose we

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Ok, I never got those responses, will have to check what happened with my email. Will respond to those. > -Original Message- > From: Pierre Gondois > Sent: Friday, July 8, 2022 1:31 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: sami.muja...@arm.com; alexei.fedo...@arm.com > Subject:

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

Just following up on my outstanding edk2 patches to check on status/review feedback. Thanks, Jeff > -Original Message- > From: Jeff Brasen > Sent: Tuesday, June 14, 2022 11:54 AM > To: devel@edk2.groups.io > Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; > zhichao@intel.com;

Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

; -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > > > gaoliming > > > Sent: Wednesday, May 18, 2022 2:40 PM > > > To: devel@edk2.groups.io; jbra...@nvidia.com > > > Cc: Feng, Bob C ; Chen, Christine > > > > > > Su

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Pierre, Any thoughts on this v2 version? -Jeff > -Original Message- > From: Jeff Brasen > Sent: Friday, July 1, 2022 10:33 AM > To: devel@edk2.groups.io > Cc: pierre.gond...@arm.com; sami.muja...@arm.com; > alexei.fedo...@arm.com; Jeff Brasen > Subject: [PATCH v2 0/4]

[edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

Some platfoms may want to modify the ACPI table created. Add support for protocol that can provide an alternative implementation. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 + .../Protocol/SsdtPcieOverrideProtocol.h | 63 +++

[edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

The translation value in ACPI should be the difference between the CPU and PCIe address. Signed-off-by: Jeff Brasen --- .../Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

Add support for selecting to use index or segment number as UID and name. This allows the path of the nodes to be well known. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 +++ .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 19 ++-

[edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

Add support for PCIe devices with UID > 0xF. This is done by using the next value in the name so PCI5, PC26, etc Signed-off-by: Jeff Brasen --- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 11 +++ .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 2 +- 2 files changed,

[edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Add fixes/features to dynamic PCIe support - Correct issue with translation in generated ACPI tables. - Allow for more than 16 controllers to be generated. - Allow optional use of segment number as UID for cases where ACPI path is needed in other places. - Add support for override protocol that

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

I don't think there are any requirements that this should be mapped this way which is why I added this under a PCD to enable it. We have a use case where it would be helpful to know the ACPI path of the PCIe controllers externally and using the segment number for that would allow us to do this

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

Currently we do the following in this call. Remove and replace the _OSC method on certain targets. I originally had this pass the template over but removed that when I added this more generic override support Add a _RST method to the root port device sub node Add a _DSD for device properties

Re: [edk2-devel] [PATCH 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

Yes, I'll try to add a v2 patch for this shortly. Thanks, Jeff > -Original Message- > From: Pierre Gondois > Sent: Friday, July 1, 2022 6:40 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: sami.muja...@arm.com; alexei.fedo...@arm.com > Subject: Re: [PATCH 1/4] DynamicTablesPkg:

[edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

Update check for enough space to occur prior to alignment offset. This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom. Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 53 +++ 1 file changed, 30 insertions(+), 23 deletions(-)

[edk2-devel] [PATCH 3/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

Add support for PCIe devices with UID > 0xF. This is done by using the next value in the name so PCI5, PC26, etc Signed-off-by: Jeff Brasen --- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 11 +++ .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 2 +- 2 files

[edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

Some platfoms may want to modify the ACPI table created. Add support for protocol that can provide an alternative implementation. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 + .../Protocol/SsdtPcieOverrideProtocol.h | 63 +++

[edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

Add support for selecting to use index or segment number as UID and name. This allows the path of the nodes to be well known. Signed-off-by: Jeff Brasen --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 +++ .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 19 ++-

[edk2-devel] [PATCH 1/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

The translation value in ACPI should be the difference between the CPU and PCIe address. Signed-off-by: Jeff Brasen --- .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH 0/4] DynamicTablesPkg: Pcie generation updates

Add fixes/features to dynamic PCIe support - Correct issue with translation in generated ACPI tables. - Allow for more than 16 controllers to be generated. - Allow optional use of segment number as UID for cases where ACPI path is needed in other places. - Add support for override protocol that

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Any thoughts on this patch? > -Original Message- > From: Jeff Brasen > Sent: Monday, February 14, 2022 11:46 AM > To: devel@edk2.groups.io > Cc: hao.a...@intel.com; ray...@intel.com; Jeff Brasen > > Subject: [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow > partial FreeBuffer

Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

; > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools build > > logs > > > > Bob: > > Do you know what files will be generated in BaseTools/BaseToolsBuild > > directory? > > > > Thanks > > Liming > > > -邮件原件-

Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

Resending this as I replying via edk2.groups.io doesn't seem to copy maintainers. Resuming this patch to see if there are any additional thoughts on this. In response to the query about DXE/BDS services we have some internal connection logic that runs in DXE to connect the devices that are

[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

Add support for getting disk info from UFS devices. Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c| 3 ++- MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Any comments on this patch? Thanks, Jeff -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89876): https://edk2.groups.io/g/devel/message/89876 Mute This Topic: https://groups.io/mt/89143704/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

Any comments on this patch? Thanks, Jeff -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89875): https://edk2.groups.io/g/devel/message/89875 Mute This Topic: https://groups.io/mt/90610467/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] [PATCH] .gitignore: Ignore build tools build logs

The python BaseTools/Edk2ToolsBuild.py creates files in BaseTools/BaseToolsBuild and should be ignored. Signed-off-by: Jeff Brasen --- BaseTools/.gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index

Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

Resuming this PATCH to see if there are any additional thoughts on this. In response to the query about DXE/BDS services we have some internal connection logic that runs in DXE to connect the devices that are needed for arch services that have to be connected prior the end of dxe. Thanks, Jeff

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

CH v2] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > External email: Use caution opening links or attachments > > > Deepthi, > Can you please help to review the changes and provide comments? > > Thanks, > Ray > > -Original Message- >

[edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Add support for partial free of non cached buffers. If a request for less than the full size is requested new allocations for the remaining head and tail of the buffer are added to the list. Added verification that Buffer is EFI_PAGE_SIZE aligned. The XHCI driver does this if the page size for the

[edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial free

Add support for partial free of non cached buffers. If a request for less than the full size is requested new allocations for the remaining head and tail of the buffer are added to the list. The XHCI driver does this if the page size for the controller is >4KB. Signed-off-by: Jeff Brasen ---

Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

> -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 14, 2021 8:00 PM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > External email: Use caution opening links or attachments > > > >

[edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBACK. This allows services like variable services that run at TPL_NOTIFY to be hosted on ScsiDisks (i.e. UFS) Aligns with the eMMC driver that also uses a higher TPL. This change was made in

Re: [edk2-devel] Question on TPL in PCD/Variable code

I am trying to get variable services hosted on a UFS device and running into TPL related issues. The variable and PCD code have locks that raise the TPL to NOTIFY prior to calling into the FVB instance and the UFS driver has a few raise tpl calls that increase the TPL to TPL_CALLBACK. This is

Re: [edk2-devel] [PATCH v3 0/4] AndroidBootImgLib improvements

That looks like something I missed and looks good, do you need me to make a v4 or will you just add that in. When I built I just used our application that has the guid in our inf so missed this. >From my looking at it AndroidFastBootApp doesn't seem to use this lib. > -Original

Re: [edk2-devel] [PATCH v3 0/4] AndroidBootImgLib improvements

Jun/Others, Any additional comments on this patch series? Thanks, Jeff From: Jeff Brasen Sent: Tuesday, September 14, 2021 10:57 AM To: Leif Lindholm Cc: devel@edk2.groups.io ; daniel.schae...@hpe.com ; abner.ch...@hpe.com ; ardb+tianoc...@kernel.org ;

Re: [edk2-devel] [PATCH v3 0/4] AndroidBootImgLib improvements

So for patch 3: This is only a change if mAndroidBootImg->UpdateDtb == NULL. This seemed like a bug as we would not add the initrd values nor would we use the fdt from the BootImg if that is where the device tree was sourced from. It seems like either we should require UpdateDtb to be

[edk2-devel] [PATCH v3 0/4] AndroidBootImgLib improvements

Added support for using loadfile2 approach for passing ramdisk to linux. Created patch series for general error handling improvments based on review feedback. If ACPI tables are in system table or PCD is defined the LoadFile2 method of passing initrd will be used. [v3] -Code review cleanup

[edk2-devel] [PATCH v3 4/4] EmbeddedPkg: Add LoadFile2 for linux initrd

Add support under a pcd feature for using the new interface to pass initrd to the linux kernel instead of via device tree. This feature is also enabled if ACPI tables are present, and will skip locating and installation of device tree. Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.dec

[edk2-devel] [PATCH v3 2/4] EmbeddedPkg: AndroidBootImgBoot error handling updates

Update AndroidBootImgBoot to use a single return point Make sure Kernel args are freed and Image is unloaded. Signed-off-by: Jeff Brasen --- .../AndroidBootImgLib/AndroidBootImgLib.c | 50 +++ 1 file changed, 29 insertions(+), 21 deletions(-) diff --git

[edk2-devel] [PATCH v3 1/4] EmbeddedPkg: Remove duplicate libfdt.h include

Remove duplicate libfdt.h include statement in AndroidBootImgLib Signed-off-by: Jeff Brasen --- EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c

[edk2-devel] [PATCH v3 3/4] EmbeddedPkg: Install FDT if UpdateDtb is not present

Currently if mAndroidBootImg->UpdateDtb is not supported on the platform the device tree updates of the initrd are not made. Signed-off-by: Jeff Brasen --- .../Library/AndroidBootImgLib/AndroidBootImgLib.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[edk2-devel] [PATCH v3 2/2] Ext4Pkg: Support uncleanly unmounted filesystems

Support for uncleanly mounted filesystems, if there is a recovery journal mark filesystem as read-only. Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c

[edk2-devel] [PATCH v3 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior

A couple of improvements to improve performance. Add check to return ACCESS_DENIED if already connected Add check to verify superblock magic during supported to reduce start calls Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++

[edk2-devel] [PATCH v3 0/2] ExtPkg Updates

I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. Had a couple updates to propose 1. Changed the implementation of the binding protocol to both check if the driver is already bound to the partition as well as added a really quick check to

Re: [edk2-devel] [PATCH v2 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior

We actually can't open the BlockIo protocol as BY_DRIVER as it is already owned by the DiskIoDxe driver. Will upload a v3 with the other feedback though. Thanks, Jeff From: Marvin Häuser Sent: Friday, September 10, 2021 12:09 PM To: Pedro Falcato Cc:

Re: [edk2-devel] [PATCH v2 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior

Yeah we need by_driver on at least one protocol to prevent re-binding to the controller. It will return ALREADY_STARTED if this driver already has it open (from in Start) or ACCESS_DENIED if another driver is holding this. I can covert both to by_driver if that is desired. Will make the other

[edk2-devel] [PATCH v2 2/2] Ext4Pkg: Support uncleanly unmounted filesystems

Support for uncleanly mounted filesystems, if there is a recovery journal mark filesystem as read-only. Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c

[edk2-devel] [PATCH v2 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior

A couple of improvements to improve performance. Add check to return ACCESS_DENIED if already connected Add check to verify superblock magic during supported to reduce start calls Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++

[edk2-devel] [PATCH v2 0/2] ExtPkg Updates

I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. Had a couple updates to propose 1. Changed the implementation of the binding protocol to both check if the driver is already bound to the partition as well as added a really quick check to

Re: [edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

Sounds good will update that in a v2 patch tomorrow Get Outlook for Android From: Pedro Falcato Sent: Thursday, September 9, 2021 10:22:51 PM To: Jeff Brasen Cc: edk2-devel-groups-io Subject: Re: [PATCH 1/2] Ext4Pkg: Improve Binding

Re: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Add LoadFile2 for linux initrd

Question below Thanks, Jeff From: Leif Lindholm Sent: Tuesday, September 7, 2021 11:51 AM To: Jeff Brasen Cc: devel@edk2.groups.io ; ardb+tianoc...@kernel.org ; abner.ch...@hpe.com ; daniel.schae...@hpe.com Subject: Re: [PATCH v2 2/2] EmbeddedPkg: Add

[edk2-devel] [PATCH 0/2] ExtPkg Updates

I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. Had a couple updates to propose 1. Changed the implementation of the binding protocol to both check if the driver is already bound to the partition as well as added a really quick check to

[edk2-devel] [PATCH 2/2] Ext4Pkg: Support non-cleanlty unmounted filesystems

Support for uncleanly mounted filesystems, if there is a recovery journal mark filesystem as read-only. Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c

[edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

A couple improvements to improve performance. Add check to return ACCESS_DENIED if already connected Add check to verify superblock magic during supported to deduce start calls Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c

Re: [edk2-devel] [PATCH v2 0/2] AndroidBootImgLib improvements

Any additional feedback on this patchset? Thanks, Jeff From: Jeff Brasen Sent: Wednesday, September 1, 2021 2:28 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com ; ardb+tianoc...@kernel.org ; abner.ch...@hpe.com ; daniel.schae...@hpe.com ; Jeff Brasen

[edk2-devel] [PATCH v2 1/2] EmbeddedPkg: AndroidBootImgBoot error handling updates

Update AndroidBootImgBoot to use a single return point Make sure Kernel args are freed and Image is unloaded. Signed-off-by: Jeff Brasen --- .../AndroidBootImgLib/AndroidBootImgLib.c | 50 +++ 1 file changed, 29 insertions(+), 21 deletions(-) diff --git

[edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Add LoadFile2 for linux initrd

Add support under a pcd feature for using the new interface to pass initrd to the linux kernel. Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.dec | 1 + .../AndroidBootImgLib/AndroidBootImgLib.inf | 3 + .../AndroidBootImgLib/AndroidBootImgLib.c | 147

[edk2-devel] [PATCH v2 0/2] AndroidBootImgLib improvements

Added support for using loadfile2 approach for passing ramdisk to linux. Created patch series for general error handling improvments based on review feedback. [v2] -Added review feedback -General improvements to error handling [v1] - Intial revision Jeff Brasen (2): EmbeddedPkg:

<    1   2   3   >