Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build

2013-07-21 Thread Guenter Roeck
On Fri, Jul 19, 2013 at 12:48:39PM -0600, Stephen Warren wrote: > On 07/18/2013 03:21 PM, Guenter Roeck wrote: > > On Thu, Jul 18, 2013 at 11:18:05AM -0600, Stephen Warren wrote: > >> On 07/18/2013 07:53 AM, Eduardo Valentin wrote: > >>> Hello Guenter, > >&

Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build

2013-07-21 Thread Guenter Roeck
On Fri, Jul 19, 2013 at 02:56:19PM -0400, Eduardo Valentin wrote: > On 19-07-2013 14:45, Stephen Warren wrote: > > On 07/19/2013 07:38 AM, Eduardo Valentin wrote: > >> On 18-07-2013 17:11, Guenter Roeck wrote: > >>> On Thu, Jul 18, 2013 at 09:53:05AM -0400

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-21 Thread Guenter Roeck
On Fri, Jul 19, 2013 at 05:40:05PM +0200, Wolfram Sang wrote: > On Mon, Jul 15, 2013 at 11:07:36PM +0200, Linus Walleij wrote: > > On Mon, Jul 15, 2013 at 4:29 PM, Jonathan Corbet wrote: > > > > > Do we need a kernel summit discussion, or do we just need a good > > > document? Or, to phrase the

Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build

2013-07-18 Thread Guenter Roeck
On Thu, Jul 18, 2013 at 11:18:05AM -0600, Stephen Warren wrote: > On 07/18/2013 07:53 AM, Eduardo Valentin wrote: > > Hello Guenter, > > > > On 17-07-2013 18:09, Guenter Roeck wrote: > >> On Wed, Jul 17, 2013 at 11:17:19AM -0400, Eduardo Valentin > >> wrot

Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build

2013-07-18 Thread Guenter Roeck
On Thu, Jul 18, 2013 at 09:53:05AM -0400, Eduardo Valentin wrote: > Hello Guenter, > > On 17-07-2013 18:09, Guenter Roeck wrote: > > On Wed, Jul 17, 2013 at 11:17:19AM -0400, Eduardo Valentin wrote: > >> Hello all, > >> > >> As you noticed, I am

Re: [RESEND PATCH V1 9/9] hwmon: tmp102: expose to thermal fw via DT nodes

2013-07-18 Thread Guenter Roeck
On Wed, Jul 17, 2013 at 11:17:28AM -0400, Eduardo Valentin wrote: > This patch adds to tmp102 temperature sensor the possibility > to expose itself as thermal zone device, registered on the > thermal framework. > > The thermal zone is built only if a device tree node > describing a thermal zone fo

Re: [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes

2013-07-18 Thread Guenter Roeck
upposed to be usable across multiple operating systems. Your proposal is clearly operating system and even subsystem specific. It does _not_ describe hardware. NACK. Guenter > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: lm-sens...@lm-sensors.org > Cc: linux-ker...@vger.kerne

Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build

2013-07-17 Thread Guenter Roeck
On Wed, Jul 17, 2013 at 11:17:19AM -0400, Eduardo Valentin wrote: > Hello all, > > As you noticed, I am working in a way to represent thermal data > using device tree [1]. Essentially, this should be a way to say > what to do with a sensor and how to associate (cooling) actions > with it. > Seems

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-15 Thread Guenter Roeck
On Mon, Jul 15, 2013 at 08:29:15AM -0600, Jonathan Corbet wrote: > On Mon, 15 Jul 2013 10:36:22 +0200 > Linus Walleij wrote: > > > > Devicetree is supposed to describe the hardware, but in many cases there > > > is > > > an overlap between hardware description and configuration and/or use. > >

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-14 Thread Guenter Roeck
On Sun, Jul 14, 2013 at 01:46:45AM +0200, Linus Walleij wrote: > On Sat, Jul 13, 2013 at 10:49 PM, Guenter Roeck wrote: > > On Sat, Jul 13, 2013 at 08:26:47PM +0100, Wolfram Sang wrote: > > >> I think the KS would be a good opportunity to present the status quo, > >>

Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature

2013-06-28 Thread Guenter Roeck
On Fri, Jun 28, 2013 at 05:24:43PM +0200, Lars-Peter Clausen wrote: > On 06/28/2013 04:50 PM, Alexandre Belloni wrote: > > On 28/06/2013 16:18, Lars-Peter Clausen wrote: > >> On 06/27/2013 09:26 PM, Alexandre Belloni wrote: > >>> > >>> They are already registered as IIO_TEMP but only implement read

Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature

2013-06-27 Thread Guenter Roeck
On Thu, Jun 27, 2013 at 11:17:32AM +0200, Maxime Ripard wrote: > On Wed, Jun 26, 2013 at 07:39:27AM -0700, Guenter Roeck wrote: > > On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote: > > > The low resolution ADC of the mxs is able to read an internal temper

Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature

2013-06-26 Thread Guenter Roeck
On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote: > The low resolution ADC of the mxs is able to read an internal temperature > sensor, expose that using hwmon. > > Signed-off-by: Alexandre Belloni > --- Wouldn't it make more sense to use iio-hwmon and improve it if necessary ?

Re: [PATCHv8 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-23 Thread Guenter Roeck
On Sun, Jun 23, 2013 at 05:39:32PM +0200, Simon Guinot wrote: > On Thu, Jun 20, 2013 at 10:21:04PM +0200, Arnaud Ebalard wrote: > > > > GMT G762/763 fan speed PWM controller is connected directly to a fan > > and performs closed-loop or open-loop control of the fan speed. Two > > modes - PWM or DC

Re: [PATCHv8 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-21 Thread Guenter Roeck
On Thu, Jun 20, 2013 at 10:21:04PM +0200, Arnaud Ebalard wrote: > > GMT G762/763 fan speed PWM controller is connected directly to a fan > and performs closed-loop or open-loop control of the fan speed. Two > modes - PWM or DC - are supported by the chip. Introduced driver > provides various knobs

Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

2013-06-19 Thread Guenter Roeck
On Thu, Jun 20, 2013 at 02:27:18AM +, Tang Yuantian-B29983 wrote: > > > > -Original Message- > > From: Guenter Roeck [mailto:li...@roeck-us.net] > > Sent: 2013年6月19日 星期三 23:43 > > To: Tang Yuantian-B29983 > > Cc: kh...@linux-fr.org; lm-sens...@

Re: [PATCHv7 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-19 Thread Guenter Roeck
On Wed, Jun 19, 2013 at 09:34:34PM +0200, Arnaud Ebalard wrote: > > GMT G762/763 fan speed PWM controller is connected directly to a fan > and performs closed-loop or open-loop control of the fan speed. Two > modes - PWM or DC - are supported by the chip. Introduced driver > provides various knobs

Re: [RESEND,PATCHv6 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-19 Thread Guenter Roeck
On Wed, Jun 19, 2013 at 11:26:33PM +0200, Simon Guinot wrote: > On Wed, Jun 19, 2013 at 01:53:21PM -0700, Guenter Roeck wrote: > > On Wed, Jun 19, 2013 at 10:15:56PM +0200, Arnaud Ebalard wrote: > > > Hi Simon, > > > > > > Simon Guinot writes: > > >

Re: [RESEND,PATCHv6 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-19 Thread Guenter Roeck
On Wed, Jun 19, 2013 at 10:15:56PM +0200, Arnaud Ebalard wrote: > Hi Simon, > > Simon Guinot writes: > > > I have tested this patch on my 2Big Network v2 board. > > > > Sometimes I get a weird "No such device" error while reading or writing > > the hwmon sysfs attributes. For example: > > > > #

Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

2013-06-19 Thread Guenter Roeck
On Wed, Jun 19, 2013 at 02:50:20PM +0800, yuantian.t...@freescale.com wrote: > From: Tang Yuantian > > Adding another way that is device tree to pass the shunt resistor > value to driver except for platform data. > > Signed-off-by: Tang Yuantian I noticed that of.h include was missing. No need

Re: [PATCH v5] watchdog: Add Broadcom BCM2835 watchdog timer driver

2013-06-18 Thread Guenter Roeck
Warren > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: linux-rpi-ker...@lists.infradead.org > Cc: linux-watch...@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org Reviewed-by: Guenter Roeck > --- > Changes for v2: > - Use per-device structure instead of

Re: [RESEND,PATCHv6 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-16 Thread Guenter Roeck
On Sun, Jun 16, 2013 at 12:36:20AM +0200, Arnaud Ebalard wrote: > > GMT G762/763 fan speed PWM controller is connected directly to a fan > and performs closed-loop or open-loop control of the fan speed. Two > modes - PWM or DC - are supported by the chip. Introduced driver > provides various knobs

Re: [RESEND,PATCHv6 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-15 Thread Guenter Roeck
On Sun, Jun 16, 2013 at 12:36:20AM +0200, Arnaud Ebalard wrote: > > GMT G762/763 fan speed PWM controller is connected directly to a fan > and performs closed-loop or open-loop control of the fan speed. Two > modes - PWM or DC - are supported by the chip. Introduced driver > provides various knobs

Re: [PATCHv4 1/1] Add support for GMT G762/G763 PWM fan controllers

2013-06-15 Thread Guenter Roeck
On Sat, Jun 15, 2013 at 06:13:49PM +0200, Arnaud Ebalard wrote: > > GMT G762/763 fan speed PWM controller is connected directly to a fan > and performs closed-loop or open-loop control of the fan speed. Two > modes - PWM or DC - are supported by the chip. Introduced driver > provides various knobs

Re: [PATCHv2 1/3] Add support for GMT G762/G763 PWM fan controller

2013-06-11 Thread Guenter Roeck
On Tue, Jun 04, 2013 at 11:23:07PM +0200, Simon Guinot wrote: > On Tue, Jun 04, 2013 at 08:52:12AM +0200, Arnaud Ebalard wrote: > > Hi Simon, > > > > Simon Guinot writes: > > > > > On Sat, Jun 01, 2013 at 07:26:54PM +0200, Arnaud Ebalard wrote: > > >> Hi Simon and Guenter, > > >> > > >> Simon G

Re: [PATCHv4 1/3] Add support for GMT G762/G763 PWM fan controller

2013-06-11 Thread Guenter Roeck
On Tue, Jun 04, 2013 at 09:14:29AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/g762.c | > > include/lin

Re: [PATCHv4 2/3] Add documentation for g762 driver

2013-06-11 Thread Guenter Roeck
On Tue, Jun 04, 2013 at 09:14:47AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard Please merge the patches into one. I don't see the benefit of having three patches as it is all part of one driver. Thanks, Guenter > --- > Documentation/hwmon/g762 | 62 >

Re: [PATCHv3 1/3] Add support for GMT G762/G763 PWM fan controller

2013-06-02 Thread Guenter Roeck
On Sun, Jun 02, 2013 at 10:14:19PM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/g762.c | 1179 > > include/lin

Re: [PATCHv3 0/3] Add G762/G763 PWM fan controller

2013-06-02 Thread Guenter Roeck
On Sun, Jun 02, 2013 at 10:14:05PM +0200, Arnaud Ebalard wrote: > Hi, > > This series adds support for GMT G762/G763. This work is based on a > basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie > NAS. Updates have been performed to run on recent kernels. Support has > been comple

Re: [PATCHv2 1/3] Add support for GMT G762/G763 PWM fan controller

2013-06-02 Thread Guenter Roeck
On Sun, Jun 02, 2013 at 05:45:58PM +0200, Arnaud Ebalard wrote: > Hi, > > >> I haven't noticed this issue while testing your v1 patch series because > >> at the time I was using a board with an U-Boot modified by LaCie. This > >> last sets the set_cnt register to 0 while U-Boot mainline don't. > >

Re: [PATCHv2 1/3] Add support for GMT G762/G763 PWM fan controller

2013-06-01 Thread Guenter Roeck
On Tue, May 28, 2013 at 12:03:14AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/g762.c | 1012 > > include/lin

Re: [PATCHv2 0/3] Add G762/G763 PWM fan controller

2013-05-28 Thread Guenter Roeck
On Tue, May 28, 2013 at 03:47:49PM +0200, Thierry Reding wrote: > On Tue, May 28, 2013 at 05:29:40AM -0700, Guenter Roeck wrote: > > On Tue, May 28, 2013 at 01:19:23PM +0200, Thierry Reding wrote: > > > On Tue, May 28, 2013 at 12:15:04PM +0200, Arnaud Ebalard wrot

Re: [PATCHv2 0/3] Add G762/G763 PWM fan controller

2013-05-28 Thread Guenter Roeck
On Tue, May 28, 2013 at 01:19:23PM +0200, Thierry Reding wrote: > On Tue, May 28, 2013 at 12:15:04PM +0200, Arnaud Ebalard wrote: > > Hi Arnd, > > > > Arnd Bergmann writes: > > > > > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote: > > >> > > >> This series adds support for GMT G762/G763.

Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

2013-05-03 Thread Guenter Roeck
On Fri, May 03, 2013 at 08:30:03PM +0200, Dirk Eibach wrote: > > > Am 03.05.2013 15:46, schrieb Guenter Roeck: > >On Fri, May 03, 2013 at 10:33:13AM +0200, Dirk Eibach wrote: > >>Hi Guenter, > >> > >>>>>>diff --git a/drivers/watchdog/Kc

Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

2013-05-03 Thread Guenter Roeck
On Fri, May 03, 2013 at 10:33:13AM +0200, Dirk Eibach wrote: > Hi Guenter, > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index e89fc31..6048593 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1172,6 +1172,38 @@ config BOOK

Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

2013-05-03 Thread Guenter Roeck
On Fri, May 03, 2013 at 10:33:13AM +0200, Dirk Eibach wrote: > Hi Guenter, > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index e89fc31..6048593 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1172,6 +1172,38 @@ config BOOK

Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

2013-05-02 Thread Guenter Roeck
Hi Dirk, On Thu, May 02, 2013 at 09:11:19PM +0200, Dirk Eibach wrote: > Hi Guenter, > > >>diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > >>index e89fc31..6048593 100644 > >>--- a/drivers/watchdog/Kconfig > >>+++ b/drivers/watchdog/Kconfig > >>@@ -1172,6 +1172,38 @@ config BOOK

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-27 Thread Guenter Roeck
On Sat, Apr 27, 2013 at 04:03:31PM +0200, Simon Guinot wrote: > On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > + /* > > +* Set default configuration values before passing the structure > > +* to OF helpers to overload them using those provided by .dts > > +* file

Re: [PATCH 09/23 v2] watchdog: coh901327: devicetree support

2013-04-26 Thread Guenter Roeck
On Fri, Apr 26, 2013 at 04:33:53PM +0200, Linus Walleij wrote: > From: Linus Walleij > > This adds support for probing the COH 901 327 watchdog from > the device tree and also adds associated bindings. > > Cc: Wim Van Sebroeck > Signed-off-by: Linus Walleij Revie

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > Tested-by: Arnaud Ebalard Tested-by is not needed here; I sure hope you tested your own code. It is only used if someone else tested it. > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 10:28:47PM +0200, Arnaud Ebalard wrote: > Hi, > > Guenter Roeck writes: > > >> > You could consider using regmap for holding this cache. > >> > > >> > http://elceurope2012.sched.org/event/100619b669ce5767341624253aa0365

Re: [PATCHv1 2/3] hwmon: Add documentation for g762 driver

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 12:06:08AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > --- > Documentation/hwmon/g762 | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/hwmon/g762 > > diff --git a/Documen

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 11:06:57AM +0200, Arnaud Ebalard wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> +struct g762_data { > >> + struct i2c_client *client; > >> + struct device *hwmon_dev; > >> + > >> + /* update mutex */ > >> + struct mutex update_lock; > >> + > >> + /* board specifi

Re: [PATCH 09/23] watchdog: coh901327: devicetree support

2013-04-22 Thread Guenter Roeck
On Mon, Apr 22, 2013 at 11:55:05AM +0200, Linus Walleij wrote: > From: Linus Walleij > > This adds support for probing the COH 901 327 watchdog from > the device tree and also adds associated bindings. > > Cc: Wim Van Sebroeck > Signed-off-by: Linus Walleij > --- > Hi Wim, I'm seeking an ACK o

Re: [PATCH 1/3] Add support for GMT G72/G763 PWM fan controller

2013-04-19 Thread Guenter Roeck
On Fri, Apr 19, 2013 at 01:30:51PM +0200, Arnaud Ebalard wrote: > Hi, > > Andrew Lunn writes: > > > Hi Arnaud > > > >> +static DEVICE_ATTR(pwm1, S_IWUSR | S_IRUGO, get_pwm, set_pwm); > >> +static DEVICE_ATTR(pwm1_polarity, S_IWUSR | S_IRUGO, > >> + get_pwm_polarity, set_pwm_polarity)

Re: [PATCH 1/3] Add support for GMT G72/G763 PWM fan controller

2013-04-18 Thread Guenter Roeck
On Fri, Apr 19, 2013 at 12:28:21AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > Tested-by: Arnaud Ebalard > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/g762.c | 1159 > > 3 file

Re: [PATCH v6 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2013 at 09:29:00AM -0700, Doug Anderson wrote: > The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme > where masters need to claim the bus with a GPIO before they can start > a transcation. This should generally only be used when standard I2C I am having fun wit

Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2013 at 11:36:33AM +0200, Wolfram Sang wrote: > Doug, > [ ... ] > > "callenge & response"? > > ... > > > diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c > > b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c > > new file mode 100644 > > index 000..bda020a > > --- /dev/nul

Re: [PATCH] watchdog: Revert the AT91RM9200_WATCHDOG dependency

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 06:33:51AM -0700, Guenter Roeck wrote: > On Wed, Apr 10, 2013 at 02:36:22PM +0200, Nicolas Ferre wrote: > > Compiling the at91rm9200_wdt.c driver without at91rm9200 > > support was leading to several errors: > > > > drivers/built-in.o:

Re: [PATCH] watchdog: Revert the AT91RM9200_WATCHDOG dependency

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 02:36:22PM +0200, Nicolas Ferre wrote: > Compiling the at91rm9200_wdt.c driver without at91rm9200 > support was leading to several errors: > > drivers/built-in.o: In function `at91_wdt_close': > at91_adc.c:(.text+0xc9fe4): undefined reference to `at91_st_base' > drivers/bui

Re: [PATCH v6] clk: add si5351 i2c common clock driver

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 06:46:57PM +0200, Sebastian Hesselbarth wrote: > This patch adds a common clock driver for Silicon Labs Si5351a/b/c > i2c programmable clock generators. Currently, the driver does not > support VXCO feature of si5351b. Passing platform_data or DT bindings > selectively allow

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 08:11:38AM +0200, Sebastian Hesselbarth wrote: > On 04/08/2013 02:17 AM, Guenter Roeck wrote: > >On Mon, Apr 08, 2013 at 01:49:24AM +0200, Sebastian Hesselbarth wrote: > >>On 04/08/2013 12:50 AM, Guenter Roeck wrote: > >>>On Fri, Apr 05, 2013

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-07 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 01:49:24AM +0200, Sebastian Hesselbarth wrote: > On 04/08/2013 12:50 AM, Guenter Roeck wrote: > >On Fri, Apr 05, 2013 at 05:23:35AM -, Sebastian Hesselbarth wrote: > >>This patch adds a common clock driver for Silicon Labs Si5351a/b/c > >

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-07 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 05:23:35AM -, Sebastian Hesselbarth wrote: > This patch adds a common clock driver for Silicon Labs Si5351a/b/c > i2c programmable clock generators. Currently, the driver supports > DT kernels only and VXCO feature of si5351b is not implemented. DT > bindings selectively

[PATCH 5/5] net/nxp/lpc_eth: Drop ifdef CONFIG_OF_NET

2013-04-02 Thread Guenter Roeck
Since of_get_mac_address() is now declared even if CONFIG_OF_NET is not configured, the ifdef is no longer necessary and can be removed. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/nxp/lpc_eth.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c

[PATCH 4/5] net/freescale/fec: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
OF dependent function as front-end. Also, the function depends on OF_NET, not on OF, so the conditional code was not correct anyway. Drop the front-end function and call of_get_phy_mode() directly. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/freescale/fec.c | 19

[PATCH 2/5] net/cadence/at91_ether: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/cadence/at91_ether.c | 44 - 1 file changed, 6 insertions(+), 38 deletions(-) diff --git a/drivers/net/ethernet/cadence

[PATCH 1/5] of_net.h: Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
unctions if OF_NET is not configured. This is safe because all callers do check the return values. Cc: David Daney Signed-off-by: Guenter Roeck Acked-by: Rob Herring --- include/linux/of_net.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/of_net.h b/include/lin

[PATCH 0/5] Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
Provide empty functions for of_get_phy_mode() and of_get_mac_address() if OF_NET is not configured. Modify affected drivers to rely on the now available functions. Guenter Roeck (5): of_net.h: Provide dummy functions if OF_NET

[PATCH 3/5] net/cadence/macb: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/cadence/macb.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c

Re: [PATCH] of_net.h: Provide dummy functions if OF_NET is not configured

2013-04-01 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 01:44:24PM -0500, Rob Herring wrote: > On 04/01/2013 01:19 PM, Guenter Roeck wrote: > > of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET > > is configured. While most callers check for the define, not all do, and > > those >

[PATCH] of_net.h: Provide dummy functions if OF_NET is not configured

2013-04-01 Thread Guenter Roeck
function declarations if OF_NET is not configured. This is safe because all callers do check the return values. If desired, at least some of the #ifdefs in the code can subsequently be removed. Cc: David Daney Signed-off-by: Guenter Roeck --- include/linux/of_net.h | 10 ++ 1 file change

Re: [PATCH v10 05/12] watchdog: Kconfig for Palmas watchdog

2013-03-24 Thread Guenter Roeck
On Fri, Mar 22, 2013 at 02:55:15PM +, Ian Lartey wrote: > Add the Kconfig and Makefile for the Palmas watchdog driver > > Signed-off-by: Ian Lartey > Signed-off-by: Graeme Gregory > --- I think this patch should be merged with the previous one. Guenter _

Re: [PATCH v10 04/12] watchdog: add Palmas Watchdog support

2013-03-24 Thread Guenter Roeck
On Fri, Mar 22, 2013 at 02:55:14PM +, Ian Lartey wrote: > From: Graeme Gregory > > Add support for the Palmas watchdog timer which has a timeout configurable > from 1s to 128s. > > Signed-off-by: Graeme Gregory > Signed-off-by: Ian Lartey > --- > drivers/watchdog/palmas_wdt.c | 169 > ++

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-13 Thread Guenter Roeck
as an iio device. > > > > During the probe ntc driver gets the respective channels of ADC > > and uses iio_raw_read calls to get the ADC converted value. > > > > Signed-off-by: Naveen Krishna Chatradhi > > --- > > Changes since v3: > > 1. Added a NULL

Re: [lm-sensors] [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2013 at 09:52:26PM -0700, Guenter Roeck wrote: > On Wed, Mar 13, 2013 at 09:38:20AM +0530, Naveen Krishna Chatradhi wrote: > > This patch adds DT support to NTC driver to parse the > > platform data. > > > > Also adds the support to work as an iio device

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
HOTPLUG_PCI drivers/pci/hotplug/Kconfig:5: symbol HOTPLUG_PCI depends on SYSFS So we can not just select IIO. I'll see if I can find a solution. Guenter > --- > Changes since v3: > 1. Added a NULL check before iio_channel_release > 2. Modified a return statement > >

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
es iio_raw_read calls to get the ADC converted value. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > 1. Added a NULL check before iio_channel_release > 2. Modified a return statement > > Guenter Roeck, Its wonderful working with you. Thanks. &g

Re: [PATCH v3] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
d to >null in case of non-DT > 6. removed a typecase of (s64) which is not needed. > > Guenter Roeck, Thanks for your valuble time and comments. They really > are helping me learn and do better on my future patches. > > Doug, Thanks for your support and testing these

Re: [PATCH v2] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2013 at 02:09:26PM +0530, Naveen Krishna Chatradhi wrote: > This patch adds DT support to NTC driver to parse the > platform data. > > Also adds the support to work as an iio device. > > During the probe ntc driver gets the respective channels of ADC > and uses iio_raw_read calls

Re: [lm-sensors] [PATCH 1/2] hwmon: ntc: Add DT support to NTC thermistor driver

2013-03-11 Thread Guenter Roeck
On Mon, Mar 11, 2013 at 05:21:44AM -0700, Guenter Roeck wrote: > On Mon, Mar 11, 2013 at 07:39:46AM +0530, Naveen Krishna Chatradhi wrote: > > This patch adds the DT support to NTC driver to parse the > > platform data. > > > > Signed-off-by: Naveen Krishna Chatradhi

Re: [PATCH 2/2] hwmon: NTC: add IIO get channel and read support

2013-03-11 Thread Guenter Roeck
On Mon, Mar 11, 2013 at 07:39:47AM +0530, Naveen Krishna Chatradhi wrote: > This patch adds the support to work as a iio device. > iio_get_channel and iio_raw_read works. > > During the probe ntc driver gets the respective channels of ADC > and uses iio_raw_read calls to get the ADC converted valu

Re: [PATCH 1/2] hwmon: ntc: Add DT support to NTC thermistor driver

2013-03-11 Thread Guenter Roeck
On Mon, Mar 11, 2013 at 07:39:46AM +0530, Naveen Krishna Chatradhi wrote: > This patch adds the DT support to NTC driver to parse the > platform data. > > Signed-off-by: Naveen Krishna Chatradhi > --- > drivers/hwmon/ntc_thermistor.c | 93 > > 1 file c

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Wed, Feb 20, 2013 at 06:51:08PM +, Jonathan Cameron wrote: > > > Guenter Roeck wrote: > > >On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote: > >> On 02/07/2013 11:09 AM, Guenter Roeck wrote: > >> > Provide bindings

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote: > On 02/07/2013 11:09 AM, Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter Roeck > > --- > > v5: > > - Updated examples in bindin

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Fri, Feb 08, 2013 at 08:30:48AM +, Jonathan Cameron wrote: > On 07/02/13 17:09, Guenter Roeck wrote: > >Provide bindings and parse OF data during initialization. > > > >Signed-off-by: Guenter Roeck > Looks fine to me. Will give it a few more days to see what oth

Re: [lm-sensors] [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

2013-02-18 Thread Guenter Roeck
On Mon, Feb 18, 2013 at 07:30:28PM +0800, Wei Ni wrote: > Register the remote sensor to the thermal framework. > It can support to show the temperature and read/write threshold. > > Signed-off-by: Wei Ni > --- > arch/arm/boot/dts/tegra30-cardhu.dtsi |1 + > drivers/hwmon/lm90.c

Re: [lm-sensors] [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq

2013-02-18 Thread Guenter Roeck
On Mon, Feb 18, 2013 at 07:30:25PM +0800, Wei Ni wrote: > Add support to handle irq. When the temperature touch the limit value, the > driver can handle the interrupt. > > Signed-off-by: Alexandre Courbot > Signed-off-by: Wei Ni > --- > drivers/hwmon/lm90.c | 38 ++

Re: [lm-sensors] [RFC PATCH 2/9] hwmon: (lm90) split set&show temp as common codes

2013-02-18 Thread Guenter Roeck
On Mon, Feb 18, 2013 at 07:30:24PM +0800, Wei Ni wrote: > Split set&show temp codes as common functions, so we can use it directly when > implement linux thermal framework. > > Signed-off-by: Wei Ni > --- > drivers/hwmon/lm90.c | 117 > +++--- > 1 fi

[PATCH v5] iio: Add OF support

2013-02-07 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- v5: - Updated examples in bindings. v4: - Fixed wrong parameter to dummy of_iio_channel_get_by_name if CONFIG_OF is undefined, and wrong return value. - Initialize indio_dev->of_node

Re: [PATCH v4 2/2] iio: Add OF support

2013-02-06 Thread Guenter Roeck
On Wed, Feb 06, 2013 at 07:37:37PM +, Jonathan Cameron wrote: > On 02/06/2013 06:29 PM, Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter Roeck > looks good to me. Couple of little queries inline. >

Re: [PATCH v4 2/2] iio: Add OF support

2013-02-06 Thread Guenter Roeck
On Wed, Feb 06, 2013 at 07:37:37PM +, Jonathan Cameron wrote: > On 02/06/2013 06:29 PM, Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter Roeck > looks good to me. Couple of little queries inline. >

[PATCH v4 2/2] iio: Add OF support

2013-02-06 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- v4: - Fixed wrong parameter to dummy of_iio_channel_get_by_name if CONFIG_OF is undefined, and wrong return value. - Initialize indio_dev->of_node in iio_device_register if the calling driver neglec

Re: [PATCH v3 2/2] iio: Add OF support

2013-02-05 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 12:26:06PM -0800, Guenter Roeck wrote: > Provide bindings and parse OF data during initialization. > > Signed-off-by: Guenter Roeck > --- > One open question is how to assign of_node to the iio device. We can either > do it > in each driver (which t

Re: [PATCH v3 2/2] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 12:26:06PM -0800, Guenter Roeck wrote: > Provide bindings and parse OF data during initialization. > > Signed-off-by: Guenter Roeck Note: One of the parameters to the dummy function of_iio_channel_get_by_name() used when CONFIG_OF is undefined is wrong. I'

[PATCH v3 2/2] iio: Add OF support

2013-02-04 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- One open question is how to assign of_node to the iio device. We can either do it in each driver (which turns out to be a huge patchset), or add something like the following to iio_device_register

[PATCH v3 0/2] iio: Devicetree support

2013-02-04 Thread Guenter Roeck
This patch set adds basic device tree support to the IIO subsystem. It is the result of discussions [1] and [2]. Patch 1 changes the first parameter to iio_channel_get() to be the pointer to the consumer device instead of the consumer device name. Patch 2 adds basic OF support to the IIO subsyste

[PATCH 1/2] iio: Update iio_channel_get API to use consumer device pointer as argument

2013-02-04 Thread Guenter Roeck
For iio_channel_get to work with OF based configurations, it needs the consumer device pointer instead of the consumer device name as argument. Signed-off-by: Guenter Roeck --- drivers/extcon/extcon-adc-jack.c|3 +-- drivers/iio/inkern.c| 11 ++- drivers/power

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 07:00:55PM +0100, Tomasz Figa wrote: > On Monday 04 of February 2013 09:51:34 Guenter Roeck wrote: > > On Mon, Feb 04, 2013 at 09:12:14AM -0800, Guenter Roeck wrote: > > > On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: > > > > On

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 09:12:14AM -0800, Guenter Roeck wrote: > On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: > > On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: > > > On 02/03/2013 06:30 PM, Tomasz Figa wrote: > > > > On Sunday 03 of

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: > On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: > > On 02/03/2013 06:30 PM, Tomasz Figa wrote: > > > On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: > > >> On Sun, Feb 03, 20

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 08:22:13AM -0800, Guenter Roeck wrote: [ ... ] > > > + > > > + /* NULL terminated array to save passing size */ > > > + chans = kzalloc(sizeof(*chans)*(nummaps + 1), GFP_KERNEL); > > > > I think using kcalloc makes sense h

Re: [PATCH 1/4] iio: max1363: Use devm_ functions whereever possible to allocate resources

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 06:02:57PM +, Jonathan Cameron wrote: > On 02/03/2013 05:18 PM, Guenter Roeck wrote: > > On Sun, Feb 03, 2013 at 12:10:32PM +, Jonathan Cameron wrote: > >> On 02/03/2013 12:59 AM, Guenter Roeck wrote: > >>> Signed-off-by: Guenter Roeck

Re: [PATCH 1/4] iio: max1363: Use devm_ functions whereever possible to allocate resources

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 12:10:32PM +, Jonathan Cameron wrote: > On 02/03/2013 12:59 AM, Guenter Roeck wrote: > > Signed-off-by: Guenter Roeck > Applied to togreg branch of iio.git. > > Note I'll probably rebase the togreg branch if / when Greg has pulled > last pul

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: > On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: > > On 02/03/2013 03:06 AM, Guenter Roeck wrote: > > > On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: > > >> Hi Guenter, >

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 12:29:23PM +0100, Lars-Peter Clausen wrote: > On 02/03/2013 03:06 AM, Guenter Roeck wrote: > > On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: > >> Hi Guenter, > >> > >> Some comments inline. > >> > >>

Re: [RFC 10/11] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 11:57:53AM +, Jonathan Cameron wrote: > On 02/03/2013 11:52 AM, Lars-Peter Clausen wrote: > > On 02/03/2013 12:47 PM, Lars-Peter Clausen wrote: > >> On 02/03/2013 12:39 PM, Jonathan Cameron wrote: > >>> On 02/02/2013 04:10 PM, Guenter Roec

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 03:17:57PM +0100, Lars-Peter Clausen wrote: > On 02/03/2013 01:59 AM, Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter Roeck > > --- > > - Documentation update per feedbac

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-02 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: > Hi Guenter, > > Some comments inline. > > On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter R

[PATCH v2 4/4] iio: Add OF support

2013-02-02 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- - Documentation update per feedback - Dropped io-channel-output-names from the bindings document. The property is not used in the code, and it is not entirely clear what it would be used for. If there

  1   2   >