[PATCH AUTOSEL 6.10 027/121] drm/amd/display: Spinlock before reading event

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit ae13c8a5cff92015b9a3eb7cee65ebc75859487f ] [WHY & HOW] A read of acrtc_attach->base.state->event was not locked so moving it inside the spinlock. This fixes a LOCK_EVASION issue reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung

[PATCH AUTOSEL 6.10 026/121] drm/amd/display: Release clck_src memory if clk_src_construct fails

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 674704a5dabe4a434645fdd11e35437f4e06dfc4 ] [Why] Coverity reports RESOURCE_LEAK for some implemenations of clock_source_create. Do not release memory of clk_src if contructor fails. [How] Free clk_src if contructor fails. Reviewed-by: Harry Wentland

[PATCH AUTOSEL 6.10 025/121] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ] [Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen

[PATCH AUTOSEL 6.10 024/121] drm/amd/display: Fix Coverity INTERGER_OVERFLOW within construct_integrated_info

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 176abbcc71952e23009a6ed194fd203b99646884 ] [Why] For substrcation, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change varaible type to int32_t. Reviewed-by: Alex Hung Reviewed-by: Harry Wentland Acked-by: Tom

[PATCH AUTOSEL 6.10 023/121] drm/amd/display: Add otg_master NULL check within resource_log_pipe_topology_update

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 871cd9d881fa791d3f82885000713de07041c0ae ] [Why] Coverity reports NULL_RETURN warning. [How] Add otg_master NULL check. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher

[PATCH AUTOSEL 6.10 022/121] drm/amd/display: Check link_index before accessing dc->links[]

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit 8aa2864044b9d13e95fe224f32e808afbf79ecdf ] [WHY & HOW] dc->links[] has max size of MAX_LINKS and NULL is return when trying to access with out-of-bound index. This fixes 3 OVERRUN and 1 RESOURCE_LEAK issues reported by Coverity. Reviewed-by: Harry Wentland

[PATCH AUTOSEL 6.10 021/121] drm/amd/display: Release state memory if amdgpu_dm_create_color_properties fail

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 52cbcf980509e6190740dd1e2a1a437e8fb8101b ] [Why] Coverity reports RESOURCE_LEAK warning. State memory is not released if dm_create_color_properties fail. [How] Call kfree(state) before return. Reviewed-by: Alex Hung Reviewed-by: Harry Wentland Acked-by: Tom

[PATCH AUTOSEL 6.10 020/121] drm/amd/display: Check msg_id before processing transcation

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit fa71face755e27dc44bc296416ebdf2c67163316 ] [WHY & HOW] HDCP_MESSAGE_ID_INVALID (-1) is not a valid msg_id nor is it a valid array index, and it needs checking before used. This fixes 4 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland

[PATCH AUTOSEL 6.10 019/121] drm/amd/display: Skip updating link encoder for unknown eng_id

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit efabdce3db9f3d306084c8946983f3d895810a6b ] This prevents accessing to negative index of link_encoders array. This fixes an OVERRUN issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel

[PATCH AUTOSEL 6.10 018/121] drm/amd/display: Check num_valid_sets before accessing reader_wm_sets[]

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit b38a4815f79b87efb196cd5121579fc51e29a7fb ] [WHY & HOW] num_valid_sets needs to be checked to avoid a negative index when accessing reader_wm_sets[num_valid_sets - 1]. This fixes an OVERRUN issue reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom

[PATCH AUTOSEL 6.10 017/121] drm/amd/display: Add array index check for hdcp ddc access

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 4e70c0f5251c25885c31ee84a31f99a01f7cf50e ] [Why] Coverity reports OVERRUN warning. Do not check if array index valid. [How] Check msg_id valid and valid array index. Reviewed-by: Alex Hung Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel

[PATCH AUTOSEL 6.10 016/121] drm/amd/display: Add missing NULL pointer check within dpcd_extend_address_range

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 5524fa301ba649f8cf00848f91468e0ba7e4f24c ] [Why & How] ASSERT if return NULL from kcalloc. Reviewed-by: Alex Hung Reviewed-by: Rodrigo Siqueira Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher

[PATCH AUTOSEL 6.10 015/121] drm/amd/display: Check index for aux_rd_interval before using

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit 9ba2ea6337b4f159aecb177555a6a81da92d302e ] aux_rd_interval has size of 7 and should be checked. This fixes 3 OVERRUN and 1 INTEGER_OVERFLOW issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by:

[PATCH AUTOSEL 6.10 014/121] drm/amd/display: Fix incorrect size calculation for loop

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit 3941a3aa4b653b69876d894d08f3fff1cc965267 ] [WHY] fe_clk_en has size of 5 but sizeof(fe_clk_en) has byte size 20 which is lager than the array size. [HOW] Divide byte size 20 by its element size. This fixes 2 OVERRUN issues reported by Coverity. Reviewed-by:

[PATCH AUTOSEL 6.10 013/121] drm/amd/display: Stop amdgpu_dm initialize when link nums greater than max_links

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit cf8b16857db702ceb8d52f9219a4613363e2b1cf ] [Why] Coverity report OVERRUN warning. There are only max_links elements within dc->links. link count could up to AMDGPU_DM_MAX_DISPLAY_INDEX 31. [How] Make sure link count less than max_links. Reviewed-by: Harry

[PATCH AUTOSEL 6.10 012/121] drm/amd/display: Stop amdgpu_dm initialize when stream nums greater than 6

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 84723eb6068c50610c5c0893980d230d7afa2105 ] [Why] Coverity reports OVERRUN warning. Should abort amdgpu_dm initialize. [How] Return failure to amdgpu_dm_init. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler

[PATCH AUTOSEL 6.10 011/121] drm/amd/display: Add NULL pointer and OVERRUN check within amdgpu_dm irq register

2024-07-31 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 6e41709eb1d9207d88e46026baf9cc850206b374 ] [WHY] Coverity reports OVERRUN issues within amdgpu_dm interrupt registers. Do not check index value before access array. Do not check NULL pointer. [HOW] Add index value check for array. Add check for pointer from

[PATCH AUTOSEL 6.10 010/121] drm/amd/display: Check gpio_id before used as array index

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit 2a5626eeb3b5eec7a36886f9556113dd93ec8ed6 ] [WHY & HOW] GPIO_ID_UNKNOWN (-1) is not a valid value for array index and therefore should be checked in advance. This fixes 5 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung

[PATCH AUTOSEL 6.10 009/121] drm/amd/display: Ensure array index tg_inst won't be -1

2024-07-31 Thread Sasha Levin
From: Alex Hung [ Upstream commit 687fe329f18ab0ab0496b20ed2cb003d4879d931 ] [WHY & HOW] tg_inst will be a negative if timing_generator_count equals 0, which should be checked before used. This fixes 2 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung

[PATCH AUTOSEL 6.10 008/121] drm/amdgpu: fix uninitialized scalar variable warning

2024-07-31 Thread Sasha Levin
From: Tim Huang [ Upstream commit 0fa4c25db8b791f79bc0d5a0cd58aff9ad85186b ] Clear warning that field bp is uninitialized when calling amdgpu_virt_ras_add_bps. Signed-off-by: Tim Huang Reviewed-by: Yang Wang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.10 007/121] drm/amd/pm: fix the Out-of-bounds read warning

2024-07-31 Thread Sasha Levin
From: Jesse Zhang [ Upstream commit 12c6967428a099bbba9dfd247bb4322a984fcc0b ] using index i - 1U may beyond element index for mc_data[] when i = 0. Signed-off-by: Jesse Zhang Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.10 006/121] drm/amd/pm: Fix negative array index read

2024-07-31 Thread Sasha Levin
From: Jesse Zhang [ Upstream commit c8c19ebf7c0b202a6a2d37a52ca112432723db5f ] Avoid using the negative values for clk_idex as an index into an array pptable->DpmDescriptor. V2: fix clk_index return check (Tim Huang) Signed-off-by: Jesse Zhang Reviewed-by: Tim Huang Signed-off-by: Alex

[PATCH AUTOSEL 6.10 005/121] drm/amd/pm: fix warning using uninitialized value of max_vid_step

2024-07-31 Thread Sasha Levin
From: Jesse Zhang [ Upstream commit 17e3bea65cdc453695b2fe4ff26d25d17f5339e9 ] Check the return of pp_atomfwctrl_get_Voltage_table_v4 as it may fail to initialize max_vid_step V2: change the check condition (Tim Huang) Signed-off-by: Jesse Zhang Reviewed-by: Tim Huang Signed-off-by: Alex

[PATCH AUTOSEL 6.10 004/121] drm/amdgpu/pm: Check the return value of smum_send_msg_to_smc

2024-07-31 Thread Sasha Levin
From: Ma Jun [ Upstream commit 579f0c21baec9e7506b6bb3f60f0a9b6d07693b4 ] Check the return value of smum_send_msg_to_smc, otherwise we might use an uninitialized variable "now" Signed-off-by: Ma Jun Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.10 003/121] drm/amdgpu: fix overflowed array index read warning

2024-07-31 Thread Sasha Levin
From: Tim Huang [ Upstream commit ebbc2ada5c636a6a63d8316a3408753768f5aa9f ] Clear overflowed array index read warning by cast operation. Signed-off-by: Tim Huang Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.10 001/121] drm/amd/display: Enable RCO for PHYSYMCLK in DCN35

2024-07-31 Thread Sasha Levin
From: Daniel Miess [ Upstream commit f2303026a5b6327247ba61152d00199b2d1be294 ] [Why & How] Enable root clock optimization for PHYSYMCLK and only disable it when it's actively being used v2: Fix array-index-out-of-bounds in dcn35_calc_blocks_to_gate Reviewed-by: Roman Li Reviewed-by:

[PATCH AUTOSEL 6.10 002/121] drm/amd/display: Assign linear_pitch_alignment even for VM

2024-07-31 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 984debc133efa05e62f5aa1a7a1dd8ca0ef041f4 ] [Description] Assign linear_pitch_alignment so we don't cause a divide by 0 error in VM environments Reviewed-by: Sohaib Nadeem Acked-by: Wayne Lin Signed-off-by: Alvin Lee Tested-by: Daniel Wheeler Signed-off-by:

Re: [PATCH v4 2/3] drm/printer: Allow NULL data in devcoredump printer

2024-07-31 Thread Matthew Brost
On Wed, Jul 31, 2024 at 04:22:03PM -0600, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-xe On Behalf Of Matthew > Brost > Sent: Wednesday, July 31, 2024 2:32 PM > To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com;

Re: [PATCH v4 3/3] drm/xe: Faster devcoredump

2024-07-31 Thread Matthew Brost
On Wed, Jul 31, 2024 at 04:31:01PM -0600, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-xe On Behalf Of Matthew > Brost > Sent: Wednesday, July 31, 2024 2:32 PM > To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com;

Re: [PATCH v3 1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

2024-07-31 Thread Doug Anderson
Hi, On Mon, Jul 29, 2024 at 1:57 PM Rob Clark wrote: > > From: Rob Clark > > The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the > existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution. > > Signed-off-by: Rob Clark > Acked-by: Conor Dooley > --- >

RE: [PATCH v4 3/3] drm/xe: Faster devcoredump

2024-07-31 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Matthew Brost Sent: Wednesday, July 31, 2024 2:32 PM To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: maarten.lankho...@linux.intel.com; Vivi, Rodrigo Subject: [PATCH v4 3/3] drm/xe: Faster devcoredump > > The

RE: [PATCH v4 1/3] drm/xe: Take ref to VM in delayed snapshot

2024-07-31 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Matthew Brost Sent: Wednesday, July 31, 2024 2:32 PM To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: maarten.lankho...@linux.intel.com; Vivi, Rodrigo Subject: [PATCH v4 1/3] drm/xe: Take ref to VM in delayed snapshot

RE: [PATCH v4 2/3] drm/printer: Allow NULL data in devcoredump printer

2024-07-31 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Matthew Brost Sent: Wednesday, July 31, 2024 2:32 PM To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: maarten.lankho...@linux.intel.com; Vivi, Rodrigo Subject: [PATCH v4 2/3] drm/printer: Allow NULL data in

[PATCH v2] drm/edid: add CTA Video Format Data Block support

2024-07-31 Thread Hamza Mahfooz
Video Format Data Blocks (VFDBs) contain the necessary information that needs to be fed to the Optimized Video Timings (OVT) Algorithm. Also, we require OVT support to cover modes that aren't supported by earlier standards (e.g. CVT). So, parse all of the relevant VFDB data and feed it to the OVT

[PATCH v4 3/3] drm/xe: Faster devcoredump

2024-07-31 Thread Matthew Brost
The current algorithm to read out devcoredump is O(N*N) where N is the size of coredump due to usage of the drm_coredump_printer in xe_devcoredump_read. Switch to a O(N) algorithm which prints the devcoredump into a readable format in snapshot work and update xe_devcoredump_read to memcpy from the

[PATCH v4 2/3] drm/printer: Allow NULL data in devcoredump printer

2024-07-31 Thread Matthew Brost
Useful to determine size of devcoreump before writing it out. Cc: Maarten Lankhorst Signed-off-by: Matthew Brost --- drivers/gpu/drm/drm_print.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index

[PATCH v4 1/3] drm/xe: Take ref to VM in delayed snapshot

2024-07-31 Thread Matthew Brost
Kernel BO's don't take a ref to the VM, we need to the VM for the delayed snapshot, so take a ref to the VM in delayed snapshot. v2: - Check for lrc_bo before taking a VM ref (CI) - Check lrc_bo->vm before taking / dropping a VM ref (CI) - Drop VM in xe_lrc_snapshot_free 47058633d9c5

[PATCH v4 0/3] Faster devcoredump and fixes

2024-07-31 Thread Matthew Brost
Combine [1] [2] for complete series to speedup devcoredump and fix it. [1] https://patchwork.freedesktop.org/series/136541/ [2] https://patchwork.freedesktop.org/series/136545/ Matthew Brost (3): drm/xe: Take ref to VM in delayed snapshot drm/printer: Allow NULL data in devcoredump printer

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-31 Thread Doug Anderson
Hi, On Mon, Jul 29, 2024 at 11:07 PM Tejas Vipin wrote: > +/** > + * mipi_dsi_dcs_get_display_brightness_multi() - gets the current brightness > value > + *of the display > + * @ctx: Context for multiple DSI transactions > + * @brightness: brightness value > + * > + * Like

Re: [PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart()

2024-07-31 Thread Mina Almasry
On Tue, Jul 30, 2024 at 4:17 AM Xuan Zhuo wrote: > > On Tue, 30 Jul 2024 02:26:05 +, Mina Almasry > wrote: > > Add netdev_rx_queue_restart() function to netdev_rx_queue.h > > > Can you say more? As far as I understand, we just release the buffer > submitted to the rx ring and get a new page

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-07-31 Thread Daniel Vetter
On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote: > On Wed, 31 Jul 2024, Thomas Weißschuh wrote: > > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > > is "12". This leads to a fairly bright minimum display backlight. > > > > Add a generic override helper for

Re: [PATCH] udmabuf: use kmem_cache to alloc udmabuf folio

2024-07-31 Thread Daniel Vetter
On Wed, Jul 31, 2024 at 11:34:49AM +0800, Huan Yang wrote: > The current udmabuf_folio contains a list_head and the corresponding > folio pointer, with a size of 24 bytes. udmabuf_folio uses kmalloc to > allocate memory. > > However, kmalloc is a public pool, starting from 64 bytes. This means >

Re: [PATCH v2 0/5] Introduce DMA_HEAP_ALLOC_AND_READ_FILE heap flag

2024-07-31 Thread Daniel Vetter
On Tue, Jul 30, 2024 at 08:04:04PM +0800, Huan Yang wrote: > > 在 2024/7/30 17:05, Huan Yang 写道: > > > > 在 2024/7/30 16:56, Daniel Vetter 写道: > > > [? daniel.vet...@ffwll.ch ? > > > https://aka.ms/LearnAboutSenderIdentification?] > > > > > > On Tue, Jul 30, 2024 at

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-31 Thread Daniel Vetter
On Tue, Jul 30, 2024 at 02:06:08PM +0200, Christian König wrote: > Am 30.07.24 um 10:36 schrieb Daniel Vetter: > > > In the end you have a really nice circle dependency. > > Maybe a follow up, so for arb robustness or vk context where we want the > > context to die and refuse to accept any more

[PATCH] drm: bridge: anx7625: Use of_property_read_variable_u8_array()

2024-07-31 Thread Rob Herring (Arm)
There's no need to get the length of an DT array property before parsing the array. of_property_read_variable_u8_array() takes a minimum and maximum length and returns the actual length (or error code). This is part of a larger effort to remove callers of of_get_property() and similar functions.

[PATCH] drm: mediatek: Drop unnecessary check for property presence

2024-07-31 Thread Rob Herring (Arm)
of_property_read_u32() returns -EINVAL if a property is not present, so the preceeding check for presence with of_find_property() can be dropped. Really, what the errno is shouldn't matter. Either the property can be read and used or it can't and is ignored. This is part of a larger effort to

Re: [PATCH] drm/bridge-connector: Fix double free in error handling paths

2024-07-31 Thread Cristian Ciocaltea
Hi Robert, On 7/18/24 3:02 PM, Robert Foss wrote: > On Thu, 11 Jul 2024 14:26:55 +0300, Cristian Ciocaltea wrote: >> The recent switch to drmm allocation in drm_bridge_connector_init() may >> cause double free on bridge_connector in some of the error handling >> paths. >> >> Drop the explicit

Re: [PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-07-31 Thread Bjorn Helgaas
On Mon, Jul 29, 2024 at 11:36:24AM +0200, Philipp Stanner wrote: > Hi everyone, > > Now that we've got the simplified PCI devres API available we can slowly > start using it in drivers and step by step phase the more problematic > API out. > > vboxvideo currently does not have a region request,

Re: [PATCH v5 02/12] drm/msm/dpu: relax YUV requirements

2024-07-31 Thread Abhinav Kumar
On 6/26/2024 2:45 PM, Dmitry Baryshkov wrote: YUV formats require only CSC to be enabled. Even decimated formats should not require scaler. Relax the requirement and don't check for the scaler block while checking if YUV format can be enabled. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU

Re: [PATCH v5 01/12] drm/msm/dpu: limit QCM2290 to RGB formats only

2024-07-31 Thread Abhinav Kumar
On 6/26/2024 2:45 PM, Dmitry Baryshkov wrote: The QCM2290 doesn't have CSC blocks, so it can not support YUV formats even on ViG blocks. Fix the formats declared by _VIG_SBLK_NOSCALE(). Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS") Signed-off-by: Dmitry Baryshkov ---

[PATCH] drm/msm/dpu: move dpu_encoder's connector assignment to atomic_enable()

2024-07-31 Thread Abhinav Kumar
For cases where the crtc's connectors_changed was set without enable/active getting toggled , there is an atomic_enable() call followed by an atomic_disable() but without an atomic_mode_set(). This results in a NULL ptr access for the dpu_encoder_get_drm_fmt() call in the atomic_enable() as the

[PATCH] drm: vc4: Use of_property_present()

2024-07-31 Thread Rob Herring (Arm)
Use of_property_present() to test for property presence rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated

[PATCH v2] drm/atomic: allow no-op FB_ID updates for async flips

2024-07-31 Thread Simon Ser
User-space is allowed to submit any property in an async flip as long as the value doesn't change. However we missed one case: as things stand, the kernel rejects no-op FB_ID changes on non-primary planes. Fix this by changing the conditional and skipping drm_atomic_check_prop_changes() only for

Re: [PATCH v2 2/2] drm/atomic: Allow userspace to use damage clips with async flips

2024-07-31 Thread Simon Ser
I've pushed both patches to drm-misc-fixes, thanks! I've added a Fixes trailer accordingly. I'll rebase my patch on top of these two.

[PATCH v2 1/2] drm/msm/a6xx: Add A642L speedbin (0x81)

2024-07-31 Thread Danila Tikhonov
From: Eugene Lepshy According to downstream, A642L's speedbin is 129 and uses 4 as index Signed-off-by: Eugene Lepshy Signed-off-by: Danila Tikhonov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 2/2] arm64: dts: qcom: sc7280: Add 0x81 Adreno speed bin

2024-07-31 Thread Danila Tikhonov
From: Eugene Lepshy A642L (speedbin 0x81) uses index 4, so this commit sets the fourth bit for A642L supported opps. Signed-off-by: Eugene Lepshy Signed-off-by: Danila Tikhonov Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 1 file changed, 4 insertions(+),

[PATCH v2 0/2] Add Qualcomm Adreno 642L speedbin and update SC7280 OPPs

2024-07-31 Thread Danila Tikhonov
This patch series adds support for the A642L GPU speedbin (0x81) to the Adreno driver and updates the device tree for the SC7280 platform to include this new speedbin. The A642L is used in the Qualcomm Snapdragon SM7325 SoCs family, which is identical to the SC7280, just as the SM7125 is identical

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-07-31 Thread Jani Nikula
On Wed, 31 Jul 2024, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic override helper for the user to override the settings > provided by the firmware through

Re: [PATCH v3] udmabuf: use kmem_cache to alloc udmabuf folio

2024-07-31 Thread Christophe JAILLET
Le 31/07/2024 à 09:37, Huan Yang a écrit : The current udmabuf_folio contains a list_head and the corresponding folio pointer, with a size of 24 bytes. udmabuf_folio uses kmalloc to allocate memory. However, kmalloc is a public pool, starting from 8,16,32 bytes. Additionally, if the size is not

Re: [PATCH] drm/mgag200: Fix VBLANK interrupt handling

2024-07-31 Thread Jocelyn Falempe
On 31/07/2024 09:09, Thomas Zimmermann wrote: Fix support for VBLANK interrupts on G200ER, G200EV and G200SE, which use a slightly different implementation than the others. The original commits forgot to update the custom helpers when adding interrupt handling for VBLANK events. Thanks, it

[PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-07-31 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a generic override helper for the user to override the settings provided by the firmware through the kernel cmdline. Also add amdgpu as a user of that

[PATCH v3 2/2] drm/amd/display: implement minimum brightness override

2024-07-31 Thread Thomas Weißschuh
This is useful if the minimum backlight as reported by machines VBT does not match the user expectations. As an example, the minimum backlight brightness on the Framework 13 matte panel is too high. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6

[PATCH v3 1/2] drm/connector: add drm_connector_get_cmdline_min_brightness_override()

2024-07-31 Thread Thomas Weißschuh
Add a helper which can read a overridden minimum backlight value from the kernel cmdline. This is useful if the minimum backlight as reported by machines VBT does not match the user expectations. As an example, the minimum backlight brightness on the Framework 13 matte panel is too high.

Re: [PATCH V2 09/16] drm/vc4: v3d: simplify clock retrieval

2024-07-31 Thread Stefan Wahren
Hi Maíra, Am 30.07.24 um 13:23 schrieb Maíra Canal: On 7/28/24 10:00, Stefan Wahren wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe() and devm_clk_get_optional(). This results in much less code. Signed-off-by: Stefan Wahren ---  

Re: [PATCH v2 0/3] drm/msm: Further expose UBWC tiling parameters

2024-07-31 Thread Rob Clark
On Wed, Jul 3, 2024 at 3:54 AM Connor Abbott wrote: > > After testing, there are more parameters that we're programming which > affect how UBWC tiles are laid out in memory and therefore affect > the Mesa implementation of VK_EXT_host_image_copy [1], which includes a > CPU implementation of

Re: [PATCH] drm/edid: add CTA Video Format Data Block support

2024-07-31 Thread Hamza Mahfooz
On 7/31/24 04:36, Jani Nikula wrote: On Tue, 30 Jul 2024, Hamza Mahfooz wrote: Video Format Data Blocks (VFDBs) contain the necessary information that needs to be fed to the Optimized Video Timings (OVT) Algorithm. Also, we require OVT support to cover modes that aren't supported by earlier

[PATCH] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-07-31 Thread Marco Rodolfi
From: Marco Rodolfi This patch also take account of the different resolution for the aftermarket DeckHD panel, which hasn't been accounted for yet in kernel, since these quirks are applied based on BIOS information + panel resolution. This patch correct that problem and make the panel oriented

[PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

2024-07-31 Thread Riyan Dhiman
Adhere to Linux kernel coding style Reported by checkpatch: CHECK: mutex definition without comment Signed-off-by: Riyan Dhiman --- drivers/staging/vme_user/vme_bridge.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/vme_user/vme_bridge.h

[PATCH] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-07-31 Thread Marco Rodolfi
This patch also take account of the different resolution for the aftermarket DeckHD panel, which hasn't been accounted for yet in kernel, since these quirks are applied based on BIOS information + panel resolution. This patch correct that problem and make the panel oriented the right way.

[PATCH] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-07-31 Thread Marco Rodolfi
Signed-off-by: Marco Rodolfi --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 3860a8ce1e2d..32582dbdc184 100644 ---

[PATCH] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-07-31 Thread Marco Rodolfi
From: Marco Rodolfi Signed-off-by: Marco Rodolfi --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index

Issues with sending patch to this mailing list

2024-07-31 Thread marco . rodolfi
Hi, I have a patch staged to fix a quirks in the DRM rendering manager, but it seems that I can't send it up using an old email alias on gmail (since my current client, tutanota, do not support smtp and copy-pasting patches usually always screw up whitespaces). I do not get nothing back from

Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

2024-07-31 Thread Riyan Dhiman
Hello, Thank you for reviewing my patch. I received your feedback: > Are you sure about all of these? Please document them individually and > put the proof of that in the changelog text. I'd like to clarify a few points to ensure I address your concerns correctly: 1. By "document them

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-07-31 Thread Hans Verkuil
Hi Maxime, On 27/05/2024 15:57, Maxime Ripard wrote: > Hans Verkuil also expressed interest in implementing a mechanism in v4l2 > to retrieve infoframes from HDMI receiver and implementing a tool to > decode (and eventually check) infoframes. His current work on > edid-decode to enable that

Re: [PATCH v2 3/5] dma-buf: heaps: support alloc async read file

2024-07-31 Thread kernel test robot
Hi Huan, kernel test robot noticed the following build warnings: [auto build test WARNING on 931a3b3bccc96e7708c82b30b2b5fa82dfd04890] url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/dma-buf-heaps-Introduce-DMA_HEAP_ALLOC_AND_READ_FILE-heap-flag/20240730-170340 base:

Re: [PATCH 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a

2024-07-31 Thread Rob Herring (Arm)
On Mon, 29 Jul 2024 21:38:45 -0400, Richard Acayan wrote: > This adds support for the speed-binned A615 GPU on SDM670. > > Richard Acayan (4): > dt-bindings: display/msm/gmu: Add SDM670 compatible > drm/msm/adreno: add a615 support > arm64: dts: qcom: sdm670: add gpu > arm64: dts: qcom:

Re: [PATCH v2 09/16] drm/imx: Add i.MX8qxp Display Controller KMS

2024-07-31 Thread Dmitry Baryshkov
On Tue, Jul 30, 2024 at 04:31:35PM GMT, Liu Ying wrote: > On 07/28/2024, Dmitry Baryshkov wrote: > > On Fri, Jul 12, 2024 at 05:32:36PM GMT, Liu Ying wrote: > >> i.MX8qxp Display Controller(DC) is comprised of three main components that > >> include a blit engine for 2D graphics accelerations,

Re: [PATCH v2 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-07-31 Thread Laurent Pinchart
Hi Biju, On Mon, Jul 29, 2024 at 09:05:59AM +, Biju Das wrote: > On Saturday, July 27, 2024 1:50 AM, Laurent Pinchart wrote: > > On Tue, Jul 09, 2024 at 02:51:41PM +0100, Biju Das wrote: > > > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > > > SoC, but has only DPI

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-07-31 Thread Dmitry Baryshkov
On Wed, Jul 31, 2024 at 03:12:44PM GMT, Philipp Zabel wrote: > Hi Dmitry, > > On Sa, 2024-07-27 at 14:17 +0300, Dmitry Baryshkov wrote: > > On Sun, Jun 02, 2024 at 03:04:40PM GMT, Dmitry Baryshkov wrote: > > > The IPUv3 DRM i.MX driver contains several codepaths for different > > > usescases:

Re: [PATCH 3/4] arm64: dts: qcom: sdm670: add gpu

2024-07-31 Thread Dmitry Baryshkov
On Mon, Jul 29, 2024 at 09:38:48PM GMT, Richard Acayan wrote: > The Snapdragon 670 has the Adreno A615 GPU. Add it along with its device > tree dependencies. > > Signed-off-by: Richard Acayan > --- > arch/arm64/boot/dts/qcom/sdm670.dtsi | 168 +++ > 1 file changed, 168

Re: [PATCH v4 0/5] Support alpha blending in MTK display driver

2024-07-31 Thread Chun-Kuang Hu
Hi, Shawn: Hsiao Chien Sung via B4 Relay 於 2024年7月17日 週三 下午1:24寫道: > > Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by > adding correct blend mode property when the planes init. > Before this patch, only the "Coverage" mode (default) is supported. For the whole series,

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-07-31 Thread Philipp Zabel
Hi Dmitry, On Sa, 2024-07-27 at 14:17 +0300, Dmitry Baryshkov wrote: > On Sun, Jun 02, 2024 at 03:04:40PM GMT, Dmitry Baryshkov wrote: > > The IPUv3 DRM i.MX driver contains several codepaths for different > > usescases: both LDB and paralllel-display drivers handle next-bridge, > > panel and the

[PATCH 2/2] staging: olpc_dcon: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Jens Frederich Cc: Jon Nettleton Cc: Greg Kroah-Hartman ---

[PATCH 0/2] staging: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for power states") introduced dedicated constants for backlight power states. Convert staging drivers to the new constants. The new constants replace the fbdev constants. This is part of a larger effort to make kernel subsystems more

[PATCH 1/2] staging: fbtft: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Greg Kroah-Hartman --- drivers/staging/fbtft/fb_ssd1351.c | 2 +-

Re: [PATCH 2/9] drm/i915: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Hi Am 31.07.24 um 14:56 schrieb Jani Nikula: On Wed, 31 Jul 2024, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc:

Re: [PATCH 2/9] drm/i915: Use backlight power constants

2024-07-31 Thread Jani Nikula
On Wed, 31 Jul 2024, Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc:

Re: [PATCH v4 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-07-31 Thread Adrián Larumbe
Hi Steven, thanks for the remarks. On 19.07.2024 15:14, Steven Price wrote: > On 16/07/2024 21:11, Adrián Larumbe wrote: > > Enable calculations of job submission times in clock cycles and wall > > time. This is done by expanding the boilerplate command stream when running > > a job to include

[PATCH 8/9] fbdev: rivafb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Cc: Helge Deller --- drivers/video/fbdev/riva/fbdev.c | 2 +- 1 file changed, 1

[PATCH 9/9] fbdev: sh_mobile_lcdc_fb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- 1 file changed, 3

[PATCH 5/9] fbdev: nvidiafb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas Cc: Helge Deller --- drivers/video/fbdev/nvidia/nv_backlight.c | 2 +- 1 file

[PATCH 6/9] fbdev: omapfb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 4 ++--

[PATCH 7/9] fbdev: radeonfb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Benjamin Herrenschmidt Cc: Helge Deller --- drivers/video/fbdev/aty/radeon_backlight.c | 2 +- 1

[PATCH 4/9] fbdev: chipsfb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/9] fbdev: atyfb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/9] fbdev: atmel_lcdfb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Nicolas Ferre Cc: Helge Deller Cc: Alexandre Belloni Cc: Claudiu Beznea ---

[PATCH 2/9] fbdev: aty128fb: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/aty/aty128fb.c | 6 +++--- 1 file changed, 3 insertions(+),

[PATCH 0/9] fbdev: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for power states") introduced dedicated constants for backlight power states. Convert fbdev drivers to the new constants. The new constants replace the fbdev constants. This is part of a larger effort to make kernel subsystems more

Re: [bug report] drm/omap: gem: Replace struct_mutex usage with omap_obj private lock

2024-07-31 Thread Laurent Pinchart
Hi Dan, (CC'ing Tomi) Thank for the report. It indeed seems that something is wrong. Tomi, could you handle this and send a fix ? On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote: > Hello Laurent Pinchart, > > Commit 3cbd0c587b12 ("drm/omap: gem: Replace struct_mutex usage with >

[PATCH 8/9] drm/radeon: Use backlight power constants

2024-07-31 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan ---

<    1   2   3   4   5   6   7   8   9   10   >