On 2021-09-06 17:38, Uma Shankar wrote:
> Define the structure with XE_LPD degamma lut ranges. HDR and SDR
> planes have different capabilities, implemented respective
> structure for the HDR planes.
>
> Signed-off-by: Uma Shankar
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 52 ++
On 2021-11-04 04:38, Pekka Paalanen wrote:
> On Wed, 3 Nov 2021 11:08:13 -0400
> Harry Wentland wrote:
>
>> On 2021-09-06 17:38, Uma Shankar wrote:
>>> Existing LUT precision structure is having only 16 bit
>>> precision. This is not enough for upcoming e
+Nick
It looks to be the old drm_plane_state->fb holds that reference. See
dm_plane_helper_cleanup_fb() in amdgpu_dm.c.
Harry
On 2021-11-04 08:51, Christian König wrote:
> Hi guys,
>
> adding the usual suspects which might know that of hand: When we do a KMS
> page flip, who keeps the referen
On 2021-11-05 08:59, Ville Syrjälä wrote:
> On Wed, Nov 03, 2021 at 11:10:37AM -0400, Harry Wentland wrote:
>>
>>
>> On 2021-09-06 17:38, Uma Shankar wrote:
>>> Define the structure with XE_LPD degamma lut ranges. HDR and SDR
>>> planes have differe
On 2021-11-05 07:49, Ville Syrjälä wrote:
> On Thu, Nov 04, 2021 at 12:27:56PM -0400, Harry Wentland wrote:
>>
>>
>> On 2021-11-04 04:38, Pekka Paalanen wrote:
>>> On Wed, 3 Nov 2021 11:08:13 -0400
>>> Harry Wentland wrote:
>>>
>>>>
On 2021-11-08 04:54, Pekka Paalanen wrote:
> On Thu, 4 Nov 2021 12:27:56 -0400
> Harry Wentland wrote:
>
>> On 2021-11-04 04:38, Pekka Paalanen wrote:
>>> On Wed, 3 Nov 2021 11:08:13 -0400
>>> Harry Wentland wrote:
>>>
>>>> On 202
On 2021-11-09 16:45, Ville Syrjälä wrote:
> On Tue, Nov 09, 2021 at 03:19:47PM -0500, Harry Wentland wrote:
>> On 2021-11-05 08:59, Ville Syrjälä wrote:
>>> On Wed, Nov 03, 2021 at 11:10:37AM -0400, Harry Wentland wrote:
>>>>
>>>>
>>>> On
On 2021-11-10 06:55, Ville Syrjälä wrote:
> On Wed, Nov 10, 2021 at 10:49:24AM +0200, Pekka Paalanen wrote:
>> On Wed, 10 Nov 2021 00:02:16 +0200
>> Ville Syrjälä wrote:
>>
>>> On Tue, Nov 09, 2021 at 03:47:58PM -0500, Harry Wentland wrote:
>>>>
On 2021-11-05 03:35, Yuan, Perry wrote:
> [AMD Official Use Only]
>
> Hi Jani:
>
>
>> -Original Message-
>> From: Jani Nikula
>> Sent: Wednesday, November 3, 2021 7:31 PM
>> To: Yuan, Perry ; Maarten Lankhorst
>> ; Maxime Ripard
>> ; Thomas Zimmermann ;
>> David Airlie ; Daniel Vetter
On 2021-09-06 17:38, Uma Shankar wrote:
> Define the structure with XE_LPD degamma lut ranges. HDR and SDR
> planes have different capabilities, implemented respective
> structure for the HDR planes.
>
> Signed-off-by: Uma Shankar
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 52 ++
On 2021-11-11 15:42, Shankar, Uma wrote:
>
>
>> -Original Message-
>> From: Ville Syrjälä
>> Sent: Thursday, November 11, 2021 10:13 PM
>> To: Harry Wentland
>> Cc: Shankar, Uma ; intel-...@lists.freedesktop.org;
>> dri-
>>
On 2021-11-12 03:37, Pekka Paalanen wrote:
> On Thu, 11 Nov 2021 21:58:35 +
> "Shankar, Uma" wrote:
>
>>> -Original Message-----
>>> From: Harry Wentland
>>> Sent: Friday, November 12, 2021 2:41 AM
>>> To: Shankar, Uma ; Ville Sy
On 2021-09-06 17:38, Uma Shankar wrote:
> This is a RFC proposal for plane color hardware blocks.
> It exposes the property interface to userspace and calls
> out the details or interfaces created and the intended
> purpose.
>
> Credits: Ville Syrjälä
> Signed-off-by: Uma Shankar
> ---
> Doc
On 2021-11-18 04:50, Pekka Paalanen wrote:
> On Mon, 15 Nov 2021 15:17:45 +0530
> Bhanuprakash Modem wrote:
>
>> From the Plane Color Management feature design, userspace can
>> take the smart blending decisions based on hardware supported
>> plane color features to obtain an accurate color pr
On 2021-11-15 04:47, Bhanuprakash Modem wrote:
> To verify Plane gamma, draw 3 gradient rectangles in red, green and blue,
> with a maxed out gamma LUT and verify we have the same CRC as drawing solid
> color rectangles.
>
> Cc: Harry Wentland
> Cc: Ville Syrjälä
> Cc
On 2021-11-15 04:47, Bhanuprakash Modem wrote:
> To verify plane CTM, draw 3 rectangles using before colors with the
> ctm matrix applied and verify the CRC is equal to using after colors
> with an identify ctm matrix.
>
> Cc: Harry Wentland
> Cc: Ville Syrjälä
> Cc
On 2021-11-15 04:47, Bhanuprakash Modem wrote:
> From: Mukunda Pramodh Kumar
>
> Add helper functions to support logarithmic gamma mode
>
> Cc: Harry Wentland
> Cc: Ville Syrjälä
> Cc: Juha-Pekka Heikkila
> Cc: Uma Shankar
> Signed-off-by: Mukunda Pra
On 2021-11-15 04:47, Bhanuprakash Modem wrote:
> Add helper functions to support Plane color management properties.
>
> Cc: Harry Wentland
> Cc: Ville Syrjälä
> Cc: Juha-Pekka Heikkila
> Cc: Uma Shankar
> Signed-off-by: Bhanuprakash Modem
> ---
> tes
On 2021-11-18 04:19, Pekka Paalanen wrote:
> On Mon, 15 Nov 2021 15:17:52 +0530
> Bhanuprakash Modem wrote:
>
>> Negative check for:
>> * plane gamma lut sizes
>> * plane degamma lut sizes
>> * plane ctm matrix sizes
>>
>> Cc: Harry Went
On 2021-11-29 04:20, Pekka Paalanen wrote:
> On Fri, 26 Nov 2021 11:54:55 -0500
> Harry Wentland wrote:
>
>> On 2021-11-18 04:50, Pekka Paalanen wrote:
>>> On Mon, 15 Nov 2021 15:17:45 +0530
>>> Bhanuprakash Modem wrote:
>>>
>>>> Fro
On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote:
>
>
> On 2021-11-29 7:06 a.m., Jani Nikula wrote:
>> On Fri, 26 Nov 2021, Daniel Vetter wrote:
>>> On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote:
Display core documentation is not well organized, and it is hard to find
>
On 2021-11-30 10:59, Rodrigo Siqueira Jordao wrote:
>
>
> On 2021-11-30 10:48 a.m., Harry Wentland wrote:
>> On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote:
>>>
>>>
>>> On 2021-11-29 7:06 a.m., Jani Nikula wrote:
>>>> On Fri, 26 Nov
Thanks for this. It's really good to see this.
Reviewed-by: Harry Wentland
Harry
On 2021-12-09 09:20, Rodrigo Siqueira wrote:
> Display Core (DC) is one of the components under amdgpu, and it has
> multiple features directly related to the KMS API. Unfortunately, we
> don
On 2021-12-09 01:23, Kees Cook wrote:
> On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote:
>> On Fri, 03 Dec 2021, Kees Cook wrote:
>>> The link_status array was not large enough to read the Adjust Request
>>> Post Cursor2 register. Adjust the size to include it. Found with a
>>> -War
rence before null check")
> Fixes: 3f68c01be9a22 ("drm/amd/display: add cyan_skillfish display support")
> Signed-off-by: José Expósito
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 3 ++-
> 1 file changed, 2 insertions(+),
On 2022-01-02 23:05, Modem, Bhanuprakash wrote:
>> From: Harry Wentland
>> Sent: Friday, November 26, 2021 10:25 PM
>> To: Modem, Bhanuprakash ; igt-
>> d...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Cc: Ville Syrjälä ; Juha-Pekka Heikkila
>>
On 2022-01-02 23:11, Modem, Bhanuprakash wrote:
>> From: Harry Wentland
>> Sent: Monday, November 29, 2021 8:50 PM
>> To: Pekka Paalanen
>> Cc: dri-devel@lists.freedesktop.org; Modem, Bhanuprakash
>> ; igt-...@lists.freedesktop.org; Kumar,
>> Mukunda Pramod
On 2022-01-05 06:21, Modem, Bhanuprakash wrote:
>> From: Harry Wentland
>> Sent: Wednesday, January 5, 2022 2:49 AM
>> To: Modem, Bhanuprakash ; igt-
>> d...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Cc: Ville Syrjälä ; Shankar, Uma
>> ; ppaa
t; Fixes: e27c41d5b0681 ("drm/amd/display: Support for DMUB HPD interrupt
> handling")
> Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
> Signed-off-by: José Expósito
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/
om
synchronization.
v2:
Don't drop is_blanked logic
Reviewed-by: Jun Lei
Reviewed-by: Mustapha Ghaddar
Acked-by: Bhawanpreet Lakha
Signed-off-by: meenakshikumar somasundaram
Tested-by: Daniel Wheeler
Signed-off-by: Alex Deucher
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/disp
On 2022-01-11 15:51, Linus Torvalds wrote:
> On Tue, Jan 11, 2022 at 7:38 AM Harry Wentland wrote:
>>
>> Attached is a v2 of the buggy patch that should get this right.
>> If you have a chance to try it out let us know
>
> I can confirm that I do not see the horrib
x27;t take this into account
and forced voters to rank every candidate. Due to the lack of
controversy about the candidates we don't expect this to have had any
impact on the final results.
Thanks,
Harry Wentland,
On behalf of the Xorg
On 2019-04-30 3:56 p.m., Mario Kleiner wrote:
> [CAUTION: External Email]
>
> On Tue, Apr 30, 2019 at 2:22 PM Kazlauskas, Nicholas
> wrote:
>>
>> On 4/30/19 3:44 AM, Michel Dänzer wrote:
>>> [CAUTION: External Email]
>>>
>>> On 2019-04-30 9:37 a.m., Mario Kleiner wrote:
Allow to detect any
It was there all along in the patch description when this change was
introduced but it would be helpful to have the same documented in the
code.
Signed-off-by: Harry Wentland
Cc: Sean Paul
Cc: Sean Paul
Cc: Bhawanpreet Lakha
---
drivers/gpu/drm/drm_connector.c | 9 +
1 file changed
now since that's all the
> DRM interface supports. It requires a modeset for entering and exiting HDR
> but the metadata can be changed without one.
>
> Cc: Harry Wentland
>
Series is
Reviewed-by: Harry Wentland
Harry
> Nicholas Kazlauskas (2):
> drm/amd/dis
On 2019-05-30 12:12 p.m., Colin King wrote:
> From: Colin Ian King
>
> The variable status is initialized with a value that is never read
> and status is reassigned several statements later. This initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-
2:35 p.m., Dingchen Zhang wrote:
> 'n-1' is the index to replace the newline character of CRC source name.
>
Add here:
v2: Update patch subject (Sam)
> Cc: Leo Li
> Cc: Harry Wentland
> Signed-off-by: Dingchen Zhang
> ---
> drivers/gpu/drm/drm_debugfs_crc.c
blems for Rockchip with the Analogix
bridge.
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c
> b/drivers/gpu/drm/drm_debugfs_crc.c
> index e20ad
arm32's udelay only allows values up to 2000 microseconds. msleep
does the trick for us here as there is no problem if this isn't
microsecond accurate and takes a tad longer.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
1 file changed, 1
(I'm sending this as an email as lowest common denominator but feel an issue on
the color-and-hdr repo would be a better interface for productive discussion.
Please pop over to https://gitlab.freedesktop.org/pq/color-and-hdr/-/issues/10
if you agree. Hopefully we can drive the discussion there b
On 2022-06-14 11:57, Randy Dunlap wrote:
> Fix build error when CONFIG_DEBUG_FS is not enabled by adding a
> stub function for crtc_debugfs_init().
>
> Eliminates this build error:
>
> ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
> ‘amdgpu_dm_crtc_late_register’:
>
On 2022-06-15 17:00, Alex Deucher wrote:
> amdgpu_dm_crtc_late_register is only used when CONFIG_DEBUG_FS
> so make it dependent on that.
>
> Fixes: 4cd79f614b50 ("drm/amd/display: Move connector debugfs to drm")
> Cc: Bhanuprakash Modem
> Cc: Harry Wentland
>
ne gamma feature. We
> can build up and add other platform/hardware specific implementation
> on top of this series.
>
> Credits: Special mention and credits to Ville Syrjala for coming up
> with a design for this feature and inputs. This series is based on
> his original desig
call to drm_plane_create_color_properties
with a default of BT709 means we're getting BT709 as color_encoding
as part of atomic commits.
Harry
> Fix the mismatch by using an initial value of BT601 in
> drm_plane_create_color_properties().
>
> Cc: amd-...@lists.freedesktop.or
On 2022-02-07 13:57, Harry Wentland wrote:
> On 2022-02-07 11:34, Maxime Ripard wrote:
>> The amdgpu KMS driver calls drm_plane_create_color_properties() with a
>> default encoding set to BT709.
>>
>> However, the core will ignore it and the driver doesn't forc
some code in __drm_atomic_helper_plane_state_reset() to get
> the initial zpos value if the property has been attached in order to fix
> this.
>
> Signed-off-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/dr
igned-off-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_atomic_state_helper.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c
> b/drivers/
On 2022-02-10 03:42, Maxime Ripard wrote:
> Hi Harry,
>
> On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote:
>> On 2022-02-07 13:57, Harry Wentland wrote:
>>> On 2022-02-07 11:34, Maxime Ripard wrote:
>>>> The amdgpu KMS driver calls drm_pl
On 2022-04-22 10:28, Melissa Wen wrote:
On 04/21, Harry Wentland wrote:
On 2022-04-21 15:20, Melissa Wen wrote:
On 04/21, Harry Wentland wrote:
On 2022-04-21 10:37, Melissa Wen wrote:
Hi all,
I'm examining how DRM color management properties (degamma, ctm, gamma)
are applied t
On 2022-04-27 04:08, Ryan Lin wrote:
Disable ABM feature when the system is running on AC mode to get the more
perfect contrast of the display.
v2: remove "UPSTREAM" from the subject.
v3: adv->pm.ac_power updating by amd gpu_acpi_event_handler.
V4: Add the file I lost to fix the build error
On 2022-04-27 06:52, Pekka Paalanen wrote:
> Hi Ville and Alex,
>
> thanks for the replies. More below.
>
> TL;DR:
>
> My take-away from this is that I should slam 'max bpc' to the max by
> default, and offer a knob for the user in case they want to lower it.
>
>
> On Tue, 26 Apr 2022 20:55
gt;> drm
>>> layer.
>>>
>>> This patch will also move "Current" bpc to the crtc debugfs from
>>> connector
>>> debugfs, since we are getting this info from crtc_state.
>>>
>>> Cc: Harry Wentland
>>> Cc: Rodrigo Siqueira
>
On 2022-05-02 10:27, Modem, Bhanuprakash wrote:
> On Mon-02-05-2022 07:08 pm, Harry Wentland wrote:
>>
>>
>> On 2022-05-02 09:28, Modem, Bhanuprakash wrote:
>>> On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote:
>>>>
>>>>
>>>&g
ix typo in comments (Harry)
>
> Cc: Jani Nikula
> Cc: Ville Syrjälä
> Cc: Harry Wentland
> Signed-off-by: Bhanuprakash Modem
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_debugfs.c | 21 +
> 1 file changed, 21 insertions(+)
tc debugfs from
> connector debugfs, since we are getting this info from crtc_state.
>
> Cc: Harry Wentland
> Cc: Rodrigo Siqueira
> Signed-off-by: Bhanuprakash Modem
> Reported-by: kernel test robot
Reviewed-by: Harry Wentland
Harry
> ---
> .../gpu/drm/amd/display
On 2022-05-02 10:29, Harry Wentland wrote:
>
>
> On 2022-05-02 10:27, Modem, Bhanuprakash wrote:
>> On Mon-02-05-2022 07:08 pm, Harry Wentland wrote:
>>>
>>>
>>> On 2022-05-02 09:28, Modem, Bhanuprakash wrote:
>>>
or not, remove the one entry between CONFIG_DRM_AMD_DC_DCN ifdef
> guards.
>
> Signed-off-by: Magali Lemes
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/am
t dropped. Linus noticed on this
> rx580 and I've reproduced on FIJI which makes sense as these
> are pre-modifier GPUs.
>
> With this applied, I get gdm back.
>
> Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")
> Signed-off-by: Dave Air
On 2022-08-04 16:43, Nathan Chancellor wrote:
> On Thu, Aug 04, 2022 at 09:24:41PM +0200, Arnd Bergmann wrote:
>> On Thu, Aug 4, 2022 at 8:52 PM Linus Torvalds
>> wrote:
>>>
>>> On Thu, Aug 4, 2022 at 11:37 AM Sudip Mukherjee (Codethink)
>>> wrote:cov_trace_cmp
git bisect points to 3
On 5/18/22 01:38, Modem, Bhanuprakash wrote:
> On Mon-16-05-2022 02:09 pm, Jani Nikula wrote:
>> On Mon, 02 May 2022, Harry Wentland wrote:
>>> Both the kernel and IGT series look good to me.
>>>
>>> I recommend you merge the entire kernel set as one into d
compositor can immediately make use of it.
Fixes: https://gitlab.freedesktop.org/wayland/weston/-/issues/609
Signed-off-by: Harry Wentland
Cc: ppaala...@gmail.com
Cc: sebastian.w...@redhat.com
Cc: vpros...@amd.com
Cc: Uma Shankar
---
drivers/gpu/drm/drm_edid.c | 6 ++
1 file changed, 2 i
description (Pekka)
Signed-off-by: Harry Wentland
Cc: ppaala...@gmail.com
Cc: sebastian.w...@redhat.com
Cc: vpros...@amd.com
Cc: Uma Shankar
Cc: Ville Syrjälä
Acked-by: Pekka Paalanen
---
drivers/gpu/drm/drm_edid.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gp
On 2022-06-23 04:09, Colin Ian King wrote:
> There is a spelling mistake in a dml_print message. Fix it.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 +-
> 1 file changed,
On 2022-06-27 08:18, Ville Syrjälä wrote:
> On Sun, Jun 19, 2022 at 09:31:03PM -0100, Melissa Wen wrote:
>> Add 3D LUT for gammar correction using a 3D lookup table. The position
>> in the color correction pipeline where 3D LUT is applied depends on hw
>> design, being after CTM or gamma. If ju
On 2022-06-19 18:30, Melissa Wen wrote:
> Hi,
>
> I've been working on a proposal to add 3D LUT interface to DRM CRTC
> color mgmt, that means new **after-blending** properties for color
> correction. As I'm targeting AMD display drivers, I need to map these
> new properties to AMD DC interface
nected
> * displays will be forced to synchronize.
> * @dmcub_trace_event_en: enable dmcub trace events
> + * @num_of_edps: dumber of embedded Display Ports
/s/dumber/number
Thanks for turning these into kerneldocs. With the above minor nit fixed this is
Reviewed-by:
On 6/19/22 18:31, Melissa Wen wrote:
> Add details about color correction capabilities and explain a bit about
> differences between DC hw generations and also how they are mapped
> between DRM and DC interface. Two schemas for DCN 2.0 and 3.0
> (rasterized from the original png) is included to
On 6/19/22 18:31, Melissa Wen wrote:
> Add 3D LUT for gammar correction using a 3D lookup table. The position
> in the color correction pipeline where 3D LUT is applied depends on hw
> design, being after CTM or gamma. If just after CTM, a shaper lut must
> be set to shape the content for a non
On 2022-07-06 05:13, Guo Zhengkui wrote:
> Remove a repeated "#include "
>
> Signed-off-by: Guo Zhengkui
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/os_types.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers
On 2022-07-07 14:22, Alex Deucher wrote:
> On Wed, Jul 6, 2022 at 3:41 AM Zhongjun Tan wrote:
>>
>> From: Zhongjun Tan
>>
>> Fix unsigned expression compared with zero
>>
>> Signed-off-by: Zhongjun Tan
>> ---
>> .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 4 ++--
>> 1 fil
On 2022-07-07 23:10, Zhongjun Tan wrote:
> From: Zhongjun Tan
>
> Remove condition with no effect
Please explain why you think this has no effect.
Harry
>
> Signed-off-by: Zhongjun Tan
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4
> 1 file changed, 4 deleti
On 2022-03-31 13:26, David Zhang wrote:
> [why & how]
> In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
Please fix up the type in "fileds"
> support.
>
> Signed-off-by: David Zhang
With that fixed this patch is
Reviewed-by: Harry Wentland
On 2022-04-03 10:21, Tom Rix wrote:
> Smatch reports this issue
> hdcp1_execution.c:500:29: warning: function
> 'mod_hdcp_hdcp1_dp_execution' with external linkage
> has definition
>
Which branch are you using?
I don't see the 'extern' on
https://gitlab.freedesktop.org/agd5f/linux/-/blob/
On 2022-04-04 11:43, Tom Rix wrote:
>
> On 4/4/22 8:22 AM, Harry Wentland wrote:
>>
>> On 2022-04-03 10:21, Tom Rix wrote:
>>> Smatch reports this issue
>>> hdcp1_execution.c:500:29: warning: function
>>> 'mod_hdcp_hdcp1_dp_execution' w
On 2022-04-07 01:52, Haowen Bai wrote:
> The pointer dc is dereferencing pointer plane_state before plane_state
> is being null checked. Fix this by assigning plane_state->ctx->dc to
> dc only if plane_state is not NULL, otherwise just NULL.
>
> Signed-off-by: Haowen Bai
> ---
> drivers/gpu/d
On 2022-04-07 02:00, Haowen Bai wrote:
> Smatch reports the following:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2174
> dcn10_enable_vblanks_synchronization() warn: if statement not indented
>
> Signed-off-by: Haowen Bai
Reviewed-by: Harry W
On 2022-04-07 12:07, Alex Deucher wrote:
> Actually this just causes another warning. Dropped for now. More below.
>
> On Thu, Apr 7, 2022 at 11:52 AM Alex Deucher wrote:
>>
>> Applied. Thanks!
>>
>> Alex
>>
>> On Thu, Apr 7, 2022 at 10:18 AM
On 2022-04-08 02:53, Bhanuprakash Modem wrote:
> It's useful to know the connector's max supported bpc for IGT
> testing. Expose it via a debugfs file on the connector "output_bpc".
>
> Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc
>
> Cc: Jani Ni
tc debugfs from
> connector debugfs, since we are getting this info from crtc_state.
>
Does the amd_max_bpc test pass after this change?
Harry
> Cc: Harry Wentland
> Cc: Rodrigo Siqueira
> Signed-off-by: Bhanuprakash Modem
> ---
> .../gpu/drm/amd/display/am
On 2022-04-08 11:23, Modem, Bhanuprakash wrote:
> On Fri-08-04-2022 08:33 pm, Harry Wentland wrote:
>>
>>
>> On 2022-04-08 02:53, Bhanuprakash Modem wrote:
>>> As drm_connector already have the display_info, instead of creating
>>> "output_bpc"
On 2022-09-13 05:33, Javier Martinez Canillas wrote:
> Provides a default plane state check handler for primary planes that are a
> fullscreen scanout buffer and whose state scale and position can't change.
>
Even though this might be how some drivers are handling the primary
plane this assump
On 2022-09-13 10:46, Javier Martinez Canillas wrote:
> On 9/13/22 15:49, Harry Wentland wrote:
>>
>>
>> On 2022-09-13 05:33, Javier Martinez Canillas wrote:
>>> Provides a default plane state check handler for primary planes that are a
>>> fullscreen s
t; drm: document DRM_MODE_PAGE_FLIP_ASYNC
> amd/display: only accept async flips for fast updates
> drm: introduce drm_mode_config.atomic_async_page_flip_not_supported
> drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits
> drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP
> amd/display: indicate support for atomic async pag
On 9/12/22 11:59, Maíra Canal wrote:
> From: Tales Aparecida
>
> The fixed31_32 library performs a lot of the mathematical operations
> involving fixed-point arithmetic and the conversion of integers to
> fixed-point representation.
>
> This unit tests intend to assure the proper functioning
st robot
> Reported-by: Dan Carpenter
> Signed-off-by: Melissa Wen
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgp
g it enabled for the rest of the kernel.
>
> Fixes: 9d1d02ff3678 ("drm/amd/display: Don't build DCN1 when kcov is enabled")
> Cc: Arnd Bergmann
> Cc: Leo Li
> Signed-off-by: Guenter Roeck
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/am
On 2019-10-29 9:57 p.m., zhong jiang wrote:
> kfree has taken null pointer into account. hence it is safe to remove
> the unnecessary check.
>
> Signed-off-by: zhong jiang
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 4 +---
&g
On 2019-11-01 3:38 p.m., Jerry (Fangzhi) Zuo wrote:
> DP 1.4 edid corruption test requires source DUT to write calculated
> CRC, not the corrupted CRC from reference sink.
>
> Return the calculated CRC back, and initiate the required sequence.
>
> -v2: Have separate routine for returning real CRC
On 2019-11-04 5:53 a.m., Daniel Vetter wrote:
> On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote:
>> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet
>> wrote:
>>>
>>> I misunderstood and was talking about the ksv validation specifically
>>> (usage of drm_hdcp_check_ksvs_revoked()).
>>
>> Hm
Nov 4, 2019 at 11:55 AM Daniel Vetter wrote:
>>>>>
>>>>> On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote:
>>>>>> On 2019-11-04 5:53 a.m., Daniel Vetter wrote:
>>>>>>> On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote:
&g
On 2019-11-05 9:23 a.m., Daniel Vetter wrote:
> On Tue, Nov 5, 2019 at 3:17 PM Harry Wentland wrote:
>>
>>
>>
>> On 2019-11-05 8:14 a.m., Daniel Vetter wrote:
>>> On Tue, Nov 5, 2019 at 1:52 PM Alex Deucher wrote:
>>>>
>>>> On Mon,
On 2019-11-11 7:28 a.m., YueHaibing wrote:
> Fix a build warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1:
> warning: 'static' is not at beginning of declaration
> [-Wold-style-declaration]
>
> Signed-off-by: YueHaibing
Revi
On 2019-11-12 2:51 a.m., Yuehaibing wrote:
> On 2019/11/12 10:39, Joe Perches wrote:
>> On Mon, 2019-11-11 at 20:28 +0800, YueHaibing wrote:
>>> Fix a build warning:
>>>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1:
>>> warning: 'static' is not at beginning of declaration
>>> [-Wol
ariable 'bp' in
> bios_parser.c
> drm/amd/display: remove set but not used variable 'min_content'
>
These would be fine as a single patch as well but I don't have a strong
preference either way.
Patches are:
Reviewed-by: Harry Wentland
Harry
> drivers/gp
=112140
> References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
> Signed-off-by: Chris Wilson
Reviewed-by: Harry Wentland
Harry
> Cc: Harry Wentland
> Cc: Jean Delvare
> Cc: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu
On 2019-12-14 4:12 a.m., zhengbin wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: Unneeded
> semicolon
>
> Reported-by: Hulk Robot
> Signed-off-by: zhengbin
Reviewed-by: Harry Wentland
Harry
> ---
>
finition. All
patches should compile on their own.
Thanks,
Harry
> Cc: Harry Wentland
> Cc: Alex Deucher
> Signed-off-by: Animesh Manna
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dri
On 2019-12-18 11:13 a.m., Manna, Animesh wrote:
>
> On 18-12-2019 21:12, Harry Wentland wrote:
>> On 2019-12-18 10:13 a.m., Animesh Manna wrote:
>>> [Why]:
>>> Aligh with DP spec wanted to follow same naming convention.
>>>
>>> [How]:
>>
/dc/core/dc_resource.c:975:6:
> warning: symbol 'restore_border_left_from_dst' was not declared. Should
> it be static?
>
> Fixes: 89d07b662f5e (drm/amd/display: fix 270 degree rotation for mixed-SLS
> mode)
> Reported-by: Hulk Robot
> Signed-off-by: Chen Zhou
was not declared. Should
> it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:768:6:
> warning: symbol 'dce110_clock_source_destroy' was not declared. Should
> it be static?
>
> Reported-by: Hulk Robot
> Signed
101 - 200 of 1155 matches
Mail list logo
