Re: [PATCH 1/3] mga: Use request_firmware() to load microcode

2009-02-22 Thread Stephane Marchesin
Hi, This mga patch replaces a firmware that was split in pieces by functionality and that had comments with a single blob. So IMO it's actually decreasing the quality of the code. Stephane -- Open Source Business Confere

Re: [PATCH 1/3] mga: Use request_firmware() to load microcode

2009-02-22 Thread Ben Hutchings
On Mon, 2009-02-23 at 00:06 +0100, Stephane Marchesin wrote: > Hi, > > This mga patch replaces a firmware that was split in pieces by > functionality and that had comments with a single blob. Each pipe's code was converted to a seperate line of the ihex file. > So IMO it's actually decreasing th

Re: [PATCH 1/3] mga: Use request_firmware() to load microcode

2009-02-23 Thread Ville Syrjälä
On Sun, Feb 22, 2009 at 11:45:21PM +, Ben Hutchings wrote: > On Mon, 2009-02-23 at 00:06 +0100, Stephane Marchesin wrote: > > Hi, > > > > This mga patch replaces a firmware that was split in pieces by > > functionality and that had comments with a single blob. > > Each pipe's code was convert

Re: [PATCH 1/3] mga: Use request_firmware() to load microcode

2009-02-23 Thread Ben Hutchings
On Mon, 2009-02-23 at 13:14 +0200, Ville Syrjälä wrote: > On Sun, Feb 22, 2009 at 11:45:21PM +, Ben Hutchings wrote: > > On Mon, 2009-02-23 at 00:06 +0100, Stephane Marchesin wrote: > > > Hi, > > > > > > This mga patch replaces a firmware that was split in pieces by > > > functionality and tha