On 12/15/2014 05:01 PM, Rickard Strandqvist wrote:
Hi
No the rtw_hw_resume23a() is not used anywhere.
I also do a check of all functions that are not used, but not in the
drivers/staging, I suspected that these might be under development and
used in the future.
What do you want to do, who decid
On 12/12/2014 04:50 PM, Krzysztof Konopko wrote:
On 12/12/14 18:35, Larry Finger wrote:
On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
On 12/12/14 00:53, Larry Finger wrote:
In particular, did you test on big-endian hardware after you
made this change?
Nope. I don't have any big-e
On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
On 12/12/14 00:53, Larry Finger wrote:
This fix may make the sparse warnings go away, but I think it introduces
new bugs.
Right, I see. Nice try though, isn't it? ;)
In particular, did you test on big-endian hardware after you
made
On 12/12/2014 06:52 AM, Dan Carpenter wrote:
On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote:
On 12/11/2014 04:23 PM, Krzysztof Konopko wrote:
Some struct fields in wifi.h are meant to be __le16 bu were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c
On 12/11/2014 04:23 PM, Krzysztof Konopko wrote:
Some struct fields in wifi.h are meant to be __le16 bu were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c:538:24: warning: cast to restricted __le16
rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
r
| 33 +
1 file changed, 15 insertions(+), 18 deletions(-)
Acked-by: Larry Finger
Thanks for porting your changes found in one of the Realtek drivers.
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
On 12/01/2014 09:53 AM, Anjana Sasindran wrote:
This patch fix the checkpatch.pl warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
dif
On 11/27/2014 10:28 AM, Greg KH wrote:
On Thu, Nov 27, 2014 at 10:10:21AM -0600, Larry Finger wrote:
The DLink GO-USB-N150 with revision B1 uses this driver.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
The DLink GO-USB-N150 with revision B1 uses this driver.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 65a257f
On 11/15/2014 08:25 AM, Christian Resell wrote:
Simple style fix ("else is not generally useful after a break or return").
For the eudyptula challenge (http://eudyptula-challenge.org/).
Signed-off-by: Christian F. Resell
---
This patch leads to the following build warnings:
CC [M] drivers
rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(),
and rtw_check_bcn_info().
Signed-off-by: Larry Finger
Cc: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 22 +++---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
drive
On 09/29/2014 12:05 PM, Greg KH wrote:
On Sun, Sep 28, 2014 at 08:39:51PM -0500, Larry Finger wrote:
A new version of this driver has been merged into the wireless-testing tree
as commit 21e4b0726dc671c423e2dc9a85364716219c4502. It is both possible and
desirable to delete the staging version to
On 09/29/2014 01:17 AM, Greg KH wrote:
On Sun, Sep 28, 2014 at 08:39:51PM -0500, Larry Finger wrote:
A new version of this driver has been merged into the wireless-testing tree
as commit 21e4b0726dc671c423e2dc9a85364716219c4502. It is both possible and
desirable to delete the staging version to
On 09/04/2014 03:58 PM, Andreea Bernat wrote:
Hello,
I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modif
The Elecom WDC-150SU2M uses this chip.
Reported-by: Hiroki Kondo
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index
The Elecom WDC-150SU2M uses this chip.
Reported-by: Hiroki Kondo
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index
From: Holger Paradies
The stick is not recognized.
This dongle uses r8188eu but usb-id is missing.
3.16.0
Signed-off-by: Holger Paradies
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu
On 08/01/2014 08:06 AM, Miguel Oliveira wrote:
> Fix sparse warning:
> drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol
> 'efuse_GetCurrentSize23a' was not declared. Should it be static?
>
> Signed-off-by: Miguel Oliveira
> ---
> drivers/staging/rtl8723au/include/rtw_efuse.h |
On 07/21/2014 09:10 PM, Greg KH wrote:
> On Mon, Jul 21, 2014 at 08:50:26PM -0400, Chris Murphy wrote:
>> Problem: On Asus TX201LA running 15.6 kernel x86_64, driver repeatedly
>> disconnects and reconnects. Dual boot same machine on Win 8.1 is very stable.
>>
>> Behavior starts as soon as Linux is
TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger
---
V2 - Remove extraneous parenthesis
drivers/staging/rtl8192ee/base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192
TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192ee/base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c
index 71ed12e..b8b897a 10064
On 06/21/2014 12:52 PM, Christian Lamparter wrote:
On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote:
On 20/06/14 23:52, Christian Lamparter wrote:
On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote:
Kristina wrote:
I'm helping Greg do a bit of cleanup in the staging
On 06/20/2014 09:52 PM, Nick Krause wrote:
Is this patch being merged or is this not an issue. I am confused
did I make a mistake in my patch or is there being a different
patch being merged.
Thank Nick
On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote:
On Fri, 2014-06-20 at 22:26 -0400, Nic
On 06/20/2014 10:40 AM, Kristina Martšenko wrote:
Hi Larry and Florian,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving rtl8712 out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because othe
On 06/09/2014 10:39 AM, Jes Sorensen wrote:
Greg KH writes:
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Greg,
Thanks for pushing my other changes to Linus. This set goes on top of
the set I sent you on 2014/05/31 and the fix from 2014/06/03. I
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Ah yes, all the "benefits" of adding a new driver in one tree (staging) that
depends of changes in another (wireless). I have been maintaining this patch in
my own source for several weeks.
Acked-by: Larry Finger
Thanks,
Larry
---
Hi,
42e4c20f114c71e12cdf35d9b5dd60d2546c7d57
yesterday in staging-next. If it has not reached linux-next, the attached patch
should fix the problem.
Thanks,
Larry
>From d10ca90ffaf99f43bb61d5b4001f6a6acfde3454 Mon Sep 17 00:00:00 2001
From: Larry Finger
Date: Mon, 26 May 2014 13:35:48 -0500
Subj
name is used for the rtlwifi drivers in the regular
wireless tree, and the staging drivers r8192ee and r8821ae. The fix
is to rename the algorithm used in r8192ee.
Reported-by: Jet Chen
Signed-off-by: Larry Finger
Tested-by: Jet Chen
---
drivers/staging/rtl8192ee/rc.c | 2 +-
1 file changed, 1
A build of this driver fails when PCI is not selected. It would also
fail if MAC80211 is not selected. Kconfig is fixed to handle these
conditions, and to select additional necessary components.
Reported-by: Randy Dunlap
Reported-by: Ben Hutchings
Signed-off-by: Larry Finger
---
drivers
The zero day testing facility reported a problem with duplicate
registration of the rate-control algorithm. Although not yet reported,
this driver needs the same fix.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8821ae/rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Finger
Larry Finger (3):
staging: r8192ee: Fix kernel WARN splat associated with rate control
staging: r8192ee: Fix build errors when PCI is not available
staging: r8821ae: Fix potential problem with rate control registration
drivers/staging/rtl8192ee/Kconfig | 7 +++
drivers/staging
On 05/26/2014 01:06 PM, Ben Hutchings wrote:
On Wed, 2014-05-21 at 16:25 -0500, Larry Finger wrote:
[...]
--- /dev/null
+++ b/drivers/staging/rtl8192ee/Kconfig
@@ -0,0 +1,8 @@
+config R8192EE
+ tristate "Realtek RTL8192EE Wireless Network Adapter"
depends on MAC80211 &&
On 05/26/2014 09:55 AM, Jet Chen wrote:
Jet,
0day kernel testing robot got the below dmesg and the first bad commit is
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
commit 0629f3b8c33899140b48d5897259eab8ebae78ca
Author: Larry Finger
AuthorDate: Wed May 21
In addition, this commit contains a TODO file for this driver
Signed-off-by: Larry Finger
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/rtl8192ee/Kconfig | 8
drivers/staging/rtl8192ee/Makefile | 40
problems have been fixed. The code needs additional
polishing before it can be merged into the regular wireless tree; however,
that should not take more than a single cycle.
Signed-off-by: Larry Finger
Larry Finger (4):
staging: r8192ee: Add source files for core driver
staging: r8192ee: Add code
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 127 ++
Greg,
This E-mail is to prepare you for a new Realtek RTL8192EE driver that I intend
to submit early next week. I hope it will be in time for kernel 3.16.
This device is incorporated in the recently introduced Lenovo T440s tablet, and
from the correspondence that I have received, there have b
Engelmayer
Acked-by: Larry Finger
This Ack is valid for all 5 patches.
Larry
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu
On 04/22/2014 09:14 AM, Dan Carpenter wrote:
On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
Hi dan
it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.
ng: symbol
'process_pwrbit_data' was not declared. Should it be static?
drivers/staging/rtl8188eu/core/rtw_recv.c:1828:5: warning: symbol
'enqueue_reorder_recvframe' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Larry Finger
Cc: Dan C
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparison against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 15 ++-
1
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparison against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/rtl871x_recv.c | 13 ++---
1 file
stack, the array may not be
sorted correctly.
Signed-off-by: Geert Uytterhoeven
---
Acked-by: Larry Finger
Geert,
Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.
Larry
drivers/staging/rtl8723au/core/rtw_wlan_util.c |2 +-
1 file changed, 1 insertion(+), 1
On 04/09/2014 11:25 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:13 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by
e" to
match
the actual routine. The third warning comes from testing that a u8 quantity is
positive.
Reported-by: kbuild test robot
Signed-off-by: Larry Finger
Cc: Jes Sorensen
Cc: kbuild-...@01.org
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++--
drivers/staging/rtl8723a
On 04/09/2014 11:24 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:12 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 20
While analyzing parts of the recently merged r8723au driver, Jes Sorensen
found two bugs that are found in other Reaktek drivers in staging. This
set of patches fixes them.
Signed-off-by: Larry Finger
Larry Finger (3):
staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/rtl871x_recv.c | 15 +++
1 file
e" to
match
the actual routine. The third warning comes from testing that a u8 quantity is
positive.
Reported-by: kbuild test robot
Signed-off-by: Larry Finger
Cc: Jes Sorensen
Cc: kbuild-...@01.org
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
drivers/staging/rtl8723au/
On 04/07/2014 04:08 AM, Paul Bolle wrote:
Larry,
0) I stumbled on two minor Kconfig related issues in the r8723au driver
in staging-next.
1) drivers/staging/rtl8723au/include/drv_types.h
Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
preprocessor define for CONFIG_BR_E
ivers/input/Kconfig:8:symbol INPUT is selected by ACPI_CMPC
drivers/platform/x86/Kconfig:635: symbol ACPI_CMPC depends on RFKILL
To avoid substituting one build error for another, I added a "depends on
RFKILL".
My suspicion is that this particular error is caused by a kbuild b
23au/r8723au.ko]
undefined!
ERROR: "cfg80211_disconnected" [drivers/staging/rtl8723au/r8723au.ko] undefined!
ERROR: "ieee80211_amsdu_to_8023s" [drivers/staging/rtl8723au/r8723au.ko]
undefined!
ERROR: "cfg80211_scan_done" [drivers/staging/rtl8723au/r8723au.ko] undefin
On 03/28/2014 10:26 PM, Joe Perches wrote:
On Fri, 2014-03-28 at 21:37 -0500, Larry Finger wrote:
The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
A driver for it has been available in a GitHub repo for several months.
[]
133 files changed, 89878 insertions(+)
eek
This commit also creates a TODO file.
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/rtl8723au/Kconfig | 37
drivers/staging/rtl8723au/Makefile | 58
: Larry Finger
Cc: Jes Sorensen
Larry Finger (6):
staging: r8723au: Add source files for new driver - part 1
staging: r8723au: Add source files for new driver - part 2
staging: r8723au: Add source files for new driver - part 3
staging: r8723au: Add source files for new driver - part 4
From: Fengguang Wu
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with
struct assignment
Generated by: coccinelle/misc/memcpy-assign.cocci
Signed-off-by: Fengguang Wu
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file
From: Manu Gupta
The D-Link DWA-123 REV D1 with USB ID 2001:3310 uses this driver.
Signed-off-by: Manu Gupta
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers
On 02/15/2014 02:41 PM, Greg KH wrote:
On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote:
I've applied this series up to here.
Nevermind, the others applied, so I've merged them, just not this patch.
I have split this patch into two parts that I will send tomorrow. The first one
just
On 02/16/2014 03:09 AM, Dan Carpenter wrote:
On Sun, Feb 16, 2014 at 11:02:52AM +0800, Zhao, Gang wrote:
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
This alignment entry in union recv_frame does nothing. It certainly
dues not ensure alignment.
^
typo here.
I
On 02/15/2014 04:41 AM, Dan Carpenter wrote:
On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote:
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 1fa5370..d5f6a32 100644
--- a/drivers/staging/rtl8188eu/hal
This is simply a wrapper around schedule_work().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_led.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_xmit.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_xmit.h
b/drivers/staging/rtl8188eu/include/rtw_xmit.h
index 1ac1dd3..62f5db1 100644
--- a/drivers/staging/rtl8188eu/include
This is simply another name for INIT_WORK().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_led.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 6 --
3 files changed, 2 insertions(+), 8
This wrapper returned the result of mutex_lock_interruptible(); however,
none of the callers checked the returned value.
As a result of a gcc upgrade to version 4.8.1, two false unitialized variable
warnings appeared. To silence the warnings, they are initialized to 0.
Signed-off-by: Larry
-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 6 ++
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h| 9 -
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/staging
This wrapper is a simple call to mutex_exit().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 7 ---
drivers/staging/rtl8188eu/os_dep
From: Stas Sergeev
The present code reloads the firmware file from the disk every time the
interface
re-inits. Change to hold the firmware in memory, and only download to the
device.
Signed-off-by: Stas Sergeev
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal
This simple routine is replaced by a simple access of the len member.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 5 -
2 files changed, 1 insertion(+), 6
the disk file every time the device reinits.
Signed-off-by: Larry Finger
Larry Finger (12):
staging: r8188eu: Remove unnecessary list_head entry from recv_frame
union
staging: r8188eu: Remove pointless "alignment" entry in recv_frame
staging: r8188eu: Remove union w
These functions are not called from the outside source.
Suggested-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 38
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 81fdcf5
Struct recv_frame_hdr already contains a list head. This one is pointless.
Suggested-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 7 ---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
2 files changed, 4 insertions
This alignment entry in union recv_frame does nothing. It certainly
dues not ensure alignment.
Suggested-by: jes.soren...@redhat.com
Signed-off-by: Larry Finger
Cc: jes.soren...@redhat.com
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a
Smatch reports the following:
drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info:
ignoring unreachable code.
Upon investigation, the code in this region has the capability of creating
an infinite loop.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8821ae
previously assumed 'pregpriv' could be null (see line 4469)
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 +-
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/d
ble_Ch14' 33 <= 255
Not listed here is one remaining buffer overflow message that I believe to be
an error in Smatch.
These warnings were reported by the 0-DAY kernel build testing backend.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 32
The driver contains a macro that gets the next item in a linked list.
Replace it with a simple copy of the pointer.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 32 +++---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging
rt of that union.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 16 -
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_debug.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 14 ---
After the previous cleanups, file hal/odm_interface.c is now empty. It
is hereby deleted, and removed from Makefile.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/Makefile| 1 -
drivers/staging/rtl8188eu/hal/odm_interface.c | 1 -
2 files changed, 2 deletions(-)
delete
The headers for this driver contain a number of unused structs and macros
that are removed. File include/ioctl_cfg80211.h is now empty and was
deleted.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ioctl_cfg80211.h | 107 -
drivers/staging/rtl8188eu
This wrapper is replaced with a simple memcmp(). As the wrapper inverts the
logic of memcmp(), care needed to be taken.
This patch also adds one include of vmalloc.h that was missed in a previous
patch.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 16
As has been noted, this driver is very rough. This set of patches is
intended to smooth some of the rough edges.
Signed-off-by: Larry Finger
Larry Finger (6):
staging: r8188eu: Replace wrapper around _rtw_memcmp()
staging: r8188eu: Remove dead file
staging: r8188eu: Remove some dead code
On 02/09/2014 02:29 AM, Surendra Patil wrote:
Fixed few coding style errors in header files
base.h:58: WARNING: please, no space before tabs
base.h:81: ERROR: "(foo*)" should be "(foo *)"
pci.h:338: ERROR: "foo * bar" should be "foo *bar"
pci.h:151: ERROR: do not use C99 // comments
Signed-off-b
On 02/09/2014 01:30 AM, Surendra Patil wrote:
Fixed multiple coding style errors and warnings
wifi.h:1077: WARNING: please, no space before tabs
wifi.h:762: WARNING: missing space after struct definition
wifi.h:972: WARNING: please, no spaces at the start of a line
wifi.h:1825: WARNING: Unnecessa
ually works, it will be submitted to the
drivers/net/wireless tree of the regular kernel, and it should be there by 3.15.
That said, Acked-by: Larry Finger
Larry
---
drivers/staging/rtl8821ae/wifi.h | 450 ---
1 file changed, 226 insertions(+), 224 de
de vzalloc and vfree.
This problem was reported by the kbuild test robot.
Signed-off-by: Larry Finger
---
V2 - add attribution to the build robot
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 +
drivers/staging/rtl8188eu/core/rtw_mp.c| 1 +
drivers/staging/rtl8188eu/core
On 02/07/2014 06:04 PM, Greg KH wrote:
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote:
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitle
de vzalloc and vfree.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 +
drivers/staging/rtl8188eu/core/rtw_mp.c| 1 +
drivers/staging/rtl8188eu/core/rtw_recv.c | 1 +
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 1 +
drivers/staging/rtl81
On 02/03/2014 04:38 PM, Dan Carpenter wrote:
MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer
in sync. It leads to a bogus pointer dereference.
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8188eu
This routine is the equivalent of rtw_write32.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 2 +-
drivers/staging/rtl8188eu/hal/odm_interface.c | 7 ---
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 1 insertion(+), 10
This wrapper for vzalloc() is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers
This routine is essentially a duplicate of rtw_read32.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 9 +
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 2 +-
drivers/staging/rtl8188eu/hal/odm.c | 8
drivers
truct is
allocated with rtw_zmalloc()
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index 153ec61493ab..96df62f95b6b 100644
--- a/drivers/staging/rtl8188eu/core/rtw_wla
This wrapper is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 8
drivers/staging/rtl8188eu/include/odm_interface.h | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
This routine is the equivalent of rtw_write16.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +++-
drivers/staging/rtl8188eu/hal/odm_interface.c| 6 --
drivers/staging/rtl8188eu/include/odm_interface.h| 2 --
3 files changed, 3
The driver contains a large number of wrapper routines. None of them are
needed.
Signed-off-by: Larry Finger
Larry Finger (12):
staging: r8188eu: Remove ODM_Read1Byte
staging: r8188eu: Remove ODM_Read2Byte
staging: r8188eu: Remove ODM_Read4Byte
staging: r8188eu: Remove ODM_Write1Byte
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++---
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8188eu
401 - 500 of 621 matches
Mail list logo
