Re: [edk2] [PATCH] OvmfPkg: AcpiTables: serialize control methods that create named objects

2015-09-01 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-08-28 02:16:29, Laszlo Ersek wrote: > Bruce Cran reported the following issue: > > With iasl version 20150410-64 building OvmfX64 (using OvmfPkg/build.sh > -a X64 -t GCC49 -b RELEASE) results in a couple of warnings about > methods that should be serializ

Re: [edk2] [patch] Add more strict check for MOR variable, besides MOR lock variable.

2015-09-01 Thread Zhang, Chao B
It is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Wednesday, September 02, 2015 1:11 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] Add more strict check for MOR variable, besides MOR

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Ryan Harkin
On 1 Sep 2015 18:21, "Leif Lindholm" wrote: > > On Tue, Sep 01, 2015 at 07:12:33PM +0200, Ard Biesheuvel wrote: > > On 1 September 2015 at 18:59, Leif Lindholm wrote: > > > On Tue, Sep 01, 2015 at 11:58:20AM +0200, Ard Biesheuvel wrote: > > >> The Intel BDS platform library still depends on the A

[edk2] [patch] Handle extra module patchable PCD variable in Linux map.

2015-09-01 Thread jiewen yao
Add comment for python function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yao, Jiewen Reviewed-by: Mudusuru, Giri P Cc: Mudusuru, Giri P --- IntelFspPkg/Tools/PatchFv.py | 346 +-- 1 file changed, 334 insertions(+), 12 delet

[edk2] [patch] Add more strict check for MOR variable, besides MOR lock variable.

2015-09-01 Thread jiewen yao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yao, Jiewen Cc: Zhang, Chao B --- .../Tcg/MemoryOverwriteRequestControlLock/TcgMorLock.c| 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/SecurityPkg/Tcg/MemoryOverwriteRequestControlLock

[edk2] [patch] MdeModulePkg:Support orderedList with default value

2015-09-01 Thread Dandan Bi
Our tool can support OrderedList which has default value,but doesn't update the source code in HiiDatabase when parse the ifr data.Now update the code and add test case in DriverSample. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/Dr

Re: [edk2] [patch] CryptoPkg: Replace string wrapper functions with safe string functions

2015-09-01 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Long, Qin Sent: Tuesday, September 01, 2015 4:55 PM To: Ye, Ting; Dong, Eric Cc: edk2-devel@lists.01.org Subject: [patch] CryptoPkg: Replace string wrapper functions with safe string functions EDKII core suggest retire unsafe string func

Re: [edk2] [PATCH v2 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Benjamin Herrenschmidt
On Wed, 2015-09-02 at 01:01 +0200, Ard Biesheuvel wrote: > Excellent question. > > If you are doing a new port, there is no reason to use the old Intel > BDS and you are better off supporting only the new universal BDS. Thanks ! Cheers, Ben. > For the ARM platforms, I think we should move to t

Re: [edk2] [PATCH] MdePkg: Add UefiDebugLibDebugPortProtocol to output logs via EFI_DEBUGPORT_PROTOCOL.Write.

2015-09-01 Thread Masamitsu MURASE
Hi MdePkg maintainers, I'll be grateful if you can reply to me. I believe that this kind of feature helps debugging in PC vendors and 3rd party UEFI driver vendors. Regards, Murase --- Masamitsu MURASE https://github.com/masamitsu-murase -- Mail: masamitsu.mur...@gmail.com 村瀬 昌満 (MURASE

Re: [edk2] [PATCH v2 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Ard Biesheuvel
On 2 September 2015 at 00:32, Benjamin Herrenschmidt wrote: > On Wed, 2015-08-26 at 11:59 +0200, Ard Biesheuvel wrote: >> This adds support for the Intel BDS, by introducing a define >> 'USE_ARM_BDS' which defaults to TRUE, and can be overridden on >> the build command line. > > Out of curiosity (

Re: [edk2] [PATCH v2 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Benjamin Herrenschmidt
On Wed, 2015-08-26 at 11:59 +0200, Ard Biesheuvel wrote: > This adds support for the Intel BDS, by introducing a define > 'USE_ARM_BDS' which defaults to TRUE, and can be overridden on > the build command line. Out of curiosity (still in the process of getting my head around the BDS stuff for my P

Re: [edk2] [PATCH] OvmfPkg: AcpiTables: serialize control methods that create named objects

2015-09-01 Thread Laszlo Ersek
Jordan, can you please check this one too? It's trivial. Thanks Laszlo On 08/28/15 11:16, Laszlo Ersek wrote: > Bruce Cran reported the following issue: > > With iasl version 20150410-64 building OvmfX64 (using OvmfPkg/build.sh > -a X64 -t GCC49 -b RELEASE) results in a couple of warnings ab

Re: [edk2] [PATCH] OvmfPkg: PlatformPei: force 32-bit MMIO aperture above 3 GB on Q35

2015-09-01 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-09-01 14:43:10, Laszlo Ersek wrote: > The logic we have in place for i440fx does not work reliably on q35. For > example, if the guest has 2GB of RAM, we allow the PCI root bridge driver > to allocate the legacy video RAM BAR from the [2048 MB, 2816 MB] range, >

[edk2] [PATCH] OvmfPkg: PlatformPei: force 32-bit MMIO aperture above 3 GB on Q35

2015-09-01 Thread Laszlo Ersek
The logic we have in place for i440fx does not work reliably on q35. For example, if the guest has 2GB of RAM, we allow the PCI root bridge driver to allocate the legacy video RAM BAR from the [2048 MB, 2816 MB] range, which falls strictly outside of the Q35 PCI host MMIO aperture that QEMU configu

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 07:12:33PM +0200, Ard Biesheuvel wrote: > On 1 September 2015 at 18:59, Leif Lindholm wrote: > > On Tue, Sep 01, 2015 at 11:58:20AM +0200, Ard Biesheuvel wrote: > >> The Intel BDS platform library still depends on the ARM BDS specific > >> BdsLib. So replace its invocations

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 18:59, Leif Lindholm wrote: > On Tue, Sep 01, 2015 at 11:58:20AM +0200, Ard Biesheuvel wrote: >> The Intel BDS platform library still depends on the ARM BDS specific >> BdsLib. So replace its invocations with GenericBdsLib counterparts, >> and fix up where needed, so that we

Re: [edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 11:58:20AM +0200, Ard Biesheuvel wrote: > The Intel BDS platform library still depends on the ARM BDS specific > BdsLib. So replace its invocations with GenericBdsLib counterparts, > and fix up where needed, so that we can drop the dependency. > > Contributed-under: TianoCo

Re: [edk2] [PATCH v3 5/5] ArmPlatformPkg/ArmVExpress-FVP: enable UEFI Secure Boot

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 11:58:24AM +0200, Ard Biesheuvel wrote: > This allows the FVP target to be built with UEFI Secure Boot enabled, > by passing -D SECURE_BOOT_ENABLE to the build command line. Note that > you will need to disable the ARM BDS (-D USE_ARM_BDS=FALSE) or you will I guess this mes

Re: [edk2] [PATCH v3 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 11:58:23AM +0200, Ard Biesheuvel wrote: > This adds support for the Intel BDS, by introducing a define > 'USE_ARM_BDS' which defaults to TRUE, and can be overridden on > the build command line. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH v3 3/5] ArmPlatformPkg/PlatformIntelBdsLib: add splash screen support

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 11:58:22AM +0200, Ard Biesheuvel wrote: > Add a call to EnableQuietBoot () to BdsPlatformPolicyBehavior(), > so that a splash screen is shown in case one is present under the > correct GUID in the FV, and we have graphics support. > > Contributed-under: TianoCore Contributi

Re: [edk2] [PATCH] ArmPlatformPkg: signal EndOfDxe event in PlatformBsdInit

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 17:11, Laszlo Ersek wrote: > On 09/01/15 16:26, Ard Biesheuvel wrote: >> Like the ArmVirtPkg platforms up until SVN r17713, the ArmPlatformPkg >> platforms built with the Intel BDS fail to signal the end-of-DXE event >> 'gEfiEndOfDxeEventGroupGuid' when entering the BDS phas

Re: [edk2] [PATCH] ArmPlatformPkg: signal EndOfDxe event in PlatformBsdInit

2015-09-01 Thread Laszlo Ersek
On 09/01/15 16:26, Ard Biesheuvel wrote: > Like the ArmVirtPkg platforms up until SVN r17713, the ArmPlatformPkg > platforms built with the Intel BDS fail to signal the end-of-DXE event > 'gEfiEndOfDxeEventGroupGuid' when entering the BDS phase, which results > in some loss of functionality, i.e.,

Re: [edk2] [PATCH v3 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 16:59, Leif Lindholm wrote: > On Tue, Sep 01, 2015 at 11:58:21AM +0200, Ard Biesheuvel wrote: >> In InitializeConsolePipe (), we clobber the Status variable in the >> error handling path that reports Status in its output. Instead, >> use a NULL check on the LocateProtocol ()

Re: [edk2] [PATCH v3 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 17:02, Ryan Harkin wrote: > > > On 1 September 2015 at 10:58, Ard Biesheuvel > wrote: >> >> This adds support for the Intel BDS, by introducing a define >> 'USE_ARM_BDS' which defaults to TRUE, > > > Ooops, it's FALSE now... Sorry, that's my fault ;-) > Yep, I spotted tha

Re: [edk2] [PATCH v3 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Ryan Harkin
On 1 September 2015 at 10:58, Ard Biesheuvel wrote: > This adds support for the Intel BDS, by introducing a define > 'USE_ARM_BDS' which defaults to TRUE, Ooops, it's FALSE now... Sorry, that's my fault ;-) > and can be overridden on > the build command line. > > Contributed-under: TianoCor

Re: [edk2] [PATCH v3 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 16:59, Leif Lindholm wrote: > On Tue, Sep 01, 2015 at 11:58:21AM +0200, Ard Biesheuvel wrote: >> In InitializeConsolePipe (), we clobber the Status variable in the >> error handling path that reports Status in its output. Instead, >> use a NULL check on the LocateProtocol ()

Re: [edk2] [PATCH v3 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-09-01 Thread Leif Lindholm
On Tue, Sep 01, 2015 at 11:58:21AM +0200, Ard Biesheuvel wrote: > In InitializeConsolePipe (), we clobber the Status variable in the > error handling path that reports Status in its output. Instead, > use a NULL check on the LocateProtocol () output argument. > > Contributed-under: TianoCore Contri

[edk2] [PATCH] ArmPlatformPkg: signal EndOfDxe event in PlatformBsdInit

2015-09-01 Thread Ard Biesheuvel
Like the ArmVirtPkg platforms up until SVN r17713, the ArmPlatformPkg platforms built with the Intel BDS fail to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when entering the BDS phase, which results in some loss of functionality, i.e., variable reclaim in the VariableDxe drivers, and

[edk2] [PATCH v3 3/5] ArmPlatformPkg/PlatformIntelBdsLib: add splash screen support

2015-09-01 Thread Ard Biesheuvel
Add a call to EnableQuietBoot () to BdsPlatformPolicyBehavior(), so that a splash screen is shown in case one is present under the correct GUID in the FV, and we have graphics support. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Librar

[edk2] [PATCH v3 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Ard Biesheuvel
This adds support for the Intel BDS, by introducing a define 'USE_ARM_BDS' which defaults to TRUE, and can be overridden on the build command line. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Ryan Harkin --- ArmPlatformPkg/ArmVExpressPkg/Ar

[edk2] [PATCH v3 1/5] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-09-01 Thread Ard Biesheuvel
The Intel BDS platform library still depends on the ARM BDS specific BdsLib. So replace its invocations with GenericBdsLib counterparts, and fix up where needed, so that we can drop the dependency. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatf

[edk2] [PATCH v3 0/5] secure boot support for ARM FVP Base and Foundation models

2015-09-01 Thread Ard Biesheuvel
This series adds support for using the Intel BDS with ArmVExpress-FVP, and for building it with UEFI Secure Boot enabled. Note that the former is a prerequisite of the latter, since the ARM BDS has no GUI for enrolling certificates and enabling secure boot. Patch #1 removes the PlatformIntelBdsLI

[edk2] [PATCH v3 2/5] ArmPlatformPkg/PlatformIntelBdsLib: fix error handling

2015-09-01 Thread Ard Biesheuvel
In InitializeConsolePipe (), we clobber the Status variable in the error handling path that reports Status in its output. Instead, use a NULL check on the LocateProtocol () output argument. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/L

[edk2] [PATCH v3 5/5] ArmPlatformPkg/ArmVExpress-FVP: enable UEFI Secure Boot

2015-09-01 Thread Ard Biesheuvel
This allows the FVP target to be built with UEFI Secure Boot enabled, by passing -D SECURE_BOOT_ENABLE to the build command line. Note that you will need to disable the ARM BDS (-D USE_ARM_BDS=FALSE) or you will not be able to enroll certificates, since the ARM BDS does not provide a GUI to do so.

Re: [edk2] [PATCH v2 0/3] unify FVP Base and Foundation model support

2015-09-01 Thread Ard Biesheuvel
On 1 September 2015 at 09:11, Ryan Harkin wrote: > > > On 1 September 2015 at 08:09, Ryan Harkin wrote: >> >> >> >> On 31 August 2015 at 10:20, Ard Biesheuvel >> wrote: >>> >>> On 27 August 2015 at 15:44, Ryan Harkin wrote: >>> > >>> > >>> > On 24 August 2015 at 12:22, Ard Biesheuvel >>> > wro

[edk2] [patch] CryptoPkg: Replace string wrapper functions with safe string functions

2015-09-01 Thread Qin Long
EDKII core suggest retire unsafe string functions. This patch is to replace string wrapper functions with new-added safe string functions for consistence. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Include/OpenSslSupport.h | 10 ++ 1 fil

[edk2] [PATCH v2] MdeModulePkg: Fix the issue in DxeCore CoreInitializeMemoryServices()

2015-09-01 Thread Liming Gao
CoreInitializeMemoryServices() will essentially pickup a piece of memory out of *any* memory descriptor HOB completely ignoring the memory allocation HOBs. This change considers memory allocation hobs in this API. v2 adds check the memory range in the resource HOB that includes PHIT range to make

Re: [edk2] [PATCH v2 0/3] unify FVP Base and Foundation model support

2015-09-01 Thread Ryan Harkin
On 1 September 2015 at 08:09, Ryan Harkin wrote: > > > On 31 August 2015 at 10:20, Ard Biesheuvel > wrote: > >> On 27 August 2015 at 15:44, Ryan Harkin wrote: >> > >> > >> > On 24 August 2015 at 12:22, Ard Biesheuvel >> > wrote: >> >> >> >> On 18 August 2015 at 16:10, Ard Biesheuvel >> >> wro

Re: [edk2] [PATCH v2 0/3] unify FVP Base and Foundation model support

2015-09-01 Thread Ryan Harkin
On 31 August 2015 at 10:20, Ard Biesheuvel wrote: > On 27 August 2015 at 15:44, Ryan Harkin wrote: > > > > > > On 24 August 2015 at 12:22, Ard Biesheuvel > > wrote: > >> > >> On 18 August 2015 at 16:10, Ard Biesheuvel > >> wrote: > >> > Instead of omitting some drivers that are known to break

Re: [edk2] [PATCH v2 4/5] ArmPlatformPkg/ArmVExpress-FVP: add support for the Intel BDS

2015-09-01 Thread Ryan Harkin
On 31 August 2015 at 10:28, Ard Biesheuvel wrote: > On 27 August 2015 at 18:39, Ryan Harkin wrote: > > > > > > On 26 August 2015 at 10:59, Ard Biesheuvel > > wrote: > >> > >> This adds support for the Intel BDS, by introducing a define > >> 'USE_ARM_BDS' which defaults to TRUE, and can be overr