[edk2] 答复: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Ray, MpCpuExchangeInfo was declared as volatile type. It may not be necessary to add volatile for NumApsExecuting. Jeff 发件人: Ni, Ruiyu 发送时间: 2017年10月24日 14:03 收件人: Dong, Eric; edk2-devel@lists.01.org 主题: Re:

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

You need to have "volatile" for "UINTN NumApsExecuting;". Otherwise, compiler may optimize the code to cause below code wait forever: while (CpuMpData->MpCpuExchangeInfo->NumApsExecuting != 0) { CpuPause(); } Thanks/Ray > -Original Message- > From: Dong, Eric > Sent:

Re: [edk2] [Patch 1/2] UefiCpuPkg/MpInitLib: Change AP Index variable name.

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Monday, October 23, 2017 3:23 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch 1/2] UefiCpuPkg/MpInitLib: Change AP Index variable name. > > Original AP index variable name not well expre

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

I also agree the mapping. Julien, There is a typo in commit log " instropecting " should be " introspecting ". Anyway, you may need the commit log according to the mapping, you can take care of the typo in the updated commit log. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: T

[edk2] [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b

[edk2] [PATCH] MdeModulePkg/UfsBlockIoPei: Support IoMmu

Update the UfsBlockIoPei driver to consume IOMMU_PPI to allocate DMA buffer. If no IOMMU_PPI exists, this driver still calls PEI service to allocate DMA buffer, with assumption that DRAM==DMA. This is a compatible change. Cc: Star Zeng Cc: Jiewen Yao Contributed-under: TianoCore Contribution A

Re: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI.

Hi Karunakar, For #3, it's the non-regression issue that will cause the target IP is invalid if it's the same with previous one. And I'd like to fix it by another patch since it's not related to the InitiatorInfo display. Can you please report another Bugzilla for the ISCSI target address issue

Re: [edk2] [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.

Reviewed-by: Star Zeng -Original Message- From: Yao, Jiewen Sent: Friday, October 20, 2017 5:07 PM To: edk2-devel@lists.01.org; Zeng, Star Subject: Re: [edk2] [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory. Correct email address thank you! Yao, Jiewen > 在 2017年10月20日，下午4

Re: [edk2] [PATCH] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

I prefer to set the attributes to 0 for the MorLock deletion in the same patch. It is fine to have empty MorLockInitAtEndOfDxe() in TcgMorLockDxe.c with your explanation. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 11, 2017 1:2

Re: [edk2] Fwd: timer ticks ?

Hi David, I think EVT_TIMER is required functionality. Many drivers depend on it. I know it goes away at runtime, but so do the rest of boot services. There's nothing that can be done about that; even the BIOS timer tick was taken over by all modern operating systems, so it wasn't reliably pe

[edk2] Fwd: timer ticks ?

Hi, Is there a reliable (always available) way to get a timer tick in an application similar to the old 18.2 per second timer tick from BIOS. That one was always there, high speed access (no slow access to a RTC) and the tick count is known (to approx calculate intervals for polling and other thi

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Hi Laszlo, On 18/10/17 13:11, Laszlo Ersek wrote: On 10/18/17 12:19, Julien Grall wrote: After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change serial attributes", serial is initialized using the reset method that will call SetAttributes. However, SetAttributes may not be supp

Re: [edk2] [Patch 0/2] Add IPv6 support condition check for HTTP/ISCSI.

Hi Jiaxin, 1. I've verified, IPv6 support condition check for HTTP/ISCSI, It works fine and the ASSERT issue also resolved. 2. Regards Display Initiator IP, It resolves the issues the issues which I've mentioned previously. 3. I found some other issue in ISCSI, Below are the details A. Add Attem

Re: [edk2] Adding VLAN changing Boot order to default

Hello All, Boot order is changing to default if we add VLAN, below are the steps followed. [Steps] 1. Change default boot order to some other, Then Commit changes and Exit. (In my case first boot option Is UEFI Internal Shell, then I changed PXEv4 as first boot option) 2. Add a VL

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

On 23 October 2017 at 15:18, Gao, Liming wrote: > This is for debug purpose. I think UINT32 is OK if AARCH64 can operate 32bit > value. > Both my ARM and AARCH64 implementations write 16 bytes at a time, and so whether the source value is UINT32 or UINT64 or UINT16 does not make any difference a

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

This is for debug purpose. I think UINT32 is OK if AARCH64 can operate 32bit value. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, October 21, 2017 1:19 AM > To: Ard Biesheuvel > Cc: Gao, Liming ; edk2-devel@lists.01.org; Leif > Lin

Re: [edk2] [PATCH v3] EmbeddedPkg: add driver to set graphical/serial console preference

On 23 October 2017 at 11:26, Leif Lindholm wrote: > On Fri, Oct 20, 2017 at 10:24:04PM +0100, Ard Biesheuvel wrote: >> Linux on ARM/arm64 will infer from the presence of a /chosen/stdout-path >> DT property or of a SPCR ACPI table that the primary console is the serial >> port, even if a graphical

Re: [edk2] [PATCH v3] EmbeddedPkg: add driver to set graphical/serial console preference

On Fri, Oct 20, 2017 at 10:24:04PM +0100, Ard Biesheuvel wrote: > Linux on ARM/arm64 will infer from the presence of a /chosen/stdout-path > DT property or of a SPCR ACPI table that the primary console is the serial > port, even if a graphical console is available as well. > > So let's introduce a

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] GCC FCE

Changed tool path. 1. Add FCE for GCC build 2. Change build script to make sure that system can still boot after Setup variable deletion Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BuildBios.sh | 14 +- 1 file cha

[edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Current logic always waiting for a specific value to collect all APs count. This logic may caused some platforms cost too much time to wait for time out. This patch add new logic to collect APs count. It adds new variable NumApsExecuting to detect whether all APs have finished initialization. Each

[edk2] [Patch 1/2] UefiCpuPkg/MpInitLib: Change AP Index variable name.

Original AP index variable name not well express the meaning of the variable. Also this name is better used in later patch. So change the variable name for better understanding. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/

[edk2] [Patch 0/2] Enhance collect AP Count logic

Current logic always waiting for a specific value to collect all APs count. This logic may caused some platforms cost too much time to wait for time out. This patch series add new logic to collect APs count. It adds new variable NumApsExecuting to detect whether all APs have finished initializatio

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix bug that PCI BUS claims too much resource

Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ruiyu > Sent: Friday, October 20, 2017 5:56 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] MdeModulePkg/PciBus: Fix bug that PCI BUS claims too > much resource > > The bug was caused by 728d74973c9262b6c7b7ef4

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Use SetMem instead of SetMem64 to fix hang

Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ruiyu > Sent: Monday, October 23, 2017 1:12 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] UefiCpuPkg/MtrrLib: Use SetMem instead of SetMem64 to > fix hang > > ClearMasks and OrMasks are not 8-byte aligned. >

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

Hi Meenakshi/Liming, My 2 cents, around this. 1) Having a new lib for BE read might not be helpful for us, e.g. a IP which is in BE mode access the UART for print or system registers which are in LE, then with new Lib, we will get all read/write in BE mode 2) Especially for our IPs, which a