Re: [E-devel] [Patch] [elm_entry] New APIs for user style

2012-05-30 Thread The Rasterman
> Thanks & Regards, > Thiep Ha > > --- Original Message --- > Sender : Daniel Juyung Seo > Date : May 27, 2012 05:40 (GMT+09:00) > Title : Re: [E-devel] [Patch] [elm_entry] New APIs for user style > > great as your first patch! and code

Re: [E-devel] [Patch] [elm_entry] New APIs for user style

2012-05-29 Thread thiep ha
_user as Daniel's comment. Please review it. Thanks & Regards, Thiep Ha --- Original Message --- Sender : Daniel Juyung Seo Date : May 27, 2012 05:40 (GMT+09:00) Title : Re: [E-devel] [Patch] [elm_entry] New APIs for user style great as your first patch! and code looks good to

Re: [E-devel] [Patch] [elm_entry] New APIs for user style

2012-05-26 Thread Daniel Juyung Seo
great as your first patch! and code looks good to me too. but i have two comments. 1. add const to the parameter of elm_entry_text_style_user_peek. 2. add example for pop and keep to test_entry_style_user. and here is a tip for thiep. http://trac.enlightenment.org/e/wiki/PatchReview thanks. On Ma

Re: [E-devel] [Patch] [elm_entry] New APIs for user style

2012-05-25 Thread The Rasterman
On Thu, 24 May 2012 09:12:45 + (GMT) thiep ha said: looks good with 1 exception. missing as part of the patch a patch to the Changelog file and adding yourself to AUTHORS. can you add those into your patch and re-send? > Hello, > > As we known that, the user style is a convenience way whic

[E-devel] [Patch] [elm_entry] New APIs for user style

2012-05-24 Thread thiep ha
Hello, As we known that, the user style is a convenience way which helps users to work with style without the need of new edc file. It means that users can set their own style (e.g. font, font_size, color) without making new edc file. Currently, in Elementary Entry, there is no APIs supporting