[FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-04 Thread Marc-Antoine ARNAUD
0001-prores_ks-use-CodecContext-for-color-information-if-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-04 Thread Paul B Mahol
On 10/4/18, Marc-Antoine ARNAUD wrote: > > Why? IIRC this patch is not needed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-05 Thread Marc-Antoine ARNAUD
In our case we have some files with bad colorspaces (in HD but with bt601 colorspace). So we use -colorspace, -color_trc, -color_primaries to force the output colorspace. We keep compatibility with "old command line", we get source colorspace if nothing is mentionned. It work like that for Mpeg2vi

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-05 Thread Paul B Mahol
On 10/5/18, Marc-Antoine ARNAUD wrote: > In our case we have some files with bad colorspaces (in HD but with bt601 > colorspace). > So we use -colorspace, -color_trc, -color_primaries to force the output > colorspace. > > We keep compatibility with "old command line", we get source colorspace if >

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-10 Thread Marc-Antoine ARNAUD
For me it's the only codec who use picture colorspace as source. All others uses only the CodecContext. I don't know the exact reason, but I suppose it can be easiest to manage output colorspace during merge of video, as a video can have only one "static" video colorspace. So for me it made sense

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-10 Thread Paul B Mahol
On 10/10/18, Marc-Antoine ARNAUD wrote: > For me it's the only codec who use picture colorspace as source. > All others uses only the CodecContext. > I don't know the exact reason, but I suppose it can be easiest to manage > output colorspace during merge of video, as a video can have only one > "

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-10 Thread Marc-Antoine ARNAUD
I have updated the patch with our discussion. It took information only from the codec context. Marc-Antoine Le mer. 10 oct. 2018 à 11:36, Paul B Mahol a écrit : > On 10/10/18, Marc-Antoine ARNAUD wrote: > > For me it's the only codec who use picture colorspace as source. > > All others uses on

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-13 Thread Martin Vignali
Le mer. 10 oct. 2018 à 17:13, Marc-Antoine ARNAUD < arnaud.marcanto...@gmail.com> a écrit : > I have updated the patch with our discussion. > It took information only from the codec context. > > Marc-Antoine > > Hello, If i correctly understand (which is not sure :-) : the colorspace for AVCodec

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-15 Thread Marc-Antoine ARNAUD
Hi Martin, For my point of view, the AVFrame contains the colorspace for each frame, which can be different (maybe not volunteer..). The colorspace in AVCodecContext is the "pre-computed" colorspace, used to generate the output file, as header/footer of wrappers can require colorspace informations

Re: [FFmpeg-devel] prores_ks: use CodecContext for color information if specified

2018-10-15 Thread Martin Vignali
Le lun. 15 oct. 2018 à 11:24, Marc-Antoine ARNAUD < arnaud.marcanto...@gmail.com> a écrit : > Hi Martin, > > For my point of view, the AVFrame contains the colorspace for each frame, > which can be different (maybe not volunteer..). > The colorspace in AVCodecContext is the "pre-computed" colorspa