Cristian Rodríguez wrote:
> flac and metaflac do not use openSSL, only libFLAC does.
But flac and metaflac are GPL and link (possibly statically) to
libFLAC.
> Personally I don't see any technical reason to use a different library
> other than politics and obscure potential license incompatibi
El 07/05/12 16:19, Eric Wong escribió:
>> flac and metaflac do not use openSSL, only libFLAC does.
>
> But since flac/metaflac use libFLAC, I suspect (IANAL) the relationship
> can be transitive. (But being an optional dependency helps as distros
> can avoid potential issues).
That's why it is o
Cristian Rodríguez wrote:
> El 07/05/12 06:23, Miroslav Lichvar escribió:
> > On Sat, May 05, 2012 at 05:34:31PM -0400, Cristian Rodríguez wrote:
> >> This has the advantage of being more efficient than the included
Btw, how much more efficient and on what hardware?
Based on previous experience
El 07/05/12 06:23, Miroslav Lichvar escribió:
> On Sat, May 05, 2012 at 05:34:31PM -0400, Cristian Rodríguez wrote:
>> This has the advantage of being more efficient than the included
>> routines and allows distros to centralize crypto mainteniance on
>> a few libraries.
>
> Isn't the OpenSSL licen
On Sat, May 05, 2012 at 05:34:31PM -0400, Cristian Rodríguez wrote:
> This has the advantage of being more efficient than the included
> routines and allows distros to centralize crypto mainteniance on
> a few libraries.
Isn't the OpenSSL license incompatible with GPL? IANAL, but I think
the flac
El 05/05/12 21:04, Eric Wong escribió:
> Cristian Rodríguez wrote:
>> +#if defined(HAVE_OPENSSL)
>> +/* decoder->private_->computed_md5sum is NULL when
>> decoder->private_->do_md5_checking == false
>> +* that causes assertion failure crash in openSSL.
>> +*/
>> +if(decoder->priva
Eric Wong wrote:
> Can you do this without sprinkling #ifdefs all over the place?
+1
> Mixing #ifdefs and normal C control structures make code hard to
> read/maintain. This is *especially* true for folks who aren't regular
> contributors to flac, myself included.
Very much agree.
Erik
--
--
Cristian Rodríguez wrote:
> +#if defined(HAVE_OPENSSL)
> +/* decoder->private_->computed_md5sum is NULL when
> decoder->private_->do_md5_checking == false
> +* that causes assertion failure crash in openSSL.
> +*/
> +if(decoder->private_->do_md5_checking) {
> +md5_failed =
This has the advantage of being more efficient than the included
routines and allows distros to centralize crypto mainteniance on
a few libraries.
---
configure.ac |4 +-
m4/ax_check_openssl.m4| 124 +
src/libFLAC/Makefile.a
