Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-28 Thread Alex Dupre
Jason Helfman ha scritto: > I am working on the following pr, and would like to get others approval to > the following patch: > http://people.freebsd.org/~jgh/files/pre-patch.txt > > This patch is fixing several use cases of SRC_BASE before it is defined. I don't agree for the quantis-kmod patch.

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-22 Thread Jason Helfman
On Tue, May 22, 2012 at 07:04:29PM -0700, Bob Frazier thus spake: On 05/21/12 15:04, Jason Helfman so wittily quipped: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/fil

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-22 Thread Bob Frazier
On 05/21/12 15:04, Jason Helfman so wittily quipped: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-22 Thread Jeremy Messenger
On Tue, May 22, 2012 at 7:13 AM, Scot Hetzel wrote: > On Tue, May 22, 2012 at 1:21 AM, Mark Linimon wrote: >> Unfortunately certain things need to be defined before bsd.port.pre.mk >> is included.  So, pointy hat to me for giving bad advice. >> >> These show up immediately as "bad distinfo" probl

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-22 Thread Scot Hetzel
On Tue, May 22, 2012 at 1:21 AM, Mark Linimon wrote: > Unfortunately certain things need to be defined before bsd.port.pre.mk > is included.  So, pointy hat to me for giving bad advice. > > These show up immediately as "bad distinfo" problems: > > http://pointyhat-west.isc.freebsd.org/errorlogs/am

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-22 Thread Mark Linimon
Unfortunately certain things need to be defined before bsd.port.pre.mk is included. So, pointy hat to me for giving bad advice. These show up immediately as "bad distinfo" problems: http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/e.10-exp.20120522050031.pointyhat-west/lsof-4.86,7

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-21 Thread Maxim Ignatenko
On вт, 22 тра 2012 01:04:49 Jason Helfman wrote: > I am working on the following pr, and would like to get others approval to > the following patch: > http://people.freebsd.org/~jgh/files/pre-patch.txt > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 > > This patch is fixing several us

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-21 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/21/12 15:04, Jason Helfman wrote: > I am working on the following pr, and would like to get others > approval to the following patch: > http://people.freebsd.org/~jgh/files/pre-patch.txt > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/16

Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-21 Thread Mark Linimon
Thanks for doing this work. A quick review looks to me to be TRT. I would suggest some minor fixes but only for style: for me, it makes it a bit clearer what's going on if the pre.mk include isn't among the various WITH_* definitions, e.g. net/skystar2. Or maybe just having a blank line before t

[RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced

2012-05-21 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 This patch is fixing several use cases of SRC_B