[PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-10 Thread Bjorn Andersson
on is expected to be done dynamically is the QCS6490 rb3gen2. The downstream driver does this unconditioanlly on any A6xx and newer, so follow suite and make the call. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 +++ 1 file changed, 11 insertions(+)

[PATCH v2 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-11-10 Thread Bjorn Andersson
er to avoid "CP | AHB bus error"-errors from the GPU. Introduce a function to allow the msm driver to invoke this call. Signed-off-by: Bjorn Andersson --- drivers/firmware/qcom/qcom_scm.c | 26 ++ drivers/firmware/qcom/qcom_scm.h | 1 + include/linu

[PATCH v2 0/2] drm/msm/adreno: Setup SMMU aparture

2024-11-10 Thread Bjorn Andersson
forms, but only with Qualcomm presence in EL2. I did receive Tested-by from Konrad and Jessica, not picking these up, as I change the firmware call pattern in this version by introducing a "is_available" check. Signed-off-by: Bjorn Andersson --- Changes in v2: - Added a check to see if

Re: (subset) [PATCH v7 0/6] HDMI TX support in msm8998

2024-10-05 Thread Bjorn Andersson
es for msm8998 commit: 2150c87db80cf7eed3939f32cbb18393055c58ce Best regards, -- Bjorn Andersson

[PATCH RFT 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-10-03 Thread Bjorn Andersson
er to avoid "CP | AHB bus error"-errors from the GPU. Introduce a function to allow the msm driver to invoke this call. Signed-off-by: Bjorn Andersson --- drivers/firmware/qcom/qcom_scm.c | 19 +++ drivers/firmware/qcom/qcom_scm.h | 1 + include/linu

[PATCH RFT 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-10-03 Thread Bjorn Andersson
on is expected to be done dynamically is the QCS6490 rb3gen2. The downstream driver does this unconditioanlly on any A6xx and newer, so follow suite and make the call. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ 1 file changed, 10 insertions(+)

[PATCH RFT 0/2] drm/msm/adreno: Setup SMMU aparture

2024-10-03 Thread Bjorn Andersson
forms, but only with Qualcomm presence in EL2. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (2): firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID drm/msm/adreno: Setup SMMU aparture for per-process page table drivers/firmware/qcom/qcom_scm.c| 19 +++ dr

Re: [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-09-26 Thread Bjorn Andersson
On Thu, Sep 26, 2024 at 04:31:33PM +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > > [v2] > - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry] > - Update bindings by fixing dt_binding_chec

Re: [PATCH v2 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-09-26 Thread Bjorn Andersson
On Thu, Sep 26, 2024 at 04:55:02PM GMT, Mahadevan P wrote: > Sorry, Please ignore this thread/coverletter > go/upstream and adopt b4, please.

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-13 Thread Bjorn Andersson
On Thu, Sep 12, 2024 at 03:34:05PM +0530, Soutrik Mukhopadhyay wrote: > > On 9/12/2024 1:32 AM, Bjorn Andersson wrote: > > On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: > > > The Qualcomm SA8775P platform comes with a DisplayPort controller > &

Re: [PATCH 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-11 Thread Bjorn Andersson
On Wed, Sep 11, 2024 at 03:38:10PM +0530, Soutrik Mukhopadhyay wrote: > In order to support different HW versions, introduce aux_cfg array > to move v4 specific aux configuration settings. > > Signed-off-by: Soutrik Mukhopadhyay > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 34 +-

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-11 Thread Bjorn Andersson
On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: > The Qualcomm SA8775P platform comes with a DisplayPort controller > with a different base offset than the previous SoCs, > add support for this in the DisplayPort driver. > > Signed-off-by: Soutrik Mukhopadhyay > --- > drive

Re: (subset) [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform

2024-08-15 Thread Bjorn Andersson
dts: qcom: sm8350: add refgen regulator commit: 08822cf3de00f1b9edb01b995d926595e48a54eb Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform

2024-08-15 Thread Bjorn Andersson
t regards, -- Bjorn Andersson

Re: (subset) [PATCH 0/3] Update Konrad Dybcio's email addresses

2024-07-31 Thread Bjorn Andersson
Dybcio's email address commit: fce6a1eefb2a1db706fa17ca21e3e7107811d2e8 Best regards, -- Bjorn Andersson

Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets

2024-07-30 Thread Bjorn Andersson
On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote: > Hi Abhinav, > > On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar wrote: > > > > Hardware document indicates that widebus is recommended on DP on all > > MDSS chipsets starting version 5.x.x and above. > > > > Follow the guideline and

Re: [PATCH 1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

2024-07-28 Thread Bjorn Andersson
On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote: > From: Eugene Lepshy > Please make sure the subject prefix matches other changes in the same driver/files. Regards, Bjorn > According to downstream, A642L's speedbin is 129 and uses 4 as index > > Signed-off-by: Eugene Lepshy >

Re: (subset) [PATCH v2 0/5] Support for Adreno X1-85 GPU

2024-07-02 Thread Bjorn Andersson
emories and double the number of data channels to improve > bandwidth to DDR. > > [...] Applied, thanks! [5/5] arm64: dts: qcom: x1e80100: Add gpu support commit: 721e38301b79a6ee8375cb0ebd586699a7f353e3 Best regards, -- Bjorn Andersson

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Bjorn Andersson
On Sun, Jun 23, 2024 at 08:46:30PM GMT, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > > On 23/06/2024 14:28, Akhil P Oommen wrote: > > > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > > >> On 23/06/2024 13:06, Akhil P Oommen w

Re: (subset) [PATCH v3 2/6] firmware: qcom_scm: Add gpu_init_regs call

2024-06-20 Thread Bjorn Andersson
regs call commit: 158ed777e330e9bf6bd592daaf1e860d965ec8b5 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v2 0/7] Add SMEM-based speedbin matching

2024-06-20 Thread Bjorn Andersson
a83 [2/7] soc: qcom: smem: Add a feature code getter commit: 81bbb2b891174da9301fc0d4fe9622bd4cb6a995 Best regards, -- Bjorn Andersson

Re: [PATCH v2 2/7] soc: qcom: smem: Add a feature code getter

2024-05-28 Thread Bjorn Andersson
On Wed, Apr 17, 2024 at 10:02:54PM GMT, Konrad Dybcio wrote: [..] > diff --git a/include/linux/soc/qcom/socinfo.h > b/include/linux/soc/qcom/socinfo.h > index 10e0a4c287f4..52439f48428f 100644 > --- a/include/linux/soc/qcom/socinfo.h > +++ b/include/linux/soc/qcom/socinfo.h > @@ -3,6 +3,8 @@ > #i

Re: [PATCH v2] arm64: dts: qcom: msm8998: enable adreno_smmu by default

2024-05-27 Thread Bjorn Andersson
any further configuration. > > Bring msm8998 in line with the 14 other platforms. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: msm8998: enable adreno_smmu by default commit: 98a0c4f2278b4d6c1c7722735c20b2247de6293f Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 0/8] MSM8976 MDSS/GPU/WCNSS support

2024-05-27 Thread Bjorn Andersson
: qcom: msm8976: Declare and wire SDC pins > arm64: dts: qcom: msm8976: Add WCNSS node > > [...] Applied, thanks! [1/8] arm64: dts: qcom: msm8976: Add IOMMU nodes commit: 418c2ffd7df9bfc25c21172bd881b78d7569fb4d Best regards, -- Bjorn Andersson

Re: [PATCH v3 2/6] firmware: qcom_scm: Add gpu_init_regs call

2024-05-26 Thread Bjorn Andersson
On Tue, Apr 30, 2024 at 11:43:16AM GMT, Connor Abbott wrote: > This will used by drm/msm to initialize GPU registers that Qualcomm's > firmware doesn't make writeable to the kernel. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Connor Abbott Acked-by: Bjorn A

Re: [PATCH] drm/msm/adreno: Check for zap node availability

2024-05-19 Thread Bjorn Andersson
(!of_device_is_available(np)) { would cover both cases and be slightly cleaner imho... But this looks reasonable either way. Reviewed-by: Bjorn Andersson Regards, Bjorn > zap_available = false; > return -ENODEV; > } > -- > 2.45.1 >

Re: (subset) [PATCH v2 0/6] drm/msm: Support a750 "software fuse" for raytracing

2024-05-01 Thread Bjorn Andersson
: Fix GPU cx_mem size commit: 0d80ac75cba26fde5cae55323b7617f0fec5322b Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v2 0/3] DisplayPort support for SM6350/SM7225

2024-04-21 Thread Bjorn Andersson
series (mostly just wiring up TCPM and the SBU > mux). > > [...] Applied, thanks! [3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller commit: 62f87a3cac4e70fa916914a359d3f045a5ad8b9b Best regards, -- Bjorn Andersson

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Bjorn Andersson
On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > index e4275d3ad581..5a5dc3faa971 100644 > > --- a/drivers/g

Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-04-09 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 02:31:45PM -0700, Abhinav Kumar wrote: > On 3/28/2024 7:40 AM, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > The dp_audio read and write operations uses members in struct dp_catalog > > for passing arguments and return va

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-09 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > Thought I commented on this already, but I don't see my reply... Can you please elaborate on what this stuff is, such that we have a track record in the history

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > > wrote: > > >> On 4/7/2024 11:48 AM

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > > > From: Kuogee Hsieh > > [..] > > > diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-07 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > From: Kuogee Hsieh [..] > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index d80f89581760..bfb6dfff27e8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/

[PATCH v2] drm/msm/dp: Remove now unused connector_type from desc

2024-04-05 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Remaining duplicate entries are squashed. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100

Re: [PATCH] phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE

2024-04-04 Thread Bjorn Andersson
t; explanation in the commit why this is changed, so I suspect it was an > oversight or happened while being extracted from some other series. Thanks for catching that, I wrote that patch long before Johan did the rename of "pcs" to "dp_dp_phy", and must have missed that w

Re: (subset) [PATCH v3 0/4] arm64: dts: fix several display-related schema warnings

2024-04-04 Thread Bjorn Andersson
ls commit: 7fb5680b589d5eae64ada1d917b6ff2dab82f5ae [3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs commit: 580701ec27f61e0996dd5fcd23b091b6bf6933e3 [4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes commit: 1106ea2266d11ebd97c3493a0c36a45272bfb67a Best reg

Re: [PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-29 Thread Bjorn Andersson
On Fri, Mar 29, 2024 at 07:23:07AM +0200, Dmitry Baryshkov wrote: > On Fri, 29 Mar 2024 at 06:02, Bjorn Andersson > wrote: > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > b/drivers/gpu/drm/msm/dp/dp_display.c [..] > > static const struct msm_dp_desc sc8280xp_e

[PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100-display-refactor-connector-v4-1-e0ebaea66

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Bjorn Andersson
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote: > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > > > + Johan and Bjorn for FYI > > > > > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > > > For internal HPD case, hpd_event_thread is

[PATCH v2 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Reviewed-by: Dmitry Baryshkov

[PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH v2 3/6] drm/msm/dp: Remove unused defines and members

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm

[PATCH v2 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Reviewed

[PATCH v2 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int, then merge dp_debug_get

[PATCH v2 0/6] drm/msm/dp: Spring cleaning

2024-03-28 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Changes in v2: - Merge dp_debug_get() and dp_debug_init() - Link to v1: https://lore.kernel.org/r/20240326-msm-dp-cleanup-v1-0-e775556ec...@quicinc.com --- Bjorn

Re: [PATCH v4 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-26 Thread Bjorn Andersson
mitry Baryshkov > Signed-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c >

Re: [PATCH v4 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-26 Thread Bjorn Andersson
l described in DT, therefore, assume it's eDP if panel node > is present. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm/dp/dp_display.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-)

[PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Signed-off-by: Bjorn Andersson

[PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Signed

[PATCH 3/6] drm/msm/dp: Remove unused defines and members

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm/msm/dp/dp_catalog.c | 1

[PATCH 0/6] drm/msm/dp: Spring cleaning

2024-03-26 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (6): drm/msm/dp: Drop unused dp_debug struct drm/msm/dp: Removed fixed nvid "support" drm/msm/dp: Remove unused defines a

[PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int. Signed-off-by: Bjorn

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Bjorn Andersson
On Fri, Mar 22, 2024 at 03:22:22PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP is not described > in DT, therefore, assume it'

Re: [PATCH v2 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-27 Thread Bjorn Andersson
-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c| 11 +++ > drivers/gpu/drm/msm/dp/dp_ctrl.h| 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 17 ++--- > 3 files changed, 26 insertions(+), 3 delet

Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-22 Thread Bjorn Andersson
t; >> > > >> > > >> > > >> On 2/22/24 00:41, Dmitry Baryshkov wrote: > > >>> On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > > >>> wrote: > > >>>> > > >>>> The max frequency listed in the DPU

Re: [PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:50:12AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > With the ADSP remoteproc loaded pmic_glink can be introduced and wired > > up to provide role and orientation switching signals. >

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:38:45AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > When upstreamed the SC7280 DP controllers where described as one being > > DP and one eDP, but they can infact both be DP or eDP. >

Re: [PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:33AM +0200, Abel Vesa wrote: > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set in devicetree via is-edp flag. > > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm

Re: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:31AM +0200, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and docoment the is-edp s/docoment/document/ > flag. This new flag will be used from now on to dictate the mode from s/from now on// Perhaps cleaner to spell out that the controllers are exp

Re: [PATCH RFC 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:32AM +0200, Abel Vesa wrote: > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h > b/drivers/gpu/drm/msm/dp/dp_ctrl.h > index fa014cee7e21..a10d1b19d172 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h > @@ -32,6 +32,7 @@ struct dp_

Re: [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration

2024-02-21 Thread Bjorn Andersson
the PHY subsystem should be reworked to address this (i.e. by > separating initialisation and registration of the PHY). > > Fixes: 2851117f8f42 ("phy: qcom-qmp-combo: Introduce orientation switching") > Cc: sta...@vger.kernel.org # 6.5 > Cc: Bjorn Andersson

Re: [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration

2024-02-21 Thread Bjorn Andersson
registration of the PHY). > > Fixes: 35921910bbd0 ("phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE") > Fixes: 1904c3f578dc ("phy: qcom-qmp-combo: Introduce drm_bridge") > Cc: sta...@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Cc: Dmitry Baryshkov > S

Re: [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m

2024-02-21 Thread Bjorn Andersson
kov > Signed-off-by: Rob Clark > Link: https://lore.kernel.org/r/20231213210644.8702-1-robdcl...@gmail.com > [ johan: rebase on 6.8-rc4, amend commit message and mention DRM ] > Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK > driver") > Cc: sta...@vger.

Re: [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-21 Thread Bjorn Andersson
ild devices, this is also a requirement due to a long-standing issue > in driver core that can otherwise lead to a probe deferral loop (see > fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")). > > Fixes: 080b4e24852b ("soc: qcom: pmic_glink: Introduce

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-21 Thread Bjorn Andersson
s already wrong in this regard. Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-21 Thread Bjorn Andersson
; Cc: Dmitry Baryshkov > Cc: Neil Armstrong > Signed-off-by: Johan Hovold Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c &g

[PATCH 4/9] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output

2024-02-21 Thread Bjorn Andersson
The RB3Gen2 board comes with a mini DP connector, describe this, enable MDSS, DP controller and the PHY that drives this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot

[PATCH 9/9] arm64: defconfig: Enable sc7280 display and gpu clock controllers

2024-02-21 Thread Bjorn Andersson
Enable the SC7280 display and gpu clock controllers to enable display support on the QCS6490 RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH 7/9] arm64: dts: qcom: qcs6490-rb3gen2: Introduce USB redriver

2024-02-21 Thread Bjorn Andersson
The RB3gen2 has a USB redriver on APPS_I2C, enable the bus and introduce the redriver. The plumbing with other components is kept separate for clarity. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH 5/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

2024-02-21 Thread Bjorn Andersson
Define firmware paths and enable the ADSP and CDSP remoteprocs. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490

[PATCH 8/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display

2024-02-21 Thread Bjorn Andersson
With MDSS, pmic_glink, and the redriver in place, wire up the various components to enable USB Type-C display on the RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 63 +++- 1 file changed, 61 insertions(+), 2 deletions(-) diff

[PATCH 2/9] arm64: dts: qcom: sc7280: Make eDP/DP controller default DP

2024-02-21 Thread Bjorn Andersson
instance and make it eDP for the SC7280 qcard. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch

[PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-21 Thread Bjorn Andersson
The max frequency listed in the DPU opp-table is 506MHz, this is not sufficient to drive a 4k@60 display, resulting in constant underrun. Add the missing MDP_CLK turbo frequency of 608MHz to the opp-table to fix this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 5

[PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
-edp to a dedicated list, to ensure existing DeviceTree will continue to select eDP. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp

[PATCH 0/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable two displays

2024-02-21 Thread Bjorn Andersson
ds on https://lore.kernel.org/linux-arm-msm/20240220-x1e80100-display-v4-0-971afd9de...@linaro.org/ Signed-off-by: Bjorn Andersson --- Bjorn Andersson (9): drm/msm/dp: Add DP support to combo instance in SC7280 arm64: dts: qcom: sc7280: Make eDP/DP controller default DP arm64

[PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
With the ADSP remoteproc loaded pmic_glink can be introduced and wired up to provide role and orientation switching signals. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Bjorn Andersson
, thanks! [1/1] arm64: dts: qcom: sm6115: fix USB PHY configuration commit: f176168bcb95bd1fdd32f5a794e68b7a36ac8740 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v4 0/6] SDM670 display subsystem support

2023-12-18 Thread Bjorn Andersson
om: sdm670: add display subsystem commit: 5f8ba4f28ddb432c8a9720c337f9047e38fa7e36 Best regards, -- Bjorn Andersson

Re: [PATCH 3/3] ARM: qcom: merge remaining subplatforms into sensible Kconfig entry

2023-12-15 Thread Bjorn Andersson
On Thu, Dec 07, 2023 at 03:55:00PM +0300, Dmitry Baryshkov wrote: > Three remaining Qualcomm platforms have special handling of the > TEXT_OFFSET to reserve the memory at the beginnig of the system RAM, see > the commit 9e775ad19f52 ("ARM: 7012/1: Set proper TEXT_OFFSET for newer > MSMs"). This is

Re: [PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-12-11 Thread Bjorn Andersson
, the function no longer relate to the "parser module", and we stash the return value of devm_drm_of_get_bridge(dev, dev->of_node, 1, 0) in parser->next_brigde, so that we 5 lines below this call can move it into dp->next_bridge. As such, I'd like to propose that w

Re: (subset) [PATCH 0/3] Add GPU support for MSM8226 (Adreno A305B)

2023-12-10 Thread Bjorn Andersson
On Thu, 30 Nov 2023 21:35:17 +0100, Luca Weiss wrote: > Add the necessary bits to bring up the GPU on msm8226. > > Tested on apq8026-lg-lenok. > > Applied, thanks! [3/3] ARM: dts: qcom: msm8226: Add GPU commit: fc209f869310776c437daba478246df64d82c38b Best reg

Re: (subset) [PATCH v3 00/12] RB1/QCM2290 features

2023-12-08 Thread Bjorn Andersson
ndings: firmware: qcom,scm: Allow interconnect for everyone commit: 56fdc35ef067c8dffee22038dd3a84bb3fa6d2a4 Best regards, -- Bjorn Andersson

Re: [PATCH 3/3] arm64: dts: qcom: sm8650: Add DisplayPort device nodes

2023-12-07 Thread Bjorn Andersson
On Thu, Dec 07, 2023 at 05:37:19PM +0100, Neil Armstrong wrote: > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi > b/arch/arm64/boot/dts/qcom/sm8650.dtsi [..] > + > + mdss_dp0: displayport-controller@af54000 { > + compatible = "qcom,sm8650-dp"; >

Re: [PATCH v2 0/4] Adreno 643 + fixes

2023-12-07 Thread Bjorn Andersson
e9206ce7b19f2735f6e [4/4] arm64: dts: qcom: sc7280: Add 0xac Adreno speed bin commit: 6a7f8c635dab30233df93b5566d4169ed956b71b Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-05 Thread Bjorn Andersson
On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: > > > On 12/3/2023 7:31 PM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > &

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-03 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > > > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > > > wrote: > >

Re: [Freedreno] (subset) [PATCH v3 00/12] RB1/QCM2290 features

2023-12-02 Thread Bjorn Andersson
10-rb1: Enable CAN bus controller commit: 252bc7ad359478dba8d77bce9502f2cc7bb547a3 [12/12] arm64: dts: qcom: qrb2210-rb1: add wifi variant property commit: b6a56a5a25d6273729b2b5139d58e3d390318ed2 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-12-01 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 09:06:45AM +0100, Johan Hovold wrote: > On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > > Similar to SC8280XP, the misconfigured SAFE logic causes rather > > significant delays in __arm_smmu_tlb_sync(), resulting in poor > > performan

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-01 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > wrote: > > On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: [..] > > > @@ -2386,6 +2390,7 @@ struct drm_encoder *dpu_encoder_init(struct

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-11-30 Thread Bjorn Andersson
On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: > Add a missing mutex lock to control vblank irq. Thus prevent race > conditions when registering/unregistering the irq callback. > I'm guessing that the mutex is needed because vblank_refcount, while being an atomic_t, doesn't actu

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-11-30 Thread Bjorn Andersson
On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8

[Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-11-30 Thread Bjorn Andersson
t;) Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h index e07f4c8c25b9..9ffc8804a6fc 10

[Freedreno] [PATCH] drm/msm/adreno: Fix A680 chip id

2023-11-30 Thread Bjorn Andersson
/adreno: Switch to chip-id for identifying GPU") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index f62a

[Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-30 Thread Bjorn Andersson
") Cc: sta...@vger.kernel.org Suggested-by: Doug Anderson Suggested-by: Rob Clark Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h b/drive

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Bjorn Andersson
On Wed, Oct 04, 2023 at 03:31:24AM +0300, Dmitry Baryshkov wrote: > clk_rcg2_shared_ops implements support for the case of the RCG which > must not be completely turned off. However its design has one major > drawback: it doesn't allow us to properly implement the is_enabled > callback, which cause

Re: [Freedreno] [PATCH v5 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

2023-10-25 Thread Bjorn Andersson
On Thu, Oct 26, 2023 at 01:28:06AM +0300, Dmitry Baryshkov wrote: > Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the > same functionality for the DRM bridge chain termination. > Reviewed-by: Bjorn Andersson Acked-by: Bjorn Andersson Regards, Bjorn

  1   2   3   4   5   6   7   8   >