Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Bernd Edlinger
On 1/4/21 10:45 PM, Jeff Law wrote: > > > On 1/4/21 1:06 PM, Bernd Edlinger wrote: >> --- a/gcc/final.c >> +++ b/gcc/final.c >> @@ -1735,7 +1735,12 @@ final_start_function_1 (rtx_insn **firstp, FILE >> *file, int *seen, >> last_filename); >> >>if

Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Richard Biener
On Wed, 6 Jan 2021, Bernd Edlinger wrote: > On 1/6/21 8:01 AM, Alexandre Oliva wrote: > > On Jan 5, 2021, Richard Biener wrote: > > > >> But isn't this a consumer issue then? If there is no line info for > >> a PC range then gdb shouldn't display any. > > > > No, there *is* line info there,

Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Bernd Edlinger
On 1/6/21 8:01 AM, Alexandre Oliva wrote: > On Jan 5, 2021, Richard Biener wrote: > >> But isn't this a consumer issue then? If there is no line info for >> a PC range then gdb shouldn't display any. > > No, there *is* line info there, carried over from an earlier .loc > directive, as there

Re: Patch RFA: Support non-ASCII file names in git-changelog

2021-01-05 Thread Martin Liška
On 1/4/21 12:47 PM, Martin Liška wrote: On 1/4/21 12:01 PM, Martin Liška wrote: Anyway, I'm going to update server hook first and I'll create an issue for  GitPython. So I was not correct about this. Also the server hooks uses now GitPython to identify modified files. I've just created an

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread abebeos via Gcc-patches
On Tue, 5 Jan 2021 at 21:25, Rainer Orth wrote: > Hi Jeff, > > > On 1/5/21 10:54 AM, Rainer Orth wrote: > >> > >> I fear I'm a bit lost here myself. I do have a little experience > >> running various builders: > >> > >> * I inherited a Golang one on Solaris/amd64 (based on their own builder >

Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Alexandre Oliva
On Jan 5, 2021, Richard Biener wrote: > But isn't this a consumer issue then? If there is no line info for > a PC range then gdb shouldn't display any. No, there *is* line info there, carried over from an earlier .loc directive, as there isn't anything like ".noloc" to output with a function

[PATCH] [AVX512] Fix ICE: Convert integer mask to vector in ix86_expand_fp_vec_cmp/ix86_expand_int_vec_cmp [PR98537]

2021-01-05 Thread Hongtao Liu via Gcc-patches
Hi: ix86_expand_fp_vec_cmp/ix86_expand_int_vec_cmp are used by vec_cmpmn for vector comparison to vector mask, but ix86_expand_sse_cmp(which is called in upper 2 functions.) may return integer mask whenever integer mask is available, so convert integer mask back to vector mask if needed.

Re: [PATCH][AVX512]Lower AVX512 vector compare to AVX version when dest is vector

2021-01-05 Thread Hongtao Liu via Gcc-patches
> >> > >> Note there's a data dependency between them. insn 7 feeds insn 9. When > >> there's a data dependency, combiner patterns are usually the better > >> choice than peepholes. I think you'd be looking to match something > >> likethis (from the . combine dump): > >> Using combiner

Re: [PATCH] ira: Skip some pseudos in move_unallocated_pseudos

2021-01-05 Thread Kewen.Lin via Gcc-patches
on 2021/1/6 上午2:19, Jeff Law wrote: > > > On 1/4/21 7:36 PM, Kewen.Lin wrote: >> Hi Jeff, >> >> on 2021/1/5 上午7:13, Jeff Law wrote: >>> >>> On 12/22/20 11:40 PM, Kewen.Lin via Gcc-patches wrote: Hi Segher, on 2020/12/22 下午9:55, Segher Boessenkool wrote: > Hi! > > Just

[committed] analyzer: fix false leaks when writing through unknown ptrs [PR97072]

2021-01-05 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-6497-gac3966e315ada63eb379d560a012fa77c3909155. gcc/analyzer/ChangeLog: PR analyzer/97072 * region-model-reachability.cc (reachable_regions::init_cluster): Convert symbolic region

[committed] analyzer: add regression test for PR 98073

2021-01-05 Thread David Malcolm via Gcc-patches
This ICE was fixed by r11-2694-g808f4dfeb3a95f50 (aka the big state rewrite for GCC 11). Successfully regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-6496-g23fc2be633c61f24a4fbd4096c669e7147ca44ae. gcc/testsuite/ChangeLog: PR analyzer/98073 * gcc.dg/analyzer/pr98073.c:

[committed] analyzer: remove xfail [PR98223]

2021-01-05 Thread David Malcolm via Gcc-patches
The bogus leak message went away after fcae5121154d1c3382b056bcc2c563cedac28e74 (aka "Hybrid EVRP and testcases") due to that patch improving a phi node in the gimple input to the analyzer. Successfully regrtested on x86_64-pc-linux-gnu. Pushed to master as

[PATCH] Add input_modes parameter to TARGET_MD_ASM_ADJUST hook

2021-01-05 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on x86_64-redhat-linux. I also built cross-compilers for arm-linux-gnueabi, cris-elf mn10300-elf, nds32-linux-gnu, pdp11-aout (didn't fully work due to https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg251887.html, but the changed code compiled fine),

[PATCH] c++: Fix thinko in auto return type checking [PR98441]

2021-01-05 Thread Marek Polacek via Gcc-patches
This fixes a thinko in my r11-2085 patch: when I said "But only give the !late_return_type errors when funcdecl_p, to accept e.g. auto (*fp)() = f; in C++11" I should've done this, otherwise we give bogus errors mentioning "function with trailing return type" when there is none.

Re: [committed] doc: Remove HSAIL from Language Standards

2021-01-05 Thread Gerald Pfeifer
On Mon, 4 Jan 2021, Martin Jambor wrote: > I trust you that HSA Foundation's web server was down for weeks but it > is not down now, http://www.hsafoundation.com/standards/ loads for me > fine and "HSA Programmer Reference Manual Specification 1.01" available > from that page describes the HSAIL

Re: [PATCH] genemit: Handle `const_double_zero' rtx

2021-01-05 Thread Maciej W. Rozycki
On Wed, 16 Dec 2020, Maciej W. Rozycki wrote: > > CONST_DOUBLE_ATOF ("0", VOIDmode) seems malformed though, and I'd expect > > it to assert in REAL_MODE_FORMAT (via the format_helper constructor). > > I'm not sure the patch is strictly safer than the status quo. > > I may have missed that,

Re: [PATCH] Add pytest for a GCOV test-case

2021-01-05 Thread Jeff Law via Gcc-patches
On 12/23/20 6:03 AM, Martin Liška wrote: > At a high level, this patch calls out to Python 3, allowing for test >> logic to be written in Python, rather than Tcl.  Are we doing this >> anywhere else in our test suite? > > No. I'm surprised.  I thought we did this for some of David's work at

Re: [PATCH] store VLA bounds in attribute access as strings (PR 97172)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/4/21 4:54 PM, Martin Sebor wrote: > On 1/4/21 2:10 PM, Jeff Law wrote: >> >> >> On 1/4/21 1:53 PM, Martin Sebor wrote: >>> On 1/4/21 12:23 PM, Jeff Law wrote: On 1/4/21 12:19 PM, Jakub Jelinek wrote: > On Mon, Jan 04, 2021 at 12:14:15PM -0700, Jeff Law via Gcc-patches

Re: [PATCH] store VLA bounds in attribute access as strings (PR 97172)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/4/21 2:20 PM, Jakub Jelinek wrote: > On Mon, Jan 04, 2021 at 02:10:39PM -0700, Jeff Law wrote: >>> I explained what the code handles and when in the pipeline in >>> the discussion of the previous patch: >>> https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559770.html >> Right, but

Re: [PATCH v3] handle MEM_REF with void* arguments (PR c++/95768)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/2/21 3:22 PM, Martin Sebor via Gcc-patches wrote: > Attached is another revision of a patch I posted last July to keep > the pretty-printer from crashing on MEM_REFs with void* arguments: >   https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549746.html > > Besides avoiding the ICE and

Re: [PATCH] libtool.m4: update GNU/Hurd test from upstream

2021-01-05 Thread Samuel Thibault via Gcc-patches
Jeff Law, le mar. 05 janv. 2021 16:04:45 -0700, a ecrit: > Thanks.  Installed. Thanks! Samuel

Re: [PATCH] libtool.m4: update GNU/Hurd test from upstream

2021-01-05 Thread Jeff Law via Gcc-patches
On 12/23/20 6:12 PM, Samuel Thibault wrote: > In upstream libtool, 47a889a4ca20 ("Improve GNU/Hurd support.") fixed > detection of shlibpath_overrides_runpath, thus avoiding unnecessary relink. > This backports it. > > ChangeLog: > > * libtool.m4: Match gnu* along other GNU systems. >

Re: [PATCH toplevel] libctf: new testsuite

2021-01-05 Thread Alan Modra via Gcc-patches
On Tue, Jan 05, 2021 at 03:25:10PM +, Nick Alcock wrote: > This enables 'make libctf-check', used by a new libctf testsuite in > binutils. > > 2021-01-05 Nick Alcock > > * Makefile.def (libctf): No longer no_check. Checking depends on > all-ld. > * Makefile.in:

Re: [PATCH] dec_math.f90 needs to be xfailed

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 12:14 PM, Steve Kargl wrote: > On Tue, Jan 05, 2021 at 11:26:24AM -0700, Jeff Law wrote: >> >> On 1/4/21 3:28 PM, Steve Kargl wrote: >>> On Mon, Jan 04, 2021 at 02:30:43PM -0700, Jeff Law wrote: On 1/2/21 1:34 AM, Steve Kargl via Gcc-patches wrote: > Can someone, anyone,

Re: [PATCH] libphobos: Allow building libphobos using Solaris/x86 assembler

2021-01-05 Thread Rainer Orth
Hi Iain, > This patch removes the disabling of libphobos when the Solaris/x86 > assembler is being used. > > Since r11-6373, D symbols are now compressed using back references, this > helped reduce the average symbol length by a factor of about 3, while > the longest symbol shrank from 416133 to

libgo patch committed: Don't define sys_SETREUID and friends

2021-01-05 Thread Ian Lance Taylor via Gcc-patches
This libgo patch changes the syscall package to not define sys_SETREUID and some friends. We don't use them anyhow, sice we always call the C library functions which do the right thing. And they aren't defined on all GNU/Linux variants. This fixes GCC PR 98510. Bootstrapped and ran Go

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-05 Thread Ian Lance Taylor via Gcc-patches
On Sat, Jan 2, 2021 at 6:14 AM Matthias Klose wrote: > > On 1/2/21 12:11 AM, Ian Lance Taylor wrote: > > On Thu, Dec 31, 2020 at 7:40 AM Matthias Klose wrote: > >> > >> On 12/31/20 12:14 AM, Ian Lance Taylor via Gcc-patches wrote: > >>> I've committed a patch to update libgo to the Go 1.16beta1

[PATCH] libphobos: Allow building libphobos using Solaris/x86 assembler

2021-01-05 Thread Iain Buclaw via Gcc-patches
Hi, This patch removes the disabling of libphobos when the Solaris/x86 assembler is being used. Since r11-6373, D symbols are now compressed using back references, this helped reduce the average symbol length by a factor of about 3, while the longest symbol shrank from 416133 to 1142 characters.

Re: [PATCH] PING implement pre-c++20 contracts

2021-01-05 Thread Jason Merrill via Gcc-patches
On 1/4/21 9:58 AM, Jeff Chapman wrote: Ping. re: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html > OK, I'll start with -alt then, thanks. Andrew is exactly correct, contracts-jac-alt is still

[committed] d: Merge upstream dmd a5c86f5b9

2021-01-05 Thread Iain Buclaw via Gcc-patches
This patch merges the D front-end implementation with upstream dmd a5c86f5b9, adding the following new `__traits' to the D language. - isDeprecated: used to detect if a function is deprecated. - isDisabled: used to detect if a function is marked with @disable. - isFuture: used to detect if a

Re: C++ Patch ping

2021-01-05 Thread Jason Merrill via Gcc-patches
On 1/5/21 11:34 AM, Jakub Jelinek wrote: Hi! I'd like to ping the: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562099.html patch. OK, thanks.

[PATCH] PR fortran/78746 - invalid access after error recovery

2021-01-05 Thread Harald Anlauf via Gcc-patches
Dear all, the PR contains a lengthy discussion of several testcases, some which were considered invalid and thus removed from the testsuite (charlen_03.f90, charlen_10.f90), charlen_15.f90 was resolved elsewhere, so that only class_61.f90 was left with an invalid access after error recovery with

Re: [PATCH] IBM Z: Fix check_effective_target_s390_z14_hw

2021-01-05 Thread Andreas Krebbel via Gcc-patches
On 1/5/21 7:37 PM, Ilya Leoshkevich wrote: > Bootstrapped and regtested on z14. Ok for master? > > > > Commit 2f473f4b065d ("IBM Z: Do not run long double tests on old > machines") introduced a predicate for tests that must run only on z14+. > However, due to a syntax error, the predicate

Re: Go patch committed: Accept -fgo-embedcfg option

2021-01-05 Thread Ian Lance Taylor via Gcc-patches
On Tue, Jan 5, 2021 at 7:15 AM Jakub Jelinek via Gcc-patches wrote: > > On Tue, Jan 05, 2021 at 11:06:27AM +0100, Andreas Schwab wrote: > > FAIL: compiler driver --help=go option(s): "^ +-.*[^:.]$" absent from > > output: " -fgo-embedcfg=List embedded files via go:embed" > > Fixed

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread Rainer Orth
Hi Jeff, > On 1/5/21 10:54 AM, Rainer Orth wrote: >> >> I fear I'm a bit lost here myself. I do have a little experience >> running various builders: >> >> * I inherited a Golang one on Solaris/amd64 (based on their own builder >> infrastructure). >> >> * I do run builders for GDB (mostly

Re: [PATCH] dec_math.f90 needs to be xfailed

2021-01-05 Thread Steve Kargl via Gcc-patches
On Tue, Jan 05, 2021 at 11:26:24AM -0700, Jeff Law wrote: > > > On 1/4/21 3:28 PM, Steve Kargl wrote: > > On Mon, Jan 04, 2021 at 02:30:43PM -0700, Jeff Law wrote: > >> On 1/2/21 1:34 AM, Steve Kargl via Gcc-patches wrote: > >>> Can someone, anyone, please commit the following trivially patch? >

Re: The performance data for two different implementation of new security feature -ftrivial-auto-var-init

2021-01-05 Thread Qing Zhao via Gcc-patches
I am attaching my current (incomplete) patch to gcc for your reference. From a71eb73bee5857440c4ff67c4c82be115e0675cb Mon Sep 17 00:00:00 2001 From: qing zhao Date: Sat, 12 Dec 2020 00:02:28 +0100 Subject: [PATCH] First version of -ftrivial-auto-var-init --- gcc/common.opt| 35

Re: [PATCH] avr: cc0 to mode_cc conversion

2021-01-05 Thread Paul Koning via Gcc-patches
> On Jan 5, 2021, at 8:54 AM, Senthil Kumar Selvaraj via Gcc-patches > wrote: > > > Senthil Kumar Selvaraj writes: > >> Georg-Johann Lay writes: >> >> ... >>> >>> 2) We just saw 100reds of insns being dublicated, basically the whole >>> machine description except for the few insns that

The performance data for two different implementation of new security feature -ftrivial-auto-var-init

2021-01-05 Thread Qing Zhao via Gcc-patches
Hi, This is an update for our previous discussion. 1. I implemented the following two different implementations in the latest upstream gcc: A. Adding real initialization during gimplification, not maintain the uninitialized warnings. D. Adding calls to .DEFFERED_INIT during gimplification,

[PATCH] x86: Use unsigned short to compute pextrw result

2021-01-05 Thread H.J. Lu via Gcc-patches
On Mon, Jan 4, 2021 at 7:41 PM Jeff Law wrote: > > > > On 1/1/21 6:34 AM, H.J. Lu via Gcc-patches wrote: > > _mm_extract_pi16 is intrinsic for pextrw, which should be zero-extended, > > not sign-extended. > > > > gcc/ > > > > PR target/98495 > > * config/i386/xmmintrin.h

Re: [PATCH] add g_nonstandard_bool attribute for GIMPLE FE use

2021-01-05 Thread Joseph Myers
On Tue, 5 Jan 2021, Richard Biener wrote: > would maybe result in a surprising result. One alternative > would be to make the attribute have the signedness specified as well > (C doesn't accept 'unsigned _Bool' or 'signed _Bool') or > simply name the attribute "signed_bool_precision". I guess

[r11-6464 Regression] FAIL: gcc.target/i386/sse2-mmx-pextrw.c execution test on Linux/x86_64

2021-01-05 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, af60b0ec79e9c5d7116122b185e44927aca5aa07 is the first bad commit commit af60b0ec79e9c5d7116122b185e44927aca5aa07 Author: H.J. Lu Date: Fri Jan 1 05:30:34 2021 -0800 x86: Cast to unsigned short first for _mm_extract_pi16 caused FAIL: gcc.target/i386/sse2-mmx-pextrw.c

[PATCH] IBM Z: Fix check_effective_target_s390_z14_hw

2021-01-05 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on z14. Ok for master? Commit 2f473f4b065d ("IBM Z: Do not run long double tests on old machines") introduced a predicate for tests that must run only on z14+. However, due to a syntax error, the predicate always returns false. gcc/testsuite/ChangeLog: 2020-12-10

Re: [PATCH] dec_math.f90 needs to be xfailed

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/4/21 3:28 PM, Steve Kargl wrote: > On Mon, Jan 04, 2021 at 02:30:43PM -0700, Jeff Law wrote: >> On 1/2/21 1:34 AM, Steve Kargl via Gcc-patches wrote: >>> Can someone, anyone, please commit the following trivially patch? >>> gfortran.dg/dec_math.f90 will never pass on i?86-*-freebsd*. >>

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 10:54 AM, Rainer Orth wrote: > > I fear I'm a bit lost here myself. I do have a little experience > running various builders: > > * I inherited a Golang one on Solaris/amd64 (based on their own builder > infrastructure). > > * I do run builders for GDB (mostly dormant since Sergio

Re: [PATCH] ira: Skip some pseudos in move_unallocated_pseudos

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/4/21 7:36 PM, Kewen.Lin wrote: > Hi Jeff, > > on 2021/1/5 上午7:13, Jeff Law wrote: >> >> On 12/22/20 11:40 PM, Kewen.Lin via Gcc-patches wrote: >>> Hi Segher, >>> >>> on 2020/12/22 下午9:55, Segher Boessenkool wrote: Hi! Just a dumb formatting comment: On Tue, Dec 22,

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread Rainer Orth
Hi Jeff, > On 1/5/21 10:09 AM, abebeos wrote: >> >> >> On Tue, 5 Jan 2021 at 18:50, Jeff Law > > wrote: >> >> >> >> On 1/5/21 2:18 AM, abebeos wrote: >> > >> > On Mon, 4 Jan 2021 at 21:40, Jeff Law > >> >

Re: [PATCH] v2: Don't link cc1 etc. against libcody.a

2021-01-05 Thread Nathan Sidwell
On 1/5/21 10:47 AM, Jakub Jelinek wrote: On Tue, Jan 05, 2021 at 10:00:06AM +0100, Jakub Jelinek via Gcc-patches wrote: On Tue, Jan 05, 2021 at 09:56:26AM +0100, Rainer Orth wrote: Richi complained on IRC that cc1 is linked against libcody.a. From my understanding, it is just the cc1plus and

Re: [PATCH] Restore input_location after recursive expand_call_inline

2021-01-05 Thread Bernd Edlinger
On 1/5/21 5:51 PM, Jeff Law wrote: > > > On 1/5/21 1:05 AM, Richard Biener wrote: >> On Tue, 5 Jan 2021, Bernd Edlinger wrote: >> >>> >>> On 1/4/21 10:23 PM, Jeff Law wrote: On 1/4/21 1:12 PM, Bernd Edlinger wrote: > Hi, > > I spotted a place where input_location is

Re: [PATCH] expand: Fold x - y < 0 to x < y during expansion [PR94802]

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 8:30 AM, Jakub Jelinek wrote: > Hi! > > My earlier patch to simplify x - y < 0 etc. for signed subtraction > with undefined overflow into x < y in match.pd regressed some tests, > even when it was guarded to be post-IPA, the following patch thus > attempts to optimize that during

Re: add alignment to enable store merging in strict-alignment targets

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 12:46 AM, Alexandre Oliva wrote: > In g++.dg/opt/store-merging-2.C, the natural alignment of types T and > S is a single byte, so we shouldn't expect store merging on > strict-alignment platforms. Indeed, without something like the > adjust-alignment pass to bump up the alignment of

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 10:09 AM, abebeos wrote: > > > On Tue, 5 Jan 2021 at 18:50, Jeff Law > wrote: > > > > On 1/5/21 2:18 AM, abebeos wrote: > > > > On Mon, 4 Jan 2021 at 21:40, Jeff Law > >

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread abebeos via Gcc-patches
On Tue, 5 Jan 2021 at 18:50, Jeff Law wrote: > > > On 1/5/21 2:18 AM, abebeos wrote: > > > > On Mon, 4 Jan 2021 at 21:40, Jeff Law > > wrote: > > > > On 12/31/20 7:13 AM, abebeos wrote: > > [...] > > > > I'm definitely curious about the testing

Re: [PATCH] Restore input_location after recursive expand_call_inline

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 1:05 AM, Richard Biener wrote: > On Tue, 5 Jan 2021, Bernd Edlinger wrote: > >> >> On 1/4/21 10:23 PM, Jeff Law wrote: >>> >>> On 1/4/21 1:12 PM, Bernd Edlinger wrote: Hi, I spotted a place where input_location is clobbered accidentally. That is in a recursive

Re: [RFC] [avr] Toolchain Integration for Testsuite Execution (avr cc0 to mode_cc0 conversion)

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 2:18 AM, abebeos wrote: > > On Mon, 4 Jan 2021 at 21:40, Jeff Law > wrote: > > On 12/31/20 7:13 AM, abebeos wrote: > [...] > >     >         I'm definitely curious about the testing setup and > >     whether or > >     >         not it can

Re: [PATCH] v2: Don't link cc1 etc. against libcody.a

2021-01-05 Thread Jeff Law via Gcc-patches
On 1/5/21 8:47 AM, Jakub Jelinek via Gcc-patches wrote: > On Tue, Jan 05, 2021 at 10:00:06AM +0100, Jakub Jelinek via Gcc-patches wrote: >> On Tue, Jan 05, 2021 at 09:56:26AM +0100, Rainer Orth wrote: Richi complained on IRC that cc1 is linked against libcody.a. From my understanding,

[PATCH] tree-optimization/98516 - fix SLP permute opt materialization

2021-01-05 Thread Richard Biener
When materializing on a VEC_PERM node we have to permute the incoming vectors, not the outgoing one. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-01-05 Richard Biener PR tree-optimization/98516 * tree-vect-slp.c (vect_optimize_slp): Permute the incoming

C++ Patch ping

2021-01-05 Thread Jakub Jelinek via Gcc-patches
Hi! I'd like to ping the: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562099.html patch. Thanks Jakub

Re: [PATCH] store VLA bounds in attribute access as strings (PR 97172)

2021-01-05 Thread Martin Sebor via Gcc-patches
On 1/5/21 5:38 AM, Richard Biener wrote: On Mon, Jan 4, 2021 at 9:53 PM Martin Sebor wrote: On 1/4/21 12:23 PM, Jeff Law wrote: On 1/4/21 12:19 PM, Jakub Jelinek wrote: On Mon, Jan 04, 2021 at 12:14:15PM -0700, Jeff Law via Gcc-patches wrote: Doing the STRING_CST is certainly less

Re: [PATCH] c++: Fix deduction from the type of an NTTP

2021-01-05 Thread Jason Merrill via Gcc-patches
On 1/4/21 5:50 PM, Patrick Palka wrote: In the testcase nontype-auto17.C below, the calls to f and g are invalid because neither deduction nor defaulting of the template parameter T yields a valid specialization. Deducing T doesn't work because T is only used in a non-deduced context, and

Re: [PATCH] libstdc++: Skip atomic instructions in _Sp_counted_base::_M_release when both counts are 1

2021-01-05 Thread Maged Michael via Gcc-patches
Please let me know if more information about this patch is needed. Thank you. Maged On Thu, Dec 17, 2020 at 3:49 PM Maged Michael wrote: > Please find a proposed patch for _Sp_counted_base::_M_release to skip the > two atomic instructions that decrement each of the use count and the weak >

Re: [PATCH] c++: ICE with deferred noexcept when deducing targs [PR82099]

2021-01-05 Thread Jason Merrill via Gcc-patches
On 1/4/21 8:31 PM, Marek Polacek wrote: In this test we ICE in type_throw_all_p because it got a deferred noexcept which it shouldn't. Here's the story: In noexcept61.C, we call bar, so we perform overload resolution. When adding the (only) candidate, we need to deduce template arguments, so

Re: [PATCH] c++, v2: Fix ICE with __builtin_bit_cast [PR98469]

2021-01-05 Thread Jason Merrill via Gcc-patches
On 1/5/21 10:26 AM, Jakub Jelinek wrote: On Mon, Jan 04, 2021 at 04:01:25PM -0500, Jason Merrill via Gcc-patches wrote: On 1/4/21 3:48 PM, Jakub Jelinek wrote: On Mon, Jan 04, 2021 at 03:44:46PM -0500, Jason Merrill wrote: This change is OK, but part of the problem is that we're trying to do

[PATCH] v2: Don't link cc1 etc. against libcody.a

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 05, 2021 at 10:00:06AM +0100, Jakub Jelinek via Gcc-patches wrote: > On Tue, Jan 05, 2021 at 09:56:26AM +0100, Rainer Orth wrote: > > > Richi complained on IRC that cc1 is linked against libcody.a. > > > From my understanding, it is just the cc1plus and cc1objplus binaries > > > that

[PATCH] move SLP debug counter

2021-01-05 Thread Richard Biener
This moves it to catch individual SLP subgraphs Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-01-05 Richard Biener * tree-vect-slp.c (vect_slp_region): Move debug counter to cover individual subgraphs. --- gcc/tree-vect-slp.c | 6 -- 1 file changed, 4

[PATCH] tree-optimization/98428 - avoid pre-existing vectors for loop SLP

2021-01-05 Thread Richard Biener
It wasn't supposed to be enabled and appearantly copying around the checking messed up the condition. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-01-05 Richard Biener PR tree-optimization/98428 * tree-vect-slp.c (vect_build_slp_tree_1): Properly reject

Re: [PATCH] nvptx: Cache stacks block for OpenMP kernel launch

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 05, 2021 at 12:13:59PM +, Julian Brown wrote: > Just to check, does my reply below address your concerns -- > particularly with regards to the current usage of CUDA streams > serializing kernel executions from different host threads? Given that > situation, and the observed speed

[PATCH] expand: Fold x - y < 0 to x < y during expansion [PR94802]

2021-01-05 Thread Jakub Jelinek via Gcc-patches
Hi! My earlier patch to simplify x - y < 0 etc. for signed subtraction with undefined overflow into x < y in match.pd regressed some tests, even when it was guarded to be post-IPA, the following patch thus attempts to optimize that during expansion instead (which is the last time we can do it,

[PATCH] c++, v2: Fix ICE with __builtin_bit_cast [PR98469]

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Mon, Jan 04, 2021 at 04:01:25PM -0500, Jason Merrill via Gcc-patches wrote: > On 1/4/21 3:48 PM, Jakub Jelinek wrote: > > On Mon, Jan 04, 2021 at 03:44:46PM -0500, Jason Merrill wrote: > > > This change is OK, but part of the problem is that we're trying to do > > > overload resolution for an S

[PATCH toplevel] libctf: new testsuite

2021-01-05 Thread Nick Alcock via Gcc-patches
This enables 'make libctf-check', used by a new libctf testsuite in binutils. 2021-01-05 Nick Alcock * Makefile.def (libctf): No longer no_check. Checking depends on all-ld. * Makefile.in: Regenerated. --- Makefile.def | 4 +-

Re: [PATCH] store-merging: Handle vector CONSTRUCTORs using bswap [PR96239]

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 05, 2021 at 01:55:21PM +0100, Richard Biener wrote: > > Note, I have no idea why the bswap code needs TODO_update_ssa if it changed > > things, for the vuses it copies them from the surrounding vuses, which looks > > correct to me. Perhaps because it uses force_gimple_operand_gsi* in

Re: Go patch committed: Accept -fgo-embedcfg option

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 05, 2021 at 11:06:27AM +0100, Andreas Schwab wrote: > FAIL: compiler driver --help=go option(s): "^ +-.*[^:.]$" absent from output: > " -fgo-embedcfg=List embedded files via go:embed" Fixed thusly, committed as obvious. 2021-01-05 Jakub Jelinek * lang.opt

[PATCH] tree-optimization/98381 - fix live bool vector extract

2021-01-05 Thread Richard Biener
This fixes extraction of live bool vector results for the case of integer mode vectors. Bootstrapped and tested on x86_64-unknown-linux-gnu (and i386.exp with SDE), pushed. 2021-01-05 Richard Biener PR tree-optimization/98381 * tree.c (vector_element_bits): Properly compute

[PATCH] i386: Prevent spurious FP exceptions with _mm_cvt{, t}ps_pi32 [PR98522]

2021-01-05 Thread Uros Bizjak via Gcc-patches
Prevent spurious FP exceptions with _mm_cvt{,t}ps_pi32 for TARGET_MMX_WITH_SSE by clearing the top 64 bytes of the input XMM register. 2021-01-05 Uroš Bizjak gcc/ PR target/98522 * config/i386/sse.md (sse_cvtps2pi): Redefine as define_insn_and_split. Clear the top 64 bytes of the

[PATCH] i386: Add _mm256_cmov_si256 [PR98521]

2021-01-05 Thread Uros Bizjak via Gcc-patches
Add missing _mm256_cmov_si256 intrinsic to xopintrin.h. 2021-01-05 Uroš Bizjak gcc/ PR target/98521 * config/i386/xopintrin.h (_mm256_cmov_si256): New. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to mainline, will be beckported to gcc-10. Uros. diff --git

[PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-05 Thread Anthony Sharp via Gcc-patches
This patch fixes PR17314 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17314). Previously, when class C attempted to access member a declared in class A through class B, where class B privately inherits from A and class C inherits from B, GCC would correctly report an access violation, but would

Re: git commit hook does not record my patches to PRs

2021-01-05 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 05, 2021 at 03:04:55PM +0100, Uros Bizjak via Gcc-patches wrote: > Hello! > > For some reason git commit hook does not record my patches to PRs, > mentioned in the commit message. Some recent examples: Maybe the python mess with UTF-8 is back. > > PR 98521: >

Re: V3 [PATCH 5/5] gnulib: Support variables from the top level Makefile

2021-01-05 Thread H.J. Lu via Gcc-patches
On Tue, Jan 5, 2021 at 5:27 AM Christian Biesinger wrote: > > On Fri, Jan 1, 2021 at 1:07 AM H.J. Lu via Gdb-patches > wrote: > > > > On Thu, Dec 31, 2020 at 3:50 PM Joseph Myers > > wrote: > > > > > > On Sat, 19 Dec 2020, H.J. Lu via Gcc-patches wrote: > > > > > > > Work around what appears

git commit hook does not record my patches to PRs

2021-01-05 Thread Uros Bizjak via Gcc-patches
Hello! For some reason git commit hook does not record my patches to PRs, mentioned in the commit message. Some recent examples: PR 98521: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=951bdbde6ade56eb63af1dfa18777348a8a0d89e and PR98522:

Re: [PATCH] avr: cc0 to mode_cc conversion

2021-01-05 Thread Senthil Kumar Selvaraj via Gcc-patches
Senthil Kumar Selvaraj writes: > Georg-Johann Lay writes: > >> >> Finally, some general remarks: > > The work on my github branch was not complete - I'd blindly followed > whatever the CC0 Transition wiki mentioned (the first three steps of > case #2), and fixed any regression fallout (for

Re: V3 [PATCH 5/5] gnulib: Support variables from the top level Makefile

2021-01-05 Thread Christian Biesinger via Gcc-patches
On Fri, Jan 1, 2021 at 1:07 AM H.J. Lu via Gdb-patches wrote: > > On Thu, Dec 31, 2020 at 3:50 PM Joseph Myers wrote: > > > > On Sat, 19 Dec 2020, H.J. Lu via Gcc-patches wrote: > > > > > Work around what appears to be a GNU make bug handling MAKEFLAGS > > > values defined in terms of make

[c++]: Improve module-decl diagnostics [PR 98327]

2021-01-05 Thread Nathan Sidwell
The diagnostic for a misplaced module decl was essentially 'computer says no', which isn't the most helpful. This adjusts it to indicate what would be acceptable. gcc/cp/ * parser.cc (cp_parser_module_declaration): Alter diagnostic text to say where is permissable.

Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Alexandre Oliva
On Jan 4, 2021, Bernd Edlinger wrote: > currently there is a problem when debugging a virtual thunk. That is > a decl with DECL_IGNORED_P. Currently the line information displayed > in gdb is completely bogus, thus the last line of whatever function > is immediately before the PC of the

RE: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-05 Thread Kyrylo Tkachov via Gcc-patches
Hi Prathamesh, > -Original Message- > From: Prathamesh Kulkarni > Sent: 05 January 2021 11:42 > To: Kyrylo Tkachov > Cc: gcc Patches > Subject: Re: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle > in vext intrinsics > > On Mon, 4 Jan 2021 at 16:01, Kyrylo Tkachov >

Re: [PATCH] store-merging: Handle vector CONSTRUCTORs using bswap [PR96239]

2021-01-05 Thread Richard Biener
On Thu, 17 Dec 2020, Jakub Jelinek wrote: > On Wed, Dec 16, 2020 at 09:29:31AM +0100, Richard Biener wrote: > > I think it probably makes sense to have some helper split out that > > collects & classifies vector constructor components we can use from > > both forwprop (where matching the V_C_E

Re: [PATCH] add g_nonstandard_bool attribute for GIMPLE FE use

2021-01-05 Thread Richard Biener
On Wed, 16 Dec 2020, Joseph Myers wrote: > On Sun, 13 Dec 2020, Martin Sebor via Gcc-patches wrote: > > > "nonstandard" isn't a very descriptive name. The leading g_ prefix > > also looks a little too terse (is that supposed to stand dor GIMPLE?). > > I would suggest choosing a better name,

[patch, committed, coarray_native] Fix CO_REDUCE with RESULT_IMAGE

2021-01-05 Thread Thomas Koenig via Gcc-patches
Hi, I just committed the attached patch to the branch. I had also merged the trunk to branch previously, so it should be more or less up to date by now. Best regards Thomas Fix CO_REDUCE with RESULT_IMAGE. gcc/fortran/ChangeLog: * trans-array.c

Re: [PATCH] store VLA bounds in attribute access as strings (PR 97172)

2021-01-05 Thread Richard Biener via Gcc-patches
On Mon, Jan 4, 2021 at 9:53 PM Martin Sebor wrote: > > On 1/4/21 12:23 PM, Jeff Law wrote: > > > > > > On 1/4/21 12:19 PM, Jakub Jelinek wrote: > >> On Mon, Jan 04, 2021 at 12:14:15PM -0700, Jeff Law via Gcc-patches wrote: > Doing the STRING_CST is certainly less fragile since the SSA names

[PATCH,committed] arc: fix accumulator first register.

2021-01-05 Thread Claudiu Zissulescu via Gcc-patches
gcc/ 2021-01-05 Claudiu Zissulescu * config/arc/arc.md (maddsidi4_split): Use ACC_REG_FIRST. (umaddsidi4_split): Likewise. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc.md | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937)

2021-01-05 Thread Richard Biener
On Mon, 4 Jan 2021, Bernd Edlinger wrote: > Hi, > > > currently there is a problem when debugging a virtual thunk. That is > a decl with DECL_IGNORED_P. Currently the line information displayed > in gdb is completely bogus, thus the last line of whatever function > is immediately before the

Re: [PATCH][tree-optimization]Optimize combination of comparisons to dec+compare

2021-01-05 Thread Richard Biener via Gcc-patches
On Mon, Jan 4, 2021 at 9:50 PM Eugene Rozenfeld wrote: > > Ping. > > -Original Message- > From: Eugene Rozenfeld > Sent: Tuesday, December 22, 2020 3:01 PM > To: Richard Biener ; gcc-patches@gcc.gnu.org > Subject: RE: Optimize combination of comparisons to dec+compare > > Re-sending my

Re: [PATCH] nvptx: Cache stacks block for OpenMP kernel launch

2021-01-05 Thread Julian Brown
Hi Jakub, Just to check, does my reply below address your concerns -- particularly with regards to the current usage of CUDA streams serializing kernel executions from different host threads? Given that situation, and the observed speed improvement with OpenMP offloading to NVPTX with the patch,

Re: [08/23] Add an alternative splay tree implementation

2021-01-05 Thread Richard Biener via Gcc-patches
On Mon, Jan 4, 2021 at 4:43 PM Richard Sandiford via Gcc-patches wrote: > > Andreas Schwab writes: > > On Jan 04 2021, Richard Sandiford wrote: > > > >> Andreas Schwab writes: > >>> That doesn't build with gcc 4.8: > >> > >> Which subversion are you using? > > > > This is 4.8.1. > > Hmm, OK. I

Re: [PATCH] match.pd: Improve (A / (1 << B)) -> (A >> B) optimization [PR96930]

2021-01-05 Thread Richard Biener
On Tue, 5 Jan 2021, Jakub Jelinek wrote: > Hi! > > The following patch improves the A / (1 << B) -> A >> B simplification, > as seen in the testcase, if there is unnecessary widening for the division, > we just optimize it into a shift on the widened type, but if the lshift > is widened too,

Re: [PATCH] reassoc: Fix reassociation on 32-bit hosts with > 32767 bbs [PR98514]

2021-01-05 Thread Richard Biener
On Tue, 5 Jan 2021, Jakub Jelinek wrote: > Hi! > > Apparently reassoc ICEs on large functions (more than 32767 basic blocks > with something to reassociate in those). > The problem is that the pass uses long type to store the ranks, and > the bb ranks are (number of SSA_NAMEs with default defs +

Re: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-05 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 4 Jan 2021 at 16:01, Kyrylo Tkachov wrote: > > Hi Prathamesh > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 04 January 2021 10:27 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in > > vext

Re: [PATCH] phiopt: Optimize x < 0 ? ~y : y to (x >> 31) ^ y [PR96928]

2021-01-05 Thread Richard Biener
On Tue, 5 Jan 2021, Jakub Jelinek wrote: > Hi! > > As requested in the PR, the one's complement abs can be done more > efficiently without cmov or branching. > > Had to change the ifcvt-onecmpl-abs-1.c testcase, we no longer optimize > it in ifcvt, on x86_64 with -m32 we generate in the end the

Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461]

2021-01-05 Thread Uros Bizjak via Gcc-patches
On Tue, Jan 5, 2021 at 11:25 AM Hongtao Liu wrote: > > On Tue, Jan 5, 2021 at 3:20 PM Uros Bizjak wrote: > > > > On Tue, Jan 5, 2021 at 8:04 AM Uros Bizjak wrote: > > > > > > > > +(define_split > > > > + [(set (match_operand:SI 0 "register_operand") > > > > +(zero_extend:SI > > > > +

Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461]

2021-01-05 Thread Hongtao Liu via Gcc-patches
On Tue, Jan 5, 2021 at 3:20 PM Uros Bizjak wrote: > > On Tue, Jan 5, 2021 at 8:04 AM Uros Bizjak wrote: > > > > > > +(define_split > > > + [(set (match_operand:SI 0 "register_operand") > > > +(zero_extend:SI > > > + (not:HI > > > +(subreg:HI > > > +

[PATCH] match.pd: Improve (A / (1 << B)) -> (A >> B) optimization [PR96930]

2021-01-05 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch improves the A / (1 << B) -> A >> B simplification, as seen in the testcase, if there is unnecessary widening for the division, we just optimize it into a shift on the widened type, but if the lshift is widened too, there is no reason to do that, we can just shift it in

  1   2   >