[gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Torsten Veller
* Ciaran McCreesh ciaran.mccre...@googlemail.com: Torsten Veller t...@gentoo.org wrote: +EXPORTED_FUNCTIONS=src_unpack src_compile src_test src_install You're probably not the only one using this trick, so it might be wise to use PERL_EXPORTED_FUNCTIONS or somesuch to avoid name collisions

Re: [gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Tomáš Chvátal
Dne pondělí 21 Září 2009 17:29:26 Torsten Veller napsal(a): * Ciaran McCreesh ciaran.mccre...@googlemail.com: Torsten Veller t...@gentoo.org wrote: +EXPORTED_FUNCTIONS=src_unpack src_compile src_test src_install You're probably not the only one using this trick, so it might be wise to

[gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Torsten Veller
* Tomáš Chvátal scarab...@gentoo.org: I think it is not required EXPF=src_compile src_test src_install - definition, also nulls anything what was in it before :] case ${EAPI:-0} in 2) EXPF=${EXPF} src_configure ;; 1|0) ;;

Re: [gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Tomáš Chvátal
Dne pondělí 21 Září 2009 18:03:56 Torsten Veller napsal(a): * Tomáš Chvátal scarab...@gentoo.org: I think it is not required EXPF=src_compile src_test src_install - definition, also nulls anything what was in it before :] case ${EAPI:-0} in 2) EXPF=${EXPF} src_configure ;;

Re: [gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Maciej Mrozowski
On Monday 21 of September 2009 17:38:53 Tomáš Chvátal wrote: I think it is not required EXPF=src_compile src_test src_install - definition, also nulls anything what was in it before :] case ${EAPI:-0} in 2) EXPF=${EXPF} src_configure ;; 1|0) ;; *) die Unknown EAPI,

[gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Torsten Veller
* Tomáš Chvátal scarab...@gentoo.org: Dne pondělí 21 Září 2009 18:03:56 Torsten Veller napsal(a): * Tomáš Chvátal scarab...@gentoo.org: I think it is not required EXPF=src_compile src_test src_install - definition, also nulls anything what was in it before :] case ${EAPI:-0} in

[gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Torsten Veller
* Maciej Mrozowski reave...@poczta.fm: How about unsetting variables after use in first place so that they no longer pollute global env. It's probably too late as it is used in functions like cmake-utils_src_compile: | has src_configure ${EXPF} || cmake-utils_src_configure

Re: [gentoo-dev] Re: perl-module.class review

2009-09-21 Thread Jeremy Olexa
On Mon, Sep 21, 2009 at 11:55 AM, Torsten Veller ml...@veller.net wrote: snip if s/EXPF/TEST_EXPF/ in test.eclass, it does:  * another_test_src_configure  * another_test_src_compile  * test_pkg_postinst Although I don't anticipate xfconf and cmake being used together, we changed