when choosing what to branch off of
in the future.
On Wed, May 28, 2014 at 6:35 AM, Eric Sunshine wrote:
> Etiquette on this list is to avoid top-posting [1].
> ...
> If you do re-roll, perhaps consider simplifying the commit messages.
Thank you for the tips; very much appreciated.
- Br
Oomph, how embarrassing. Thanks for pointing that out!
Would it be better if I rerolled the patches?
- Brian Gesiak
On Tue, May 27, 2014 at 12:25 PM, Eric Sunshine wrote:
> On Mon, May 26, 2014 at 11:33 AM, Brian Gesiak wrote:
>> xcalloc takes two arguments: the number of elements
in mind.
Should I reroll the patch based on master?
- Brian Gesiak
[1]
https://github.com/git/git/blob/4a28f169ad29ba452e0e7bea2583914c10c58322/Documentation/SubmittingPatches#L9
On Tue, May 27, 2014 at 8:11 AM, Jeremiah Mahler wrote:
> Brian,
>
> On Tue, May 27, 2014 at 12:33:42AM +090
xcalloc takes two arguments: the number of elements and their size.
grow_hash_table passes the arguments in reverse order, passing the
size of a hash table entry, followed by the number of entries.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
hash.c | 2
xcalloc takes two arguments: the number of elements and their size.
parse_refspec_internal passes the arguments in reverse order, passing the
size of a refspec, followed by the number to allocate. Rearrgange them
so they are in the correct order.
Signed-off-by: Brian Gesiak
---
remote.c | 2
xcalloc takes two arguments: the number of elements and their size.
notes.c includes several calls to xcalloc that pass the arguments in
reverse order. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
notes.c | 6 +++---
1 file changed, 3 insertions(+), 3
xcalloc takes two arguments: the number of elements and their size.
http-push passes the arguments in reverse order, passing the size
of a repo, followed by the number to allocate. Rearrgange them so
they are in the correct order.
Signed-off-by: Brian Gesiak
---
http-push.c | 2 +-
1 file
xcalloc takes two arguments: the number of elements and their size.
config.c includes several calls to xcalloc that pass the arguments
in reverse order: the size of a struct lock_file*, followed by the
number to allocate. Rearrgange them so they are in the correct order.
Signed-off-by: Brian
xcalloc takes two arguments: the number of elements and their size.
imap_open_store passes the arguments in reverse order, passing the
size of an imap_store*, followed by the number to allocate.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
imap-send.c | 2
xcalloc takes two arguments: the number of elements and their size.
transport_helper_init passes the arguments in reverse order, passing the
size of a helper_data*, followed by the number to allocate. Rearrgange
them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
transport
xcalloc takes two arguments: the number of elements and their size.
prellocate_hash passes the arguments in reverse order, passing the
size of a hash table entry, followed by the number of entries.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
hash.h | 2
xcalloc takes two arguments: the number of elements and their size.
init_pack_revindex passes the arguments in reverse order, passing the
size of a pack_revindex, followed by the number to allocate.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
pack
xcalloc takes two arguments: the number of elements and their size.
builtin/remote.c includes several calls to xcalloc that pass the
arguments in reverse order. Rearrgange them so they are in the
correct order.
Signed-off-by: Brian Gesiak
---
builtin/remote.c | 8
1 file changed, 4
xcalloc takes two arguments: the number of elements and their size.
cmd_ls_remote passes the arguments in reverse order, passing the
size of a char*, followed by the number of char* to be allocated.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
builtin/ls
xcalloc takes two arguments: the number of elements and their size.
reflog-walk.c includes several calls to xcalloc that pass the arguments
in reverse order. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
reflog-walk.c | 8
1 file changed, 4
xcalloc takes two arguments: the number of elements and their size.
reduce_heads passes the arguments in reverse order, passing the
size of a commit*, followed by the number of commit* to be allocated.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
commit.c
xcalloc takes two arguments: the number of elements and their size.
diffstat_add passes the arguments in reverse order, passing the
size of a diffstat_file*, followed by the number of diffstat_file* to
be allocated. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
xcalloc takes two arguments: the number of elements and their size.
run_add_interactive passes the arguments in reverse order, passing the
size of a char*, followed by the number of char* to be allocated.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
---
builtin
xcalloc takes two arguments: the number of elements and their size.
The vast majority of the Git codebase passes these arguments in the
correct order, but there are some exceptions. This patch series
corrects those exceptions.
Brian Gesiak (15):
builtin/add.c: rearrange xcalloc arguments
API documentation for strbuf does not document strbuf_trim or
strbuf_ltrim. Add documentation for these two functions.
Signed-off-by: Brian Gesiak
---
Documentation/technical/api-strbuf.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/technical/api-strbuf.txt
b
strbuf_trim strips whitespace from the end, then the beginning of a
strbuf. Those operations are duplicated in strbuf_rtrim and
strbuf_ltrim.
Replace strbuf_trim implementation with calls to strbuf_rtrim,
then strbuf_ltrim.
Signed-off-by: Brian Gesiak
---
This is tangential to my GSoC project
email. I'm also on GitHub[1] and
Twitter[2].
[1] https://github.com/modocache
[2] https://twitter.com/modocache
- Brian Gesiak
On Tue, Apr 22, 2014 at 10:06 AM, Andrew Ardill wrote:
> Congrats everyone who was successful in being picked for this year's GSoC.
>
> Fabian with &q
same for both cases anyway.
I had not originally thought of this, perhaps because I was preoccupied
with preventing users from seeing syntax they might not be aware of.
But I definitely agree that displaying symbolic names for all "@{-n}"
is a good way to prevent user error.
> I
sit the repository here: https://github.com/modocache/git-po-ja
Thanks!
- Brian Gesiak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
parse" to retreive the name of the rev.
- Update the tests in light of this new behavior.
Requested-by: John Keeping
Signed-off-by: Brian Gesiak
---
git-rebase.sh | 8 +++-
t/t3400-rebase.sh | 4 +---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/git-rebase.sh b/git
t be aware of "@{-1}",
however, so I'd prefer not to output it as we are currently.
Furthermore, were we to translate "@{-1}", does that mean we
should also translate "@{-2}" or prior? I don't think that's the case,
but then only translating
e-rev" to retreive the name of the rev.
- Update the tests in light of this new behavior.
Requested-by: John Keeping
Signed-off-by: Brian Gesiak
---
Previous discussion on this issue:
http://article.gmane.org/gmane.comp.version-control.git/244340
git-rebase.sh | 2 +-
t/t3400-rebase
Inline comment had incorrect grammar. Fix grammatical mistakes and
reflect actual behavior of the function.
Signed-off-by: Brian Gesiak
---
builtin/checkout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 63151e0..abe1161
s; checkout informs the user of which branch they have switched
to when using the "-" shorthand: "Switched to branch 'master'".
Should I submit a new patch, or reroll this one?
- Brian Gesiak
--
To unsubscribe from this list: send the line "unsubscribe git"
Teach rebase the same shorthand as checkout and merge; that is, that "-"
means "the branch we were previously on".
Reported-by: Tim Chase
Signed-off-by: Brian Gesiak
---
git-rebase.sh | 4
t/t3400-rebase.sh | 11 +++
2 files changed, 15 insertions(
Teach rebase the same shorthand as checkout and merge; that is, that "-"
means "the branch we were previously on".
Reported-by: Tim Chase
Signed-off-by: Brian Gesiak
---
git-rebase.sh | 4
t/t3400-rebase.sh | 6 ++
2 files changed, 10 insertions(+)
diff --g
dability is
probably more difficult than it sounds, but I don't think it's
impossible.
I'll add some more details on this to my proposal[1]. Thank you!
- Brian Gesiak
[1]
https://www.google-melange.com/gsoc/proposal/review/student/google/gsoc2014/modocache/5629499534213120
--
To u
ine the cleanup policy.
Thanks for all your help so far!
- Brian Gesiak
PS: I'm maintaining a working draft of my proposal here, in case
anyone wants to offer any feedback prior to its submission:
https://gist.github.com/modocache/9434914
On Tue, Mar 4, 2014 at 7:42 AM, Jeff King wrote:
&
No test asserts that "git branch -u refs/heads/my-branch my-branch"
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak
---
t/t3200-branch.sh | 10 ++
1 file changed, 10 insertions(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index fcdb867..e6d4
Hello all,
My name is Brian Gesiak. I'm a research student at the University of
Tokyo, and I'm hoping to participate in this year's Google Summer of
Code by contributing to Git. I'm a longtime user, first-time
contributor--some of you may have noticed my "microproject&quo
or all the feedback so far!
- Brian Gesiak
On Sat, Mar 1, 2014 at 9:23 PM, Brian Gesiak wrote:
> Branch set as own upstream using one of the following commands returns
> immediately with an exit code of 0:
>
> - `git branch --set-upstream-to foo refs/heads/foo`
> - `git branc
. Instead, exit with a status code indicating failure
by using the die function.
Signed-off-by: Brian Gesiak
---
branch.c | 9 ++---
t/t3200-branch.sh | 6 +++---
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/branch.c b/branch.c
index e163f3c..9bac8b5 100644
--- a/branch.c
misleading. Instead, exit with a status code indicating failure
by using the die function.
Signed-off-by: Brian Gesiak
---
branch.c | 9 ++---
t/t3200-branch.sh | 6 +++---
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/branch.c b/branch.c
index e163f3c..9bac8b5
orkflow this would be
included in.
In any case, if the jury's out on this one, I suppose the two patches
I submitted are good to merge? Part of me thinks the bump from warning
to error belongs in its own patch anyway.
- Brian Gesiak
--
To unsubscribe from this list: send the line "unsubscrib
case? I'm not sure I agree--how is "git
branch -f --track foo foo" less erroneous than "git branch -u foo
refs/heads/foo"? Perhaps I'm missing some insight on how "--track" is
used.
The tests appear to already cover all instances in which
install_branch_config is
uch a change. But as Peff points out it will be a large diff.
- Brian Gesiak
On Fri, Feb 28, 2014 at 4:26 PM, Jeff King wrote:
> On Fri, Feb 28, 2014 at 02:14:01AM -0500, Jeff King wrote:
>
>> I didn't think we bothered to make "sh -x" work robustly. I don't min
The install_branch_config function reimplemented the skip_prefix
function inline. Use skip_prefix function instead for brevity.
Reported-by: Michael Haggerty
Signed-off-by: Brian Gesiak
---
branch.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/branch.c
No test asserts that "git branch -u refs/heads/my-branch my-branch"
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak
---
t/t3200-branch.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index fcdb867..6164126 1007
tests to complete. Thanks for pointing
that out! Also, sorry if it's in the Makefile somewhere, but is there
an easy way
to run just a single test file in the t directory?
- Brian Gesiak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to m
From: modocache
The install_branch_config function reimplemented the skip_prefix
function inline. Use skip_prefix function instead for brevity.
Signed-off-by: Brian Gesiak
Reported-by: Michael Haggerty
---
branch.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions
From: modocache
No test asserts that "git branch -u refs/heads/my-branch my-branch"
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak
---
t/t3200-branch.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
ind
46 matches
Mail list logo
