mustafaiman opened a new pull request #1337:
URL: https://github.com/apache/hive/pull/1337
Change-Id: If398aba0130f28c17d18340c20ba681c278f
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which
pvary commented on a change in pull request #1221:
URL: https://github.com/apache/hive/pull/1221#discussion_r462725998
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
##
@@ -312,5 +558,9 @@ private String
github-actions[bot] closed pull request #1028:
URL: https://github.com/apache/hive/pull/1028
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dengzhhu653 closed pull request #1033:
URL: https://github.com/apache/hive/pull/1033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kasakrisz commented on pull request #1324:
URL: https://github.com/apache/hive/pull/1324#issuecomment-666155487
@HunterL
Thanks for reviewing this patch.
The expression
```
filterExpr: (((s_floor_space > 1000) and s_store_sk is not null) or
s_store_sk is not null)
```
is a
HunterL commented on pull request #1324:
URL: https://github.com/apache/hive/pull/1324#issuecomment-665824148
So looking through the Q tests (specifically
`auto_join_reordering_values.q.out`) we have
`explain select s.s_store_sk from store_n0 s join store_sales_n0 ss on
(s.s_store_sk =
pkumarsinha commented on a change in pull request #1329:
URL: https://github.com/apache/hive/pull/1329#discussion_r462125753
##
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##
@@ -617,6 +617,22 @@ private static void populateLlapDaemonVarsSet(Set
llapDa
soumyakanti3578 commented on a change in pull request #1317:
URL: https://github.com/apache/hive/pull/1317#discussion_r462602014
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientWithLocalCache.java
##
@@ -0,0
HunterL edited a comment on pull request #1324:
URL: https://github.com/apache/hive/pull/1324#issuecomment-665824148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aasha commented on a change in pull request #1329:
URL: https://github.com/apache/hive/pull/1329#discussion_r462697552
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/util/Retryable.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
sam-an-cloudera commented on a change in pull request #1221:
URL: https://github.com/apache/hive/pull/1221#discussion_r462496195
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
##
@@ -312,5 +558,9 @@ priv
jcamachor commented on a change in pull request #1317:
URL: https://github.com/apache/hive/pull/1317#discussion_r462584582
##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -3665,33 +3678,39 @@ public boolean dropPartition(String dbName, String
table
vineetgarg02 commented on pull request #1315:
URL: https://github.com/apache/hive/pull/1315#issuecomment-665947086
@jcamachor @zabetak I was thinking of changing all the existing tpcds
queries to replace literals with `?` and run explain on tpcds queries (using
TestTezPerfCliDriver). This
aasha commented on a change in pull request #1329:
URL: https://github.com/apache/hive/pull/1329#discussion_r462835685
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/util/Retryable.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
aasha commented on a change in pull request #1329:
URL: https://github.com/apache/hive/pull/1329#discussion_r462835685
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/util/Retryable.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
kasakrisz commented on a change in pull request #1323:
URL: https://github.com/apache/hive/pull/1323#discussion_r462852316
##
File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out
##
@@ -124,27 +124,25 @@ Stage-3
<-Reducer 2 [SIMPLE_EDGE] lla
zabetak commented on pull request #1315:
URL: https://github.com/apache/hive/pull/1315#issuecomment-666334140
> @jcamachor @zabetak I was thinking of changing all the existing tpcds
queries to replace literals with `?` and run explain on tpcds queries (using
TestTezPerfCliDriver). This sho
dengzhhu653 commented on pull request #1322:
URL: https://github.com/apache/hive/pull/1322#issuecomment-666340785
Hey @letsflyinthesky, you can move your fixes upon the master branch. There
are some detailed useful guidelines of how to contribute on
https://cwiki.apache.org/confluence/disp
letsflyinthesky commented on pull request #1322:
URL: https://github.com/apache/hive/pull/1322#issuecomment-666349043
May you give me some advice about why to remove. My commit could don't
resolve the problem or the way I the commi dose not conform to regulation.
-
jcamachor merged pull request #1305:
URL: https://github.com/apache/hive/pull/1305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
zeroflag opened a new pull request #1338:
URL: https://github.com/apache/hive/pull/1338
Work in progress
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA
soumyakanti3578 commented on a change in pull request #1317:
URL: https://github.com/apache/hive/pull/1317#discussion_r463036109
##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -3665,33 +3678,39 @@ public boolean dropPartition(String dbName, String
soumyakanti3578 commented on a change in pull request #1317:
URL: https://github.com/apache/hive/pull/1317#discussion_r463036109
##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -3665,33 +3678,39 @@ public boolean dropPartition(String dbName, String
kgyrtkirk merged pull request #1272:
URL: https://github.com/apache/hive/pull/1272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kgyrtkirk commented on pull request #1252:
URL: https://github.com/apache/hive/pull/1252#issuecomment-666403793
we should get this in sooner than later - I've also bumped into this issue;
and had to figure it out again...I didn't connected the dots
pvargacl opened a new pull request #1339:
URL: https://github.com/apache/hive/pull/1339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
maheshk114 merged pull request #1293:
URL: https://github.com/apache/hive/pull/1293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zeroflag commented on a change in pull request #1323:
URL: https://github.com/apache/hive/pull/1323#discussion_r463107179
##
File path: ql/src/test/results/clientpositive/llap/input14_limit.q.out
##
@@ -75,19 +75,19 @@ STAGE PLANS:
Reducer 2
Execution mod
maheshk114 opened a new pull request #1340:
URL: https://github.com/apache/hive/pull/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zeroflag commented on a change in pull request #1323:
URL: https://github.com/apache/hive/pull/1323#discussion_r463115806
##
File path: ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out
##
@@ -1207,7 +1223,6 @@ limit 1 offset 1
POSTHOOK: type: QUERY
POSTHOOK:
kgyrtkirk opened a new pull request #1341:
URL: https://github.com/apache/hive/pull/1341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
risdenk opened a new pull request #1342:
URL: https://github.com/apache/hive/pull/1342
Ensures that HS2 uses the default JDK keystore/truststore type when
interacting with Thrift and Jetty. It isn't possible to add a test for this
since FIPS compatible keystore/truststore needs special TLS
kgyrtkirk merged pull request #1303:
URL: https://github.com/apache/hive/pull/1303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
zeroflag commented on a change in pull request #1323:
URL: https://github.com/apache/hive/pull/1323#discussion_r463125357
##
File path: ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out
##
@@ -108,7 +111,7 @@ limit 1
POSTHOOK: type: QUERY
POSTHOOK: Input: def
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463150602
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +123,183 @@
*/
private long visibilityTxnId;
+privat
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463151233
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +123,183 @@
*/
private long visibilityTxnId;
+privat
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463156327
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +123,183 @@
*/
private long visibilityTxnId;
+privat
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463156735
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +123,183 @@
*/
private long visibilityTxnId;
+privat
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463159912
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +123,183 @@
*/
private long visibilityTxnId;
+privat
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463163160
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##
@@ -1113,10 +1119,13 @@ else if(statementId != parsedDelta.statementId) {
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463163936
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##
@@ -1165,8 +1168,14 @@ private static ParsedDelta parseDelta(Path path, String
deltaP
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463166514
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -680,14 +681,15 @@ public void setBaseAndInnerReader(
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463168246
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1574,45 +1576,46 @@ public int compareTo(CompressedOwid
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463169065
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1574,45 +1576,46 @@ public int compareTo(CompressedOwid
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463171159
##
File path: ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidInputFormat.java
##
@@ -83,6 +94,34 @@ public void testDeltaMetaConstructWithState() throws
Exc
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463237211
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -680,14 +681,15 @@ public void setBaseAndInnerReader(
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463249932
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1574,45 +1576,46 @@ public int compareTo(CompressedO
pkumarsinha opened a new pull request #1343:
URL: https://github.com/apache/hive/pull/1343
…calls to openTransaction/commitTransaction error during
get_partitions_by_names
### What changes were proposed in this pull request?
### Why are the changes needed?
jcamachor commented on a change in pull request #1326:
URL: https://github.com/apache/hive/pull/1326#discussion_r463353432
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java
##
@@ -868,17 +849,15 @@ protected T getXpathOrFuncExprNodeDesc(A
dengzhhu653 commented on pull request #1322:
URL: https://github.com/apache/hive/pull/1322#issuecomment-666864106
... you can give a view on "Understanding Hive Branches" on the above link
This is an automated message from th
dengzhhu653 edited a comment on pull request #1322:
URL: https://github.com/apache/hive/pull/1322#issuecomment-666864106
... you can give a view on "Understanding Hive Branches" on the above link,
and add some tests.
This is
jcamachor merged pull request #1310:
URL: https://github.com/apache/hive/pull/1310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jcamachor commented on a change in pull request #1324:
URL: https://github.com/apache/hive/pull/1324#discussion_r463040481
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##
@@ -247,6 +249,18 @@ public ParseContext transform(ParseContext
xiaomengzhang commented on pull request #1344:
URL: https://github.com/apache/hive/pull/1344#issuecomment-666894541
@nrg4878
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xiaomengzhang opened a new pull request #1344:
URL: https://github.com/apache/hive/pull/1344
Add an env variable BEELINE_URL_LEGACY, when this value is not empty,
run "beeline -c $BEELINE_URL_LEGACY".
Change-Id: I9bd7f34612e2bd246d5cba37ddfd8a582038bbdd
### What chan
aasha opened a new pull request #1345:
URL: https://github.com/apache/hive/pull/1345
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this
pvary commented on a change in pull request #1341:
URL: https://github.com/apache/hive/pull/1341#discussion_r463404254
##
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##
@@ -984,16 +984,23 @@ private bo
pvary commented on a change in pull request #1341:
URL: https://github.com/apache/hive/pull/1341#discussion_r463404741
##
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##
@@ -2960,4 +2977,22 @@ public vo
pvary commented on a change in pull request #1341:
URL: https://github.com/apache/hive/pull/1341#discussion_r463405230
##
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##
@@ -9483,6 +9483,81 @@ private void dro
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r463406580
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1574,45 +1576,46 @@ public int compareTo(CompressedOwid
kasakrisz commented on a change in pull request #1324:
URL: https://github.com/apache/hive/pull/1324#discussion_r463415834
##
File path:
ql/src/test/results/clientpositive/llap/annotate_stats_join_pkfk.q.out
##
@@ -1191,14 +1191,6 @@ STAGE PLANS:
sort
kasakrisz commented on a change in pull request #1324:
URL: https://github.com/apache/hive/pull/1324#discussion_r463430942
##
File path:
ql/src/test/results/clientpositive/llap/auto_join_reordering_values.q.out
##
@@ -144,122 +144,30 @@ STAGE PLANS:
ta
kgyrtkirk commented on a change in pull request #1341:
URL: https://github.com/apache/hive/pull/1341#discussion_r463435574
##
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##
@@ -9483,6 +9483,81 @@ private void
63 matches
Mail list logo