Re: [Intel-gfx] [PATCH] drm/i915: GEN7_MSG_CONTROL is ivb-only

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 08:43:53PM +, Runyan, Arthur J wrote: > > > >-Original Message- > >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > >Sent: Wednesday, January 22, 2014 2:40 PM > >To: Intel Graphics Development > >Cc: Daniel Vetter; Chris Wilson; Runyan, Arthur J; Dave Airl

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 07:55:59PM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > > On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > > > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > > > The previous check during error

Re: [Intel-gfx] [PATCH] drm/i915: GEN7_MSG_CONTROL is ivb-only

2014-01-26 Thread Runyan, Arthur J
>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] >Sent: Wednesday, January 22, 2014 2:40 PM >To: Intel Graphics Development >Cc: Daniel Vetter; Chris Wilson; Runyan, Arthur J; Dave Airlie >Subject: [PATCH] drm/i915: GEN7_MSG_CONTROL is ivb-only > >At least I couldn

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 11:00:52AM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 10:07:45AM +, Chris Wilson wrote: > > On Sun, Jan 26, 2014 at 11:01:50AM +0100, Daniel Vetter wrote: > > > On Sun, Jan 26, 2014 at 09:57:08AM +, Chris Wilson wrote: > > > > On Sun, Jan 26, 2014 at 10:17:

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 11:00:52AM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 10:07:45AM +, Chris Wilson wrote: > > On Sun, Jan 26, 2014 at 11:01:50AM +0100, Daniel Vetter wrote: > > > On Sun, Jan 26, 2014 at 09:57:08AM +, Chris Wilson wrote: > > > > On Sun, Jan 26, 2014 at 10:17:

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > > The previous check during error capture of whether or not the current VM > > > should be scanned used

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Capture PPGTT info on error capture

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 11:06:40AM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 11:42:22AM +, Chris Wilson wrote: > > On Fri, Jan 24, 2014 at 06:17:44PM -0800, Ben Widawsky wrote: > > > Cc: Chris Wilson > > > Signed-off-by: Ben Widawsky > > > --- > > > drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Capture PPGTT info on error capture

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 11:42:22AM +, Chris Wilson wrote: > On Fri, Jan 24, 2014 at 06:17:44PM -0800, Ben Widawsky wrote: > > Cc: Chris Wilson > > Signed-off-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/i915_drv.h | 7 ++ > > drivers/gpu/drm/i915/i915_gpu_error.c | 41 > > ++

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > The previous check during error capture of whether or not the current VM > > should be scanned used, gen < 7. That was more or less trying to > > determine if there was

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 10:07:45AM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 11:01:50AM +0100, Daniel Vetter wrote: > > On Sun, Jan 26, 2014 at 09:57:08AM +, Chris Wilson wrote: > > > On Sun, Jan 26, 2014 at 10:17:57AM +0100, Daniel Vetter wrote: > > > > On Sun, Jan 26, 2014 at 6:49

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Get rid of acthd based batch search on reset stats

2014-01-26 Thread Ben Widawsky
On Fri, Jan 17, 2014 at 04:20:31PM +0200, Mika Kuoppala wrote: > As we seek the guilty one using request ordering and hangcheck > score, these were needed only for debug output. > As it's only for debug output, I'd rather just leave this here until we're completely convinced the new mechanism wor

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Seek only one guilty batch per hanged ring

2014-01-26 Thread Ben Widawsky
On Fri, Jan 17, 2014 at 04:20:30PM +0200, Mika Kuoppala wrote: > Instead of going through all the requests to find a batch that > hanged the machine, use hangcheck score and the fact that hung, hanged??? > first noncompleted request on hanged ring is, with great > probability, the guilty one. This

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Tune down debug output when context is banned

2014-01-26 Thread Ben Widawsky
On Wed, Jan 22, 2014 at 05:41:29PM +0200, Mika Kuoppala wrote: > If we have stopped rings then we know that test is running > so no need for spam. In addition, only spam when default > context gets banned. > > v2: - make sure default context ban gets shown (Chris) > - use helper for checking

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915: Make sprite updates atomic

2014-01-26 Thread Daniel Vetter
On Tue, Jan 21, 2014 at 04:12:38PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a mechanism by which we can evade the leading edge of vblank. This > guarantees that no two sprite register writes will straddle on either > side of the vblank start, and that means all the

Re: [Intel-gfx] [PATCH v2] drm/i915: fix dp/sdvo i2c cleanup

2014-01-26 Thread Greg KH
On Sun, Jan 26, 2014 at 01:11:15PM +0200, Imre Deak wrote: > On Sun, 2014-01-26 at 10:21 +0100, Daniel Vetter wrote: > > On Sun, Jan 26, 2014 at 1:51 AM, Imre Deak wrote: > > > On Sat, 2014-01-25 at 21:37 +0100, Daniel Vetter wrote: > > >> On Fri, Jan 24, 2014 at 02:47:33PM +0200, Imre Deak wrote:

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Remove INTEL_INFO()

2014-01-26 Thread Daniel Vetter
On Mon, Jan 06, 2014 at 07:17:22PM +, Damien Lespiau wrote: > Finally, we reach the goal of the last few patches: the removal of > INTEL_INFO() in favor of a direct dev_priv usage. > > Signed-off-by: Damien Lespiau Please pardon my incompetence, but I think I need to pull a heelturn on this

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: move module parameters into a struct, in a new file

2014-01-26 Thread Daniel Vetter
On Tue, Jan 21, 2014 at 11:24:25AM +0200, Jani Nikula wrote: > With 20+ module parameters, I think referring to them via a struct > improves clarity over just having a bunch of globals. While at it, move > the parameter initialization and definitions into a new file > i915_params.c to reduce clutte

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Some less complex FBC fixes

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 03:33:32PM +0100, Daniel Vetter wrote: > On Sat, Jan 25, 2014 at 08:59:49PM +0100, Daniel Vetter wrote: > > On Thu, Jan 23, 2014 at 07:47:59PM +, Chris Wilson wrote: > > > On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Some less complex FBC fixes

2014-01-26 Thread Daniel Vetter
On Sat, Jan 25, 2014 at 08:59:49PM +0100, Daniel Vetter wrote: > On Thu, Jan 23, 2014 at 07:47:59PM +, Chris Wilson wrote: > > On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Since fixing the FBC locking is a bigger tas

Re: [Intel-gfx] [PATCH] lib: Export interval_tree

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 12:24:33PM +, Chris Wilson wrote: > lib/interval_tree.c provides a simple interface for an interval-tree > (an augmented red-black tree) but is only built when testing the generic > macros for building interval-trees. For drivers with modest needs, > export the simple in

Re: [Intel-gfx] [PATCH 1/3] lib: Always build and export interval_tree

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 03:58:47AM -0800, Michel Lespinasse wrote: > On Sun, Jan 26, 2014 at 3:27 AM, Chris Wilson > wrote: > > +config INTERVAL_TREE > > + boolean > > +help > > + Simple, embeddable, interval-tree. Can find the start of an > > + overlapping range i

[Intel-gfx] [PATCH] lib: Export interval_tree

2014-01-26 Thread Chris Wilson
lib/interval_tree.c provides a simple interface for an interval-tree (an augmented red-black tree) but is only built when testing the generic macros for building interval-trees. For drivers with modest needs, export the simple interval-tree library as is. v2: Lots of help from Michel Lespinasse to

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Chris Wilson
On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > The previous check during error capture of whether or not the current VM > should be scanned used, gen < 7. That was more or less trying to > determine if there was a full PPGTT. At the time, this was sort of what > I meant to do becau

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Capture PPGTT info on error capture

2014-01-26 Thread Chris Wilson
On Fri, Jan 24, 2014 at 06:17:44PM -0800, Ben Widawsky wrote: > Cc: Chris Wilson > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_drv.h | 7 ++ > drivers/gpu/drm/i915/i915_gpu_error.c | 41 > +++ > 2 files changed, 48 insertions(+) > >

Re: [Intel-gfx] [PATCH 1/3] lib: Always build and export interval_tree

2014-01-26 Thread Chris Wilson
On Fri, Jan 24, 2014 at 08:42:18PM -0800, Michel Lespinasse wrote: > Hi Chris, > > On Tue, Jan 21, 2014 at 7:07 AM, Chris Wilson > wrote: > > lib/interval_tree.c provides a simple interface for an interval-tree > > (an augmented red-black tree) but is only built when testing the generic > > macr

Re: [Intel-gfx] [PATCH v2] drm/i915: fix dp/sdvo i2c cleanup

2014-01-26 Thread Imre Deak
On Sun, 2014-01-26 at 10:21 +0100, Daniel Vetter wrote: > On Sun, Jan 26, 2014 at 1:51 AM, Imre Deak wrote: > > On Sat, 2014-01-25 at 21:37 +0100, Daniel Vetter wrote: > >> On Fri, Jan 24, 2014 at 02:47:33PM +0200, Imre Deak wrote: > >> > Atm we try to remove the connector's i2c sysfs entry too la

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 10:26 AM, Daniel Vetter wrote: > On Sun, Jan 26, 2014 at 6:09 AM, Ben Widawsky > wrote: >> Daniel, the issue is exactly with aliasing (any platform >= gen7 with >> aliasing to be precise). I did ask Ken to try some of Mika's patches >> before pursuing this, but since then

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 11:01:50AM +0100, Daniel Vetter wrote: > On Sun, Jan 26, 2014 at 09:57:08AM +, Chris Wilson wrote: > > On Sun, Jan 26, 2014 at 10:17:57AM +0100, Daniel Vetter wrote: > > > On Sun, Jan 26, 2014 at 6:49 AM, Ben Widawsky wrote: > > > > On Sat, Jan 25, 2014 at 09:28:24PM +0

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 09:57:08AM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 10:17:57AM +0100, Daniel Vetter wrote: > > On Sun, Jan 26, 2014 at 6:49 AM, Ben Widawsky wrote: > > > On Sat, Jan 25, 2014 at 09:28:24PM +0100, Daniel Vetter wrote: > > >> On Thu, Jan 23, 2014 at 07:21:10PM -08

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 10:17:57AM +0100, Daniel Vetter wrote: > On Sun, Jan 26, 2014 at 6:49 AM, Ben Widawsky wrote: > > On Sat, Jan 25, 2014 at 09:28:24PM +0100, Daniel Vetter wrote: > >> On Thu, Jan 23, 2014 at 07:21:10PM -0800, Ben Widawsky wrote: > >> > DRM gets very mad when you request an o

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 6:09 AM, Ben Widawsky wrote: > Daniel, the issue is exactly with aliasing (any platform >= gen7 with > aliasing to be precise). I did ask Ken to try some of Mika's patches > before pursuing this, but since then I've asked Mika to send me exactly > what I need to review. I a

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Create a USES_PPGTT macro

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 6:45 AM, Ben Widawsky wrote: >> > diff --git a/drivers/gpu/drm/i915/i915_drv.h >> > b/drivers/gpu/drm/i915/i915_drv.h >> > index e851a82..6f68515 100644 >> > --- a/drivers/gpu/drm/i915/i915_drv.h >> > +++ b/drivers/gpu/drm/i915/i915_drv.h >> > @@ -1844,6 +1844,7 @@ struct

Re: [Intel-gfx] [PATCH v2] drm/i915: fix dp/sdvo i2c cleanup

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 1:51 AM, Imre Deak wrote: > On Sat, 2014-01-25 at 21:37 +0100, Daniel Vetter wrote: >> On Fri, Jan 24, 2014 at 02:47:33PM +0200, Imre Deak wrote: >> > Atm we try to remove the connector's i2c sysfs entry too late in the >> > encoder's destroy callback. By that time the kobj

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-26 Thread Daniel Vetter
On Sun, Jan 26, 2014 at 6:49 AM, Ben Widawsky wrote: > On Sat, Jan 25, 2014 at 09:28:24PM +0100, Daniel Vetter wrote: >> On Thu, Jan 23, 2014 at 07:21:10PM -0800, Ben Widawsky wrote: >> > DRM gets very mad when you request an object which occupies a partial >> > page. As a DRM driver, i915 never r