[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list URL : https://patchwork.freedesktop.org/series/61405/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6170_full -> Patchwork_13141_full

[Intel-gfx] ✓ Fi.CI.BAT: success for split out intel_display_power

2019-05-31 Thread Patchwork
== Series Details == Series: split out intel_display_power URL : https://patchwork.freedesktop.org/series/61453/ State : success == Summary == CI Bug Log - changes from CI_DRM_6178 -> Patchwork_13154 Summary --- **SUCCESS** No

Re: [Intel-gfx] [RFC 1/7] drm/i915: prefer i915_runtime_pm in intel_runtime function

2019-05-31 Thread Daniele Ceraolo Spurio
On 5/21/19 1:45 AM, Jani Nikula wrote: On Thu, 16 May 2019, Daniele Ceraolo Spurio wrote: As a first step towards updating the code to work on the runtime_pm structure instead of i915, rework all the internals to use and pass around that. Signed-off-by: Daniele Ceraolo Spurio ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for split out intel_display_power

2019-05-31 Thread Patchwork
== Series Details == Series: split out intel_display_power URL : https://patchwork.freedesktop.org/series/61453/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: extract intel_display_power.h/c from intel_runtime_pm.h/c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for split out intel_display_power

2019-05-31 Thread Patchwork
== Series Details == Series: split out intel_display_power URL : https://patchwork.freedesktop.org/series/61453/ State : warning == Summary == $ dim checkpatch origin/drm-tip 757791efed23 drm/i915: extract intel_display_power.h/c from intel_runtime_pm.h/c -:64: WARNING:FILE_PATH_CHANGES:

[Intel-gfx] [PATCH 2/2] drm/i915: move more defs in intel_display_power.h

2019-05-31 Thread Daniele Ceraolo Spurio
Move over structures, enums and macros from intel_display.h and i915_drv.h to have all the display PM defines in the same header. Signed-off-by: Daniele Ceraolo Spurio Cc: Imre Deak Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h| 110

[Intel-gfx] [PATCH 0/2] split out intel_display_power

2019-05-31 Thread Daniele Ceraolo Spurio
Separate the display PM from the PCI-level runtime PM. I'll follow this up with v2 of the rpm encapsulation series [1], but I'd like to get this in before that to avoid having to carry this big dumb diff in that series. [1] https://patchwork.freedesktop.org/series/60751/ Daniele Ceraolo Spurio

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Split off pci_driver.remove() tail to drm_driver.release() (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Split off pci_driver.remove() tail to drm_driver.release() (rev2) URL : https://patchwork.freedesktop.org/series/61376/ State : success == Summary == CI Bug Log - changes from CI_DRM_6169_full -> Patchwork_13139_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Always enable mmio debugging for CI (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Always enable mmio debugging for CI (rev2) URL : https://patchwork.freedesktop.org/series/48659/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6169_full -> Patchwork_13138_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Flush output polling on shutdown (rev4)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev4) URL : https://patchwork.freedesktop.org/series/61442/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13153 Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Report all objects with allocated pages to the shrinker

2019-05-31 Thread Chris Wilson
Quoting Matthew Auld (2019-05-31 21:06:46) > On Thu, 30 May 2019 at 21:35, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > > b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > > index 9080a736663a..8b3a23bff7f6 100644 > > ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Report all objects with allocated pages to the shrinker

2019-05-31 Thread Matthew Auld
On Thu, 30 May 2019 at 21:35, Chris Wilson wrote: > > Currently, we try to report to the shrinker the precise number of > objects (pages) that are available to be reaped at this moment. This > requires searching all objects with allocated pages to see if they > fulfill the search criteria, and

[Intel-gfx] question about i915 GPU driver in VM

2019-05-31 Thread Micah Morton
Hi, I'm trying to get iGPU passthrough working in a VM running on a Chrome OS "7th Generation (Kaby Lake) Intel Core i5-7Y57 with HD Graphics 615" device. I'm able to pass the iGPU through to the VM and execute the i915 driver, but the driver doesn't succeed in getting the system to the point

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Flush output polling on shutdown (rev3)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev3) URL : https://patchwork.freedesktop.org/series/61442/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13152 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Flush output polling on shutdown (rev4)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev4) URL : https://patchwork.freedesktop.org/series/61442/ State : warning == Summary == $ dim checkpatch origin/drm-tip cb261a291f72 drm: Flush output polling on shutdown -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH i-g-t 5/5] lib/igt_core: add -h to usage

2019-05-31 Thread Lucas De Marchi
On Fri, May 31, 2019 at 01:07:33PM +0300, Petri Latvala wrote: On Wed, May 29, 2019 at 04:27:37PM -0700, Lucas De Marchi wrote: We also accept the short option -h. Signed-off-by: Lucas De Marchi Reviewed-by: Petri Latvala Please send (CC or otherwise) IGT patches to igt-dev in the future,

[Intel-gfx] [PATCH v2] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
We need to mark the output polling as disabled to prevent concurrent irqs from queuing new work as shutdown the probe -- causing that work to execute after we have freed the structs: <4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock)) <4> [341.846497] WARNING: CPU: 3 PID: 3300 at

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Flush output polling on shutdown (rev3)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev3) URL : https://patchwork.freedesktop.org/series/61442/ State : warning == Summary == $ dim checkpatch origin/drm-tip 790ebdd5fd02 drm: Flush output polling on shutdown -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH 3/3] drm/i915/huc: Update HuC status codes

2019-05-31 Thread Michal Wajdeczko
On Fri, 31 May 2019 12:13:20 +0200, Joonas Lahtinen wrote: Quoting Michal Wajdeczko (2019-05-23 01:25:00) On Wed, 22 May 2019 22:19:47 +0200, Chris Wilson wrote: > Quoting Michal Wajdeczko (2019-05-22 20:00:57) >> Without breaking existing usage, slightly update HuC status codes >> to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Flush output polling on shutdown (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev2) URL : https://patchwork.freedesktop.org/series/61442/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13151 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Flush output polling on shutdown

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown URL : https://patchwork.freedesktop.org/series/61442/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13150 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl

2019-05-31 Thread Patchwork
== Series Details == Series: drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl URL : https://patchwork.freedesktop.org/series/61299/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163_full -> Patchwork_13124_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: No need to zero the table for page dirs

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915/gtt: No need to zero the table for page dirs URL : https://patchwork.freedesktop.org/series/61439/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13149 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/selftests: Flush partial-tiling object once

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/selftests: Flush partial-tiling object once URL : https://patchwork.freedesktop.org/series/61438/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13148

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Avoid overflowing the WC stash

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Avoid overflowing the WC stash URL : https://patchwork.freedesktop.org/series/61301/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163_full -> Patchwork_13125_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Flush output polling on shutdown (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown (rev2) URL : https://patchwork.freedesktop.org/series/61442/ State : warning == Summary == $ dim checkpatch origin/drm-tip 925b889001c2 drm: Flush output polling on shutdown -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: adding state checker for gamma lut values (rev12)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev12) URL : https://patchwork.freedesktop.org/series/58039/ State : success == Summary == CI Bug Log - changes from CI_DRM_6164_full -> Patchwork_13131_full

[Intel-gfx] [PATCH v2] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
We need to mark the output polling as disabled to prevent concurrent irqs from queuing new work as shutdown the probe -- causing that work to execute after we have freed the structs: <4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock)) <4> [341.846497] WARNING: CPU: 3 PID: 3300 at

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Flush output polling on shutdown

2019-05-31 Thread Patchwork
== Series Details == Series: drm: Flush output polling on shutdown URL : https://patchwork.freedesktop.org/series/61442/ State : warning == Summary == $ dim checkpatch origin/drm-tip e0238ba7cdcd drm: Flush output polling on shutdown -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fb-helper: Move modesetting code to drm_client (rev8)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev8) URL : https://patchwork.freedesktop.org/series/58597/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13147 Summary

Re: [Intel-gfx] [PATCH] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
Quoting Chris Wilson (2019-05-31 18:16:15) > We need to mark the output polling as disabled to prevent concurrent > irqs from queuing new work as shutdown the probe -- causing that work to > execute after we have freed the structs: > > <4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock)) >

[Intel-gfx] [PATCH] drm: Flush output polling on shutdown

2019-05-31 Thread Chris Wilson
We need to mark the output polling as disabled to prevent concurrent irqs from queuing new work as shutdown the probe -- causing that work to execute after we have freed the structs: <4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock)) <4> [341.846497] WARNING: CPU: 3 PID: 3300 at

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv URL : https://patchwork.freedesktop.org/series/61345/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6165_full -> Patchwork_13133_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: vbt cleanup

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915/bios: vbt cleanup URL : https://patchwork.freedesktop.org/series/61430/ State : success == Summary == CI Bug Log - changes from CI_DRM_6175 -> Patchwork_13146 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/selftests: Flush partial-tiling object once

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/selftests: Flush partial-tiling object once URL : https://patchwork.freedesktop.org/series/61438/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/selftests: Flush partial-tiling

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Report an earlier wedged event when suspending the engines

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Report an earlier wedged event when suspending the engines URL : https://patchwork.freedesktop.org/series/61425/ State : success == Summary == CI Bug Log - changes from CI_DRM_6175 -> Patchwork_13145

[Intel-gfx] ✓ Fi.CI.IGT: success for Document fixes for DRM UAPI and HDR

2019-05-31 Thread Patchwork
== Series Details == Series: Document fixes for DRM UAPI and HDR URL : https://patchwork.freedesktop.org/series/61349/ State : success == Summary == CI Bug Log - changes from CI_DRM_6165_full -> Patchwork_13134_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gtt: No need to zero the table for page dirs

2019-05-31 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-31 17:18:36) > We set them to scratch right after allocation so prevent > useless zeroing before. > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

[Intel-gfx] [PATCH] drm/i915/gtt: No need to zero the table for page dirs

2019-05-31 Thread Mika Kuoppala
We set them to scratch right after allocation so prevent useless zeroing before. Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH 2/3] drm/i915: Use unchecked writes for setting up the fences

2019-05-31 Thread Chris Wilson
As the fence registers are not part of the engine powerwells, we do not need to fiddle with forcewake in order to update a fence. Avoid using the heavyweight debug checking normal mmio writes as the checking dominates the selftest runtime and is superfluous! In the process, retire the

[Intel-gfx] [PATCH 3/3] drm/i915: Use unchecked unccore writes to flush the GTT

2019-05-31 Thread Chris Wilson
As the GTT is outside of the powerwell, we can simplify flushing the GGTT writes by using an unchecked mmio write and post. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 1/3] drm/i915/selftests: Flush partial-tiling object once

2019-05-31 Thread Chris Wilson
We only need to flush the object once prior to starting the partial tiling test as inside the test we explicitly maintain coherency. Signed-off-by: Chris Wilson --- .../drm/i915/gem/selftests/i915_gem_mman.c| 21 --- 1 file changed, 9 insertions(+), 12 deletions(-) diff

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Drop non-NULL llist_for_each_entry_safe check for

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Drop non-NULL llist_for_each_entry_safe check for URL : https://patchwork.freedesktop.org/series/61374/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6167_full -> Patchwork_13136_full

Re: [Intel-gfx] [v7][PATCH 06/12] drm/i915: Extract i965_read_luts()

2019-05-31 Thread Ville Syrjälä
On Wed, May 29, 2019 at 03:20:56PM +0530, Swati Sharma wrote: > In this patch, hw gamma blob is created for i965. > > v4: -No need to initialize *blob [Jani] > -Removed right shifts [Jani] > -Dropped dev local var [Jani] > v5: -Returned blob instead of assigning it internally >

Re: [Intel-gfx] [v7][PATCH 11/12] drm/i915: Extract ilk_read_luts()

2019-05-31 Thread Ville Syrjälä
On Wed, May 29, 2019 at 03:21:01PM +0530, Swati Sharma wrote: > In this patch, hw gamma blob is created for ILK. > > v4: -No need to initialize *blob [Jani] > -Removed right shifts [Jani] > -Dropped dev local var [Jani] > v5: -Returned blob instead of assigning it internally within the >

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-05-31 Thread Ville Syrjälä
On Wed, May 29, 2019 at 03:20:53PM +0530, Swati Sharma wrote: > v3: -Rebase > v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > -Added the default label above the correct label [Jani] > -Corrected smatch warn "variable dereferenced before check" > [Dan

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-31 Thread Lucas De Marchi
On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote: On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: We want to check if the long option conflicts with one from the core. The check for conflicting short option already exists just above. No, this one is checking that

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fb-helper: Move modesetting code to drm_client (rev8)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev8) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fb-helper: Move modesetting code to drm_client (rev8)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev8) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f8f155f76d9 drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() 03e436436a8d

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] lib/tests: fix conflicting args test

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [1/5] lib/tests: fix conflicting args test URL : https://patchwork.freedesktop.org/series/61355/ State : success == Summary == CI Bug Log - changes from CI_DRM_6166_full -> IGTPW_3078_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Ensure port A combo PHY HW state is correct

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: Ensure port A combo PHY HW state is correct URL : https://patchwork.freedesktop.org/series/61415/ State : success == Summary == CI Bug Log - changes from CI_DRM_6173 -> Patchwork_13143 Summary

Re: [Intel-gfx] [PATCH 01/13] drm/i915/bios: make child device order the priority order

2019-05-31 Thread Ville Syrjälä
On Fri, May 31, 2019 at 04:14:51PM +0300, Jani Nikula wrote: > Make the child device order the priority order in sanitizing DDC pin and > AUX CH. First come, first served. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_bios.c | 32

[Intel-gfx] [PATCH v7 6/8] drm/fb-helper: Prepare to move out modeset config code

2019-05-31 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[Intel-gfx] [PATCH v7 8/8] drm/client: Hack: Add bootsplash example

2019-05-31 Thread Noralf Trønnes
An example to showcase the client API. TODO: - A bootsplash client needs a way to tell drm_fb_helper to stay away, otherwise it will chime in on setup and hotplug. Most DRM drivers register fbdev before calling drm_dev_register() (the generic emulation is an exception). This have to be

[Intel-gfx] [PATCH v7 5/8] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-31 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Instead we just put the useable (not writeback) connectors in a temporary array using drm_client_for_each_connector_iter() everytime we probe the outputs. Other places where it's necessary to

[Intel-gfx] [PATCH v7 7/8] drm/fb-helper: Move out modeset config code

2019-05-31 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692

[Intel-gfx] [PATCH v7 4/8] drm/fb-helper: Move out commit code

2019-05-31 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v7: Export drm_client_panel_rotation() (Gerd Hoffmann) v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c

[Intel-gfx] [PATCH v7 3/8] drm/fb-helper: Prepare to move out commit code

2019-05-31 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81

[Intel-gfx] [PATCH v7 1/8] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-05-31 Thread Noralf Trønnes
Prepare for moving drm_fb_helper modesetting code to drm_client. drm_client will be linked to drm.ko, so move __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() out of drm_kms_helper.ko. While at it, fix two checkpatch complaints: - WARNING: Block comments use a trailing */

[Intel-gfx] [PATCH v7 0/8] drm/fb-helper: Move modesetting code to drm_client

2019-05-31 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. Changes this time: - Declare drm_mode_set and drm_plane_state in patch 1 - Export drm_client_panel_rotation() (Gerd Hoffmann) - Rebase Noralf. Cc: Gerd Hoffmann Noralf Trønnes (8):

[Intel-gfx] [PATCH v7 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-31 Thread Noralf Trønnes
struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so use that directly instead and attach it as a modeset array onto drm_client_dev. drm_fb_helper will use this array to store its modesets which means it will always initialize a drm_client, but it will not register the client

Re: [Intel-gfx] [PATCH] drm/i915: add force_probe module parameter to replace alpha_support

2019-05-31 Thread Jani Nikula
On Tue, 21 May 2019, Rodrigo Vivi wrote: > On Mon, May 06, 2019 at 04:48:01PM +0300, Jani Nikula wrote: >> The i915.alpha_support module parameter has caused some confusion along >> the way. Add new i915.force_probe parameter to specify PCI IDs of >> devices to probe, when the devices are

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Update MOCS table for EHL

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Update MOCS table for EHL URL : https://patchwork.freedesktop.org/series/61409/ State : success == Summary == CI Bug Log - changes from CI_DRM_6171 -> Patchwork_13142 Summary ---

[Intel-gfx] [PATCH 12/13] drm/i915/bios: add more LFP options

2019-05-31 Thread Jani Nikula
Add new fields in the LFP block. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h

[Intel-gfx] [PATCH 11/13] drm/i915/bios: add VBT swing bit to child device definition

2019-05-31 Thread Jani Nikula
New bit to look in another BDB block for more. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h

[Intel-gfx] [PATCH 08/13] drm/i915/bios: reserve struct bdb_ prefix for BDB blocks

2019-05-31 Thread Jani Nikula
Don't use bdb_ prefixes for structs within blocks. Add a new bdb struct for SDVO panel DTDs for completeness. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 12 ++-- drivers/gpu/drm/i915/intel_vbt_defs.h | 20 2 files

[Intel-gfx] [PATCH 10/13] drm/i915/bios: sort BDB block definitions using block ID

2019-05-31 Thread Jani Nikula
Make it easier to find the right blocks. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 372 +- 1 file changed, 186 insertions(+), 186 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h

[Intel-gfx] [PATCH 13/13] drm/i915/bios: add an enum for BDB block IDs

2019-05-31 Thread Jani Nikula
Better grouping, better semantics for find_section(). No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 4 +- drivers/gpu/drm/i915/intel_vbt_defs.h | 71 ++- 2 files changed, 38 insertions(+), 37

[Intel-gfx] [PATCH 05/13] drm/i915/bios: use port info child pointer to determine LSPCON presence

2019-05-31 Thread Jani Nikula
Avoid iterating the child devices. This should be a non-functional change, but theoretically this might enable LSPCON on some extra ports with buggy VBTs. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 52 ---

[Intel-gfx] [PATCH 03/13] drm/i915/bios: refactor DDC pin and AUX CH sanitize functions

2019-05-31 Thread Jani Nikula
Add separate functions to get the port by DDC pin and AUX channel. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 48 ++- 1 file changed, 34 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c

[Intel-gfx] [PATCH 02/13] drm/i915/bios: store child device pointer in DDI port info

2019-05-31 Thread Jani Nikula
This allows us to avoid iterating the child devices in some cases. Also replace the presence bit with child device being non-NULL, and set the child device pointer last to allow us to take advantage of it in follow-up work. Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 07/13] drm/i915/bios: remove unused, obsolete VBT definitions

2019-05-31 Thread Jani Nikula
We've carried this baggage for more than a decade. Time to let it go. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 180 -- 1 file changed, 180 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h

[Intel-gfx] [PATCH 04/13] drm/i915/bios: use port info child pointer to determine HPD invert

2019-05-31 Thread Jani Nikula
Avoid iterating the child devices. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 39 +-- drivers/gpu/drm/i915/intel_bios.h | 2 +- 2 files changed, 7 insertions(+), 34 deletions(-) diff --git

[Intel-gfx] [PATCH 09/13] drm/i915/bios: add BDB block comments before definitions

2019-05-31 Thread Jani Nikula
Use the comments verbatim from the spec to help find the right block. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 57 +++ 1 file changed, 50 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [PATCH 06/13] drm/i915/bios: clean up VBT port info debug logging

2019-05-31 Thread Jani Nikula
Change the order, add some stylistic touches, and add LSPCON. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index

[Intel-gfx] [PATCH 00/13] drm/i915/bios: vbt cleanup

2019-05-31 Thread Jani Nikula
Some VBT cleanup to make it nicer to add more stuff and/or has been bugging me for a while. BR, Jani. Jani Nikula (13): drm/i915/bios: make child device order the priority order drm/i915/bios: store child device pointer in DDI port info drm/i915/bios: refactor DDC pin and AUX CH sanitize

[Intel-gfx] [PATCH 01/13] drm/i915/bios: make child device order the priority order

2019-05-31 Thread Jani Nikula
Make the child device order the priority order in sanitizing DDC pin and AUX CH. First come, first served. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 32 +++ 1 file changed, 15 insertions(+), 17 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list

2019-05-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list URL : https://patchwork.freedesktop.org/series/61405/ State : success == Summary == CI Bug Log - changes from CI_DRM_6170 -> Patchwork_13141

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-31 Thread Ville Syrjälä
On Thu, May 30, 2019 at 05:43:00AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [01/10] drm/i915: Add windowing for primary > planes on gen2/3 and chv > URL : https://patchwork.freedesktop.org/series/61345/ > State : failure > > == Summary == > > CI Bug Log

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix use of uninitialized pointer vaddr

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: fix use of uninitialized pointer vaddr URL : https://patchwork.freedesktop.org/series/61421/ State : failure == Summary == Applying: drm/i915: fix use of uninitialized pointer vaddr Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH] drm/i915/icl: Ensure port A combo PHY HW state is correct

2019-05-31 Thread Ville Syrjälä
On Fri, May 31, 2019 at 11:26:26AM +0300, Imre Deak wrote: > Make sure the HW state of the port A combo PHY is correct wrt. the > IREFGEN setting. This will force a reprogramming during init or a WARN > during uninit if the setting is incorrect. > > On my ICL RVP I haven't seen this check failing

[Intel-gfx] [PATCH] drm/i915: Report an earlier wedged event when suspending the engines

2019-05-31 Thread Chris Wilson
On i915_gem_load_power_context() we do care whether or not we succeed in completing the switch back to the kernel context (via idling the engines). Currently, we detect if an error occurs while we wait, but we do not report one if it occurred beforehand (and the status of the switch is undefined).

Re: [Intel-gfx] [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr

2019-05-31 Thread Chris Wilson
Quoting Colin King (2019-05-31 11:32:01) > From: Colin Ian King > > The assignment of err is using the incorrect pointer vaddr that has > not been initialized. Fix this by using the correct pointer obj instead. > > Addresses-Coverity: ("Uninitialized pointer read") > Fixes: 6501aa4e3a45

[Intel-gfx] [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr

2019-05-31 Thread Colin King
From: Colin Ian King The assignment of err is using the incorrect pointer vaddr that has not been initialized. Fix this by using the correct pointer obj instead. Addresses-Coverity: ("Uninitialized pointer read") Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client") Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Split off pci_driver.remove() tail to drm_driver.release() (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Split off pci_driver.remove() tail to drm_driver.release() (rev2) URL : https://patchwork.freedesktop.org/series/61376/ State : success == Summary == CI Bug Log - changes from CI_DRM_6169 -> Patchwork_13139

[Intel-gfx] [PATCH i-g-t v5] lib/i915/gem_mman: Add a helper for obtaining MMAP_GTT interface version

2019-05-31 Thread Janusz Krzysztofik
From: Janusz Krzysztofik If a test calls a function which depends on availability of a specific version of MMAP_GTT interface, an error may occur on unsupported hardware. That may negatively affect results reported by a test framework even if that test ignores the failure and succeedes. This

Re: [Intel-gfx] [PATCH 3/3] drm/i915/huc: Update HuC status codes

2019-05-31 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2019-05-23 01:25:00) > On Wed, 22 May 2019 22:19:47 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-22 20:00:57) > >> Without breaking existing usage, slightly update HuC status codes > >> to provide more info to the clients: > >> 1 if HuC

Re: [Intel-gfx] [PATCH i-g-t 5/5] lib/igt_core: add -h to usage

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:37PM -0700, Lucas De Marchi wrote: > We also accept the short option -h. > > Signed-off-by: Lucas De Marchi Reviewed-by: Petri Latvala Please send (CC or otherwise) IGT patches to igt-dev in the future, please. > --- > lib/igt_core.c | 2 +- > 1 file

Re: [Intel-gfx] [PATCH i-g-t 4/5] testdisplay: use first available option values

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:36PM -0700, Lucas De Marchi wrote: > Now that core options are set to 500 and above, start from the lowest > values without causing problems with conflicts. This also rename the > constants to follow the names from the core. > > Signed-off-by: Lucas De Marchi

Re: [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:35PM -0700, Lucas De Marchi wrote: > This is usually used by long options when working with enum to set long > option values. So replace the strchr() with a memchr() to take that into > account. > > Signed-off-by: Lucas De Marchi Reviewed-by: Petri Latvala The

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:34PM -0700, Lucas De Marchi wrote: > Start the core optiosn from 500 so the individual tests can have their > own options starting from 0. This makes it easier to set the long > options without conflicting. > > 500 is just a magic number, higher than any ascii char

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: > We want to check if the long option conflicts with one from the core. > The check for conflicting short option already exists just above. No, this one is checking that the val (the 0) doesn't conflict. -- Petri Latvala > >

Re: [Intel-gfx] [PATCH i-g-t v4] lib/i915/gem_mman: Add a helper for obtaining MMAP_GTT interface version

2019-05-31 Thread Janusz Krzysztofik
On Friday, May 31, 2019 11:35:39 AM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-05-31 10:29:16) > > From: Janusz Krzysztofik > > > > If a test calls a function which depends on availability of a specific > > version of MMAP_GTT interface, an error may occur on unsupported

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always enable mmio debugging for CI (rev2)

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Always enable mmio debugging for CI (rev2) URL : https://patchwork.freedesktop.org/series/48659/ State : success == Summary == CI Bug Log - changes from CI_DRM_6169 -> Patchwork_13138 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: add force_probe module parameter to replace alpha_support

2019-05-31 Thread Joonas Lahtinen
Quoting Jani Nikula (2019-05-06 16:48:01) > The i915.alpha_support module parameter has caused some confusion along > the way. Add new i915.force_probe parameter to specify PCI IDs of > devices to probe, when the devices are recognized but not automatically > probed by the driver. The name is

Re: [Intel-gfx] [PATCH i-g-t v4] lib/i915/gem_mman: Add a helper for obtaining MMAP_GTT interface version

2019-05-31 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-05-31 10:29:16) > From: Janusz Krzysztofik > > If a test calls a function which depends on availability of a specific > version of MMAP_GTT interface, an error may occur on unsupported hardware. > That may negatively affect results reported by a test framework

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Drop non-NULL llist_for_each_entry_safe check for

2019-05-31 Thread Patchwork
== Series Details == Series: drm/i915: Drop non-NULL llist_for_each_entry_safe check for URL : https://patchwork.freedesktop.org/series/61374/ State : success == Summary == CI Bug Log - changes from CI_DRM_6167_full -> Patchwork_13136_full

[Intel-gfx] [PATCH i-g-t v4] lib/i915/gem_mman: Add a helper for obtaining MMAP_GTT interface version

2019-05-31 Thread Janusz Krzysztofik
From: Janusz Krzysztofik If a test calls a function which depends on availability of a specific version of MMAP_GTT interface, an error may occur on unsupported hardware. That may negatively affect results reported by a test framework even if that test ignores the failure and succeedes. This

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v3] lib/i915/gem_mman: Add a helper for obtaining mappable aperture version

2019-05-31 Thread Janusz Krzysztofik
On Friday, May 31, 2019 10:55:46 AM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-05-31 09:53:41) > > Hi Chris, > > > > On Friday, May 31, 2019 10:39:47 AM CEST Chris Wilson wrote: > > > Quoting Janusz Krzysztofik (2019-05-31 09:33:38) > > > > From: Janusz Krzysztofik > > > > > >

Re: [Intel-gfx] [PATCH 12/22] gpu: i915.rst: Fix references to renamed files

2019-05-31 Thread Joonas Lahtinen
Quoting Mauro Carvalho Chehab (2019-05-30 02:23:43) > WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function > Hardware workarounds ./drivers/gpu/drm/i915/intel_workarounds.c' failed with > return code 1 > WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function

  1   2   >