Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-26 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copie

Re: [Intel-gfx] [PATCH 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-01-26 Thread Ville Syrjälä
On Tue, Jan 25, 2022 at 07:03:44PM +0200, Jani Nikula wrote: > Abstract link status check to a function that takes 128b/132b and 8b/10b > into account, and use it. Also dump link status on failures. > > Cc: Uma Shankar > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-01-26 Thread Ville Syrjälä
On Tue, Jan 25, 2022 at 07:03:43PM +0200, Jani Nikula wrote: > +static bool > +intel_dp_128b132b_lane_cds(struct intel_dp *intel_dp, > +const struct intel_crtc_state *crtc_state, > +int lttpr_count) > +{ > + struct intel_encoder *encoder = &dp_to

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-26 Thread Matthew Brost
On Thu, Jan 27, 2022 at 08:24:04AM +0100, Christian König wrote: > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > In certain situations it's useful to be able to read or write to an > > offset that is calculated by having the memory layout given by a struct > > declaration. Usually we are going

Re: [Intel-gfx] [PATCH 3/8] drm/dp: add some new DPCD macros from DP 2.0 E11

2022-01-26 Thread Ville Syrjälä
On Tue, Jan 25, 2022 at 07:03:41PM +0200, Jani Nikula wrote: > Add some of the new additions from DP 2.0 E11. > > Cc: Uma Shankar > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > include/drm/dp/drm_dp_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [Intel-gfx] [PATCH 1/8] drm/dp: add drm_dp_128b132b_read_aux_rd_interval()

2022-01-26 Thread Ville Syrjälä
On Tue, Jan 25, 2022 at 07:03:39PM +0200, Jani Nikula wrote: > The DP 2.0 errata changes DP_128B132B_TRAINING_AUX_RD_INTERVAL (DPCD > 0x2216) completely. Add a new function to read that. Follow-up will need > to clean up existing functions. > > v2: fix reversed interpretation of bit 7 meaning (Uma

Re: [Intel-gfx] mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)

2022-01-26 Thread Randy Dunlap
On 1/26/22 21:04, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to > >https://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > https://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v10,1/5] drm: improve drm_buddy_alloc function

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [v10,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99382/ State : success == Summary == CI Bug Log - changes from CI_DRM_11147_full -> Patchwork_22117_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use dma_buf_map URL : https://patchwork.freedesktop.org/series/99378/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11147_full -> Patchwork_22116_full Summar

Re: [Intel-gfx] [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-01-26 Thread kernel test robot
Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20220125] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next linus/master airlied/drm-next v5.17-rc1

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/guc: Update GuC's log-buffer-state access for error capture.

2022-01-26 Thread Teres Alexis, Alan Previn
As per the rev 5 CI results between this patch and patch7, i have introduced a lockdep splat bug, i shall fix that in the next rev. ...alan On Wed, 2022-01-26 at 02:48 -0800, Alan Previn wrote: > GuC log buffer regions for debug-log-events, crash-dumps and > error-state-capture are all a single

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Fix TypeC PHY-ready status readout

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Fix TypeC PHY-ready status readout URL : https://patchwork.freedesktop.org/series/99359/ State : success == Summary == CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22111 Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use existing uncore helper to read gpm_timestamp

2022-01-26 Thread kernel test robot
Hi Umesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to linus/master drm-intel/for-linux-next v5.17-rc1 next-20220125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness URL : https://patchwork.freedesktop.org/series/99388/ State : success == Summary == CI Bug Log - changes from CI_DRM_11148 -> Patchwork_22119 ==

Re: [Intel-gfx] [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-01-26 Thread kernel test robot
Hi Lucas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220125] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next linus/master airlied/drm-next v

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-26 Thread Umesh Nerlige Ramappa
GuC updates shared memory and KMD reads it. Since this is not synchronized, we run into a race where the value read is inconsistent. Sometimes the inconsistency is in reading the upper MSB bytes of the last_switch_in value. 2 types of cases are seen - upper 8 bits are zero and upper 24 bits are zer

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use existing uncore helper to read gpm_timestamp

2022-01-26 Thread Umesh Nerlige Ramappa
Use intel_uncore_read64_2x32 to read upper and lower fields of the GPM timestamp. v2: Fix compile error Signed-off-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness URL : https://patchwork.freedesktop.org/series/99386/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool C

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove all frontbuffer tracking calls from the gem code URL : https://patchwork.freedesktop.org/series/99365/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11145_full -> Patchwork_22113_full ===

Re: [Intel-gfx] [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-01-26 Thread kernel test robot
Hi Lucas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220125] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next linus/master airlied/drm-next v

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v10,1/5] drm: improve drm_buddy_alloc function

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [v10,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99382/ State : success == Summary == CI Bug Log - changes from CI_DRM_11147 -> Patchwork_22117

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use existing uncore helper to read gpm_timestamp

2022-01-26 Thread Umesh Nerlige Ramappa
Use intel_uncore_read64_2x32 to read upper and lower fields of the GPM timestamp. Signed-off-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_s

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-26 Thread Umesh Nerlige Ramappa
GuC updates shared memory and KMD reads it. Since this is not synchronized, we run into a race where the value read is inconsistent. Sometimes the inconsistency is in reading the upper MSB bytes of the last_switch_in value. 2 types of cases are seen - upper 8 bits are zero and upper 24 bits are zer

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/string_helpers: Add a few string helpers (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: lib/string_helpers: Add a few string helpers (rev2) URL : https://patchwork.freedesktop.org/series/99030/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11145_full -> Patchwork_22110_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v10,1/5] drm: improve drm_buddy_alloc function

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [v10,1/5] drm: improve drm_buddy_alloc function URL : https://patchwork.freedesktop.org/series/99382/ State : warning == Summary == $ dim checkpatch origin/drm-tip c9a375384fb3 drm: improve drm_buddy_alloc function -:383: WARNING:AVOID_BUG: Avo

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use dma_buf_map URL : https://patchwork.freedesktop.org/series/99378/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h CC [M] drive

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use dma_buf_map URL : https://patchwork.freedesktop.org/series/99378/ State : success == Summary == CI Bug Log - changes from CI_DRM_11147 -> Patchwork_22116 Summary ---

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Use preempt_disable/enable_rt() where recommended

2022-01-26 Thread Mario Kleiner
On Tue, Dec 14, 2021 at 3:03 PM Sebastian Andrzej Siewior < bige...@linutronix.de> wrote: > From: Mike Galbraith > > Mario Kleiner suggest in commit > ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into > kms driver.") > > a spots where preemption should be disabled on PREE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use dma_buf_map URL : https://patchwork.freedesktop.org/series/99378/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use dma_buf_map URL : https://patchwork.freedesktop.org/series/99378/ State : warning == Summary == $ dim checkpatch origin/drm-tip 65454816ee9c dma-buf-map: Add read/write helpers -:105: CHECK:MACRO_ARG_PRECEDENCE: Macro argume

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev2) URL : https://patchwork.freedesktop.org/series/98801/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11147 -> Patchwork_22115

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Lucas De Marchi
On Wed, Jan 26, 2022 at 02:48:13AM -0800, Alan Previn wrote: Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Also, populate the lists of registers we want GuC to report back to Host on engine reset events. This list should include global

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev2) URL : https://patchwork.freedesktop.org/series/98801/ State : warning == Summary == $ dim checkpatch origin/drm-tip 071c4ebbb036 drm/i915/display/vrr: Reset VRR capable property on a long hpd -:7

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Only include i915_reg.h from .c files

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:26PM -0800, Matt Roper wrote: Several of our i915 header files, have been including i915_reg.h. This means that any change to i915_reg.h will trigger a full rebuild of pretty much every file of the driver, even those that don't have any kind of register access. Let

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915: Move GT registers to their own header file

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:25PM -0800, Matt Roper wrote: +#define MEMSWCTL _MMIO(0x11170) /* Ironlake only */ +#define MEMCTL_CMD_MASK 0xe000 +#define MEMCTL_CMD_SHIFT 13 +#define MEMCTL_CMD_RCLK_OFF 0 +#define MEMCTL_CMD_RCLK_ON 1 +#define MEMCTL_CMD_CHFREQ

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915: Parameterize MI_PREDICATE registers

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:24PM -0800, Matt Roper wrote: The various MI_PREDICATE registers have per-engine instances. Today we only utilize the RCS0 instance of each, but that will likely change in the future; switch to parameterized register definitions to make these easier to work with goi

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/perf: Express OA register ranges with i915_range

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:22PM -0800, Matt Roper wrote: Let's use 'struct i915_range' to express sets of b-counter and mux registers in the perf code. This makes the code more similar to how we handle things like multicast register ranges, forcewake tables, shadow tables, etc. and also lets

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Parameterize R_PWR_CLK_STATE register definition

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:23PM -0800, Matt Roper wrote: At the moment we only use R_PWR_CLK_STATE in the context of the RCS engine, but upcoming support for compute engines will start using instances relative to the CCS engine base offsets. Let's parameterize the register and move it to the

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/perf: Move OA regs to their own header

2022-01-26 Thread Lucas De Marchi
On Mon, Jan 24, 2022 at 06:08:21PM -0800, Matt Roper wrote: The OA unit registers are only used by the perf code; move them to their own header file. Cc: Jani Nikula Cc: Umesh Nerlige Ramappa Cc: Lionel Landwerlin Signed-off-by: Matt Roper I checked the output from git show --color-moved t

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-26 Thread Teres Alexis, Alan Previn
Thanks Jani for taking the time to review... 1. apologies on the const issue, this is my bad, i think it was one of the comments from earlier rev not sure how i missed it. Will fix this on next rev. 2. I do have a question below on the const for one of specific types of tables. Need your though

[Intel-gfx] ✗ Fi.CI.BAT: failure for Initial support for small BAR recovery

2022-01-26 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery URL : https://patchwork.freedesktop.org/series/99370/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11146 -> Patchwork_22114 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Clean up PIPESRC defines

2022-01-26 Thread Ville Syrjälä
On Wed, Jan 26, 2022 at 04:42:52PM +0200, Jani Nikula wrote: > On Fri, 12 Nov 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use REG_GENMASK() & co. when dealing with PIPESRC. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/i9xx_plane.c| 4 ++-- > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial support for small BAR recovery

2022-01-26 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery URL : https://patchwork.freedesktop.org/series/99370/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial support for small BAR recovery

2022-01-26 Thread Patchwork
== Series Details == Series: Initial support for small BAR recovery URL : https://patchwork.freedesktop.org/series/99370/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8c8317fbf210 drm: improve drm_buddy_alloc function -:399: WARNING:AVOID_BUG: Avoid crashing the kernel - try u

[Intel-gfx] [PATCH 18/19] drm/i915/guc: Convert __guc_ads_init to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Now that all the called functions from __guc_ads_init() are converted to use ads_map, stop using ads_blob in __guc_ads_init(). Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu

[Intel-gfx] [PATCH 15/19] drm/i915/guc: Prepare for error propagation

2022-01-26 Thread Lucas De Marchi
Currently guc_mmio_reg_add() relies on having enough memory available in the array to add a new slot. It uses `GEM_BUG_ON(count >= regset->size);` to protect going above the threshold. In order to allow guc_mmio_reg_add() to handle the memory allocation by itself, it must return an error in case o

[Intel-gfx] [PATCH 08/19] drm/i915/guc: Convert engine record to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use dma_buf_map to read fields from the dma_blob so access to IO and system memory is abstracted away. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/uc/intel_gu

[Intel-gfx] [PATCH 14/19] drm/i915/guc: Convert capture list to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use dma_buf_map to write the fields ads.capture_*. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 10 +- 1 file changed, 5 insertion

[Intel-gfx] [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-01-26 Thread Lucas De Marchi
The ADS initialitazion was using 2 passes to calculate the regset sent to GuC to initialize each engine: the first pass to just have the final object size and the second to set each register in place in the final gem object. However in order to maintain an ordered set of registers to pass to guc,

[Intel-gfx] [PATCH 19/19] drm/i915/guc: Remove plain ads_blob pointer

2022-01-26 Thread Lucas De Marchi
Now we have the access to content of GuC ADS either using dma_buf_map API or using a temporary buffer. Remove guc->ads_blob as there shouldn't be updates using the bare pointer anymore. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Cerao

[Intel-gfx] [PATCH 10/19] drm/i915/guc: Convert guc_ads_private_data_reset to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use dma_buf_map_memset() to zero the private data as ADS may be either on system or IO memory. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c

[Intel-gfx] [PATCH 17/19] drm/i915/guc: Convert guc_mmio_reg_state_init to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Now that the regset list is prepared, convert guc_mmio_reg_state_init() to use dma_buf_map to copy the array to the final location and initialize additional fields in ads.reg_state_list. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Cera

[Intel-gfx] [PATCH 12/19] drm/i915/guc: Replace check for golden context size

2022-01-26 Thread Lucas De Marchi
In the other places in this function, guc->ads_map is being protected from access when it's not yet set. However the last check is actually about guc->ads_golden_ctxt_size been set before. These checks should always match as the size is initialized on the first call to guc_prep_golden_context(), b

[Intel-gfx] [PATCH 07/19] drm/i915/guc: Convert policies update to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use dma_buf_map to write the policies update so access to IO and system memory is abstracted away. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/uc/intel_guc_ad

[Intel-gfx] [PATCH 11/19] drm/i915/guc: Convert golden context prep to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use the saved ads_map to prepare the golden context. One difference from the init context is that this function can be called before there is a gem object (and thus the guc->ads_map) to calculare the size of the golden context that should be allocated for that object. So in this case the function

[Intel-gfx] [PATCH 03/19] drm/i915/gt: Add helper for shmem copy to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Add a variant of shmem_read() that takes a dma_buf_map pointer rather than a plain pointer as argument. It's mostly a copy __shmem_rw() but adapting the api and removing the write support since there's currently only need to use dma_buf_map as destination. Reworking __shmem_rw() to share the imple

[Intel-gfx] [PATCH 05/19] drm/i915/guc: Add read/write helpers for ADS blob

2022-01-26 Thread Lucas De Marchi
Add helpers on top of dma_buf_map_read_field() / dma_buf_map_write_field() functions so they always use the right arguments and make code easier to read. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas

[Intel-gfx] [PATCH 13/19] drm/i915/guc: Convert mapping table to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Use dma_buf_map to write the fields system_info.mapping_table[][]. Since we already have the info_map around where needed, just use it instead of going through guc->ads_map. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio S

[Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-26 Thread Lucas De Marchi
In certain situations it's useful to be able to read or write to an offset that is calculated by having the memory layout given by a struct declaration. Usually we are going to read/write a u8, u16, u32 or u64. Add a pair of macros dma_buf_map_read_field()/dma_buf_map_write_field() to calculate th

[Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-26 Thread Lucas De Marchi
Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper Cc: Sumit Semwal Cc: Christian König Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.lin

[Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-26 Thread Lucas De Marchi
When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copies the struct and add the offset to the proper address. Cc: Sumit Semwal Cc: Christian König Cc: linux-me...@vge

[Intel-gfx] [PATCH 06/19] drm/i915/guc: Convert golden context init to dma_buf_map

2022-01-26 Thread Lucas De Marchi
Now the map is saved during creation, so use it to initialize the golden context, reading from shmem and writing to either system or IO memory. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi

[Intel-gfx] [PATCH 00/19] drm/i915/guc: Refactor ADS access to use dma_buf_map

2022-01-26 Thread Lucas De Marchi
While porting i915 to arm64 we noticed some issues accessing lmem. Some writes were getting corrupted and the final state of the buffer didn't have exactly what we wrote. This became evident when enabling GuC submission: depending on the number of engines the ADS struct was being corrupted and GuC

[Intel-gfx] [PATCH 04/19] drm/i915/guc: Keep dma_buf_map of ads_blob around

2022-01-26 Thread Lucas De Marchi
Convert intel_guc_ads_create() and initialization to use dma_buf_map rather than plain pointer and save it in the guc struct. This will help with additional updates to the ads_blob after the creation/initialization by abstracting the IO vs system memory. Cc: Matt Roper Cc: Thomas Hellström Cc: D

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Cancel requests immediately

2022-01-26 Thread Matthew Brost
On Wed, Jan 26, 2022 at 10:58:46AM -0800, John Harrison wrote: > On 1/24/2022 07:01, Matthew Brost wrote: > > Change the preemption timeout to the smallest possible value (1 us) when > > disabling scheduling to cancel a request and restore it after > > cancellation. This not only cancels the reques

Re: [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Fix execlists request cancellation corner case

2022-01-26 Thread Matthew Brost
On Wed, Jan 26, 2022 at 11:03:24AM -0800, John Harrison wrote: > On 1/24/2022 07:01, Matthew Brost wrote: > > More than 1 request can be submitted to a single ELSP at a time if > > multiple requests are ready run to on the same context. When a request > > is canceled it is marked bad, an idle pulse

Re: [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message

2022-01-26 Thread Lucas De Marchi
On Wed, Jan 26, 2022 at 08:24:54PM +0200, Jani Nikula wrote: On Tue, 25 Jan 2022, Lucas De Marchi wrote: Only x86 and in some cases PPC have support added in drm_cache.c for the clflush class of functions. However warning once is sufficient to taint the log instead of spamming it with "Architec

Re: [Intel-gfx] [2/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-26 Thread Teres Alexis, Alan Previn
Thanks for the offline run through of all the corner cases we are trying to handle through below codes. Reviewed-by: Alan Previn ...alan On Mon, 2022-01-24 at 18:01 -0800, Umesh Nerlige Ramappa wrote: > GuC updates shared memory and KMD reads it. Since this is not > synchronized, we run int

Re: [Intel-gfx] [PATCH 18/20] drm/i915/uapi: forbid ALLOC_TOPDOWN for error capture

2022-01-26 Thread kernel test robot
to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Auld/Initial-support-for-small-BAR-recovery/20220126-232640 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-a013-202201

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove all frontbuffer tracking calls from the gem code URL : https://patchwork.freedesktop.org/series/99365/ State : success == Summary == CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22113 Sum

Re: [Intel-gfx] [PATCH 18/20] drm/i915/uapi: forbid ALLOC_TOPDOWN for error capture

2022-01-26 Thread kernel test robot
to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Auld/Initial-support-for-small-BAR-recovery/20220126-232640 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a002-202201

[Intel-gfx] [PATCH v2] drm/i915/display/vrr: Reset VRR capable property on a long hpd

2022-01-26 Thread Manasi Navare
With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings. When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit in the DPCD. Currently the driver parses that onevery HPD but fails to reset the corresponding VRR Capable Connector property. Henc

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adlp: Fix TypeC PHY-ready status readout

2022-01-26 Thread Imre Deak
On Wed, Jan 26, 2022 at 06:47:33PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/adlp: Fix TypeC PHY-ready status readout > URL : https://patchwork.freedesktop.org/series/99359/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rpl-s: Add stepping info (rev4)

2022-01-26 Thread Matt Roper
On Wed, Jan 26, 2022 at 02:30:38AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/rpl-s: Add stepping info (rev4) > URL : https://patchwork.freedesktop.org/series/99162/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_11135_full -> Patchwork_22105_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove all frontbuffer tracking calls from the gem code URL : https://patchwork.freedesktop.org/series/99365/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add GuC Error Capture Support (rev5)

2022-01-26 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support (rev5) URL : https://patchwork.freedesktop.org/series/97187/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22112 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Fix execlists request cancellation corner case

2022-01-26 Thread John Harrison
On 1/24/2022 07:01, Matthew Brost wrote: More than 1 request can be submitted to a single ELSP at a time if multiple requests are ready run to on the same context. When a request is canceled it is marked bad, an idle pulse is triggered to the engine (high priority kernel request), the execlists s

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Cancel requests immediately

2022-01-26 Thread John Harrison
On 1/24/2022 07:01, Matthew Brost wrote: Change the preemption timeout to the smallest possible value (1 us) when disabling scheduling to cancel a request and restore it after cancellation. This not only cancels the request as fast as possible, it fixes a bug where the preemption timeout is 0 whi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add GuC Error Capture Support (rev5)

2022-01-26 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support (rev5) URL : https://patchwork.freedesktop.org/series/97187/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GuC Error Capture Support (rev5)

2022-01-26 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support (rev5) URL : https://patchwork.freedesktop.org/series/97187/ State : warning == Summary == $ dim checkpatch origin/drm-tip 233b325e5a87 drm/i915/guc: Update GuC ADS size for error capture lists -:32: WARNING:FILE_PATH_CHANGES: added, m

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adlp: Fix TypeC PHY-ready status readout

2022-01-26 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Fix TypeC PHY-ready status readout URL : https://patchwork.freedesktop.org/series/99359/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22111 Summary ---

Re: [Intel-gfx] [PATCH 02/20] drm: implement top-down allocation method

2022-01-26 Thread Robert Beckett
On 26/01/2022 15:21, Matthew Auld wrote: From: Arunpravin Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation.

Re: [Intel-gfx] [CI] drm/i915/rpl-s: Add stepping info

2022-01-26 Thread Jani Nikula
On Tue, 25 Jan 2022, Anusha Srivatsa wrote: > Add stepping-substepping info in > accordance to BSpec changes. > Though it looks weird, the revision ID > for the newer stepping is indeed backwards > and is in accordance to the spec. > > v2: Rearrange the platforms in logical order (Matt) > > Bspec:

Re: [Intel-gfx] [PATCH 1/3] drm: Stop spamming log with drm_cache message

2022-01-26 Thread Jani Nikula
On Tue, 25 Jan 2022, Lucas De Marchi wrote: > Only x86 and in some cases PPC have support added in drm_cache.c for the > clflush class of functions. However warning once is sufficient to taint > the log instead of spamming it with "Architecture has no drm_cache.c > support" every few millisecond.

Re: [Intel-gfx] [PATCH] drm/i915/display/vrr: Reset VRR capable property on a long hpd

2022-01-26 Thread Navare, Manasi
On Fri, Jan 14, 2022 at 02:33:29PM +0200, Jani Nikula wrote: > On Wed, 12 Jan 2022, Manasi Navare wrote: > > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel > > settings. > > When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore > > MSA bit > > in th

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Update GuC ADS size allocation to include space for > the lists of error state capture register descriptors. > > Also, populate the lists of registers we want GuC to report back to > Host on engine reset events. This list should include global, > engine-cl

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Add device specific tables and register lists to cover different engines > class types for GuC error state capture for XE_LP products. > > Also, add runtime allocation and freeing of extended register lists > for registers that need steering identifiers th

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/string_helpers: Add a few string helpers (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: lib/string_helpers: Add a few string helpers (rev2) URL : https://patchwork.freedesktop.org/series/99030/ State : success == Summary == CI Bug Log - changes from CI_DRM_11145 -> Patchwork_22110 Summary ---

Re: [Intel-gfx] [PATCH v5 01/10] drm/i915/guc: Update GuC ADS size for error capture lists

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Alan Previn wrote: > Update GuC ADS size allocation to include space for > the lists of error state capture register descriptors. > > Also, populate the lists of registers we want GuC to report back to > Host on engine reset events. This list should include global, > engine-cl

Re: [Intel-gfx] [PATCH v2 4/5] mei: gsc: add runtime pm handlers

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 05:58:06PM +0200, Alexander Usyskin wrote: > From: Tomas Winkler > > Implement runtime handlers for mei-gsc, to track > idle state of the device properly. > > CC: Rodrigo Vivi > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin > --- > drivers/misc/mei/g

Re: [Intel-gfx] [PATCH v2 2/5] mei: add support for graphics system controller (gsc) devices

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 05:58:04PM +0200, Alexander Usyskin wrote: > From: Tomas Winkler > > GSC is a graphics system controller, based on CSE, it provides > a chassis controller for graphics discrete cards, as well as it > supports media protection on selected devices. > > mei_gsc binds to a au

Re: [Intel-gfx] [PATCH 01/20] drm: improve drm_buddy_alloc function

2022-01-26 Thread Jani Nikula
On Wed, 26 Jan 2022, Matthew Auld wrote: > From: Arunpravin > > - Make drm_buddy_alloc a single function to handle > range allocation and non-range allocation demands > > - Implemented a new function alloc_range() which allocates > the requested power-of-two block comply with range limitation

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for lib/string_helpers: Add a few string helpers (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: lib/string_helpers: Add a few string helpers (rev2) URL : https://patchwork.freedesktop.org/series/99030/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/string_helpers: Add a few string helpers (rev2)

2022-01-26 Thread Patchwork
== Series Details == Series: lib/string_helpers: Add a few string helpers (rev2) URL : https://patchwork.freedesktop.org/series/99030/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7b5dcbd538bd lib/string_helpers: Consolidate string helpers implementation f129a0e5877f drm/i915:

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix oops due to missing stack depot

2022-01-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix oops due to missing stack depot URL : https://patchwork.freedesktop.org/series/99353/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11141_full -> Patchwork_22109_full

Re: [Intel-gfx] [PATCH v5 4/5] drm/i915: add gtt misalignment test

2022-01-26 Thread Robert Beckett
On 26/01/2022 14:05, Thomas Hellström (Intel) wrote: On 1/25/22 20:35, Robert Beckett wrote: add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel te

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: enforce min GTT alignment for discrete cards

2022-01-26 Thread Robert Beckett
On 26/01/2022 15:45, Thomas Hellström (Intel) wrote: On 1/25/22 20:35, Robert Beckett wrote: From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the ty

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: add needs_compact_pt flag

2022-01-26 Thread Robert Beckett
On 26/01/2022 13:49, Thomas Hellström (Intel) wrote: On 1/25/22 20:35, Robert Beckett wrote: From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only in

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: enforce min GTT alignment for discrete cards

2022-01-26 Thread Intel
On 1/25/22 20:35, Robert Beckett wrote: From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update

[Intel-gfx] [PATCH 20/20] HAX: DG1 small BAR

2022-01-26 Thread Matthew Auld
Just for CI. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 5 ++--- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_create.c b/drivers/gpu/drm/i915/gem/i915_gem_c

  1   2   >