Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/898
[CARBONDATA-1033] Fixed complex data type in CarbonSource
Analysis: Earlier the flow to get TableModel was different for CarbonSource
which cause the create table to fail in case of complex
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/919
[CARBONDATA-1056] Added check for starting dictionary server
Analysis: If all the dictionary columns are marked as dictionary exclude
then the dictionary generator is not created for that
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/925
[CARBONDATA-1064] Updated null check for right expression in not in
expression
Analysis: Right expression value was null in NotInExpression which cased
the select query to throw
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/933
[CARBON DATA-1075] Close Dictionary Server when application ends
Analysis: The dictionary server which is started when a load is done with
"single_pass=true" is never closed whic
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/933
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/948
[CARBONDATA-1093] During single pass load user data is printed in logs
If the server fails to respond to the client then the client throws a
timeout exception and the user data is printed in
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/948
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/948
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/948
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/948
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1001
[CARBONDATA-1135] Added partition column info in describe formatted
Currently the partition columns are not listed in describe formatted
command.
This PR will enable the listing of
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1011#discussion_r121313761
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestDDLForPartitionTable.scala
---
@@ -122,6
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1011#discussion_r121313629
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestDDLForPartitionTable.scala
---
@@ -122,6
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1011#discussion_r121313645
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestDDLForPartitionTable.scala
---
@@ -122,6
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1031
[CARBONDATA-1170] Added condition to skip single_pass for first load
The user should not be able to load using "single_pass"="true" for the
first load instead the load wou
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1031
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1040
[CARBONDATA-1171] Added support for show partitions DDL
This PR will give support for show partitions DDL.
Example:- show partitions .
You can merge this pull request into a Git
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1040
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1053
[CARBONDATA-1188] fixed codec for UpscaleFloatingCodec
When the table has a column with double datatype then in
UpscaleFloatingCodec that value is being converted to float in the following
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1053
@jackylk is there a test file in which i can add the test case or should i
create a new one??
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1053#discussion_r122912709
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -96,8 +96,7 @@ public void update
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1053
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1040
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1053
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1053
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1040
@jackylk changes have been made. Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123463416
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/ShowPartitionInfoExample.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123465686
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -170,6 +171,7 @@ object CarbonIUDAnalysisRule
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123466861
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,95
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123467182
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,95
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123466013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -203,6 +205,7 @@ case class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123466992
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,95
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123463948
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala
---
@@ -0,0 +1,157
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123463537
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ShowPartitionInfoExample.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123466148
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,98
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123464378
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,95
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1042#discussion_r123465927
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,98
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1094#discussion_r123987774
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala
---
@@ -0,0 +1,188
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1094#discussion_r123987699
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1094#discussion_r123987965
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,52
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1094#discussion_r123987924
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/ShowCarbonPartitionsCommand.scala
---
@@ -0,0 +1,51
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1053
@jackylk @kumarvishal09 Please review again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1097
[WIP] [CARBONDATA-1229] Skip dictionary and data writing if table is dropped
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1118
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1153
[CARBONDATA-1229]acquired meta.lock during table drop
This PR will restrict the table from getting dropped if a load is in
progress
You can merge this pull request into a Git repository by
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1166
[CARBONDATA-1305] Added limit for external dictionary values
Analysis: During dictionary creation the dictionary values are kept in a
HashSet. When the size of hashset reaches more than
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1168
[CARBONDATA-1229] restrict drop when loading is in progress
This PR will restrict the table from getting dropped if a load is in progres
You can merge this pull request into a Git
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1168#discussion_r127120097
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -738,27 +739,26 @@ private[sql] case
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1097
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1201
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1201
[CARBONDATA-1326] Fixed normal/low priority findbug issues
Fixed normal/low priority findbug issues in the code
You can merge this pull request into a Git repository by running:
$ git
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1168
@jackylk done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1201
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1097
@manishgupta88 @gvramana review this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1097
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1166
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1097
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1166
retest this please
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1201
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1097
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1365
[WIP] move Load command to seperate file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata dataload_refactor
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1373
[CARBONDATA-1490] Fixed memory allocation for carbon row
Analysis: While creating carbon row the space for measures is assigned
based on outputLength and not on measureCount which will tend
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1375
[CARBONDATA-1288] skip single_pass if dictionary column is not present
Analysis: If none of the columns in the table have dictionary encoding then
no need to go to single_pass flow as it will
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1375
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1420
Fixed IntermediateFileMerger for decimal types
Analysis: casting bigdecimal to byte[] was throwing ClassCastException in
IntermediateFileMerger.
Solution: Use DataType
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
@jackylk test case added..Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1420#discussion_r145643832
--- Diff:
processing/src/test/java/org/apache/carbondata/processing/sort/sortdata/IntermediateFileMergerTest.java
---
@@ -0,0 +1,104
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
@jackylk added integration test instead of unit test.
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1428
[WIP] Drop agg support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata drop_agg_support
Alternatively you can review
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1428
retest this please
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1428
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1443
[CARBONDATA-1524[CARBONDATA-1525] Added support for aggregate table drop
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1443
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1446
[CARBONDATA-1520] [PreAgg] Support pre-aggregate table load
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
@ravipesala This test is passing on my local
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1420
@ravipesala Please review.. The build is randomly failing.
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2381
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2643
LGTM
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2655
[WIP][TEST] sk ak test
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/2655
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
@ravipesala Please review.
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
@ravipesala fixed the comments
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2623#discussion_r212869553
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -79,6 +80,7 @@
@Override
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2623
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2667
[CARBONDATA-2865] Fix StackOverflowException during compaction in migrated
store
**Problem:**
When compaction is fired on migrated partition table, PartitionSpec object
is unnecessarily
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2678
[WIP] Multi user support for SDK on S3
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2678
@ravipesala Please review, Fixed failing test cases
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2465
@jackylk Yes i am working on this. Just need to fix the build. Will do it
soon
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2678
@ravipesala Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2697#discussion_r215862792
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -225,7 +225,7 @@ protected void
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2678
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198665
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -76,20 +77,29
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198687
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -35,7 +37,8 @@
/**
* It is called to load the
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198700
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -354,6 +364,22 @@ private
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198714
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonIndexFileReader.java
---
@@ -79,6 +80,17 @@ public void openThriftReader(String
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216198723
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/ThriftReader.java ---
@@ -87,6 +88,15 @@ public void open() throws IOException
201 - 300 of 763 matches
Mail list logo
