[GitHub] [commons-statistics] chtompki commented on issue #17: STATISTICS-7

chtompki commented on issue #17: STATISTICS-7 URL: https://github.com/apache/commons-statistics/pull/17#issuecomment-502323597 Figure'd that I'd start the conversation here. :-) Good work plugging along with all of this..

[GitHub] [commons-statistics] chtompki opened a new pull request #17: STATISTICS-7

chtompki opened a new pull request #17: STATISTICS-7 URL: https://github.com/apache/commons-statistics/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (CSV-235) WRONG Implementation for RFC4180

[ https://issues.apache.org/jira/browse/CSV-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864480#comment-16864480 ] Sebb commented on CSV-235: -- RFC4180 only supports 'escaping' for the DQ character. The DQ cannot be used to escape

[jira] [Resolved] (CSV-243) CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs

[ https://issues.apache.org/jira/browse/CSV-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CSV-243. -- Resolution: Fixed dd5de38 CSV-243 CSVFormat withTrim() and withIgnoreSurroundingSpaces() > CSVFormat withTrim() and

[GitHub] [commons-statistics] aherbert opened a new pull request #16: Upgrade junit5

aherbert opened a new pull request #16: Upgrade junit5 URL: https://github.com/apache/commons-statistics/pull/16 This removes all JUnit 4. Migration was straight forward: - Add JUnit 5 Bill-of-materials (BOM) and dependencies to pom to support JUnit 4 - Updated all the

[jira] [Work logged] (DAEMON-243) Support for Failure Recovery

[ https://issues.apache.org/jira/browse/DAEMON-243?focusedWorklogId=260680=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260680 ] ASF GitHub Bot logged work on DAEMON-243: - Author: ASF GitHub Bot

[GitHub] [commons-daemon] markt-asf closed pull request #6: DAEMON-243: Failure of Windows service when child process fails

markt-asf closed pull request #6: DAEMON-243: Failure of Windows service when child process fails URL: https://github.com/apache/commons-daemon/pull/6 This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-daemon] markt-asf commented on issue #6: DAEMON-243: Failure of Windows service when child process fails

markt-asf commented on issue #6: DAEMON-243: Failure of Windows service when child process fails URL: https://github.com/apache/commons-daemon/pull/6#issuecomment-502238431 This had already been resolved in DAEMON-302 This

[jira] [Work logged] (DAEMON-399) apxStrUnQuoteInplaceA removes needed quotes

[ https://issues.apache.org/jira/browse/DAEMON-399?focusedWorklogId=260678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260678 ] ASF GitHub Bot logged work on DAEMON-399: - Author: ASF GitHub Bot

[GitHub] [commons-daemon] markt-asf closed pull request #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes

markt-asf closed pull request #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes URL: https://github.com/apache/commons-daemon/pull/9 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-daemon] markt-asf commented on issue #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes

markt-asf commented on issue #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes URL: https://github.com/apache/commons-daemon/pull/9#issuecomment-502237941 A variation (that also removed all the unused code) has been applied and will be in 1.1.1 onwards.

[jira] [Resolved] (CSV-242) CSVFormat equals() and hashCode() don't use all fields

[ https://issues.apache.org/jira/browse/CSV-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CSV-242. -- Resolution: Fixed Fixed by: 605bc01 CSV-242 CSVFormat equals() and hash() don't use all fields c683594 CSV-242

[jira] [Updated] (CSV-242) CSVFormat equals() and hashCode() don't use all fields

[ https://issues.apache.org/jira/browse/CSV-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CSV-242: - Summary: CSVFormat equals() and hashCode() don't use all fields (was: CSVFormat equals() and hash() don't use all fields)

[jira] [Resolved] (DAEMON-397) jsvc on macOS cannot find libjli.dylib when home is OpenJDK 10 or 11

[ https://issues.apache.org/jira/browse/DAEMON-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-397. Resolution: Fixed Fix Version/s: 1.1.1 Thanks for the patch. Applied. > jsvc on macOS

[GitHub] [commons-csv] coveralls edited a comment on issue #44: Post release fixes

coveralls edited a comment on issue #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#issuecomment-501905854 [](https://coveralls.io/builds/24002845) Coverage increased (+1.7%) to 92.543% when

[jira] [Resolved] (DAEMON-297) Show jsvc path in debug output

[ https://issues.apache.org/jira/browse/DAEMON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-297. Resolution: Fixed Fix Version/s: 1.1.1 The check for "/" is not validation. Logically, such

[GitHub] [commons-numbers] coveralls edited a comment on issue #48: [WIP] perform the actual migration to JUnit 5

coveralls edited a comment on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-500176439 [](https://coveralls.io/builds/24001890) Coverage

[jira] [Resolved] (JEXL-305) Script debugger produces incorrect syntax

[ https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-305. Resolution: Fixed Changeset: 4ffa7acc032f58cdf484f4ceae1283111cf1c3b5 Author:henrib Date:

[GitHub] [commons-numbers] aherbert commented on issue #48: [WIP] perform the actual migration to JUnit 5

aherbert commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502141328 @Schamschi I would try locally just removing these lines: ``` org.junit.platform junit-platform-runner

[jira] [Comment Edited] (JEXL-305) Script debugger produces incorrect syntax

[ https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864163#comment-16864163 ] Henri Biestro edited comment on JEXL-305 at 6/14/19 2:50 PM: - Found a

[jira] [Reopened] (JEXL-305) Script debugger produces incorrect syntax

[ https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro reopened JEXL-305: Found a regression case. > Script debugger produces incorrect syntax >

[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes

aherbert commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293838167 ## File path: src/main/java/org/apache/commons/csv/CSVParser.java ## @@ -495,13 +495,14 @@ private Headers createHeaders() throws

[jira] [Created] (CSV-243) CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs

Sebb created CSV-243: Summary: CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs Key: CSV-243 URL: https://issues.apache.org/jira/browse/CSV-243 Project: Commons CSV Issue Type:

[jira] [Created] (CSV-242) CSVFormat equals() and hash() don't use all fields

Sebb created CSV-242: Summary: CSVFormat equals() and hash() don't use all fields Key: CSV-242 URL: https://issues.apache.org/jira/browse/CSV-242 Project: Commons CSV Issue Type: Bug

[GitHub] [commons-numbers] Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5

Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502118743 @grimreaper PR [#36](https://github.com/apache/commons-numbers/pull/36) has been merged into master. Since you said it's OK if the

[jira] [Commented] (CSV-177) Support trimming leading and trailing blanks

[ https://issues.apache.org/jira/browse/CSV-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864091#comment-16864091 ] Sebb commented on CSV-177: -- AFAICT withTrim() only affects the printer, not the parser > Support trimming leading

[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry

[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864083#comment-16864083 ] Rod Widdowson commented on DAEMON-329: -- You knew this anyway, but this works like a dream.  We'll

[jira] [Commented] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma

[ https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864038#comment-16864038 ] Gary Gregory commented on CSV-228: -- We will need a reproducible test case, preferably in the form of a PR.

[jira] [Commented] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma

[ https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864034#comment-16864034 ] Sebb commented on CSV-228: -- According to my reading of RFC4180[1], the fields between delimiters are either either

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293795559 ## File path: pom.xml ## @@ -153,8 +153,9 @@ CSV files of various types. 3.0.0 ${basedir}/LICENSE-header.txt -

[jira] [Updated] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma

[ https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CSV-228: - Summary: CSVParser extracts columns wrong in case of space before quoted col name with comma (was: CSVParser exctracts

[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes

aherbert commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293785511 ## File path: pom.xml ## @@ -153,8 +153,9 @@ CSV files of various types. 3.0.0 ${basedir}/LICENSE-header.txt -

[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes

aherbert commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293781762 ## File path: src/main/java/org/apache/commons/csv/CSVParser.java ## @@ -495,13 +495,14 @@ private Headers createHeaders() throws

[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes

aherbert commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r29319 ## File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java ## @@ -1471,4 +1471,31 @@ public void

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293771920 ## File path: pom.xml ## @@ -153,8 +153,9 @@ CSV files of various types. 3.0.0 ${basedir}/LICENSE-header.txt -

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772548 ## File path: src/main/java/org/apache/commons/csv/CSVParser.java ## @@ -495,13 +495,14 @@ private Headers createHeaders()

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772905 ## File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java ## @@ -1471,4 +1471,31 @@ public void

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772934 ## File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java ## @@ -1471,4 +1471,31 @@ public void

[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes

garydgregory commented on a change in pull request #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772010 ## File path: pom.xml ## @@ -202,6 +203,31 @@ CSV files of various types. false + +

[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry

[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863859#comment-16863859 ] Rod Widdowson commented on DAEMON-329: -- Awesome mark.  Thanks.  > Can procrun detect the JVM

[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry

[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863833#comment-16863833 ] Mark Thomas commented on DAEMON-329: It should work for any value of JavaHome under the procrun

[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry

[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863784#comment-16863784 ] Rod Widdowson commented on DAEMON-329: -- [~markt], can I ask a follow up question?  Just this week [I