[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394536#comment-17394536
]
L commented on VFS-807:
---
[~ggregory]: thanks for pushing the tests.
As for "the tests pass without the change to
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634949
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893998646
@aherbert , @XenoAmess if there are no other comments/feedback, I'll merge
this PR next week or week after :+1:
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634942=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634942
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
coveralls edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-846470672
[![Coverage
Status](https://coveralls.io/builds/41950090/badge)](https://coveralls.io/builds/41950090)
Coverage decreased (-0.2%) to 97.865% when pulling
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634934=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634934
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893966587
Thanks for your review, @kinow ! And I appreciate your efforts in tracing
the pseudo-code and creating more confidence in its correctness for those of us
who didn't
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634922
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari edited a comment on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893949018
@kinow ,
> ... zooming-in as much as I could into the pseudocode of algorithm C.
I agree that the paper, being printed a long time ago, is not as
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634921=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634921
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893949018
@kinow ,
> ... zooming-in as much as I could into the pseudocode of algorithm C.
I agree that the paper, being printed a long time ago, is not as clean as
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634920=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634920
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893945166
Hi @ali-ghanbari
Thanks for the prompt reply. I went out for lunch, and am back to whiteboard
(literally a small whiteboard). Where I'm having fun after zooming-in as
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634917
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893941483
Thank you @kinow once again for your review, refactoring, and constructive
feedback :+1:
I checked the comments. Hopefully, I have answered all of them. Please
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634915
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683888330
##
File path:
src/test/java/org/apache/commons/text/jmh/LongestCommonSubsequencePerformance.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634914
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
ali-ghanbari commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683888067
##
File path:
src/main/java/org/apache/commons/text/similarity/LongestCommonSubsequence.java
##
@@ -29,36 +29,109 @@
*
*
*
- * This
coveralls commented on pull request #193:
URL: https://github.com/apache/commons-math/pull/193#issuecomment-893933178
[![Coverage
Status](https://coveralls.io/builds/41948519/badge)](https://coveralls.io/builds/41948519)
Coverage increased (+0.01%) to 90.487% when pulling
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634905
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#issuecomment-893057654
[![Coverage
Status](https://coveralls.io/builds/41948306/badge)](https://coveralls.io/builds/41948306)
Coverage increased (+0.009%) to 95.004% when
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634871
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683855155
##
File path:
src/main/java/org/apache/commons/text/similarity/LongestCommonSubsequence.java
##
@@ -29,36 +29,109 @@
*
*
*
- * This
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634868=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634868
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683853652
##
File path:
src/main/java/org/apache/commons/text/similarity/LongestCommonSubsequence.java
##
@@ -29,36 +29,109 @@
*
*
*
- * This
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634864=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634864
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683851199
##
File path:
src/main/java/org/apache/commons/text/similarity/LongestCommonSubsequence.java
##
@@ -29,36 +29,109 @@
*
*
*
- * This
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634862
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683849914
##
File path:
src/test/java/org/apache/commons/text/jmh/LongestCommonSubsequencePerformance.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634860
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683839207
##
File path: src/test/resources/lcs-perf-analysis-inputs.csv
##
@@ -0,0 +1,5 @@
+"This code is free software; you can redistribute it and/or modify
[
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634844=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634844
]
ASF GitHub Bot logged work on TEXT-212:
---
Author: ASF GitHub Bot
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893866771
Placeholder ticket: https://issues.apache.org/jira/browse/TEXT-212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Bruno P. Kinoshita created TEXT-212:
---
Summary: A More Efficient Implementation for Calculating Size of
Longest Common Subsequence
Key: TEXT-212
URL: https://issues.apache.org/jira/browse/TEXT-212
kinow commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-893866228
Rebased PR onto latest `master`. Diff in GH UI now showing only code added
for this PR. Also amending commit now to include the JIRA ticket.
--
This is an automated message
Alex Herbert created RNG-159:
Summary: ZigguratSampler.NormalizedGaussian has incorrect Gaussian
output
Key: RNG-159
URL: https://issues.apache.org/jira/browse/RNG-159
Project: Commons RNG
arturobernalg commented on a change in pull request #193:
URL: https://github.com/apache/commons-math/pull/193#discussion_r683735800
##
File path:
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/SimpleCurveFitter.java
##
@@ -187,10 +187,7 @@ public
[
https://issues.apache.org/jira/browse/LANG-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394274#comment-17394274
]
Hubert Wojciechowski commented on LANG-1593:
Changes are ready.
Please review when you will
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634754=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634754
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683724884
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4858,6 +5127,38 @@ public static String join(final short[] array, final
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634752=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634752
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634751=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634751
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683719682
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4307,13 +4481,48 @@ public static String join(final int[] array, final
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683719485
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4818,13 +5052,48 @@ public static String join(final short[] array, final
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634750=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634750
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683718647
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4858,6 +5127,38 @@ public static String join(final short[] array, final
aherbert commented on a change in pull request #193:
URL: https://github.com/apache/commons-math/pull/193#discussion_r683685310
##
File path:
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/SimpleCurveFitter.java
##
@@ -187,10 +187,7 @@ public int
[
https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=634705=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634705
]
ASF GitHub Bot logged work on MATH-1573:
Author: ASF GitHub Bot
arturobernalg closed pull request #177:
URL: https://github.com/apache/commons-math/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg opened a new pull request #193:
URL: https://github.com/apache/commons-math/pull/193
* Simplify bitwise
* Simplify boolean expression
* Simplify conditional expression
* Redundant 'if' statement
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/MATH-1572?focusedWorklogId=634682=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634682
]
ASF GitHub Bot logged work on MATH-1572:
Author: ASF GitHub Bot
arturobernalg closed pull request #176:
URL: https://github.com/apache/commons-math/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394206#comment-17394206
]
Gary D. Gregory commented on VFS-807:
-
i [~klv_m72]
I pushed your tests and the same fix as Commons IO
dependabot[bot] opened a new pull request #209:
URL: https://github.com/apache/commons-vfs/pull/209
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.44 to
8.45.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's
garydgregory merged pull request #208:
URL: https://github.com/apache/commons-vfs/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/MATH-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394018#comment-17394018
]
Gilles Sadowski commented on MATH-1618:
---
bq. [...] {{AbstractGeneticAlgorithm}} [...]
With what
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634430
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
coveralls commented on pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#issuecomment-893057654
[![Coverage
Status](https://coveralls.io/builds/41915872/badge)](https://coveralls.io/builds/41915872)
Coverage increased (+0.009%) to 95.003% when pulling
garydgregory merged pull request #255:
URL: https://github.com/apache/commons-io/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=634241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634241
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub Bot
coveralls edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-891708225
[![Coverage
Status](https://coveralls.io/builds/41898328/badge)](https://coveralls.io/builds/41898328)
Coverage increased (+0.0005%) to 86.355% when
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=634206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634206
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub Bot
matthijsln commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892573540
Wrapping a byte array in a `ByteBuffer` is the most efficient. In the
following implementation an array copy is only needed when hitting EOF:
```
public
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=634162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634162
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub Bot
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892526508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017191
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -4858,6 +5127,38 @@ public static String join(final short[] array,
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=634076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634076
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=634071=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634071
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub Bot
matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892573540
The "no copy buffer" version can be more efficient by only calling
`Arrays.copyOf()` when hitting EOF. This avoids copying the byte array when it
is completely
[
https://issues.apache.org/jira/browse/DBCP-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393735#comment-17393735
]
Bruno P. Kinoshita commented on DBCP-509:
-
Hi Gary,
Unfortunately this is one of those issues I
[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633968
]
ASF GitHub Bot logged work on COMPRESS-584:
---
Author: ASF GitHub Bot
PeterAlfredLee commented on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-893209493
This current implemention looks good to me now.
For the "no copy buffer" version, it looks more efficient. But I'm not quite
sure about this. I will try to
73 matches
Mail list logo