[GitHub] [flink] wanglijie95 commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-17 Thread GitBox
wanglijie95 commented on a change in pull request #12181: URL: https://github.com/apache/flink/pull/12181#discussion_r426375851 ## File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java ## @@ -27,18 +27,31 @@ import org.junit.Rule;

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12193: URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659 ## CI report: * a36bef2ce9bc2c3724217931c5d30b212e8ef856 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11837: URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896 ## CI report: * 2b6338c91d9a1e176fcedf3b1f45dcc1adc0059c Azure:

[GitHub] [flink] curcur commented on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-17 Thread GitBox
curcur commented on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-629949773 BTW, I have updated the javaDocs, and pushed. This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot edited a comment on pull request #12199: [FLINK-17774] [table] supports all kinds of changes for select result

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12199: URL: https://github.com/apache/flink/pull/12199#issuecomment-629793563 ## CI report: * 3a1729c5513f3a86af9e6b9d0dec00325e375c7b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12192: [FLINK-17758][runtime] Remove unused AdaptedRestartPipelinedRegionStrategyNG

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12192: URL: https://github.com/apache/flink/pull/12192#issuecomment-629673624 ## CI report: * 27144288995d450def38b46b6f526fb023620af4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12208: URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875 ## CI report: * f25b5668db8f6c57472286fd839ed8a548ee051b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12103: [FLINK-16998][core] Add a changeflag to Row

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12103: URL: https://github.com/apache/flink/pull/12103#issuecomment-627456433 ## CI report: * 05ab513e7a7aed7481001668eecddf26b8fd05cb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11837: [FLINK-16160][table-planner-blink] Fix proctime()/rowtime() doesn't w…

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11837: URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896 ## CI report: * 2b6338c91d9a1e176fcedf3b1f45dcc1adc0059c Azure:

[jira] [Closed] (FLINK-17669) Use new WatermarkStrategy/WatermarkGenerator in Kafka connector

2020-05-17 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17669. Resolution: Fixed master: 5be27b090c80e97c611db83e04b5d82a8abced9d > Use new

[jira] [Closed] (FLINK-17661) Add APIs for using new WatermarkStrategy/WatermarkGenerator

2020-05-17 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17661. Resolution: Fixed master: d755e1b4e7252f968e0a66836353f30b2e4f64bd > Add APIs for using

[jira] [Closed] (FLINK-17766) Use checkpoint lock instead of fine-grained locking in Kafka AbstractFetcher

2020-05-17 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17766. Resolution: Fixed master: 59714b9d6addb1dbf2171cab937a0e3fec52f2b1 > Use checkpoint lock

[jira] [Closed] (FLINK-17658) Add new TimestampAssigner and WatermarkGenerator interfaces

2020-05-17 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17658. Resolution: Fixed master: 12b984f13a11c0f314d060dc7267e11e60e4930e > Add new

[jira] [Closed] (FLINK-17659) Add common watermark strategies and WatermarkStrategies helper

2020-05-17 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17659. Resolution: Fixed master: eaef2d7f7acfd9b2063d1c421c97ad521734536b > Add common

[GitHub] [flink] klion26 commented on pull request #12174: [FLINK-17736] Add flink cep example

2020-05-17 Thread GitBox
klion26 commented on pull request #12174: URL: https://github.com/apache/flink/pull/12174#issuecomment-629945677 @dengziming thanks for the contribution. But, as the [contribute guild](https://flink.apache.org/contributing/contribute-code.html#create-jira-ticket-and-reach-consensus) said,

[GitHub] [flink] aljoscha closed pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

2020-05-17 Thread GitBox
aljoscha closed pull request #12147: URL: https://github.com/apache/flink/pull/12147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] aljoscha commented on pull request #12147: [FLINK-17653] FLIP-126: Unify (and separate) Watermark Assigners

2020-05-17 Thread GitBox
aljoscha commented on pull request #12147: URL: https://github.com/apache/flink/pull/12147#issuecomment-629944823 Thanks for the patient review! I merged this This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot edited a comment on pull request #12199: [FLINK-17774] [table] supports all kinds of changes for select result

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12199: URL: https://github.com/apache/flink/pull/12199#issuecomment-629793563 ## CI report: * 3a1729c5513f3a86af9e6b9d0dec00325e375c7b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12103: [FLINK-16998][core] Add a changeflag to Row

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12103: URL: https://github.com/apache/flink/pull/12103#issuecomment-627456433 ## CI report: * 05ab513e7a7aed7481001668eecddf26b8fd05cb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * d8b233f483d45b8901cc28770be9da71a39929ef Azure:

[GitHub] [flink] twalthr commented on a change in pull request #12201: [hotfix] Remove raw class usages in Configuration.

2020-05-17 Thread GitBox
twalthr commented on a change in pull request #12201: URL: https://github.com/apache/flink/pull/12201#discussion_r426365127 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ## @@ -909,12 +909,10 @@ private void

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-17 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r426365219 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointListener.java ## @@ -38,4 +38,12 @@ * @throws Exception

[jira] [Closed] (FLINK-17029) Introduce a new JDBC connector with new property keys

2020-05-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-17029. --- Fix Version/s: 1.11.0 Resolution: Fixed master (1.11.0): ce843a2e601cbc2ddba8d3feacaa930aea810877 >

[GitHub] [flink] wuchong closed pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-17 Thread GitBox
wuchong closed pull request #12176: URL: https://github.com/apache/flink/pull/12176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] guoweiM edited a comment on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

2020-05-17 Thread GitBox
guoweiM edited a comment on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629923445 HI @aljoscha , 1. First of all, I think you are right we should merge to master after all the participants agree with the pr. 2. I could split the commit to two

[jira] [Closed] (FLINK-16999) Data structure should cover all conversions declared in logical types

2020-05-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-16999. Fix Version/s: 1.11.0 Resolution: Fixed > Data structure should cover all conversions

[jira] [Commented] (FLINK-16999) Data structure should cover all conversions declared in logical types

2020-05-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109828#comment-17109828 ] Timo Walther commented on FLINK-16999: -- Enabled in 1.11.0: adfd45fbbd826488e6a00cc8d8f6436fa2179579

[jira] [Commented] (FLINK-15792) Make Flink logs accessible via kubectl logs per default

2020-05-17 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109827#comment-17109827 ] Yang Wang commented on FLINK-15792: --- Just like what we have discussed in the PR[1] of FLINK-17166, we

[GitHub] [flink] TsReaper commented on pull request #12202: [FLINK-14807][table] Support collecting query results under all execution and network environments

2020-05-17 Thread GitBox
TsReaper commented on pull request #12202: URL: https://github.com/apache/flink/pull/12202#issuecomment-629936566 Azure passed in https://dev.azure.com/tsreaper96/Flink/_build/results?buildId=27=results This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #12203: [FLINK-17687][tests] Collect TM log files before tearing down Mesos

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12203: URL: https://github.com/apache/flink/pull/12203#issuecomment-629845268 ## CI report: * 9e6f064d217572b17f71450b6397b5587691551c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12193: URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659 ## CI report: * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12192: [FLINK-17758][runtime] Remove unused AdaptedRestartPipelinedRegionStrategyNG

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12192: URL: https://github.com/apache/flink/pull/12192#issuecomment-629673624 ## CI report: * 15ca64e3a20101239b30b90064f3b0f35238c828 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * d8b233f483d45b8901cc28770be9da71a39929ef Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12171: [FLINK-17715][sql client] Supports function DDLs in SQL-CLI

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12171: URL: https://github.com/apache/flink/pull/12171#issuecomment-629218919 ## CI report: * f807fd2e590f6bc6fe0a8022c94486a96de3dcb4 Azure:

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-17 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r426360979 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@

[jira] [Commented] (FLINK-14255) Integrate hive to streaming file sink

2020-05-17 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109820#comment-17109820 ] Jingsong Lee commented on FLINK-14255: -- master(parquet and orc): 

[GitHub] [flink] JingsongLi merged pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi merged pull request #12206: URL: https://github.com/apache/flink/pull/12206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] JingsongLi commented on pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi commented on pull request #12206: URL: https://github.com/apache/flink/pull/12206#issuecomment-629934589 Thanks @lirui-apache for the review, merging... This is an automated message from the Apache Git Service. To

[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-17 Thread GitBox
zhuzhurk commented on a change in pull request #12181: URL: https://github.com/apache/flink/pull/12181#discussion_r426358510 ## File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java ## @@ -198,4 +211,27 @@ public void

[GitHub] [flink] yangyichao-mango closed pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango closed pull request #12196: URL: https://github.com/apache/flink/pull/12196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango commented on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629932611 That is the result after execute sh docs/check_links.sh. Thx for review. @klion26

[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango commented on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629932483 > @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh

[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12208: URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875 ## CI report: * f25b5668db8f6c57472286fd839ed8a548ee051b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12207: [hotfix][doc] Fix broken link in the native Kubernetes document

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12207: URL: https://github.com/apache/flink/pull/12207#issuecomment-629928836 ## CI report: * ac05af3e3c748efa3478dab616be670578721f92 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12206: URL: https://github.com/apache/flink/pull/12206#issuecomment-629916046 ## CI report: * 521334c523a5004883f94e1fb996cdd18081500c UNKNOWN * 2ea5f52f890c9cb5728fd7772f59bea4b38f07ca Azure:

[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango commented on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629932386 > @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12193: URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659 ## CI report: * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 216b86cf20cccbc2462b36c8edc5b5a396ebd3c0 Azure:

[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango commented on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629932115 ![image](https://user-images.githubusercontent.com/29545877/82173155-dd4abf80-98fe-11ea-8f36-5f10f6f10781.png)

[GitHub] [flink] yangyichao-mango removed a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
yangyichao-mango removed a comment on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629932115 ![image](https://user-images.githubusercontent.com/29545877/82173155-dd4abf80-98fe-11ea-8f36-5f10f6f10781.png)

[GitHub] [flink] flinkbot edited a comment on pull request #12192: [FLINK-17758][runtime] Remove unused AdaptedRestartPipelinedRegionStrategyNG

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12192: URL: https://github.com/apache/flink/pull/12192#issuecomment-629673624 ## CI report: * 15ca64e3a20101239b30b90064f3b0f35238c828 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-613252882 ## CI report: * 066795205734add3b142a92c687c98b25253985e UNKNOWN * 4536aff7587de64758b09c03e9fa295926d8d9cb Azure:

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-17 Thread Eui Heo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109795#comment-17109795 ] Eui Heo edited comment on FLINK-17077 at 5/18/20, 3:48 AM: --- Thanks for your

[GitHub] [flink] flinkbot commented on pull request #12207: [hotfix][doc] Fix broken link in the native Kubernetes document

2020-05-17 Thread GitBox
flinkbot commented on pull request #12207: URL: https://github.com/apache/flink/pull/12207#issuecomment-629928836 ## CI report: * ac05af3e3c748efa3478dab616be670578721f92 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
flinkbot commented on pull request #12208: URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875 ## CI report: * f25b5668db8f6c57472286fd839ed8a548ee051b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Commented] (FLINK-17493) Possible direct memory leak in cassandra sink

2020-05-17 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109803#comment-17109803 ] Xintong Song commented on FLINK-17493: -- [~nobleyd], That sounds like memory leak to me. What I'm

[GitHub] [flink] curcur commented on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-17 Thread GitBox
curcur commented on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-629925937 Thank you both so much! This is my very first feature and it means a lot to me. I am especially impressed by the level of code integrity @AHeise insists. The code quality is

[jira] [Commented] (FLINK-16267) Flink uses more memory than taskmanager.memory.process.size in Kubernetes

2020-05-17 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109802#comment-17109802 ] Xintong Song commented on FLINK-16267: -- [~trystan] I'm sorry for your confusion. As [~azagrebin]

[GitHub] [flink] flinkbot edited a comment on pull request #12171: [FLINK-17715][sql client] Supports function DDLs in SQL-CLI

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12171: URL: https://github.com/apache/flink/pull/12171#issuecomment-629218919 ## CI report: * 14bc25ea3f1f55ff6d6d67cbca3b02199a2bee31 Azure:

[jira] [Assigned] (FLINK-17786) Cannot switch dialect in SQL CLI

2020-05-17 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-17786: Assignee: Rui Li > Cannot switch dialect in SQL CLI > >

[jira] [Created] (FLINK-17786) Cannot switch dialect in SQL CLI

2020-05-17 Thread Rui Li (Jira)
Rui Li created FLINK-17786: -- Summary: Cannot switch dialect in SQL CLI Key: FLINK-17786 URL: https://issues.apache.org/jira/browse/FLINK-17786 Project: Flink Issue Type: Bug Components:

[GitHub] [flink] zhuzhurk commented on a change in pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-17 Thread GitBox
zhuzhurk commented on a change in pull request #12181: URL: https://github.com/apache/flink/pull/12181#discussion_r426350896 ## File path: flink-core/src/test/java/org/apache/flink/core/fs/SafetyNetCloseableRegistryTest.java ## @@ -27,18 +27,31 @@ import org.junit.Rule;

[GitHub] [flink] JingsongLi commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi commented on a change in pull request #12206: URL: https://github.com/apache/flink/pull/12206#discussion_r426350492 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java ## @@ -205,4 +208,10 @@

[jira] [Created] (FLINK-17785) Refactor orc shim to create a OrcShimFactory in hive

2020-05-17 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17785: Summary: Refactor orc shim to create a OrcShimFactory in hive Key: FLINK-17785 URL: https://issues.apache.org/jira/browse/FLINK-17785 Project: Flink Issue

[GitHub] [flink] guoweiM commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

2020-05-17 Thread GitBox
guoweiM commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629923445 HI @aljoscha , 1. First of all, I think you are right we should merge to master after all the participants agree with the pr. 2. I could split the commit to two commits:

[jira] [Created] (FLINK-17784) Better detection for parquet and orc in hive

2020-05-17 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17784: Summary: Better detection for parquet and orc in hive Key: FLINK-17784 URL: https://issues.apache.org/jira/browse/FLINK-17784 Project: Flink Issue Type:

[GitHub] [flink] JingsongLi commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi commented on a change in pull request #12206: URL: https://github.com/apache/flink/pull/12206#discussion_r426350298 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java ## @@ -143,21 +206,51 @@ public

[GitHub] [flink] klion26 commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master

2020-05-17 Thread GitBox
klion26 commented on pull request #12196: URL: https://github.com/apache/flink/pull/12196#issuecomment-629922624 @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p `

[jira] [Comment Edited] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-17 Thread Eui Heo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109795#comment-17109795 ] Eui Heo edited comment on FLINK-17077 at 5/18/20, 3:11 AM: --- Thanks for your

[GitHub] [flink] flinkbot commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
flinkbot commented on pull request #12208: URL: https://github.com/apache/flink/pull/12208#issuecomment-629921803 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-17077) FLINK_CONF_DIR environment variable to locate flink-conf.yaml in Docker container

2020-05-17 Thread Eui Heo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109795#comment-17109795 ] Eui Heo commented on FLINK-17077: - Thanks for your review. The original motivation of this issue is

[GitHub] [flink] cshuo commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
cshuo commented on pull request #12208: URL: https://github.com/apache/flink/pull/12208#issuecomment-629921395 @godfreyhe @JingsongLi It's appreciated if you can have a look. This is an automated message from the Apache Git

[jira] [Updated] (FLINK-17651) DecomposeGroupingSetsRule generates wrong plan when there exist distinct agg and simple agg with same filter

2020-05-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17651: --- Labels: pull-request-available (was: ) > DecomposeGroupingSetsRule generates wrong plan

[GitHub] [flink] JingsongLi commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi commented on a change in pull request #12206: URL: https://github.com/apache/flink/pull/12206#discussion_r426348785 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java ## @@ -205,4 +208,10 @@

[jira] [Closed] (FLINK-17700) The callback client of JavaGatewayServer should run in a daemon thread

2020-05-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-17700. --- Resolution: Fixed Merged to - release-1.10 via 2bc4628876715698c9bae542e36014344a93c42b - release-1.9 via

[GitHub] [flink] cshuo opened a new pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

2020-05-17 Thread GitBox
cshuo opened a new pull request #12208: URL: https://github.com/apache/flink/pull/12208 …es wrong plan when there exist distinct agg and simple agg with same filter. ## What is the purpose of the change DecomposeGroupingSetsRule may generates wrong plan when there exist distinct

[GitHub] [flink] JingsongLi commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
JingsongLi commented on a change in pull request #12206: URL: https://github.com/apache/flink/pull/12206#discussion_r426348623 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/write/HiveOutputFormatFactory.java ## @@ -0,0

[jira] [Updated] (FLINK-17700) The callback client of JavaGatewayServer should run in a daemon thread

2020-05-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-17700: Fix Version/s: (was: 1.10.0) (was: 1.9.0) 1.9.4

[GitHub] [flink] dianfu closed pull request #12166: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-17 Thread GitBox
dianfu closed pull request #12166: URL: https://github.com/apache/flink/pull/12166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] dianfu commented on pull request #12166: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-17 Thread GitBox
dianfu commented on pull request #12166: URL: https://github.com/apache/flink/pull/12166#issuecomment-629920883 Merged via 6ce59a8719d721f40aaf6551a91489a74683ddc5 This is an automated message from the Apache Git Service. To

[GitHub] [flink] zhuzhurk edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

2020-05-17 Thread GitBox
zhuzhurk edited a comment on pull request #12193: URL: https://github.com/apache/flink/pull/12193#issuecomment-629920503 @GJL @tillrohrmann this PR and #12192 are to remove unused legacy failover strategies. There is no behavior change nor interface change. Would you take a look?

[GitHub] [flink] flinkbot edited a comment on pull request #12171: [FLINK-17715][sql client] Supports function DDLs in SQL-CLI

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12171: URL: https://github.com/apache/flink/pull/12171#issuecomment-629218919 ## CI report: * 14bc25ea3f1f55ff6d6d67cbca3b02199a2bee31 Azure:

[GitHub] [flink] lirui-apache commented on a change in pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
lirui-apache commented on a change in pull request #12206: URL: https://github.com/apache/flink/pull/12206#discussion_r426342495 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveRowDataPartitionComputer.java ## @@ -0,0

[GitHub] [flink] zhuzhurk commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

2020-05-17 Thread GitBox
zhuzhurk commented on pull request #12193: URL: https://github.com/apache/flink/pull/12193#issuecomment-629920503 @GJL @tillrohrmann this PR and #12193 are to remove unused legacy failover strategies. There is no behavior change nor interface change. Would you take a look?

[GitHub] [flink] flinkbot edited a comment on pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12206: URL: https://github.com/apache/flink/pull/12206#issuecomment-629916046 ## CI report: * 521334c523a5004883f94e1fb996cdd18081500c UNKNOWN * 2ea5f52f890c9cb5728fd7772f59bea4b38f07ca UNKNOWN Bot commands The

[GitHub] [flink] flinkbot edited a comment on pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12176: URL: https://github.com/apache/flink/pull/12176#issuecomment-629283127 ## CI report: * e006fa3ad7437b5fc9e4089630f7a17c21367971 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-613252882 ## CI report: * 066795205734add3b142a92c687c98b25253985e UNKNOWN * 4536aff7587de64758b09c03e9fa295926d8d9cb Azure:

[GitHub] [flink] dianfu closed pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-17 Thread GitBox
dianfu closed pull request #12165: URL: https://github.com/apache/flink/pull/12165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] dianfu commented on pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-17 Thread GitBox
dianfu commented on pull request #12165: URL: https://github.com/apache/flink/pull/12165#issuecomment-629920046 Merged via 2bc4628876715698c9bae542e36014344a93c42b This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #12207: [hotfix][doc] Fix broken link in the native Kubernetes document

2020-05-17 Thread GitBox
flinkbot commented on pull request #12207: URL: https://github.com/apache/flink/pull/12207#issuecomment-629919994 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] wangyang0918 opened a new pull request #12207: [hotfix][doc] Fix broken link in the native Kubernetes document

2020-05-17 Thread GitBox
wangyang0918 opened a new pull request #12207: URL: https://github.com/apache/flink/pull/12207 Fix the broken link in the native Kubernetes document. The "its tags" link in the follow part is broken.

[GitHub] [flink] wangyang0918 commented on pull request #12207: [hotfix][doc] Fix broken link in the native Kubernetes document

2020-05-17 Thread GitBox
wangyang0918 commented on pull request #12207: URL: https://github.com/apache/flink/pull/12207#issuecomment-629919426 cc @azagrebin This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (FLINK-17783) Add array,map,row types support for orc row writer

2020-05-17 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17783: Summary: Add array,map,row types support for orc row writer Key: FLINK-17783 URL: https://issues.apache.org/jira/browse/FLINK-17783 Project: Flink Issue

[jira] [Created] (FLINK-17782) Add array,map,row types support for parquet row writer

2020-05-17 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17782: Summary: Add array,map,row types support for parquet row writer Key: FLINK-17782 URL: https://issues.apache.org/jira/browse/FLINK-17782 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #12202: [FLINK-14807][table] Support collecting query results under all execution and network environments

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12202: URL: https://github.com/apache/flink/pull/12202#issuecomment-629806443 ## CI report: * 9385209a72fa1314e604a3998a149d93a12617d9 UNKNOWN * 1b46780c0bf016a524a379cec83d120563ddcb9d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #12176: URL: https://github.com/apache/flink/pull/12176#issuecomment-629283127 ## CI report: * e006fa3ad7437b5fc9e4089630f7a17c21367971 Azure:

[GitHub] [flink] flinkbot commented on pull request #12206: [FLINK-14255][hive] Integrate hive to streaming file sink with parquet and orc

2020-05-17 Thread GitBox
flinkbot commented on pull request #12206: URL: https://github.com/apache/flink/pull/12206#issuecomment-629916046 ## CI report: * 521334c523a5004883f94e1fb996cdd18081500c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-05-17 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 216b86cf20cccbc2462b36c8edc5b5a396ebd3c0 Azure:

[GitHub] [flink-web] yangjf2019 commented on a change in pull request #268: [FLINK-13343][docs-zh] Translate "Contribute Code" page into Chinese

2020-05-17 Thread GitBox
yangjf2019 commented on a change in pull request #268: URL: https://github.com/apache/flink-web/pull/268#discussion_r426343712 ## File path: contributing/contribute-code.zh.md ## @@ -136,91 +136,91 @@ Apache Flink is maintained, improved, and extended by code contributions of

[GitHub] [flink] curcur commented on a change in pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-17 Thread GitBox
curcur commented on a change in pull request #11725: URL: https://github.com/apache/flink/pull/11725#discussion_r426343289 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/shuffle/FlinkKafkaShuffle.java ## @@ -0,0

  1   2   3   4   5   6   >