Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/763#issuecomment-108262606
looks good, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/434#issuecomment-108278253
Hey @andralungu!
I think we should close this one. We can't really continue from this state
anyway. I guess we'll have to revisit this problem once w
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-108283573
Hey @balidani!
Would you like to finish this up?
It's not really urgent, but it's almost finished and it'd be a pity to
abandon :)
Someone else
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-108284020
Hey @joey001!
Are you still working on this? Let us know if you need help!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/818#discussion_r32374703
--- Diff: docs/libs/gelly_guide.md ---
@@ -240,6 +240,7 @@ Graph networkWithWeights =
network.joinWithEdgesOnSource(v
+* Difference
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/818#discussion_r32374715
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1234,6 +1234,18 @@ public void coGroup(Iterable> edge,
Itera
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-111759442
Hi @shghatge! Thank you for the PR!
I left you a couple of comments. Let us know if you have questions :)
---
If your project is set up for it, you can reply to this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111760267
Hey @andralungu,
I'm not sure I understand this one. It's a coGroup of vertices with the
edges. For the vertex iterator to be empty, doesn't it me
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/770#discussion_r32374939
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasure.java
---
@@ -66,34 +63,47 @@ public static void main
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/770#issuecomment-111760796
+1 except the minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111762942
Then shouldn't we throw an exception like we do in degrees with a "The edge
src/trg id is invalid" or something, instead of hiding the exception?
---
If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111993642
@andralungu, I believe the same issue appears in
`ApplyCoGroupFunctionOnAllEdges` and `ApplyCoGroupFunction`. Could you check if
that's the case and fix those t
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-112095145
Hi @andralungu, @shghatge,
I'm a bit confused by your changes.. Why did you add a new `removeVertices`
API method for DataSet?
I thought we had agreed that
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-112814353
Hey,
difference in not a fancy way of removing vertices, no :)
If you recall our previous conversation in #678, we decided to have
add/remove methods for small
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-112923172
Hi @shghatge!
For this issue, I think we should only add the `difference` method. If you
want to avoid duplicating code, you can always define a private helper
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/779#issuecomment-112933533
+1, looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-112940323
Perfect, thanks @andralungu! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672727
--- Diff: docs/libs/gelly_guide.md ---
@@ -102,6 +102,15 @@ DataSet> edgeTuples =
env.readCsvFile("path/to/ed
Graph graph = Graph.fromTupl
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672805
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672827
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672972
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672778
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673063
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32672995
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673105
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673158
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673221
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673274
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673330
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,58 @@ public void flatMap(Edge edge,
Collector>
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673548
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32673806
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674930
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674923
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674967
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32675011
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674944
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674993
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32674908
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32676277
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-112954221
Hey @shghatge,
this is a great first try, you got the logic right and I really like the
detailed javadocs ^^
I left a few inline comments, which should be easy
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r32679424
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,388 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114422736
Hey,
I also checked this over the weekend!
(and realized how rusty my Scala has gotten :-S)
I agree with both of you on the scaladocs, docs and
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/818#discussion_r33026720
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1234,6 +1248,17 @@ public void coGroup(Iterable> edge,
Itera
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-114430160
Hi @shghatge!
Thank you for the quick update. Apart from my minor comment, this looks
good now :)
---
If your project is set up for it, you can reply to this email
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114426618
Oh, one more thing :)
In order to make this work in Eclipse, I had to add a few lines to the
pom.xml.
Basically, I copied the `` block from the streaming-scala
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/865
[FLINK-2271] [FLINK-1522] [gelly] add missing example tests
This PR adds missing Gelly tests for PageRank and MusicProfiles examples.
It also changes both vertex-centric and GSA PageRank examples to
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/863#issuecomment-115194215
Thank you @samk3211! This looks good :)
I see that like here, @mjsax has also created a utils class for the new
comparison methods in #866.
Since all migrated
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-115215460
Thank you @shghatge! I'll merge this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/865#issuecomment-115252595
Thank you for looking at this @mxm :) I'll merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/765#issuecomment-118161158
Hi there!
What is the status of this PR?
It seems that travis is failing with checkstyle violations related to using
spaces instead of tabs.
Let us know if you
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/801#discussion_r33820633
--- Diff: docs/apis/zip_elements_guide.md ---
@@ -63,4 +63,44 @@ env.execute()
will yield the tuples: (0,A), (1,B), (2,C), (3,D), (4,E), (5,F
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/801#issuecomment-118164049
Great work @andralungu, +1 from me!
Make sure you squash your commits and appropriately update the commit
message before merging ;)
---
If your project is set up for
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33822502
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,471 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33822653
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,471 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33823666
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationITCase.java
---
@@ -54,16 +75,13 @@ public void
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33823849
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationWithMapperITCase.java
---
@@ -52,16 +72,13 @@ public void
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-118173012
Hi @shghatge! Thank you for the update :)
I left some comments inline. There are still some formatting issues in the
code. Please, carefully go through your
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33826389
--- Diff: docs/libs/gelly_guide.md ---
@@ -734,6 +737,24 @@ public static final class Apply {
{% endhighlight %}
+The following example
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-118179278
Hi @shghatge!
This looks good in general.
Apart from my small inline comment, I have an objection regarding the added
example. If I understand correctly, this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-118180990
In my view it's a straight-forward configuration option. If the user wants
to propagate changes in this direction, they set the parameter.
Also, I'm seeing
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/883#issuecomment-118181248
Hi @samk3211! Thank you for spotting this :)
Can you please (1) close #881, (2) add this comment also to GSAPageRank as
@andralungu (3) squash your commits to a single
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33951120
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/GatherSumApplyIteration.java
---
@@ -367,6 +394,20 @@ public void join(Vertex
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-118912040
Hi @shghatge, @andralungu!
I left one comment that I think is quite serious. Apart from that, I had
also left a minor comment on the gelly-guide changes in the last
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/765#issuecomment-119744587
Hi @mfahimazizi!
Thank you for the update.
It seems Travis is still complaining about checkstyle. Could you check
again please? You can see these errors
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/892#discussion_r34204825
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java
---
@@ -0,0 +1,249
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/892#discussion_r34204894
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java
---
@@ -0,0 +1,249
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-119750756
Hi @shghatge,
thank you for working on this! It's not a trivial problem :)
I have two general comments:
- I would prefer to see this as library m
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-120319905
Hi @shghatge!
I agree, let's deal with the approximate version as a separate issue. In
the end though, it would be nice to have a single library method a
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-120404920
You can use this PR for the exact computation, no need to open a new one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121025189
Hi @andralungu,
do you mean support for POJOs as vertex / edge values?
I guess that's a limitation we can't easily overcome, I agree.
Still though
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121033796
I hadn't realized that they would both need to be called in my previous
comment, my bad.
Any idea for decent method names? `typesNoEdgeValue` and
`typesNoVertex
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121072347
Still an overkill I think... Could another way be to have only `types(K,
VV, EV)` with all 3 arguments and expect `NullValue` if a value is missing?
---
If your project
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121215586
yes, I mean `NullValue.class` :)
I'd like to know @shghatge's opinion, too!
---
If your project is set up for it, you can reply to this email and have
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/916
[FLINK-1943] [gelly] Added GSA compiler and translation tests
Thanks @StephanEwen for the help!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-123236061
Hi @shghatge,
let me try to explain the implementation in detail here :)
First of all, can you change this to a library method instead of an
example? The
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/923#issuecomment-123394302
Hi @shghatge!
The comments I left on #892 apply here as well. The difference would be
that the neighborhoods of each of the neighbors will be represented as a
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-123402206
I see your point @shghatge.
However, I think naming just one method differently will be confusing..
If we're going to have custom method names, let'
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125112165
Hey @PieterJanVanAeken!
Are you back working on this or would you rather someone else takes over?
I think I can find some time next week to resolve remaining issues
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125132370
Perfect, thanks @PieterJanVanAeken!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-125225039
Hi @shghatge, @andralungu,
I built on the current state of this PR and made the proposed changes
above, together with some styling changes. You can see the result
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/968
[FLINK-2452] [Gelly] adds a playcount threshold to the MusicProfiles example
This PR adds a user-defined parameter to the MusicProfiles example that
filters out songs that a user has listened to only
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/326
[FLINK-1201] Add flink-gelly to flink-addons
This PR adds an initial version of Gelly, a graph API for Flink, to the
flink-addons project.
The development of Gelly took place as a collaboration on
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70725539
Hi @rmetzger! Thanks for starting on it so fast ^^
Regarding the name, we thought it'd be nice to have one.. It was actually
@ktzoumas that came up with
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70839009
Thank you all for the suggestions regarding preserving the commit history!
I'll try them out later today and see whether I can make it :)
---
If your project is set u
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71181165
Thanks a lot for looking into this @StephanEwen !
Can you share more details on how you did the filtering? Might be useful
for next time :)
Shouldn'
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71344479
Yosh! Managed to preserve history and fixed the package name:
https://github.com/vasia/flink/commits/gelly-with-history
I'm also addressing @rmetzger's comment
Github user vasia closed the pull request at:
https://github.com/apache/flink/pull/326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/335
Add flink-gelly to flink-addons (with commit history)
Hi everyone,
here's the new PR for the graph api.
I have addressed the comments of #326 and looking forward to additional
feedback!
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71491484
No worries, I can rename the tests. It's better to be consistent :)
May I ask, what is the difference between a XyzTest and a XyzITCase test
though? Thnx!
---
If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71494713
Alright, thanks @fhueske! So, it seems all of our tests are integration
test cases. I will update later today I hope :)
---
If your project is set up for it, you can reply
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71507264
Tests renamed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72372857
Right, thanks @fhueske for bringing this up!
@balidani, @andralungu, @cebe: could you please complete and sign [this
form](https://www.apache.org/licenses/icla.pdf) (if
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72883525
@balidani that's OK :)
@cebe we've got the acknowledgement for you, thanks!
@andralungu has submitted hers today.
---
If your project is set up for i
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434636
@rmetzger does this mean I need to do the history filtering magic again and
open a new pr?
@andralungu thanks a lot!
@balidani have you submitted yours?
---
If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434977
Great, thanks ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73547684
Simple renaming didn't seem to keep the history, so I did the filtering
again :)
Didn't you have the same problem when moving flink-addons to flink-staging?
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73688058
I'm getting the following error on travis:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.12.1:check (validate) on
pr
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73694315
Ha! Thanks :))
On Feb 10, 2015 1:10 PM, "zentol" wrote:
> in the pom.xml in flink-gelly; change flink-addons to flink-staging
>
>
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73749137
Thanks @balidani.
And travis tests now pass :tada:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/400#issuecomment-74493011
Hi @balidani! Thanks for the PR. The commit history is a bit messed up, but
we'll fix that. It's just the last commit that's relevant, right?
If I r
501 - 600 of 1141 matches
Mail list logo
