[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-653849751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[jira] [Updated] (HBASE-24659) Calculate FIXED_OVERHEAD automatically

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24659: -- Summary: Calculate FIXED_OVERHEAD automatically (was: Calcuate FIXED_OVERHEAD automatically) > Calcu

[GitHub] [hbase] Apache-HBase commented on pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2017: URL: https://github.com/apache/hbase/pull/2017#issuecomment-653836591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21

[GitHub] [hbase] Apache-HBase commented on pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2017: URL: https://github.com/apache/hbase/pull/2017#issuecomment-653836459 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55

[GitHub] [hbase] Apache-HBase commented on pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2017: URL: https://github.com/apache/hbase/pull/2017#issuecomment-653836281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50

[GitHub] [hbase] nyl3532016 opened a new pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-04 Thread GitBox
nyl3532016 opened a new pull request #2017: URL: https://github.com/apache/hbase/pull/2017 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151444#comment-17151444 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151434#comment-17151434 ] Hudson commented on HBASE-24625: Results for branch branch-2.2 [build #906 on b

[jira] [Commented] (HBASE-24635) Split TestMetaWithReplicas

2020-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151435#comment-17151435 ] Hudson commented on HBASE-24635: Results for branch branch-2.2 [build #906 on b

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151433#comment-17151433 ] Hudson commented on HBASE-24625: Results for branch branch-2 [build #2733 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #2010: HBASE-24391 Implement meta split

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2010: URL: https://github.com/apache/hbase/pull/2010#issuecomment-653799657 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s

[GitHub] [hbase] Apache-HBase commented on pull request #2010: HBASE-24391 Implement meta split

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2010: URL: https://github.com/apache/hbase/pull/2010#issuecomment-653799155 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s

[GitHub] [hbase] Apache-HBase commented on pull request #2010: HBASE-24391 Implement meta split

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2010: URL: https://github.com/apache/hbase/pull/2010#issuecomment-653785551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache9 commented on a change in pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-04 Thread GitBox
Apache9 commented on a change in pull request #1991: URL: https://github.com/apache/hbase/pull/1991#discussion_r449781947 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java ## @@ -497,7 +497,7 @@ public void run(MultiResponse resp) {

[jira] [Resolved] (HBASE-24635) Split TestMetaWithReplicas

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24635. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.2+. Thanks [~zghao] for reviewing

[jira] [Updated] (HBASE-24635) Split TestMetaWithReplicas

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24635: -- Fix Version/s: 2.2.6 > Split TestMetaWithReplicas > -- > > Key

[jira] [Assigned] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24625: - Assignee: chenglei > AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synce

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24625: -- Fix Version/s: 2.4.0 > AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced >

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24625: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Push

[jira] [Comment Edited] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151184#comment-17151184 ] chenglei edited comment on HBASE-24625 at 7/4/20, 1:56 PM: --- [~

[jira] [Comment Edited] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151184#comment-17151184 ] chenglei edited comment on HBASE-24625 at 7/4/20, 1:56 PM: --- [~

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-24625: - Release Note: We add a method getSyncedLength in WALProvider.WriterBase interface for WALFileLengthPr

[jira] [Updated] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-24625: - Release Note: We add a method {{getSyncedLength}} in {{WALProvider.WriterBase}} interface for {{WALFi

[GitHub] [hbase] Apache9 merged pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread GitBox
Apache9 merged pull request #1970: URL: https://github.com/apache/hbase/pull/1970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] sanjeetnishad95 commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-07-04 Thread GitBox
sanjeetnishad95 commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-653753860 ping @saintstack . Any review comments on this PR? This is an automated message from the Apache Git Servic

[GitHub] [hbase] Apache-HBase commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-653747409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39

[GitHub] [hbase] Apache-HBase commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-653746081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[jira] [Assigned] (HBASE-24680) Refactor the checkAndMutate code on the server side

2020-07-04 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki reassigned HBASE-24680: Assignee: Toshihiro Suzuki > Refactor the checkAndMutate code on the server side

[jira] [Created] (HBASE-24680) Refactor the checkAndMutate code on the server side

2020-07-04 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-24680: Summary: Refactor the checkAndMutate code on the server side Key: HBASE-24680 URL: https://issues.apache.org/jira/browse/HBASE-24680 Project: HBase I

[jira] [Updated] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-04 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24650: - Summary: Change the return types of the new checkAndMutate methods introduced in HBASE-8

[jira] [Updated] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-04 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24650: - Description: To support CheckAndMutate with Increment/Append, the new checkAndMutate met

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-653736081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151226#comment-17151226 ] Anoop Sam John commented on HBASE-23634: No need right? The WAL splitter will cr

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-653735490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2013: HBASE-24671 Add excludefile and designatedfile options to graceful_stop.sh

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2013: URL: https://github.com/apache/hbase/pull/2013#issuecomment-653734785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[jira] [Created] (HBASE-24679) HBase on Cloud Blob FS : Provide config to skip HFile archival while table deletion

2020-07-04 Thread Anoop Sam John (Jira)
Anoop Sam John created HBASE-24679: -- Summary: HBase on Cloud Blob FS : Provide config to skip HFile archival while table deletion Key: HBASE-24679 URL: https://issues.apache.org/jira/browse/HBASE-24679

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-04 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151213#comment-17151213 ] ramkrishna.s.vasudevan commented on HBASE-23634: Right. I meant async re

[GitHub] [hbase] Apache-HBase commented on pull request #2013: HBASE-24671 Add excludefile and designatedfile options to graceful_stop.sh

2020-07-04 Thread GitBox
Apache-HBase commented on pull request #2013: URL: https://github.com/apache/hbase/pull/2013#issuecomment-653733314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (HBASE-24678) Add Bulk load param details into its responseTooSlow log

2020-07-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151197#comment-17151197 ] Anoop Sam John commented on HBASE-24678: For all RPC requests, we have only comm

[jira] [Created] (HBASE-24678) Add Bulk load param details into its responseTooSlow log

2020-07-04 Thread Anoop Sam John (Jira)
Anoop Sam John created HBASE-24678: -- Summary: Add Bulk load param details into its responseTooSlow log Key: HBASE-24678 URL: https://issues.apache.org/jira/browse/HBASE-24678 Project: HBase