[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020848#comment-16020848
]
Hudson commented on HBASE-17786:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #244 (See
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008866#comment-16008866
]
Umesh Agashe commented on HBASE-17786:
--
Thanks [~busbey] for reviewing and committing the changes.
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008529#comment-16008529
]
Hudson commented on HBASE-17786:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2998 (See
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008132#comment-16008132
]
Sean Busbey commented on HBASE-17786:
-
I have time set aside today to do another round of review.
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007653#comment-16007653
]
stack commented on HBASE-17786:
---
+1 from me. [~busbey] Ok to commit sir?
> Create LoadBalancer perf-tests
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007333#comment-16007333
]
Umesh Agashe commented on HBASE-17786:
--
Errors doesn't look related!
> Create LoadBalancer
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005724#comment-16005724
]
Hadoop QA commented on HBASE-17786:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997737#comment-15997737
]
Hadoop QA commented on HBASE-17786:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997592#comment-15997592
]
Umesh Agashe commented on HBASE-17786:
--
Linked reviewboard: https://reviews.apache.org/r/59003/.
>
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997589#comment-15997589
]
Sean Busbey commented on HBASE-17786:
-
thanks! can you link to the reviewboard here and I'll use it
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997579#comment-15997579
]
Umesh Agashe commented on HBASE-17786:
--
bq. nit: the file header should use "/*" instead of "/**"
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997564#comment-15997564
]
Hadoop QA commented on HBASE-17786:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997402#comment-15997402
]
Sean Busbey commented on HBASE-17786:
-
{code}
+ // Non-default configurations.
+ private void
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997393#comment-15997393
]
Sean Busbey commented on HBASE-17786:
-
bq. What's the rationale for using System.out directly instead
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997390#comment-15997390
]
Sean Busbey commented on HBASE-17786:
-
{code}
+/**
+ * Tool to test performance of different {@link
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997352#comment-15997352
]
Sean Busbey commented on HBASE-17786:
-
{code}
+ public static final int SERVER_PORT = 61000;
...
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997346#comment-15997346
]
Sean Busbey commented on HBASE-17786:
-
{code}
+// Do round-robin assignment
{code}
Comments like
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997345#comment-15997345
]
Sean Busbey commented on HBASE-17786:
-
What's the rationale for using System.out directly instead of
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997333#comment-15997333
]
Sean Busbey commented on HBASE-17786:
-
{code}
+ public static final int DEFAULT_NUM_REGIONS =
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997327#comment-15997327
]
Sean Busbey commented on HBASE-17786:
-
{quote}
bq. Why this change to make it mutable?
I think all
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997322#comment-15997322
]
Sean Busbey commented on HBASE-17786:
-
{code}
+/**
+ * Tool to test performance of different {@link
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997316#comment-15997316
]
Sean Busbey commented on HBASE-17786:
-
{code}
index
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997318#comment-15997318
]
Umesh Agashe commented on HBASE-17786:
--
bq. Why this change to make it mutable?
I think all field
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997306#comment-15997306
]
Sean Busbey commented on HBASE-17786:
-
{code}
// Used to signal to the caller that the region(s)
[
https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994017#comment-15994017
]
Umesh Agashe commented on HBASE-17786:
--
Quote from [~mbertozzi] on internal JIRA:
This is a
25 matches
Mail list logo
