szaszm closed pull request #1727: MINIFICPP-2293 Support installing python
dependencies defined inline
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1561007673
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerf
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560985716
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560808960
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerf
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559273234
##
extensions/python/PythonCreator.h:
##
@@ -78,6 +80,11 @@ class PythonCreator : public minifi::core::CoreComponent {
class_name = full_name;
fgerlits commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1549915952
##
extensions/python/PythonCreator.h:
##
@@ -78,6 +80,11 @@ class PythonCreator : public minifi::core::CoreComponent {
class_name = full_name;
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559125910
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,43 @@
+import ast
+import sys
+import subproc
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1559125185
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerf
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1555663138
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1553992990
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,49 @@
+import ast
+import sys
+import subprocess
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1553987364
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,43 @@
+import ast
+import sys
+import subprocess
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1539519179
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerf
lordgamez commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1539359322
##
extensions/python/pythonprocessors/nifi_python_processors/utils/inline_dependency_installer.py:
##
@@ -0,0 +1,43 @@
+import ast
+import sys
+import subproc
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1532369112
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile
lordgamez opened a new pull request, #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727
https://issues.apache.org/jira/browse/MINIFICPP-2293
--
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
18 matches
Mail list logo