Integrated: JDK-8287524: Improve checkboxes to select releases on deprecated API page

2022-06-06 Thread Hannes Wallnöfer
On Wed, 1 Jun 2022 14:46:31 GMT, Hannes Wallnöfer wrote: > The original purpose of this issue was to fix the problems of elements on the > deprecated API list that can't be deselected because their release is not > included in the list of checkboxes at the top of the page. This is fixed here >

Re: RFR: JDK-8287674: CSS improvements for summary lists [v2]

2022-06-06 Thread Hannes Wallnöfer
> This is a refinement of CSS styles mostly in the deprecated and new API pages. > > - Provide a two-row table view for the new sortable three-column tables > - Make sure no line wraps are inserted between a checkbox and its label > - Slightly increase the line height of the check box row to ma

Re: RFR: JDK-8287674: CSS improvements for summary lists

2022-06-06 Thread openjdk-notifier[bot]
On Wed, 1 Jun 2022 16:16:33 GMT, Hannes Wallnöfer wrote: > This is a refinement of CSS styles mostly in the deprecated and new API pages. > > - Provide a two-row table view for the new sortable three-column tables > - Make sure no line wraps are inserted between a checkbox and its label > - S

RFR: 8286206: Missing cases for RECORD

2022-06-06 Thread Jan Lahoda
Adds handling of `ElementKind.RECORD` to JShell's code completion. - Commit messages: - 8286206: Missing cases for RECORD Changes: https://git.openjdk.java.net/jdk/pull/9042/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9042&range=00 Issue: https://bugs.openjdk.java

Re: RFR: 8286206: Missing cases for RECORD

2022-06-06 Thread Jonathan Gibbons
On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda wrote: > Adds handling of `ElementKind.RECORD` to JShell's code completion. I can't easily verify whether you have found all the necessary places to update, but I do understand/approve what I see here. On switch statements, like at JavadocHelper:701,

Re: RFR: 8286206: Missing cases for RECORD

2022-06-06 Thread Vicente Romero
On Mon, 6 Jun 2022 14:40:01 GMT, Jan Lahoda wrote: > Adds handling of `ElementKind.RECORD` to JShell's code completion. looks sensible to me - Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/9042

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Sun, 5 Jun 2022 20:55:12 GMT, Pavel Rappo wrote: >> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only >> copies one instance of the specified exception. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Sun, 5 Jun 2022 20:55:12 GMT, Pavel Rappo wrote: >> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only >> copies one instance of the specified exception. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Sun, 5 Jun 2022 20:55:12 GMT, Pavel Rappo wrote: >> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only >> copies one instance of the specified exception. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v3]

2022-06-06 Thread Jonathan Gibbons
On Fri, 3 Jun 2022 14:47:13 GMT, Pavel Rappo wrote: >> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only >> copies one instance of the specified exception. > > Pavel Rappo has updated the pull request incrementally with three additional > commits since the last revision

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:22:34 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into 8287333 >> >>This resolves a conflict in ParamTaglet.

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:24:08 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into 8287333 >> >>This resolves a conflict in ParamTaglet.

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:27:07 GMT, Jonathan Gibbons wrote: > It does more than just warn ... What else beyond converting `ParamTree`s to `Content` and warning authors about unexpected `ParamTree` does it do? Separately. Could it be that you haven't seen further commits? GitHub does not seem to

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:39:10 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into 8287333 >> >>This resolves a conflict in ParamTaglet.

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:50:05 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into 8287333 >> >>This resolves a conflict in ParamTaglet.

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v3]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 21:27:25 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Remove upper-bounded wildcard >> >>This change simplifies code without any disadvantages: >> >>

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Pavel Rappo
On Mon, 6 Jun 2022 20:43:11 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into 8287333 >> >>This resolves a conflict in ParamTaglet.

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Tue, 7 Jun 2022 01:10:24 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java >> line 206: >> >>> 204: // Of these two, only methods inherit documentation. >>> 205: // Don't waste time on constructors.

Re: RFR: JDK-8287674: CSS improvements for summary lists [v3]

2022-06-06 Thread Hannes Wallnöfer
> This is a refinement of CSS styles mostly in the deprecated and new API pages. > > - Provide a two-row table view for the new sortable three-column tables > - Make sure no line wraps are inserted between a checkbox and its label > - Slightly increase the line height of the check box row to ma

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Tue, 7 Jun 2022 00:26:13 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java >> line 237: >> >>> 235: Utils utils = writer.configuration().utils; >>> 236: Content result = writer.getOutputInstance(); >>> 237:

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v3]

2022-06-06 Thread Jonathan Gibbons
On Tue, 7 Jun 2022 00:35:56 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java >> line 92: >> >>> 90: ? utils.getTypeParamTrees(ee) >>> 91: : utils.getParamTrees(ee); >>> 92: List paramet

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Mon, 6 Jun 2022 23:31:19 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java >> line 70: >> >>> 68: */ >>> 69: private static Map mapNameToPosition(Utils utils, >>> List params) { >>> 70: Map result = new Ha

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Mon, 6 Jun 2022 23:46:05 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java >> line 209: >> >>> 207: List >>> formalParameters, >>> 208: TagletWriter

Re: RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

2022-06-06 Thread Jonathan Gibbons
On Sun, 5 Jun 2022 20:55:12 GMT, Pavel Rappo wrote: >> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only >> copies one instance of the specified exception. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request

Re: RFR: JDK-8287674: CSS improvements for summary lists [v4]

2022-06-06 Thread Hannes Wallnöfer
> This is a refinement of CSS styles mostly in the deprecated and new API pages. > > - Provide a two-row table view for the new sortable three-column tables > - Make sure no line wraps are inserted between a checkbox and its label > - Slightly increase the line height of the check box row to ma

Re: RFR: JDK-8287674: CSS improvements for summary lists [v4]

2022-06-06 Thread Hannes Wallnöfer
On Tue, 7 Jun 2022 06:21:59 GMT, Hannes Wallnöfer wrote: >> This is a refinement of CSS styles mostly in the deprecated and new API >> pages. >> >> - Provide a two-row table view for the new sortable three-column tables >> - Make sure no line wraps are inserted between a checkbox and its labe

Integrated: JDK-8287674: CSS improvements for summary lists

2022-06-06 Thread Hannes Wallnöfer
On Wed, 1 Jun 2022 16:16:33 GMT, Hannes Wallnöfer wrote: > This is a refinement of CSS styles mostly in the deprecated and new API pages. > > - Provide a two-row table view for the new sortable three-column tables > - Make sure no line wraps are inserted between a checkbox and its label > - S