Re: CFV: New Jigsaw Committer: George Triantafillou

2015-10-06 Thread Alan Bateman
On 06/10/2015 19:14, Christian Tornqvist wrote: I hereby nominate George Triantafillou to Jigsaw Committer. Would it be better to wait until George has 8 or more significant contributions (as per the guidelines)? -Alan

CFV: New Jigsaw Committer: George Triantafillou

2015-10-06 Thread Christian Tornqvist
I hereby nominate George Triantafillou to Jigsaw Committer. George has contributed new tests and made changes to the existing hotspot tests for jigsaw in the jigsaw/m3 forest, including access control tests. Votes are due by: October 20, 2015, 7:00 PST. Only current Jigsaw Committers [1]

Re: Fixes in the jlink tool

2015-10-06 Thread Andrei Eremeev
Resending. I am covered by the OCA; so I can contribute to OpenJDK. Best regards, Andrei Eremeev >Tuesday, October 6, 2015 12:40 AM +03:00 from Andrei Eremeev >: > >Hi Jigsaw team, > >Please review fixes in jlink for the following issues: >https://bugs.openjdk.java.net/browse/JDK-8135170 >http

RE: RFR: JDK-8138960 - Module version is checked incorrectly in libjimage

2015-10-06 Thread Iris Clark
Hi, Jim. >> http://cr.openjdk.java.net/~jlaskey/8138960/webrev/index.html These changes look good to me too. I assume that you'll be pushing this to verona/stage? Thanks, iris -Original Message- From: Mandy Chung Sent: Tuesday, October 06, 2015 7:26 AM To: Alan Bateman Cc: jigsaw-dev

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
> On Oct 6, 2015, at 4:38 AM, Claes Redestad wrote: > > Hi Mandy, > > On 2015-10-05 23:13, Mandy Chung wrote: >> I have been experimenting a jlink plugin to improve the module system >> startup time. On a Quad-Core Intel Xeon E5 @3.7 GHz, 16G memory (Mac Pro) >> machine, the module system s

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
See http://cr.openjdk.java.net/~mchung/jigsaw/jake-startup.20151005.pdf Mandy p.s. In fact the attachment got trimmed. > On Oct 6, 2015, at 7:31 AM, Mandy Chung wrote: > > I realize I missed the attachment after seeing Claes’ question. This > includes the heap usage after GC. > > > > > >

Re: RFR: JDK-8138960 - Module version is checked incorrectly in libjimage

2015-10-06 Thread Mandy Chung
> On Oct 6, 2015, at 6:28 AM, Alan Bateman wrote: > > > On 06/10/2015 14:22, Jim Laskey (Oracle) wrote: >> Verona pit failing do to NEXT_VERSION +1 . libjimage code assumed that the >> module version would be constant until some later date. >> >> http://cr.openjdk.java.net/~jlaskey/8138960/w

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
I realize I missed the attachment after seeing Claes’ question. This includes the heap usage after GC. > On Oct 5, 2015, at 2:13 PM, Mandy Chung wrote: > > I have been experimenting a jlink plugin to improve the module system startup > time. On a Quad-Core Intel Xeon E5 @3.7 GHz, 16G m

Re: RFR: JDK-8138960 - Module version is checked incorrectly in libjimage

2015-10-06 Thread Alan Bateman
On 06/10/2015 14:22, Jim Laskey (Oracle) wrote: Verona pit failing do to NEXT_VERSION +1 . libjimage code assumed that the module version would be constant until some later date. http://cr.openjdk.java.net/~jlaskey/8138960/webrev/index.html

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Alan Bateman
On 06/10/2015 12:38, Claes Redestad wrote: Alternatively, wouldn't it be possible for the plugin to modify the module-info.class directly? Generating the classes at link time is about eliminating the need to parse the module-info and reconstitute the module descriptors via the builder API. Th

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Claes Redestad
Hi Mandy, On 2015-10-05 23:13, Mandy Chung wrote: I have been experimenting a jlink plugin to improve the module system startup time. On a Quad-Core Intel Xeon E5 @3.7 GHz, 16G memory (Mac Pro) machine, the module system startup takes 110 ms and 75% of it is to reconstitute 64 module descri

Re: Review request 8132297: JDK9 build.tools.module.ImageBuilder does not filter out .class.bc files

2015-10-06 Thread Chris Hegarty
On 5 Oct 2015, at 23:32, Mandy Chung wrote: > JDK 9 currently use a build tool (ImageBuilder) to create the JDK modular > image. A in-house tool doing static analysis generates additional files that > should be excluded in the image. > > jlink and jmod tool in jake build has the option to exc