mjsax merged PR #14714:
URL: https://github.com/apache/kafka/pull/14714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #14714:
URL: https://github.com/apache/kafka/pull/14714#issuecomment-1842147167
Jenkins issues:
- build 7: `JDK 11 and Scala 2.13` failed
- build 6: `JDK 8 and Scala 2.12` failed
Test failures seems to be unrelated to this PR. Merging.
--
This is an
lihaosky commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1414713123
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java:
##
@@ -394,6 +394,106 @@ public void testDeterministic() {
}
mjsax commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1414683411
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareGraphConstructorTest.java:
##
@@ -97,6 +98,17 @@ private int getCost(final
lihaosky commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1409723863
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/BalanceSubtopologyGraphConstructor.java:
##
@@ -0,0 +1,186 @@
+package
mjsax commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1408740752
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareGraphConstructor.java:
##
@@ -0,0 +1,47 @@
+package
lihaosky opened a new pull request, #14714:
URL: https://github.com/apache/kafka/pull/14714
### Description
Refactor graph construction and assignment in `RackAwareAssignor` to new
interface. Will add implementation for subtopology case and unit test later
--
This is an automated
