github-actions[bot] commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1933309585
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1388376812
##
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##
@@ -130,7 +131,7 @@ class EncryptingPasswordEncoder(
val decrypted = cipher.doFinal(encryptedPasswor
jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1388381937
##
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java:
##
@@ -99,7 +100,7 @@ public void configure(Map configs) throws
KafkaException {
jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1388376812
##
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##
@@ -130,7 +131,7 @@ class EncryptingPasswordEncoder(
val decrypted = cipher.doFinal(encryptedPasswor
C0urante commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1804121753
I realize that. I think preserving the existing exception type is more
valuable (and correct) here. We'd also be dropping the stack trace for the
top-level exception (see
[ApiException:
bob-barrett commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1804101882
I dropped the changes in the Connect code, because I wasn't confident in
what the implications could be.
--
This is an automated message from the Apache Git Service.
To respond to t
bob-barrett commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1804100758
@C0urante we would keep the message in that case but not the nested
exception, so we would lose the stack trace. We actually already keep the
message, because `ConfigException` tries
C0urante commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1804080696
IMO it'd be cleaner if we could keep the same exception type. We could
concatenate the existing messages with the cause's message (if non-null); for
example:
```java
String message
jolshan commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1803010902
> None of the other changes can wind up in an API response. So for
compatibility, we should drop the DymamicBrokerConfig change, but the others
should be safe to keep. If we want to be ex
bob-barrett commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1802992442
> Looks reasonable. Just want to confirm that all of these are thrown and
not returned by any response apis?
Good point, the `DynamicBrokerConfig` change can wind up bubbling up
jolshan commented on PR #14721:
URL: https://github.com/apache/kafka/pull/14721#issuecomment-1802978156
Looks reasonable. Just want to confirm that all of these are thrown and not
returned by any response apis?
--
This is an automated message from the Apache Git Service.
To respond to the
bob-barrett commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1387343761
##
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##
@@ -20,12 +20,12 @@ import java.nio.charset.StandardCharsets
import java.security.{AlgorithmParameters
jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1387343457
##
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##
@@ -20,12 +20,12 @@ import java.nio.charset.StandardCharsets
import java.security.{AlgorithmParameters, No
bob-barrett opened a new pull request, #14721:
URL: https://github.com/apache/kafka/pull/14721
There are some places in the code where we create `ConfigException` object
by passing in a message String and an Exception. This is a standard pattern for
exceptions, but it is incorrect for `Conf
14 matches
Mail list logo
