Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16345: URL: https://github.com/apache/kafka/pull/16345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
kirktrue commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643453935 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -785,6 +805,13 @@ void removeRequest() { } } +

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
kirktrue commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643453077 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -362,7 +362,7 @@ private void transitionTo(MemberState

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
lianetm commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643448438 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -362,7 +362,7 @@ private void transitionTo(MemberState

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
lianetm commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643442351 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -785,6 +805,13 @@ void removeRequest() { } } +

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
kirktrue commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643412421 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -785,6 +805,13 @@ void removeRequest() { } } +

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
lianetm commented on PR #16345: URL: https://github.com/apache/kafka/pull/16345#issuecomment-2174253436 Thanks for the review @chia7712! All comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
lianetm commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643334957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-17 Thread via GitHub
lianetm commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1643334348 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -741,6 +756,9 @@ public void onResponse(final ClientResponse

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-16 Thread via GitHub
chia7712 commented on code in PR #16345: URL: https://github.com/apache/kafka/pull/16345#discussion_r1641765619 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest