apoorvmittal10 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1670701123
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
soarez merged PR #16532:
URL: https://github.com/apache/kafka/pull/16532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soarez commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1670656927
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669472238
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669472238
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669467090
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669467090
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
apoorvmittal10 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669355387
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
chia7712 commented on PR #16532:
URL: https://github.com/apache/kafka/pull/16532#issuecomment-2215008466
@apoorvmittal10 you had reviewed on #15966, so could you please take a look
at this PR? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
m1a2st commented on PR #16532:
URL: https://github.com/apache/kafka/pull/16532#issuecomment-2213556224
@chia7712, Thanks for your comments, add assert for size()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1668324513
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,16 @@ public void
m1a2st commented on PR #16532:
URL: https://github.com/apache/kafka/pull/16532#issuecomment-2212596673
@chia7712, Thanks for your comments, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1667732886
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,16 @@ public void
m1a2st commented on PR #16532:
URL: https://github.com/apache/kafka/pull/16532#issuecomment-2211750460
@chia7712, Thanks for your comments, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1667226563
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,52 @@ public void
chia7712 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1667176539
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,52 @@ public void
m1a2st opened a new pull request, #16532:
URL: https://github.com/apache/kafka/pull/16532
The response data should change accordingly to the input, however with the
current design, it will not change even if the input changes. We should remove
this cache logic to avoid returning wrong
chia7712 commented on PR #15966:
URL: https://github.com/apache/kafka/pull/15966#issuecomment-2208775816
close this PR @m1a2st will file another one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 closed pull request #15966: KAFKA-16684: Remove cache in responseData
URL: https://github.com/apache/kafka/pull/15966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
m1a2st commented on PR #15966:
URL: https://github.com/apache/kafka/pull/15966#issuecomment-2207562526
@chia7712, Thanks for your comments, I will open new PR for this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on PR #15966:
URL: https://github.com/apache/kafka/pull/15966#issuecomment-2206969288
```
org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not
complete execution for Gradle Test Executor 100.
at
m1a2st commented on PR #15966:
URL: https://github.com/apache/kafka/pull/15966#issuecomment-2205221490
LGTM, I wll add test after this PR merge into trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #15966:
URL: https://github.com/apache/kafka/pull/15966#issuecomment-2153290523
@johnnychhsu This is a bug fix, so please add test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
johnnychhsu commented on code in PR #15966:
URL: https://github.com/apache/kafka/pull/15966#discussion_r1629471445
##
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##
@@ -99,28 +99,24 @@ public Errors error() {
}
public LinkedHashMap
chia7712 commented on code in PR #15966:
URL: https://github.com/apache/kafka/pull/15966#discussion_r1605998588
##
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##
@@ -99,28 +99,24 @@ public Errors error() {
}
public LinkedHashMap
johnnychhsu opened a new pull request, #15966:
URL: https://github.com/apache/kafka/pull/15966
## Context
The response data should change accordingly to the input, however with the
current design, it will not change even if the input changes. We should remove
this cache logic to avoid
26 matches
Mail list logo
