soarez merged PR #16287:
URL: https://github.com/apache/kafka/pull/16287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jlprat commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2210568624
I don't have any concerns :) Go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
soarez commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2210556747
@jlprat I'd like to merge this, unless you have any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
soarez commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2207104921
Yes, @jlprat please share any issues you run into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
soarez commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2206328635
@mimaison I suspect some of the difficulty comes from the reason for this
PR: the current script is difficult to reason about.
If you think it would help with the review, I can look into
jlprat commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2203894286
I wanted to use this script to release 3.8 now that is finally unblocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
soarez commented on code in PR #16287:
URL: https://github.com/apache/kafka/pull/16287#discussion_r1636242129
##
release/notes.py:
##
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file d
jlprat commented on code in PR #16287:
URL: https://github.com/apache/kafka/pull/16287#discussion_r1635964691
##
release/notes.py:
##
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file d
soarez commented on PR #16287:
URL: https://github.com/apache/kafka/pull/16287#issuecomment-2161244497
cc @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
soarez opened a new pull request, #16287:
URL: https://github.com/apache/kafka/pull/16287
The current release script has a couple of issues:
* It's a single long file with duplicated logic, which makes it difficult to
understand and make changes
* When a command fails, the user is
10 matches
Mail list logo