Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-05 Thread via GitHub
soarez merged PR #16287: URL: https://github.com/apache/kafka/pull/16287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-05 Thread via GitHub
jlprat commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2210568624 I don't have any concerns :) Go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-05 Thread via GitHub
soarez commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2210556747 @jlprat I'd like to merge this, unless you have any concerns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-03 Thread via GitHub
soarez commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2207104921 Yes, @jlprat please share any issues you run into. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-03 Thread via GitHub
soarez commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2206328635 @mimaison I suspect some of the difficulty comes from the reason for this PR: the current script is difficult to reason about. If you think it would help with the review, I can look into

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-07-02 Thread via GitHub
jlprat commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2203894286 I wanted to use this script to release 3.8 now that is finally unblocked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-06-12 Thread via GitHub
soarez commented on code in PR #16287: URL: https://github.com/apache/kafka/pull/16287#discussion_r1636242129 ## release/notes.py: ## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file d

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-06-12 Thread via GitHub
jlprat commented on code in PR #16287: URL: https://github.com/apache/kafka/pull/16287#discussion_r1635964691 ## release/notes.py: ## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file d

Re: [PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-06-11 Thread via GitHub
soarez commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2161244497 cc @jlprat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] KAFKA-16934: Clean up and refactor release.py [kafka]

2024-06-11 Thread via GitHub
soarez opened a new pull request, #16287: URL: https://github.com/apache/kafka/pull/16287 The current release script has a couple of issues: * It's a single long file with duplicated logic, which makes it difficult to understand and make changes * When a command fails, the user is