Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Honours

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-26 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6042 --- dolphin/src/kitemviews/kitemlistcontroller.cpp

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6050 --- Thanks for the update, but could you please revert the changes w

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6056 --- This review has been submitted with commit b0db096e4a3efc58da1c

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Peter Penz
> On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: > > Thanks for the update, but could you please revert the changes with > > KGlobalSettings::changeCursorOverIcon()? I consider this option an > > unnecessary "micro-option" and plan to implement the same behavior as in > > Dolphin 1.7. > > Tir

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/ --- (Updated Aug. 27, 2011, 7:31 a.m.) Review request for KDE Base Apps and Pe

Re: Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

2011-08-27 Thread Tirtha Chatterjee
> On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: > > Thanks for the update, but could you please revert the changes with > > KGlobalSettings::changeCursorOverIcon()? I consider this option an > > unnecessary "micro-option" and plan to implement the same behavior as in > > Dolphin 1.7. Yeah su