Re: Review Request 123679: Fix build with Qt 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80075 --- src/kselectionproxymodel.cpp (line 2501)

Review Request 123679: Fix build with Qt 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

> On May 7, 2015, 7:24 a.m., Alex Richardson wrote: > > Seems like this is duplicated in a few places already so I agree we should > > add it. But won't most users of the API want only a single plugin returned? > > Maybe also add a function `KPluginMetaData > > KPluginLoader::findPluginById(con

Re: Review Request 123493: Fix leaky incubation controller

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/ --- (Updated May 7, 2015, 9:20 p.m.) Status -- This change has been mark

Re: Review Request 123492: Fix memory leak in AppletQuickItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/ --- (Updated May 7, 2015, 9:18 p.m.) Status -- This change has been mark

Re: Review Request 123677: Bring back use of KEncodingFileDialog

> On May 7, 2015, 8:48 p.m., David Rosca wrote: > > Sorry, didn't know of the bug. Should I discard this rr? > > Christoph Feck wrote: > Why? What you propose here was discussed as one possible option. Yes, but from the bug discussion it seems reverting those commits is not something that

debugfull -> debug

Hi, As with some other bits of knowledge during porting today I just share this one: https://community.kde.org/index.php?title=Calligra/Building/3&diff=42353&oldid=42349 When you use Qt4/KF5, debugfull is dead [1] so you'd be surprised debugging isn't working for you. We don't have any precise r

Re: Review Request 123677: Bring back use of KEncodingFileDialog

> On May 7, 2015, 8:48 p.m., David Rosca wrote: > > Sorry, didn't know of the bug. Should I discard this rr? Why? What you propose here was discussed as one possible option. - Christoph --- This is an automatically generated e-mail. To

Re: Review Request 123677: Bring back use of KEncodingFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/#review80059 --- Sorry, didn't know of the bug. Should I discard this rr? - Da

Re: Review Request 123677: Bring back use of KEncodingFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated May 7, 2015, 8:45 p.m.) Review request for Kate and KDE Framewor

Review Request 123677: Bring back use of KEncodingFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- Review request for KDE Frameworks. Repository: ktexteditor Description

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 2:31 p.m.) Status -- This change has been mark

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 1:15 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 7, 2015, 11:59 a.m., Sebastian Kügler wrote: > > src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml, line > > 197 > > > > > > This line may have slipped in? ouch, i pushed a commit in

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

> On May 6, 2015, 11:24 p.m., David Edmundson wrote: > > autotests/kpluginloadertest.cpp, line 357 > > > > > > not that it really matters, but invalid is spelt wrong. > > Double the invalidity. it says "inva

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

> On May 7, 2015, 7:24 a.m., Alex Richardson wrote: > > Seems like this is duplicated in a few places already so I agree we should > > add it. But won't most users of the API want only a single plugin returned? > > Maybe also add a function `KPluginMetaData > > KPluginLoader::findPluginById(con

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review80030 --- Ship it! Looks good. src/declarativeimports/plasmacomponent

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review80025 --- solved issues, still there the magic self() call, for that, an

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 9:06 a.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > src/plasma/pluginloader.cpp, line 892 > > > > > > Can this lead to containmentactions being listed twice? (I haven't seen > > it in the UI, but seems pla

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > src/plasma/pluginloader.cpp, line 826 > > > > > > Why? This remark makes it kinda magical and doesn't provide any other > > information than "rather don'

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review80013 --- Seems like this is duplicated in a few places already so I agr