aleksejshilin added a comment.
So, any comments on the updated revision?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8958
To: aleksejshilin, #frameworks
Cc: broulik, ngraham
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Thu, 07 Dec 2017 19:37:52 +
Build duration:
7 min 37 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Thu, 07 Dec 2017 19:37:52 +
Build duration:
7 min 45 sec and counting
JUnit Tests
Name:
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/26/
Project:
Frameworks baloo kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 07 Dec 2017 19:37:53 +
Build duration:
5 min 33 sec and counting
CONSOLE
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:98aa41f388f4: [RunnerManager] Dont mess with
ThreadWeaver thread count (authored by broulik).
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9240?vs=23616=23619
sitter accepted this revision.
sitter added a comment.
I love it
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks, davidedmundson, sitter
Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai,
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9241
To: renatoo, franckarrecot, mwolff
Cc: mwolff, #frameworks
renatoo updated this revision to Diff 23617.
renatoo added a comment.
used static_cast() for cast enums
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9241?vs=23614=23617
REVISION DETAIL
https://phabricator.kde.org/D9241
AFFECTED FILES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
broulik updated this revision to Diff 23616.
broulik retitled this revision from "[RunnerManager] Use
QThread::idealThreadCount() instead of going through Solid" to "[RunnerManager]
Don't mess with ThreadWeaver thread count".
broulik edited the summary of this revision.
broulik edited the test
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1215
> +QList args = groupHiddenSignal.takeFirst();
> +QCOMPARE(args.at(0).toInt(), (int) KFilePlacesModel::SearchForType);
> +
renatoo added a reviewer: franckarrecot.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9241
To: renatoo, franckarrecot
Cc: #frameworks
sitter added a comment.
It seems to me the only reason we have custom code to set the max count is
because of that `maxThreads` config entry. An entry for which I can't see any
UI backing, so it's borderline usless to begin with. The qMin then destroys any
remaining use that entry may have
davidedmundson added inline comments.
INLINE COMMENTS
> runnermanager.cpp:105
> if (numThreads > Queue::instance()->maximumNumberOfThreads()) {
> Queue::instance()->setMaximumNumberOfThreads(numThreads);
> }
Threadweaver defaults to
inventoryMax(qMax(4, 2 *
broulik added inline comments.
INLINE COMMENTS
> runnermanager.cpp:107
> const int maxThreads = config.readEntry("maxThreads", 16);
> -const int numThreads = qMin(maxThreads, 2 + ((numProcs - 1) * 2));
> -//qCDebug(KRUNNER) << "setting up" << numThreads << "threads for"
broulik added reviewers: Plasma, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks
Cc: plasma-devel, #frameworks,
renatoo added a dependent revision: D9241: Emit 'groupHiddenChanged' signal..
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
renatoo edited the summary of this revision.
renatoo added a dependency: D8450: User can now hide an entire places group
from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9241
To: renatoo
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Emit 'groupHiddenChanged' when group hidden value change
TEST PLAN
Unit test created
REPOSITORY
R241 KIO
REVISION DETAIL
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We query Solid for processors causing a ton of processing to be done just to
get the number of CPUs and then some magic math to determin
davidedmundson abandoned this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8159
To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, #frameworks,
mwolff added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7968
To: mwolff, apol, dfaure
Cc: #frameworks
mwolff updated this revision to Diff 23604.
mwolff added a comment.
use QOverload::of as suggested by apol
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7968?vs=23522=23604
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7968
AFFECTED FILES
rkflx added a comment.
No problem at all :) Good luck with your thesis!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
simgunz added a comment.
The deadline of my PhD thesis is very close, so my free time is basically
zero in this period. Unfortunately, I didn't manage to complete these reviews
before entering this critical period. In January I should have free time and
I'll complete this. I also can't wait
25 matches
Mail list logo
