T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ndavis added a comment. I could probably make the python script instead, but I'm in the same spot when it comes to writing CMake. TASK DETAIL https://phabricator.kde.org/T12855 To: ndavis Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. I haven't been working on it. There's an outstanding request to do this in a combination of CMake and Python, so it's cross-platform for Windows users of Breeze Icons too (see D27557#622879 ). Honestly I need to re-do the

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. @ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ndavis, ngraham, kde-frameworks-devel,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep event less. I have sorted them into two files. F8221155: dark_icons_to_keep.txt

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ndavis added a comment. In T12855#224570 , @davidhurka wrote: > Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended. TASK DETAIL https://phabricator.kde.org/T12855 To:

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. Ah, that was an oversight on my behalf. I changed the rating icon to be black to fix a bug where it becomes invisible on a selected item. I probably forgot to change it to be white for the dark version. :/ TASK DETAIL https://phabricator.kde.org/T12855 To:

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. By the way I looked through the 319 icons. - Some icons actually need fixing in icons/. - The emblem rating is blue in icons-dark/, because it links to another class. We can: - Leave rating in icons-dark/ - Change the light version to be blue too -

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have to take some short notes here. I have written a .sed script which we can use to convert icons/ files to icons-dark/ files. It does the same substitutions as my perl script above, but matches only in the stylesheet. That means, fixed colors will not be

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. Yeah, I was planning to. It would probably be helpful to do the cleanup first though. TASK DETAIL https://phabricator.kde.org/T12855 To: ngraham Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ngraham,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path) There are false positives: F8199094: categories_32_applications-development.png

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. None whatsoever. :) I suspect that most of the dark icons that are different from their light counterparts could be auto-ted and the differences are errors. So yeah, for any that aren't, the built script would simply avoid making an auto-generated version

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a parent task: T11950: Reduce the pain of working on monochrome Breeze icons. TASK DETAIL https://phabricator.kde.org/T12855 To: ngraham Cc: kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh,