git hooks for reviews mandatory?

2014-06-19 Thread Marco Martin
Hi all, I was thinking, since the policy for committing in frameworks is to always asking for a review, what about on repositories under frameworks/* adding an hook that accepts pushes only if the comment has a REVIEW: line? I have been guilty too many times of not respecting that, mostly for no

Re: git hooks for reviews mandatory?

2014-06-19 Thread Luigi Toscano
Marco Martin ha scritto: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? ... or "Reviewed by:" https://communit

Re: git hooks for reviews mandatory?

2014-06-19 Thread Nicolás Alvarez
2014-06-19 18:21 GMT-03:00 Marco Martin : > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty t

Re: git hooks for reviews mandatory?

2014-06-19 Thread Aleix Pol
On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding > an > hook that accepts pushes only if the comment has a REVIEW: line? > > I ha

Re: git hooks for reviews mandatory?

2014-06-19 Thread Kevin Ottens
On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an > > hook that acc

Re: git hooks for reviews mandatory?

2014-06-20 Thread Marco Martin
On Thursday 19 June 2014 23:38:05 Luigi Toscano wrote: > Marco Martin ha scritto: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accepts pushes only if the comm

Re: git hooks for reviews mandatory?

2014-06-20 Thread Aleix Pol
On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens wrote: > On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin > wrote: > > > Hi all, > > > I was thinking, since the policy for committing in frameworks is to > always > > > asking for a review, what abo

Re: git hooks for reviews mandatory?

2014-06-20 Thread Alex Merry
On 19/06/14 22:21, Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty t

Re: git hooks for reviews mandatory?

2014-06-20 Thread David Faure
On Friday 20 June 2014 19:25:19 Alex Merry wrote: > On 19/06/14 22:21, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accepts pushes only if

Re: git hooks for reviews mandatory?

2014-06-20 Thread Albert Astals Cid
El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure: > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 13:13:20 Aleix Pol wrote: > On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens wrote: > > On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > > > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin > > > > wrote: > > > > Hi all, > > > > I was thinking, since the policy for committing

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 22:11:57 Albert Astals Cid wrote: > El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure: > > I've heard of many complaints about how noisy is kde-frameworks mailing > > list because of review requests. Also, I fear there's people not working > > at full sp

Re: git hooks for reviews mandatory?

2014-06-21 Thread Michael Pyne
On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have bee

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Saturday 21 June 2014 11:22:28 Michael Pyne wrote: > On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accept

Re: git hooks for reviews mandatory?

2014-06-21 Thread Michael Pyne
On Sat, June 21, 2014 19:34:21 Kevin Ottens wrote: > On Saturday 21 June 2014 11:22:28 Michael Pyne wrote: > > On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > > > Hi all, > > > I was thinking, since the policy for committing in frameworks is to > > > always > > > asking for a review, what abou