https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #60 from David Gustafsson ---
Have discovered several serious issues with the current patch in this issue, so
do not recommend that any one uses it or re-roll it against master. My personal
view is that the current approa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #61 from Katrin Fischer ---
Hi David, we've always been keen on this one. If you have something to submit,
I'd be interested in testing. As we work in a union catalog setting (union
catalog is 'master'), Koha's missing ab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #62 from David Gustafsson ---
Hi! The code can be found here, but there are some parts (help section, tests,
user UI) that has not really been adjusted for the new code. Have performed
some limited manual testing and seem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Frank Hansen changed:
What|Removed |Added
CC||frank.han...@ub.lu.se
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Katrin Fischer changed:
What|Removed |Added
Status|Patch doesn't apply |Failed QA
--- Comment #63
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #64792|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |In Discussion
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
paxed changed:
What|Removed |Added
CC||pasi.kalli...@joensuu.fi
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #66 from David Gustafsson ---
Attaching the patch with latest changes even though not yet ready for sign off
to not block any further contributions by someone else.
Since the model for how rules work has changed since th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Katrin Fischer changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #72498|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #69 from David Gustafsson ---
Removed String::Similarity dependency and fixed an issue with the field data
hashing function.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #70 from David Gustafsson ---
@Katrin Fischer Yes it could use some work, still have not gotten around to
updating the help-pages and tests. We are currently running this in production
though and has been doing so for a c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #74855|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #72 from David Gustafsson ---
Rebase against master and remove (probably last of) String::Similarity related
code. Have not had time to work on the other issues. We have been running this
in production for a couple of wee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #73 from David Gustafsson ---
Which I now saw I already wrote about in previous comment. Still need to fix
tests and documentation as the bare minimum before ready for sign-off.
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #49 from David Gustafsson ---
Have discovered a lot of weirdness in how permissions are applied, not sure if
this is something I have introduces or present in the original patch, but don't
merge in this quite yet. Will up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #60825|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #51 from David Gustafsson ---
Made some small adjustments:
- Removed $options-{filter} arguments from ModBiblioMarc in AddBiblio since
ApplyMarcPermissions is never run on adding new biblios anyways (since no
caller uses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Johan Larsson changed:
What|Removed |Added
Attachment #61065|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Johan Larsson changed:
What|Removed |Added
CC||johan.lars...@ub.gu.se
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #61641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #55 from David Gustafsson ---
As another criticism, some of the things that should be easy are not, in
particular, Server-Side Rendering. Ember’s implementation of SSR requires two
simple entries on the command-line. Vue’
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #56 from David Gustafsson ---
Ops, wrong copy paste. Fixed missing "String::Similarity" include in Biblio.pm,
and changed $filter argument in ModBiblio to more flexible $options to avoid
future merge conflicts and provide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #61736|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #58 from David Gustafsson ---
The last change (adding the $options parameter) contained several mistakes,
(hopefully) fixed those now. Have run the tests and did some manual testing
(which I apparently did not do last tim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #74 from David Gustafsson ---
I'm actively working on fixing the remaining issues and moving relevant things
from C4 into the Koha namespace. Will probably submit changes tomorrow or
beginning of next week.
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #75118|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76201|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #77 from David Gustafsson ---
Created attachment 76203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76203&action=edit
Bug 14957 - Rule based permission for MARC fields
Change "MARC permissions" to "M
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76202|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #79 from David Gustafsson ---
Created attachment 76205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76205&action=edit
Bug 14957 - Refactor and fix tests and documention
Change "MARC permissions" to "
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #81 from David Gustafsson ---
Created attachment 76207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76207&action=edit
Bug 14957 - Refactor and fix tests and documentation
Change "MARC permissions" to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76204|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76205|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #84 from David Gustafsson ---
Sorry about the many attachments, had some issues adding the latest patch. Now
everything should be in order.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #85 from David Gustafsson ---
Created attachment 76210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76210&action=edit
Bug 14957 - Remove exports of removed subroutines
Remove exports of subroutines p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #86 from Katrin Fischer ---
Hi David, thank you for your work on this!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #87 from David Gustafsson ---
Thanks. Since this is a rather big change there probably are some minor
undiscovered issues with the current patch and we are still running with the
prior version in production. The tests are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Cab Vinton changed:
What|Removed |Added
CC||bibli...@gmail.com
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #89 from Cab Vinton ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 14957:
Something went wrong !Applying: Bug 14957 - Rule based permission for
MARC fields
.git/rebase-appl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76208|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76210|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #76209|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #93 from David Gustafsson ---
Rebased against master. Patches should now apply. Have not tested that still
works though. I will report back once have had the time to test, or if someone
else does before me.
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Claire Gravely changed:
What|Removed |Added
CC||claire_grav...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #95 from Tomás Cohen Arazi ---
I think I might be repeating myself, probably on a different bug. But I think
we should add both whitelisting and blacklisting 'MARC record overlay
configurations', and then hook them into w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #78653|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #78652|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #78651|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #79367|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #100 from David Gustafsson ---
(In reply to Tomás Cohen Arazi from comment #95)
> I think I might be repeating myself, probably on a different bug. But I
> think we should add both whitelisting and blacklisting 'MARC reco
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Tomás Cohen Arazi changed:
What|Removed |Added
Version|unspecified |master
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #102 from David Gustafsson ---
Created attachment 79890
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79890&action=edit
Bug 14957 - Add missing use in Biblio.pm
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #103 from David Gustafsson ---
Ok :) Fixed an issue where Biblio.pm was missing "use Koha::MarcMergeRules". I
missed this since the test works (where file was incluced), but obviously had
not tested the code in the staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Andreas Hedström Mace changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Cori Lynn Arnold changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #79368|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #79890|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #79369|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #79370|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #109 from David Gustafsson ---
Rebased against master. I think I was responsible for the conflict this time
(bug 19687) :)
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #110 from David Gustafsson ---
Created attachment 81176
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81176&action=edit
Bug 14957: Fix control field rules regression and add rule validation
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81176|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81177|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81178|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Cori Lynn Arnold changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #115 from David Gustafsson ---
(In reply to Cori Lynn Arnold from comment #114)
> Applied fine, but there were runtime errors:
>
> 5. You should see a new link "MARC field permissions" in the "Catalog"
>secti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #116 from David Gustafsson ---
Created attachment 81621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81621&action=edit
Bug 14957: DO NOT PUSH Schema changes
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #117 from David Gustafsson ---
Pushed the schema changes and followed the convention in Bug 19482.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #118 from David Gustafsson ---
I could also squash all the changes and add a new updated "To test", anyone has
some input on this?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #119 from Cori Lynn Arnold ---
Thoughts in IRC are that squishing would be fine and to please re-write the
tests to make them clearer and easier to follow with correct information.
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #120 from David Gustafsson ---
Ok, help pages will have to moved to online manual as previously noted.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #80972|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #122 from David Gustafsson ---
Created attachment 81700
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81700&action=edit
Bug 14957: DO NOT PUSH Schema changes
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81700|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #123 from David Gustafsson ---
Created attachment 81705
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81705&action=edit
Bug 14957: Merge rules system for merging of MARC records
Add a rule based syste
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81699|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81706|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Cori Lynn Arnold changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #128 from David Gustafsson ---
Created attachment 81969
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81969&action=edit
Bug 21596: (follow-up) Handle updated_on part 2
It seems that I have over compli
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81969|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81708|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81707|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #131 from David Gustafsson ---
(In reply to Cori Lynn Arnold from comment #127)
>
> 10. Try creating a rule with tag set to "008" (or other control
> field) and set Appended: Append and Removed: Skip, the oth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81971|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #81970|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #134 from David Gustafsson ---
Fixed too long foreign key length causing troubles with MariaDB.
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Attachment #82030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Commen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Stenberg changed:
What|Removed |Added
Assignee|gmcha...@gmail.com |mar...@bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Marc Véron changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #2 from Martin Stenberg
---
Created attachment 44056
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44056&action=edit
Bug 14957: Rule based permission for MARC fields
This patch adds a rule based permis
1 - 100 of 539 matches
Mail list logo
