https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Blocks||37214
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Katrin Fischer changed:
What|Removed |Added
Blocks||31011
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Blocks||29704
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||29801
Referenced Bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||28797
Referenced Bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
David Nind changed:
What|Removed |Added
Keywords||Manual
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Blocks||28581
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Katrin Fischer changed:
What|Removed |Added
Text to go in the|This patch adds a script|This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Text to go in the|This patch adds a script|This patch adds a script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #74 from Fridolin Somers ---
Enhancement not pushed to 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #73 from Jonathan Druart ---
Follow-up pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.k
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #72 from Jonathan Druart ---
Created attachment 120224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120224&action=edit
Bug 15986: Remove \r from HOLD_REMINDER in the yml
To prevent the following erro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Victor Grousset/tuxayo changed:
What|Removed |Added
Blocks||28198
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #70 from Jonathan Druart
---
Follow-up pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #69 from Jonathan Druart
---
Created attachment 119748
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119748&action=edit
Bug 15986: Add missing notice template for it-IT
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #68 from Jonathan Druart
---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #67 from Jonathan Druart
---
Created attachment 119725
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119725&action=edit
Bug 15986: move holds_reminder.pl to misc/cronjobs/holds/
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Blocks||28153
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #66 from Nick Clemens ---
Created attachment 119624
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119624&action=edit
Bug 15986: (follow-up) Switch nomail to confirm
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |ASSIGNED
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #65 from Jonathan Druart
---
Few more questions, (sorry!)
1.
58-n No email will be sent
shouldn't be replaced with a --confirm flag?
2. Shouldn't we add a new message preference to let
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #64 from Jonathan Druart
---
Created attachment 119386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119386&action=edit
Bug 15986: Fix typo following vs follwing
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #63 from Jonathan Druart
---
Created attachment 119384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119384&action=edit
Bug 15986: Use KohaDates filter to correctly format the waitingdate
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #62 from Nick Clemens ---
Created attachment 119383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119383&action=edit
Bug 15986: (follow-up) Add atomic update
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #61 from Nick Clemens ---
Created attachment 119329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119329&action=edit
Bug 15986: Add sample notice to translated notices
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #60 from Nick Clemens ---
Created attachment 119328
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119328&action=edit
Bug 15986: Add sample notice and use as default
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #59 from Nick Clemens ---
Created attachment 119327
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119327&action=edit
Bug 15986: (follow-up) Add all holds per patron
This changes the code to loop throu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|In Discussion |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #58 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #57)
> (In reply to Nick Clemens from comment #55)
> > Created attachment 119308 [details] [review] [review]
> > Bug 15986: (follow-up) Use inbound_e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #57 from Martin Renvoize ---
(In reply to Nick Clemens from comment #55)
> Created attachment 119308 [details] [review]
> Bug 15986: (follow-up) Use inbound_email_address for library
Damn, Shame on me for missing that on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #56 from Nick Clemens ---
(In reply to Jonathan Druart from comment #54)
> 1. Shouldn't it be $library->inbound_email_address instead?
Done
> 2.There are now 2 mtt, phone and itiva. Here you need to compare with 'itiva'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #55 from Nick Clemens ---
Created attachment 119308
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119308&action=edit
Bug 15986: (follow-up) Use inbound_email_address for library
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #54
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #53 from Nick Clemens ---
Created attachment 119277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119277&action=edit
Bug 15986: (follow-up) Fix usage statement
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Text to go in the||This patch adds a script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #52 from Martin Renvoize ---
Created attachment 118737
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118737&action=edit
Bug 15986: (QA follow-up) Fix spelling mistake
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #50 from Martin Renvoize ---
Created attachment 118736
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118736&action=edit
Bug 15986: (QA follow-up) Account for bugs 25333 and 25334
Bug 25333 changed the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Attachment #113001|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Attachment #113000|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Martin Renvoize changed:
What|Removed |Added
Attachment #112999|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Barbara Johnson changed:
What|Removed |Added
CC||barbara.johnson@bedfordtx.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #46 from Victor Grousset/tuxayo ---
Good, there doesn't seem to be a bad choice.
Thanks for the info Andrew, that was my 2 cents, I'll leave the rest to more
knowledgeable people ^^"
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #45 from Andrew Fuerste-Henry ---
I don't really get the sense one option is more standard or more likely to be
correct for any given library -- it's just one of those things one ends up
asking every new library about. Sa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #44 from Victor Grousset/tuxayo ---
> The various sysprefs that determine whether or not to consult the calendar
> for various tasks are inconsistent in a new install
:o
> However, ExcludeHolidaysFromMaxPickUpDelay def
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #43 from Andrew Fuerste-Henry ---
The various sysprefs that determine whether or not to consult the calendar for
various tasks are inconsistent in a new install -- some are on and some are
off. However, ExcludeHolidaysFro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #41 from Séverine Queune ---
(In reply to Nick Clemens from comment #40)
> (In reply to Séverine Queune from comment #36)
> > This patch works fine !
> > But I won't sign it because of 2 points :
> > - I can't test the s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #40 from Nick Clemens ---
(In reply to Séverine Queune from comment #36)
> This patch works fine !
> But I won't sign it because of 2 points :
> - I can't test the sms part, I don't know how it works and how to use the
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Kim Gnerre changed:
What|Removed |Added
CC|rhilli...@hotchkiss.org |
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Kim Gnerre changed:
What|Removed |Added
CC||kgne...@hotchkiss.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #106963|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #106962|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #106964|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #35 from Nick Clemens ---
Adding a holiday means the holds are waiting 1-less day, not 1 more :-)
Fixed the math in the test plan :-)
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #33 from Nick Clemens ---
Created attachment 106963
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106963&action=edit
Bug 15986: Update for bug 24159
The job is concerned with holds waiting and takes d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #34 from Nick Clemens ---
Created attachment 106964
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106964&action=edit
Bug 15986: Rename send_notice to queue_notice and update test count
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #102926|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
BASE Library Consortium changed:
What|Removed |Added
CC||baselibrary.consor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #30 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #29)
> Comment on attachment 102926 [details] [review]
> Bug 15986: Add a script for sending hold waiting reminder notices
>
> Review of attachment 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #29 from Martin Renvoize ---
Comment on attachment 102926
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102926
Bug 15986: Add a script for sending hold waiting reminder notices
Review of attachment 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #28 from David Nind ---
Thanks Nick!
I can now get most things to work, except for steps 17 and 21 - not sure what
I'm doing wrong here.
There are reserves table entries: current date = 2020-04-15, waitingdate for
items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #102723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #27 from Nick Clemens ---
(In reply to David Nind from comment #24)
> For step 17, 19, 21, and 24 I'm getting an error message when running the
> script:
>
> perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMIND
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #25 from David Nind ---
Also, in step 11 '..INTERVAL 3 DAYS)..' should be '..INTERVAL 3 DAY)..' (that
is, DAYS should be DAY).
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #24 from David Nind ---
For step 17, 19, 21, and 24 I'm getting an error message when running the
script:
perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL
-holidays -days 3
branch CPL passed on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #99919|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #21 from Nick Clemens ---
(In reply to Jonathan Druart from comment #20)
> Is the test_mode parameter of the method really useful?
Yes.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #20 from Jonathan Druart
---
Is the test_mode parameter of the method really useful?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #91768|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Axelle Aix-Marseille Université changed:
What|Removed |Added
CC||axelle.cla
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #91767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #16 from Nick Clemens ---
(In reply to Katrin Fischer from comment #13)
> I think if we do #9 later it will introduce a change in workflow - if we did
> it from the beginning, we could safe people from having to change th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #15 from Nick Clemens ---
(In reply to Chris Cormack from comment #12)
> I think comment 9 could be a future enhancement. But mostly comment 10
> (moving the code to a module and writing tests) and an independent sign off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Attachment #55723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Nick Clemens changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Joy Nelson changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #13 from Katrin Fischer ---
I think if we do #9 later it will introduce a change in workflow - if we did it
from the beginning, we could safe people from having to change their setups.
But I am not blocking this, just exp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Chris Cormack changed:
What|Removed |Added
Status|In Discussion |ASSIGNED
--- Comment #12 fr
1 - 100 of 120 matches
Mail list logo