Re: [PULL 0/3] 4.0 patch queue 2015-03-25

2015-03-25 Thread Marcelo Tosatti
On Wed, Mar 25, 2015 at 10:58:54PM +0100, Alexander Graf wrote: > Hi Paolo, > > This is my current patch queue for 4.0. Please pull. > > Alex > > > The following changes since commit f710a12d73dfa1c3a5d2417f2482b970f03bb850: > > Merge tag 'kvm-arm-fixes-4.0-rc5' of > git://git.kernel.org/p

Re: [PULL 0/6] ppc patch queue 2013-05-02 for 3.10

2013-05-02 Thread Marcelo Tosatti
On Thu, May 02, 2013 at 03:32:45PM +0200, Alexander Graf wrote: > Hi Marcelo / Gleb, > > This is my current patch queue for ppc. Please pull and apply to next, so it > makes its way into 3.10. Sorry for the late request. > > There is still one RCU patch outstanding that needs a respin, so expect

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-02 Thread Marcelo Tosatti
On Wed, May 01, 2013 at 07:27:23PM -0500, Scott Wood wrote: > On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: > >On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: > >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > >> index 1020119..506

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-01 Thread Marcelo Tosatti
On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: > KVM core expects arch code to acquire the srcu lock when calling > gfn_to_memslot and similar functions. > > Signed-off-by: Scott Wood > --- > arch/powerpc/kvm/44x_tlb.c |5 + > arch/powerpc/kvm/booke.c| 19

Re: [PATCH 16/17] KVM: PPC: MPIC: Add support for KVM_IRQ_LINE

2013-05-01 Thread Marcelo Tosatti
On Thu, Apr 25, 2013 at 11:13:40PM +0200, Alexander Graf wrote: > > On 25.04.2013, at 21:03, Scott Wood wrote: > > > On 04/25/2013 09:49:23 AM, Alexander Graf wrote: > >> On 25.04.2013, at 13:30, Alexander Graf wrote: > >> > > >> > On 19.04.2013, at 20:51, Scott Wood wrote: > >> > > >> >> On 04/1

Re: [PULL 0/7] ppc patch queue 2013-03-22

2013-04-16 Thread Marcelo Tosatti
On Tue, Apr 16, 2013 at 07:26:35PM +0200, Alexander Graf wrote: > >>> So I may send a pull request against 3.9 with the 3 commits that already > >>> are in kvm/next? > >> > >> If you decide that the fixes are important enough to justify the > >> existance of duplicate commits, i don't see a probl

Re: [PULL 0/7] ppc patch queue 2013-03-22

2013-04-12 Thread Marcelo Tosatti
On Thu, Apr 11, 2013 at 03:50:13PM +0200, Alexander Graf wrote: > > On 11.04.2013, at 15:45, Marcelo Tosatti wrote: > > > On Tue, Mar 26, 2013 at 12:59:04PM +1100, Paul Mackerras wrote: > >> On Tue, Mar 26, 2013 at 03:33:12AM +0200, Gleb Natapov wrote: > >>>

Re: [PULL 0/7] ppc patch queue 2013-03-22

2013-04-11 Thread Marcelo Tosatti
On Tue, Mar 26, 2013 at 12:59:04PM +1100, Paul Mackerras wrote: > On Tue, Mar 26, 2013 at 03:33:12AM +0200, Gleb Natapov wrote: > > On Tue, Mar 26, 2013 at 12:35:09AM +0100, Alexander Graf wrote: > > > I agree. So if it doesn't hurt to have the same commits in kvm/next and > > > kvm/master, I'd be

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-23 Thread Marcelo Tosatti
On Thu, Feb 21, 2013 at 08:00:25PM -0600, Scott Wood wrote: > On 02/21/2013 05:03:32 PM, Marcelo Tosatti wrote: > >On Wed, Feb 20, 2013 at 07:28:52PM -0600, Scott Wood wrote: > >> On 02/20/2013 06:14:37 PM, Marcelo Tosatti wrote: > >> >On Wed, Feb 20, 2013 at 05:5

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-21 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 07:28:52PM -0600, Scott Wood wrote: > On 02/20/2013 06:14:37 PM, Marcelo Tosatti wrote: > >On Wed, Feb 20, 2013 at 05:53:20PM -0600, Scott Wood wrote: > >> >It is then not necessary to set device attributes on a live > >guest and > >> >

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 05:53:20PM -0600, Scott Wood wrote: > >Why exactly you need to set attributes Scott? > > That's best answered by looking at patch 6/6 and discussing the > actual attributes that are defined so far. > > The need to set the base address of the registers is > straightforward.

Re: [PATCH 3/9] KVM: PPC: Book3S: Add kernel emulation for the XICS interrupt controller

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 06:20:51PM -0600, Scott Wood wrote: > On 02/20/2013 01:58:54 PM, Marcelo Tosatti wrote: > >This is probably a stupid question, but why the > >KVM_SET_IRQCHIP/KVM_SET_GSI_ROUTING interface is not appropriate for > >your purposes? > > > >x86 s

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 05:20:50PM -0600, Scott Wood wrote: > On 02/20/2013 03:17:27 PM, Marcelo Tosatti wrote: > >On Mon, Feb 18, 2013 at 05:01:40PM -0600, Scott Wood wrote: > >> On 02/18/2013 06:21:59 AM, Gleb Natapov wrote: > >> >Copying Christoffer since

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 06:28:24PM -0300, Marcelo Tosatti wrote: > On Wed, Feb 20, 2013 at 03:09:49PM +0200, Gleb Natapov wrote: > > On Tue, Feb 19, 2013 at 03:16:37PM -0600, Scott Wood wrote: > > > On 02/19/2013 06:24:18 AM, Gleb Natapov wrote: > > > >On Mon, Fe

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Wed, Feb 20, 2013 at 03:09:49PM +0200, Gleb Natapov wrote: > On Tue, Feb 19, 2013 at 03:16:37PM -0600, Scott Wood wrote: > > On 02/19/2013 06:24:18 AM, Gleb Natapov wrote: > > >On Mon, Feb 18, 2013 at 05:01:40PM -0600, Scott Wood wrote: > > >> The ability to set/get attributes is needed. Sorry,

Re: [RFC PATCH 1/6] kvm: add device control API

2013-02-20 Thread Marcelo Tosatti
On Mon, Feb 18, 2013 at 05:01:40PM -0600, Scott Wood wrote: > On 02/18/2013 06:21:59 AM, Gleb Natapov wrote: > >Copying Christoffer since ARM has in kernel irq chip too. > > > >On Wed, Feb 13, 2013 at 11:49:15PM -0600, Scott Wood wrote: > >> Currently, devices that are emulated inside KVM are confi

Re: [PATCH 3/9] KVM: PPC: Book3S: Add kernel emulation for the XICS interrupt controller

2013-02-20 Thread Marcelo Tosatti
On Sat, Feb 16, 2013 at 01:56:14PM +1100, Paul Mackerras wrote: > On Fri, Feb 15, 2013 at 05:59:11PM -0600, Scott Wood wrote: > > On 02/15/2013 05:18:31 PM, Paul Mackerras wrote: > > >On Fri, Feb 15, 2013 at 02:05:41PM -0600, Scott Wood wrote: > > >> On 02/14/2013 06:01:08 PM, Paul Mackerras wrote:

Re: [PULL 00/14] ppc patch queue 2013-02-15

2013-02-18 Thread Marcelo Tosatti
Pulled, thanks. On Fri, Feb 15, 2013 at 01:16:16AM +0100, Alexander Graf wrote: > Hi Marcelo / Gleb, > > This is my current patch queue for ppc. Please pull. > > Highlights of this queue drop are: > > - BookE: Fast mapping support for 4k backed memory > - BookE: Handle alignment interrupts

Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8

2013-01-21 Thread Marcelo Tosatti
On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote: > Hi Marcelo / Gleb, > > This is my current patch queue for ppc against 3.8. Please pull. > > It contains a bug fix for an issue that Ben Collins ran into, where > a guest would just abort because it traps during an unknown instruct

Re: [PULL 00/28] ppc patch queue 2012-12-06

2012-12-09 Thread Marcelo Tosatti
On Thu, Dec 06, 2012 at 01:40:49AM +0100, Alexander Graf wrote: > Hi Marcelo / Gleb, > > This is my current patch queue for ppc. Please pull. > > Major changes this time around include: > > - Book3S PR: Multiple fixes for POWER7 hosts > - Book3S HV: Prepare for full state exposure (live mig

Re: [PULL 00/12] ppc patch queue 2012-10-30

2012-10-31 Thread Marcelo Tosatti
On Wed, Oct 31, 2012 at 11:22:55AM +0100, Alexander Graf wrote: > > > On 31.10.2012, at 02:32, Marcelo Tosatti wrote: > > > On Tue, Oct 30, 2012 at 11:02:13AM +0100, Alexander Graf wrote: > >> Hi Avi / Marcelo, > >> > >> This is

Re: [PULL 00/12] ppc patch queue 2012-10-30

2012-10-31 Thread Marcelo Tosatti
On Wed, Oct 31, 2012 at 12:26:04PM +0200, Avi Kivity wrote: > On 10/31/2012 12:22 PM, Alexander Graf wrote: > > > > > > On 31.10.2012, at 02:32, Marcelo Tosatti wrote: > > > >> On Tue, Oct 30, 2012 at 11:02:13AM +0100, Alexander Graf wrote: > >&g

Re: [PULL 00/12] ppc patch queue 2012-10-30

2012-10-30 Thread Marcelo Tosatti
On Tue, Oct 30, 2012 at 11:02:13AM +0100, Alexander Graf wrote: > Hi Avi / Marcelo, > > This is my current patch queue for ppc. Please pull. > > Headline changes are: > > * Fix 440 target > * Fix uapi conflict Can you regenerate against queue branch? (btw i forgot to update fsl_hcalls.h..

Re: [PATCH 1/2] KVM: PPC: e500: fix allocation size error on g2h_tlb1_map

2012-09-27 Thread Marcelo Tosatti
On Tue, Sep 25, 2012 at 09:46:01AM +0200, Alexander Graf wrote: > > On 23.08.2012, at 03:04, Scott Wood wrote: > > > We were only allocating half the bytes we need, which was made more > > obvious by a recent fix to the memset in clear_tlb1_bitmap(). > > > > Signed-off-by: Scott Wood > > Than

Re: [PATCH] KVM: Move some PPC ioctl definitions to the correct place

2012-09-15 Thread Marcelo Tosatti
On Fri, Sep 14, 2012 at 04:19:29PM +0200, Alexander Graf wrote: > > On 14.09.2012, at 09:44, Paul Mackerras wrote: > > > This moves the definitions of KVM_CREATE_SPAPR_TCE and > > KVM_ALLOCATE_RMA in include/linux/kvm.h from the section listing the > > vcpu ioctls to the section listing VM ioctls

Re: [PATCH RFC 1/2] KVM: PPC: Move kvm->arch.slot_phys into memslot.arch

2012-08-27 Thread Marcelo Tosatti
On Sat, Aug 25, 2012 at 10:40:40PM +1000, Paul Mackerras wrote: > Now that we have an architecture-specific field in the kvm_memory_slot > structure, we can use it to store the array of page physical addresses > that we need for Book3S HV KVM on PPC970 processors. This reduces the > size of struct

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-24 Thread Marcelo Tosatti
On Fri, Aug 24, 2012 at 07:29:53PM +1000, Paul Mackerras wrote: > On Thu, Aug 23, 2012 at 10:55:37AM -0300, Marcelo Tosatti wrote: > > > There are a number of options to consider: > > > > 1) Merge the current patchset from Paul, which has two downsides: > > 1-1)

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-23 Thread Marcelo Tosatti
On Sat, Aug 18, 2012 at 06:32:25AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2012-08-17 at 15:39 -0300, Marcelo Tosatti wrote: > > On Fri, Aug 17, 2012 at 05:06:18PM +1000, Benjamin Herrenschmidt wrote: > > > On Wed, 2012-08-15 at 14:59 -0300, Marcelo Tosatti wrote: > >

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-17 Thread Marcelo Tosatti
On Fri, Aug 17, 2012 at 05:06:18PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-15 at 14:59 -0300, Marcelo Tosatti wrote: > > > > The guest should not expect memory accesses to an address > > to behave sanely while changing a BAR anyway. > > > > Yes

Re: [PULL 3.6 0/3] ppc patch queue 2012-08-16 for 3.6

2012-08-17 Thread Marcelo Tosatti
On Thu, Aug 16, 2012 at 02:16:50PM +0200, Alexander Graf wrote: > Hi Avi, > > This is my patch queue for ppc patches that should go into 3.6. Please pull. > > * Fix memset in e500_tlb > * Fix icache flush when mapping executable pages > * Fix wrong branch in book3s hv code > > Alex > >

Re: [PATCH 16/38] KVM: PPC: BookE: Add check_requests helper function

2012-08-15 Thread Marcelo Tosatti
On Tue, Aug 14, 2012 at 07:10:43PM -0500, Scott Wood wrote: > On 08/14/2012 06:04 PM, Alexander Graf wrote: > > We need a central place to check for pending requests in. Add one that > > only does the timer check we already do in a different place. > > > > Later, this central function can be exten

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-15 Thread Marcelo Tosatti
On Wed, Aug 15, 2012 at 12:26:05PM +0300, Avi Kivity wrote: > On 08/14/2012 01:04 AM, Marcelo Tosatti wrote: > > On Mon, Aug 13, 2012 at 01:34:11PM -0300, Marcelo Tosatti wrote: > >> On Sat, Aug 11, 2012 at 10:37:54AM +1000, Paul Mackerras wrote: > >> > On Fri, Au

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-13 Thread Marcelo Tosatti
On Mon, Aug 13, 2012 at 01:34:11PM -0300, Marcelo Tosatti wrote: > On Sat, Aug 11, 2012 at 10:37:54AM +1000, Paul Mackerras wrote: > > On Fri, Aug 10, 2012 at 03:35:53PM -0300, Marcelo Tosatti wrote: > > > There's no plan. I just wanted to confirm this before converting >

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-13 Thread Marcelo Tosatti
On Sat, Aug 11, 2012 at 10:37:54AM +1000, Paul Mackerras wrote: > On Fri, Aug 10, 2012 at 03:35:53PM -0300, Marcelo Tosatti wrote: > > There's no plan. I just wanted to confirm this before converting > > to per-memslot flush. > > > > 1)

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-10 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 11:09:09AM +0900, Takuya Yoshikawa wrote: > On Thu, 9 Aug 2012 22:25:32 -0300 > Marcelo Tosatti wrote: > > > I'll send a patch to flush per memslot in the next days, you can work > > out the PPC details in the meantime. Not anymore. > Ar

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Fri, Aug 10, 2012 at 10:34:39AM +1000, Paul Mackerras wrote: > On Thu, Aug 09, 2012 at 03:16:12PM -0300, Marcelo Tosatti wrote: > > > The !memslot->npages case is handled in __kvm_set_memory_region > > (please read that part, before kvm_arch_prepare

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Thu, Aug 09, 2012 at 10:25:32PM -0300, Marcelo Tosatti wrote: > On Fri, Aug 10, 2012 at 10:34:39AM +1000, Paul Mackerras wrote: > > On Thu, Aug 09, 2012 at 03:16:12PM -0300, Marcelo Tosatti wrote: > > > > > The !memslot->npages case is handled in __kvm_set_memory_reg

Re: [PATCH 4/5] KVM: PPC: Book3S HV: Take the SRCU read lock before looking up memslots

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:06:55PM +1000, Paul Mackerras wrote: > The generic KVM code uses SRCU (sleeping RCU) to protect accesses > to the memslots data structures against updates due to userspace > adding, modifying or removing memory slots. We need to do that too, > both to avoid accessing sta

Re: [PATCH 3/5] KVM: PPC: Book3S HV: Handle memory slot deletion and modification correctly

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:06:03PM +1000, Paul Mackerras wrote: > >From 44067a8ee15021583636bea4cc1d47e5370b8397 Mon Sep 17 00:00:00 2001 > From: Paul Mackerras > Date: Mon, 30 Jul 2012 16:40:54 +1000 > Subject: > > At present the HV style of KVM doesn't handle deletion or modification > of memo

Re: [RFC PATCH 5/5] KVM: PPC: Take the SRCU lock around memslot use

2012-08-09 Thread Marcelo Tosatti
On Mon, Aug 06, 2012 at 08:08:16PM +1000, Paul Mackerras wrote: > The generic KVM code uses SRCU (sleeping RCU) to protect accesses > to the memslots data structures against updates due to userspace > adding, modifying or removing memory slots. We need to do that too, > both to avoid accessing sta

Re: Reset problem vs. MMIO emulation, hypercalls, etc...

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 02:41:13PM -0300, Marcelo Tosatti wrote: > On Fri, Aug 03, 2012 at 06:20:18AM +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2012-08-02 at 15:35 +0300, Avi Kivity wrote: > > > This is actually documented in api.txt, though not in relat

Re: Reset problem vs. MMIO emulation, hypercalls, etc...

2012-08-03 Thread Marcelo Tosatti
On Fri, Aug 03, 2012 at 06:20:18AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2012-08-02 at 15:35 +0300, Avi Kivity wrote: > > This is actually documented in api.txt, though not in relation to > > reset: > > > > NOTE: For KVM_EXIT_IO, KVM_EXIT_MMIO and KVM_EXIT_OSI, the > > corresponding o

Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation

2012-07-25 Thread Marcelo Tosatti
On Wed, Jul 25, 2012 at 06:55:16PM -0500, Scott Wood wrote: > On 07/25/2012 03:37 PM, Marcelo Tosatti wrote: > > On Fri, Jul 20, 2012 at 04:29:08PM -0500, Scott Wood wrote: > >> On 07/20/2012 12:00 AM, Bharat Bhushan wrote: > >>> This patch adds the watchdog

Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation

2012-07-25 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 04:29:08PM -0500, Scott Wood wrote: > On 07/20/2012 12:00 AM, Bharat Bhushan wrote: > > This patch adds the watchdog emulation in KVM. The watchdog > > emulation is enabled by KVM_ENABLE_CAP(KVM_CAP_PPC_WDT) ioctl. > > The kernel timer are used for watchdog emulation and emu

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-18 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: > v3->v4: Resolved trace_kvm_age_page() issue -- patch 6,7 > v2->v3: Fixed intersection calculations. -- patch 3, 8 > > Takuya > > Takuya Yoshikawa (8): > KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() > KVM:

Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4

2012-07-05 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: > v3->v4: Resolved trace_kvm_age_page() issue -- patch 6,7 > v2->v3: Fixed intersection calculations. -- patch 3, 8 > > Takuya > > Takuya Yoshikawa (8): > KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() > KVM:

Re: [PATCH v2] KVM: PPC: Rework wqp conditional code

2012-03-13 Thread Marcelo Tosatti
On Tue, Mar 13, 2012 at 10:35:01PM +0100, Alexander Graf wrote: > On PowerPC, we sometimes use a waitqueue per core, not per thread, > so we can't always use the vcpu internal waitqueue. > > This code has been generalized by Christoffer Dall recently, but > unfortunately broke compilation for Powe

Re: [PATCH v4] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-03-09 Thread Marcelo Tosatti
On Thu, Mar 08, 2012 at 04:44:24PM -0500, Christoffer Dall wrote: > Any news on the status of this? > > On Thu, Feb 9, 2012 at 8:45 PM, Alexander Graf wrote: > > > > On 10.02.2012, at 02:40, Christoffer Dall wrote: > > > >> The kvm_vcpu_kick function performs roughly the same funcitonality on > >

Re: [PATCH 19/38] KVM: PPC: e500mc: add load inst fixup

2012-03-08 Thread Marcelo Tosatti
On Wed, Feb 29, 2012 at 01:09:47AM +0100, Alexander Graf wrote: > There's always a chance we're unable to read a guest instruction. The guest > could have its TLB mapped execute-, but not readable, something odd happens > and our TLB gets flushed. So it's a good idea to be prepared for that case >

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-02-06 Thread Marcelo Tosatti
On Mon, Feb 06, 2012 at 09:06:04PM +0100, Jan Kiszka wrote: > On 2012-02-06 19:25, Marcelo Tosatti wrote: > >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > >> index c38efd7..a1761ff 100644 > >> --- a/arch/x86/kvm/x86.c > >> +++ b/arch/x86/kv

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-02-06 Thread Marcelo Tosatti
On Tue, Jan 24, 2012 at 11:27:39PM -0500, Christoffer Dall wrote: > The kvm_vcpu_kick function performs roughly the same funcitonality on > most all architectures, so we shouldn't have separate copies. > > PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch > structure and to acco

Re: [PATCH 0/4] KVM: Decouple rmap_pde from lpage_info write_count

2012-01-23 Thread Marcelo Tosatti
On Mon, Jan 23, 2012 at 07:42:04PM +0900, Takuya Yoshikawa wrote: > The last one is an RFC patch: > > I think it is better to refactor the rmap things, if needed, before > other architectures than x86 starts large pages support. > > Takuya Looks good to me. -- To unsubscribe from this lis

Re: [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code

2012-01-23 Thread Marcelo Tosatti
On Thu, Jan 19, 2012 at 10:22:41PM -0500, Christoffer Dall wrote: > The kvm_vcpu_kick function performs roughly the same funcitonality on > most all architectures, so we shouldn't have separate copies. > > PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch > structure and to acco

Re: [PULL 00/52] ppc patch queue 2012-01-13

2012-01-16 Thread Marcelo Tosatti
On Fri, Jan 13, 2012 at 03:31:03PM +0100, Alexander Graf wrote: > Hi Avi, > > This is my current patch queue for ppc. Please pull. > > Alex > > > The following changes since commit 188fc33198ddb1469562d40de33bcc29e7e2ed5f: > Christian Borntraeger (1): > kvm-s390: provide access guest

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-12-19 Thread Marcelo Tosatti
On Mon, Dec 19, 2011 at 01:58:32PM +0100, Alexander Graf wrote: > I still don't fully understand. You pass in a list of register modifications. > The same would happen from guest code. You have a code stream of register > modifications. They should both end up calling the same functions in the >

Re: [RFC PATCH 0/11] KVM: PPC: Update Book3S HV memory handling

2011-11-23 Thread Marcelo Tosatti
On Sat, Nov 19, 2011 at 08:54:24AM +1100, Paul Mackerras wrote: > On Fri, Nov 18, 2011 at 02:57:11PM +0100, Alexander Graf wrote: > > > > This touches areas that I'm sure non-PPC people would want to see as > > well. Could you please CC kvm@vger too next time? > > > > Avi, Marcelo, mind to review

Re: [RFC PATCH 11/11] KVM: PPC: Eliminate global spinlock in kvmppc_h_enter

2011-11-23 Thread Marcelo Tosatti
On Thu, Nov 17, 2011 at 10:55:49AM +1100, Paul Mackerras wrote: > >From dfd5bcfac841f8a36593edf60d9fb15e0d633287 Mon Sep 17 00:00:00 2001 > From: Paul Mackerras > Date: Mon, 14 Nov 2011 13:30:38 +1100 > Subject: > > Currently, kvmppc_h_enter takes a spinlock that is global to the guest, > kvm->m

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-11-23 Thread Marcelo Tosatti
On Wed, Nov 16, 2011 at 12:45:45AM +0100, Alexander Graf wrote: > > On 10.11.2011, at 18:35, Marcelo Tosatti wrote: > > > On Thu, Nov 10, 2011 at 05:49:42PM +0100, Alexander Graf wrote: > >>>> Documentation/virtual/kvm/api.txt | 47 > >>>> +

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-11-10 Thread Marcelo Tosatti
On Thu, Nov 10, 2011 at 05:49:42PM +0100, Alexander Graf wrote: > >> Documentation/virtual/kvm/api.txt | 47 > >> ++ > >> arch/powerpc/kvm/powerpc.c| 51 > >> + > >> include/linux/kvm.h | 32 +

Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

2011-11-10 Thread Marcelo Tosatti
On Mon, Oct 31, 2011 at 08:53:11AM +0100, Alexander Graf wrote: > Right now we transfer a static struct every time we want to get or set > registers. Unfortunately, over time we realize that there are more of > these than we thought of before and the extensibility and flexibility of > transferring

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-21 Thread Marcelo Tosatti
On Tue, Sep 20, 2011 at 09:03:51PM +0100, Jamie Lokier wrote: > Marcelo Tosatti wrote: > > In case the VM stops for whatever reason, the host system is not > > supposed to adjust time related hardware state to compensate, in an > > attempt to present apparent continuous time.

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-21 Thread Marcelo Tosatti
On Wed, Sep 21, 2011 at 07:11:08AM -0700, Dave Hansen wrote: > On Tue, 2011-09-20 at 16:55 -0300, Marcelo Tosatti wrote: > > > and the wall clock stays behind my host wall clock by the amount of > > > time it took to resume. > > > > This is expected, similar t

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-20 Thread Marcelo Tosatti
On Tue, Sep 20, 2011 at 03:00:54PM -0400, Eric B Munson wrote: > On Thu, 15 Sep 2011, Marcelo Tosatti wrote: > > > On Tue, Sep 13, 2011 at 04:49:55PM -0400, Eric B Munson wrote: > > > On Fri, 09 Sep 2011, Marcelo Tosatti wrote: > > > > > > > On T

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-15 Thread Marcelo Tosatti
On Tue, Sep 13, 2011 at 04:49:55PM -0400, Eric B Munson wrote: > On Fri, 09 Sep 2011, Marcelo Tosatti wrote: > > > On Thu, Sep 01, 2011 at 02:27:49PM -0600, emun...@mgebm.net wrote: > > > On Thu, 01 Sep 2011 14:24:12 -0500, Anthony Liguori wrote: > > > >On 08/

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-09 Thread Marcelo Tosatti
On Thu, Sep 01, 2011 at 02:27:49PM -0600, emun...@mgebm.net wrote: > On Thu, 01 Sep 2011 14:24:12 -0500, Anthony Liguori wrote: > >On 08/30/2011 07:26 AM, Marcelo Tosatti wrote: > >>On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: > >>>Currently, when

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 10:37:13AM -0600, Eric B Munson wrote: > On Tue, Aug 30, 2011 at 06:26, Marcelo Tosatti wrote: > > On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: > >> Currently, when qemu stops a guest kernel that guest will issue a soft > >>

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 09:43:19AM -0500, Ryan Harper wrote: > * Marcelo Tosatti [2011-08-30 09:40]: > > On Tue, Aug 30, 2011 at 09:12:17AM -0500, Ryan Harper wrote: > > > * Marcelo Tosatti [2011-08-30 07:35]: > > > > On Mon, Aug 29, 2011 at 05:27:1

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 09:12:17AM -0500, Ryan Harper wrote: > * Marcelo Tosatti [2011-08-30 07:35]: > > On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: > > > Currently, when qemu stops a guest kernel that guest will issue a soft > > > lockup > >

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Marcelo Tosatti
On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: > Currently, when qemu stops a guest kernel that guest will issue a soft lockup > message when it resumes. This set provides the ability for qemu to > comminucate > to the guest that it has been stopped. When the guest hits the watch

Re: [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host

2011-08-04 Thread Marcelo Tosatti
On Wed, Aug 03, 2011 at 10:24:58AM -0400, Eric B Munson wrote: > This set is just a rough first pass at avoiding soft lockup warnings when a > host > pauses the execution of a guest. A flag is set by the host in the shared page > used for the pvclock when the host goes to stop the guest. When th

Re: [PULL 00/17] KVM PPC patch queue 2011-07-04

2011-07-07 Thread Marcelo Tosatti
On Mon, Jul 04, 2011 at 04:12:37PM +0200, Alexander Graf wrote: > Hi Avi, > > Here is my current patch queue for KVM on PPC. It contains support for > hardware accelerated KVM on 970 and POWER7 (no hardware) which is one > of the most interesting features we had added for a while now. > > This ne

Re: [PATCH] KVM: PPC: Fix SPRG get/set for Book3S and BookE

2011-01-06 Thread Marcelo Tosatti
On Wed, Dec 29, 2010 at 01:51:25PM -0600, Peter Tyser wrote: > Previously SPRGs 4-7 were improperly read and written in > kvm_arch_vcpu_ioctl_get_regs() and kvm_arch_vcpu_ioctl_set_regs(); > > Signed-off-by: Peter Tyser > --- > I noticed this while grepping for somthing unrelated and assume its >

Re: [PATCH] powerpc: kvm: fix information leak to userland

2010-11-01 Thread Marcelo Tosatti
On Sat, Oct 30, 2010 at 01:04:24PM +0400, Vasiliy Kulikov wrote: > Structure kvm_ppc_pvinfo is copied to userland with flags and > pad fields unitialized. It leads to leaking of contents of > kernel stack memory. > > Signed-off-by: Vasiliy Kulikov > --- > I cannot compile this driver, so it is

Re: [PATCH] PPC: KVM: Book E doesn't have __end_interrupts.

2010-10-19 Thread Marcelo Tosatti
On Tue, Oct 19, 2010 at 12:57:29AM +0200, Alexander Graf wrote: > > On 19.10.2010, at 00:35, Scott Wood wrote: > > > Fix an unresolved symbol with CONFIG_KVM_GUEST plus CONFIG_RELOCATABLE on > > Book E. > > Thanks, applied to the kvm-ppc-next tree. > > Avi, could you please pull my tree asap? T

Re: [PATCH 0/2] Faster MMU lookups for Book3s v3

2010-07-01 Thread Marcelo Tosatti
On Wed, Jun 30, 2010 at 03:18:44PM +0200, Alexander Graf wrote: > Book3s suffered from my really bad shadow MMU implementation so far. So > I finally got around to implement a combined hash and list mechanism that > allows for much faster lookup of mapped pages. > > To show that it really is faste

Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()

2010-06-23 Thread Marcelo Tosatti
On Wed, Jun 23, 2010 at 12:00:47PM +0300, Avi Kivity wrote: > On 06/23/2010 12:01 PM, Takuya Yoshikawa wrote: > >(2010/06/23 17:48), Avi Kivity wrote: > > > >>>diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c > >>>index 801d9f3..bea6f7c 100644 > >>>--- a/arch/powerpc/kvm/book3s.c

Re: [PATCH 0/4] KVM: kvm_vm_ioctl_get_dirty_log() fix and cleanup

2010-06-22 Thread Marcelo Tosatti
On Tue, Jun 22, 2010 at 06:03:58PM +0900, Takuya Yoshikawa wrote: > This patch set is for making dirty logging development, and of course > maintenance, easier. Please see individual patches for details. > > Takuya > > --- > arch/ia64/kvm/kvm-ia64.c | 54 ++--

Re: [PATCH] kvm/ppc: fix build warning in kvm_arch_vcpu_ioctl_run

2010-06-11 Thread Marcelo Tosatti
On Fri, Jun 11, 2010 at 11:23:26AM +, Denis Kirjanov wrote: > Fix compile warning: > CC [M] arch/powerpc/kvm/powerpc.o > arch/powerpc/kvm/powerpc.c: In function 'kvm_arch_vcpu_ioctl_run': > arch/powerpc/kvm/powerpc.c:290: warning: 'gpr' may be used uninitialized in > this function > a

Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack

2010-06-02 Thread Marcelo Tosatti
On Mon, May 31, 2010 at 09:59:13PM +0200, Andreas Schwab wrote: > Instead of instantiating a whole thread_struct on the stack use only the > required parts of it. > > Signed-off-by: Andreas Schwab > Tested-by: Alexander Graf > --- > arch/powerpc/include/asm/kvm_fpu.h | 27 + > a

Re: Any comments? Re: [RFC][PATCH 0/12] KVM, x86, ppc, asm-generic: moving dirty bitmaps to user space

2010-06-01 Thread Marcelo Tosatti
On Tue, Jun 01, 2010 at 09:05:38PM +0900, Takuya Yoshikawa wrote: > (2010/06/01 19:55), Marcelo Tosatti wrote: > > >>>Sorry but I have to say that mmu_lock spin_lock problem was completely > >>>out of > >>>my mind. Although I looked throu

Re: Any comments? Re: [RFC][PATCH 0/12] KVM, x86, ppc, asm-generic: moving dirty bitmaps to user space

2010-06-01 Thread Marcelo Tosatti
On Mon, May 24, 2010 at 04:05:29PM +0900, Takuya Yoshikawa wrote: > (2010/05/17 18:06), Takuya Yoshikawa wrote: > > > >>User allocated bitmaps have the advantage of reducing pinned memory. > >>However we have plenty more pinned memory allocated in memory slots, so > >>by itself, user allocated bitm

Re: [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic vcpu ioctls

2010-05-14 Thread Marcelo Tosatti
On Thu, May 13, 2010 at 02:17:35PM +0300, Avi Kivity wrote: > All vcpu ioctls need to be locked, so instead of locking each one specifically > we lock at the generic dispatcher. > > This patch only updates generic ioctls and leaves arch specific ioctls alone. > > Signed-off-by: Avi Kivity > ---

Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()

2010-05-12 Thread Marcelo Tosatti
On Tue, May 11, 2010 at 01:10:49AM +0200, Alexander Graf wrote: > > On 11.05.2010, at 00:58, Hollis Blanchard wrote: > > > On Sun, May 9, 2010 at 8:26 AM, Roel Kluin wrote: > >> An index of KVM44x_GUEST_TLB_SIZE is already one too large. > >> > >> Signed-off-by: Roel Kluin > > > > Acked-by: H

Re: [RFC][PATCH 11/12] KVM: introduce new API for getting/switching dirty bitmaps

2010-05-11 Thread Marcelo Tosatti
On Tue, May 11, 2010 at 02:53:54PM +0900, Takuya Yoshikawa wrote: > (2010/05/11 12:43), Marcelo Tosatti wrote: > >On Tue, May 04, 2010 at 10:08:21PM +0900, Takuya Yoshikawa wrote: > >>+How to Get > >>+ > >>+Before calling this, you have to set the slot member of

Re: [RFC][PATCH RFC 10/12] KVM: move dirty bitmaps to user space

2010-05-10 Thread Marcelo Tosatti
On Tue, May 04, 2010 at 10:07:02PM +0900, Takuya Yoshikawa wrote: > We move dirty bitmaps to user space. > > - Allocation and destruction: we use do_mmap() and do_munmap(). >The new bitmap space is twice longer than the original one and we >use the additional space for double buffering: t

Re: [RFC][PATCH 11/12] KVM: introduce new API for getting/switching dirty bitmaps

2010-05-10 Thread Marcelo Tosatti
On Tue, May 04, 2010 at 10:08:21PM +0900, Takuya Yoshikawa wrote: > Now that dirty bitmaps are accessible from user space, we export the > addresses of these to achieve zero-copy dirty log check: > > KVM_GET_USER_DIRTY_LOG_ADDR > > We also need an API for triggering dirty bitmap switch to take

Re: [PATCH v2 0/3] kvmppc/e500: fix breaks

2010-01-23 Thread Marcelo Tosatti
On Fri, Jan 22, 2010 at 06:50:28PM +0800, Liu Yu wrote: > These patches fix current e500 break. > > v2: > patch 2: add comment about PIR > patch 3: move tlbcfg code to init Applied all (and updated 3/3), thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of

Re: [PATCH] PPC: Fix typo in rebolting code

2010-01-06 Thread Marcelo Tosatti
On Mon, Jan 04, 2010 at 10:19:22PM +0100, Alexander Graf wrote: > When we're loading bolted entries into the SLB again, we're checking if an > entry is in use and only slbmte it when it is. > > Unfortunately, the check always goes to the skip label of the first entry, > resulting in an endless loo

Re: [PATCH] PPC: Enable lightweight exits again

2010-01-06 Thread Marcelo Tosatti
On Mon, Jan 04, 2010 at 10:19:25PM +0100, Alexander Graf wrote: > The PowerPC C ABI defines that registers r14-r31 need to be preserved across > function calls. Since our exit handler is written in C, we can make use of > that > and don't need to reload r14-r31 on every entry/exit cycle. > > This

Re: build error

2010-01-05 Thread Marcelo Tosatti
On Sun, Jan 03, 2010 at 03:09:52AM +0100, Alexander Graf wrote: > Hi Marcelo, > > On 30.12.2009, at 16:40, Giuseppe Falsetti wrote: > > > Hi, > > I get this error when compile the git tree virt/kvm/kvm.git next > > > > My machine is a Xserve G5 DUAL processor, Lenny with gcc-4.3.2 > > > > HOSTC

Re: [PATCH] PPC: Adjust memory slot accesses to recent patches

2010-01-05 Thread Marcelo Tosatti
-off-by: Alexander Graf > Reported-by: Giuseppe Falsetti > CC: Marcelo Tosatti Yes, this is right. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Only expose compat ioctl when CONFIG_COMPAT

2009-10-23 Thread Marcelo Tosatti
On Fri, Oct 23, 2009 at 11:41:54AM +0200, Alexander Graf wrote: > Jan spotted that we shouldn't use a function only available when CONFIG_COMPAT > in a struct that's available without the config option. > > So since my patch introduces that, let's just not export the compat ioctl > function when C

Re: [PATCH] Enable 32bit dirty log pointers on 64bit host

2009-10-22 Thread Marcelo Tosatti
On Wed, Oct 21, 2009 at 04:08:29PM +0200, Alexander Graf wrote: > From: Arnd Bergmann > > With big endian userspace, we can't quite figure out if a pointer > is 32 bit (shifted >> 32) or 64 bit when we read a 64 bit pointer. > > This is what happens with dirty logging. To get the pointer interpr