Re: [libav-devel] [PATCH] ffplay: notify user about audio metadata switch

2011-04-28 Thread Vladimir Pantelic
On 04/28/2011 05:10 PM, Ronald S. Bultje wrote: Hi, On Thu, Apr 28, 2011 at 3:05 PM, Clément Bœsch wrote: This patch allows users to be notified about track switch on a continuous audio stream. The A-V statusbar mess up a bit the printing sometimes, I don't know how I should handle that. Also,

Re: [libav-devel] [FFmpeg-devel] GSoC project (JPEG 2000)

2011-04-28 Thread rukhsana afroz
On Wed, Apr 27, 2011 at 3:09 AM, rukhsana afroz wrote: Just have pushed one clean repository. -- Rukhsana Ruby Phd Student Department of Electrical & Computer Engineering The University of British Columbia ___ libav-devel m

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Vladimir Pantelic
On 04/28/2011 06:41 PM, Kirill Gavrilov wrote: 2011/4/28 Alex Converse mailto:alex.conve...@gmail.com>> This code already won't compile in a C++ compiler because of the way it uses malloc(). I know a lot of things why LibAV sources couldn't be compiled with C++ compiler however I intere

Re: [libav-devel] PTS preservation when decoding an h.264 frame

2011-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 28, 2011 at 5:35 PM, Dennis Munsie wrote: > I might be missing something, but it doesn't appear that the PTS field in > AVPacket is preserved when decoding an h.264 frame.  The AVFrame that gets > returned has PTS set to AV_NOPTS_VALUE.  Is this the desired behavior?  If I > pu

Re: [libav-devel] [PATCH] lavf: inspect more frames for fps when container time base is coarse

2011-04-28 Thread Luca Barbato
On 04/28/2011 02:00 PM, Måns Rullgård wrote: > And meanwhile startup overhead will be twice the already insane amount. I'm afraid fixing the issue could require few weekends with at least 3-4 people banging their heads on the code to understand what the code tries to do, write a clean replacement

Re: [libav-devel] patch signoff policy

2011-04-28 Thread Felipe Contreras
On Thu, Apr 28, 2011 at 2:40 PM, Diego Biurrun wrote: > On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote: >> >> I prefer to always s-o-b patches. >> >> Think of this scenario; a person sends a patch, it is modified by >> somebody else, and then applied. Did the original author agre

Re: [libav-devel] [PATCH] vp8: frame-multithreading.

2011-04-28 Thread Luca Barbato
On 04/23/2011 04:32 PM, Ronald S. Bultje wrote: > From: Ronald S. Bultje > > Tested on a Mac Pro, 2 CPUs, 2 cores each, OSX 10.6.6: > > time ./ffmpeg -v 0 -vsync 0 -threads [1234] -i \ > ~/Downloads/sintel_trailer_1080p_vp8_vorbis.webm \ > -f null -vcodec rawvideo -an - > 1: 0m14.630s (89.9

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 28, 2011 at 4:06 PM, Ronald S. Bultje wrote: > On Thu, Apr 28, 2011 at 3:11 PM, Ronald S. Bultje wrote: >> On Thu, Apr 28, 2011 at 2:36 PM, Justin Ruggles >> wrote: >>> The EMU_EDGE part looks correct.  We should go ahead and commit that. >> >> Did you confirm that it does not i

Re: [libav-devel] [PATCH] avio: Fix the deprecated fallback URL-prefixed open flags

2011-04-28 Thread Martin Storsjö
On Thu, 28 Apr 2011, Luca Barbato wrote: > On 4/28/11 9:41 AM, Martin Storsjö wrote: > > These should be removed at some point, but they aren't removed yet. > > The intent is to be able to recompile an old application against > > the new ABI without modifying the code, and this doesn't work > > cu

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 28, 2011 at 3:11 PM, Ronald S. Bultje wrote: > On Thu, Apr 28, 2011 at 2:36 PM, Justin Ruggles > wrote: >> The EMU_EDGE part looks correct.  We should go ahead and commit that. > > Did you confirm that it does not introduce valgrind errors when > running ffmpeg -flags emu_edge -i

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 11:08 AM, Diego Biurrun wrote: > From: Baptiste Coudurier > > Ported-by: Alex Converse > --- /dev/null > +++ b/libavcodec/s302m.c > @@ -0,0 +1,141 @@ > +/* > + * SMPTE 302M decoder > + * Copyright (c) 2008 Laurent Aimar > + * Copyright (c) 2009 Baptiste Coudurier > + *

[libav-devel] [PATCH] PTS preservation when decoding an h.264 frame

2011-04-28 Thread Dennis Munsie
On Apr 28, 2011, at 1:35 PM, Dennis Munsie wrote: > Hi everyone -- > > I might be missing something, but it doesn't appear that the PTS field in > AVPacket is preserved when decoding an h.264 frame. The AVFrame that gets > returned has PTS set to AV_NOPTS_VALUE. Is this the desired behavior?

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Ronald S. Bultje
Hi. On Thu, Apr 28, 2011 at 2:36 PM, Justin Ruggles wrote: > The EMU_EDGE part looks correct.  We should go ahead and commit that. Did you confirm that it does not introduce valgrind errors when running ffmpeg -flags emu_edge -i file.amv -f null -? Ronald ___

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Reinhard Tartler
On Thu, Apr 28, 2011 at 02:36:45PM -0400, Justin Ruggles wrote: > On 04/28/2011 01:20 PM, Aℓex Converse wrote: > > > On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler > > wrote: > >> On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote: > >>> On 04/27/2011 03:25 PM, Reinhard Tartler wr

Re: [libav-devel] [PATCH] avoid duplicate -lm in .pc files

2011-04-28 Thread Reinhard Tartler
On Wed, Apr 27, 2011 at 14:18:56 (CEST), Diego Biurrun wrote: > On Wed, Apr 27, 2011 at 08:28:19AM +0200, Reinhard Tartler wrote: >> --- >> configure |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > IIUC you can remove $LIBM from libswscale as well, since that one would > pick u

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Justin Ruggles
On 04/28/2011 01:20 PM, Aℓex Converse wrote: > On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler wrote: >> On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote: >>> On 04/27/2011 03:25 PM, Reinhard Tartler wrote: >>> From: Michael Niedermayer Reported-at: Thu, 21 Apr 201

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 11:25 AM, Justin Ruggles wrote: > Hi, > > On 04/28/2011 02:08 PM, Diego Biurrun wrote: > >> +    if (*data_size < 4 * buf_size * 8 / (avctx->bits_per_coded_sample + 4)) >> +        return -1; > > > I think this can cause invalid writes if buf_size > INT_MAX/32 Can't happen

Re: [libav-devel] [PATCH] vorbisdec: Replace some sizeof(type) by sizeof(variable).

2011-04-28 Thread Martin Storsjö
On Thu, 28 Apr 2011, Diego Biurrun wrote: > --- > libavcodec/vorbisdec.c | 41 - > 1 files changed, 24 insertions(+), 17 deletions(-) Looks good to me. Perhaps the patch subject should be changed to end in =sizeof(*variable) instead, too, but no need t

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Justin Ruggles
Hi, On 04/28/2011 02:08 PM, Diego Biurrun wrote: > +if (*data_size < 4 * buf_size * 8 / (avctx->bits_per_coded_sample + 4)) > +return -1; I think this can cause invalid writes if buf_size > INT_MAX/32 -Justin ___ libav-devel mailing list

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 11:08 AM, Diego Biurrun wrote: > > From: Baptiste Coudurier > > Ported-by: Alex Converse > --- > > This includes all review comments so far, plus a documentation entry > and random prettyprinting. > >  Changelog              |    2 + >  doc/general.texi       |    1 + >  

[libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Diego Biurrun
From: Baptiste Coudurier Ported-by: Alex Converse --- This includes all review comments so far, plus a documentation entry and random prettyprinting. Changelog |2 + doc/general.texi |1 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Alex Converse
2011/4/28 Aℓex Converse : > 2011/4/28 Aℓex Converse : >> On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles >> wrote: >>> Hi, >>> >>> On 04/27/2011 08:19 PM, Aℓex Converse wrote: >>> +    frame_size = (h >> 16) & 0x; +    channels = 2 + 2*((h >> 14) & 0x03); +    id = (h >> 6) & 0x

[libav-devel] PTS preservation when decoding an h.264 frame

2011-04-28 Thread Dennis Munsie
Hi everyone -- I might be missing something, but it doesn't appear that the PTS field in AVPacket is preserved when decoding an h.264 frame. The AVFrame that gets returned has PTS set to AV_NOPTS_VALUE. Is this the desired behavior? If I put together a patch that preserved the PTS field, wou

[libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Diego Biurrun
From: Baptiste Coudurier Ported-by: Alex Converse --- Changelog |2 + doc/general.texi |1 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 + libavcodec/s302m.c | 141 ++

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
2011/4/28 Aℓex Converse : > On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles > wrote: >> Hi, >> >> On 04/27/2011 08:19 PM, Aℓex Converse wrote: >> >>> +    frame_size = (h >> 16) & 0x; >>> +    channels = 2 + 2*((h >> 14) & 0x03); >>> +    id = (h >> 6) & 0xff; >>> +    bits = 16 + 4*((h >> 4)

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler wrote: > On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote: >> On 04/27/2011 03:25 PM, Reinhard Tartler wrote: >> >> > From: Michael Niedermayer >> > >> > Reported-at: Thu, 21 Apr 2011 14:38:25 + >> > Reported-by: Dominic Chell >

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles wrote: > Hi, > > On 04/27/2011 08:19 PM, Aℓex Converse wrote: > >> +    frame_size = (h >> 16) & 0x; >> +    channels = 2 + 2*((h >> 14) & 0x03); >> +    id = (h >> 6) & 0xff; >> +    bits = 16 + 4*((h >> 4) & 0x03); > > > This would be easier to

Re: [libav-devel] [PATCH] vf_fieldorder: Replace FFmpeg by Libav in license boilerplate.

2011-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 28, 2011 at 1:00 PM, Diego Biurrun wrote: > --- >  libavfilter/vf_fieldorder.c |    8 >  1 files changed, 4 insertions(+), 4 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/ma

[libav-devel] [PATCH] vf_fieldorder: Replace FFmpeg by Libav in license boilerplate.

2011-04-28 Thread Diego Biurrun
--- libavfilter/vf_fieldorder.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_fieldorder.c b/libavfilter/vf_fieldorder.c index 59ca778..b55640b 100644 --- a/libavfilter/vf_fieldorder.c +++ b/libavfilter/vf_fieldorder.c @@ -1,20 +1,20 @@ /* * Copy

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Kirill Gavrilov
2011/4/28 Alex Converse > This code already won't compile in a C++ compiler because of the way > it uses malloc(). > I know a lot of things why LibAV sources couldn't be compiled with C++ compiler however I interested what did you mean by malloc() usage? Usage without explicit typecast? Diego Bi

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Aℓex Converse
On Thu, Apr 28, 2011 at 9:13 AM, Diego Biurrun wrote: > On Thu, Apr 28, 2011 at 08:11:37AM -0700, Alex Converse wrote: >> On Thu, Apr 28, 2011 at 7:59 AM, Diego Biurrun wrote: >> > On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote: >> >> On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun

Re: [libav-devel] [PATCH] oggdec: fix number of stream being incremented at format context level

2011-04-28 Thread Luca Barbato
On 04/28/2011 02:35 PM, Clément Bœsch wrote: > Sure. The best way to notice the issue is changing the modified line in > the patch with av_dump_format(s, 0, s->filename, 0) and you'll notice that > kind of stuff after a few track switches (if it's a continuous bitstream): > > Stream #0.1: Inva

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 08:11:37AM -0700, Alex Converse wrote: > On Thu, Apr 28, 2011 at 7:59 AM, Diego Biurrun wrote: > > On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote: > >> On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun wrote: > >> > On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓe

Re: [libav-devel] [PATCH] ffplay: notify user about audio metadata switch

2011-04-28 Thread Kostya
On Thu, Apr 28, 2011 at 03:10:03PM +, Ronald S. Bultje wrote: > Hi, > > On Thu, Apr 28, 2011 at 3:05 PM, Clément Bœsch wrote: > > This patch allows users to be notified about track switch on a continuous > > audio stream. The A-V statusbar mess up a bit the printing sometimes, I > > don't kno

Re: [libav-devel] [FFmpeg-devel] [PATCH]: Fix decoding of mpegts streams with h264 video that does *NOT* have b frames

2011-04-28 Thread Tony Strauss
On Thu, Apr 28, 2011 at 10:14 AM, Mike Scheutzow < mike.scheut...@alcatel-lucent.com> wrote: > This problem was more difficult to solve than I expected. I've attached a > patch which takes a different approach than Tony's patch. > > One of the causes of this bug is that the h264 parser defaults lo

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Alex Converse
On Wed, Apr 27, 2011 at 9:35 PM, Kirill Gavrilov wrote: > Just notice. I don't think that usage of "class_" name is stupid. > "class" is a keyword in C++ and you can not use it as a name for variables. > However while this name appear in source file (.c, not a header, because > appearing in header

Re: [libav-devel] [PATCH 1/4] indeo3: Eliminate use of long.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 8:15 AM, Alex Converse wrote: > On Thu, Apr 28, 2011 at 3:21 AM, Felipe Contreras > wrote: >> 2011/4/28 Aℓex Converse : >> >> Why don't you use 'git send-email'? Or at least put the patches line. >> > > Because I can't retrieve the patches on the computer I commit from if

Re: [libav-devel] [PATCH 1/4] indeo3: Eliminate use of long.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 3:21 AM, Felipe Contreras wrote: > 2011/4/28 Aℓex Converse : > > Why don't you use 'git send-email'? Or at least put the patches line. > Because I can't retrieve the patches on the computer I commit from if I do that. ___ libav-d

Re: [libav-devel] [PATCH 2/4] aacdec: Guard undefined shifts with an if.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 5:04 AM, Måns Rullgård wrote: > Aℓex Converse writes: > >> There is most likely a performance hit here but the current code is >> *undefined.* >> >> Haters are welcome to send suggestions on how to do this without an if. >> >> From 554be95192ad9803f51f00fec18bf6db9a562779

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 7:59 AM, Diego Biurrun wrote: > On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote: >> On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun wrote: >> > On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote: >> >> --- /dev/null >> >> +++ b/libavcodec/s302m.c >>

Re: [libav-devel] [PATCH] ffplay: notify user about audio metadata switch

2011-04-28 Thread Ronald S. Bultje
Hi, On Thu, Apr 28, 2011 at 3:05 PM, Clément Bœsch wrote: > This patch allows users to be notified about track switch on a continuous > audio stream. The A-V statusbar mess up a bit the printing sometimes, I > don't know how I should handle that. Also, I wonder if there is an > performance issue

Re: [libav-devel] [PATCH 3/4] bitstream: Properly promote av_reverse values before shifting.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 5:08 AM, Måns Rullgård wrote: > Aℓex Converse writes: > >> From ae62aa2fca3b2cf45a98dc2f9777065bcb452797 Mon Sep 17 00:00:00 2001 >> From: Alex Converse >> Date: Tue, 26 Apr 2011 09:08:26 -0700 >> Subject: [PATCH 3/4] bitstream: Properly promote av_reverse values before

[libav-devel] [PATCH] ffplay: notify user about audio metadata switch

2011-04-28 Thread Clément Bœsch
This patch allows users to be notified about track switch on a continuous audio stream. The A-V statusbar mess up a bit the printing sometimes, I don't know how I should handle that. Also, I wonder if there is an performance issue looping on every metadata that often. Regards, -- Clément B. From

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote: > On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun wrote: > > On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote: > >> --- /dev/null > >> +++ b/libavcodec/s302m.c > >> @@ -0,0 +1,142 @@ > >> +/* > >> + * SMPTE 302M decoder > >

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Alex Converse
On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun wrote: > On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote: >> It's a little ugly but without chain demux it isn't something we can >> do particularly cleanly. This is similar to how we do LATM. >> >> Let me know if you think the git metad

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Justin Ruggles
Hi, On 04/27/2011 08:19 PM, Aℓex Converse wrote: > +frame_size = (h >> 16) & 0x; > +channels = 2 + 2*((h >> 14) & 0x03); > +id = (h >> 6) & 0xff; > +bits = 16 + 4*((h >> 4) & 0x03); This would be easier to read if aligned. like this: frame_size = (h >> 16) & 0x; channe

[libav-devel] [PATCH] vorbisdec: Replace some sizeof(type) by sizeof(variable).

2011-04-28 Thread Diego Biurrun
--- libavcodec/vorbisdec.c | 41 - 1 files changed, 24 insertions(+), 17 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index a9ddc7d..c70bd75 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -247,9 +247,9 @@

Re: [libav-devel] [PATCH] oggdec: fix number of stream being incremented at format context level

2011-04-28 Thread Clément Bœsch
On Thu, Apr 28, 2011 at 02:23:59PM +0200, Luca Barbato wrote: > On 4/28/11 1:19 PM, Clément Bœsch wrote: > >The number of streams in the Ogg context is well set to 0 but not in the > >a/v format context, so the number of stream is incremented in > >av_new_stream and leads to a leak (and maybe worst

Re: [libav-devel] [PATCH] oggdec: fix number of stream being incremented at format context level

2011-04-28 Thread Luca Barbato
On 4/28/11 1:19 PM, Clément Bœsch wrote: The number of streams in the Ogg context is well set to 0 but not in the a/v format context, so the number of stream is incremented in av_new_stream and leads to a leak (and maybe worst). The attached patch fix this. Could you please give us more context

Re: [libav-devel] [PATCH 3/4] bitstream: Properly promote av_reverse values before shifting.

2011-04-28 Thread Måns Rullgård
Aℓex Converse writes: > From ae62aa2fca3b2cf45a98dc2f9777065bcb452797 Mon Sep 17 00:00:00 2001 > From: Alex Converse > Date: Tue, 26 Apr 2011 09:08:26 -0700 > Subject: [PATCH 3/4] bitstream: Properly promote av_reverse values before > shifting. > MIME-Version: 1.0 > Content-Type: multipart/mixe

Re: [libav-devel] [PATCH 2/4] aacdec: Guard undefined shifts with an if.

2011-04-28 Thread Måns Rullgård
Aℓex Converse writes: > There is most likely a performance hit here but the current code is > *undefined.* > > Haters are welcome to send suggestions on how to do this without an if. > > From 554be95192ad9803f51f00fec18bf6db9a562779 Mon Sep 17 00:00:00 2001 > From: Alex Converse > Date: Tue, 26

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Måns Rullgård
Reinhard Tartler writes: > On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote: >> On 04/27/2011 03:25 PM, Reinhard Tartler wrote: >> >> > From: Michael Niedermayer >> > >> > Reported-at: Thu, 21 Apr 2011 14:38:25 + >> > Reported-by: Dominic Chell >> > Signed-off-by: Michael Ni

Re: [libav-devel] [PATCH] lavf: inspect more frames for fps when container time base is coarse

2011-04-28 Thread Måns Rullgård
Luca Barbato writes: > On 4/28/11 10:20 AM, Reinhard Tartler wrote: >> From: Anssi Hannula >> >> As per issue2629, most 23.976fps matroska H.264 files are incorrectly >> detected as 24fps, as the matroska timestamps usually have only >> millisecond precision. >> >> Fix that by doubling the amount

Re: [libav-devel] patch signoff policy

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote: > > I prefer to always s-o-b patches. > > Think of this scenario; a person sends a patch, it is modified by > somebody else, and then applied. Did the original author agree to > those changes? If the s-o-b is there, yes, otherwise

Re: [libav-devel] [PATCH] AMV: Fix possibly exploitable crash.

2011-04-28 Thread Reinhard Tartler
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote: > On 04/27/2011 03:25 PM, Reinhard Tartler wrote: > > > From: Michael Niedermayer > > > > Reported-at: Thu, 21 Apr 2011 14:38:25 + > > Reported-by: Dominic Chell > > Signed-off-by: Michael Niedermayer > > (cherry picked from c

Re: [libav-devel] patch signoff policy

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 01:14:17PM +0200, Diego Biurrun wrote: > On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote: > > On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun wrote: > > > On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote: > > >> > > >> On Tue, Apr 26, 2011 at

Re: [libav-devel] [PATCH] vorbisdec: Replace some sizeof(type) by sizeof(variable).

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 12:14:43PM +0300, Martin Storsjö wrote: > On Thu, 28 Apr 2011, Diego Biurrun wrote: > > --- a/libavcodec/vorbisdec.c > > +++ b/libavcodec/vorbisdec.c > > @@ -753,7 +753,7 @@ static int > > vorbis_parse_setup_hdr_mappings(vorbis_context *vc) > > > > if (mapping_se

Re: [libav-devel] [PATCH] dir-local variables for emacs

2011-04-28 Thread Andrea Crotti
"Ronald S. Bultje" writes: > Yeah it's still interesting, I like this patch a lot more. :-). I'm glad it's better now, since there aren't other comments yet I send another version, c-indentation-style had to be c-file-style. I also added a couple more variables and commented much more. I tested

[libav-devel] [PATCH] oggdec: fix number of stream being incremented at format context level

2011-04-28 Thread Clément Bœsch
The number of streams in the Ogg context is well set to 0 but not in the a/v format context, so the number of stream is incremented in av_new_stream and leads to a leak (and maybe worst). The attached patch fix this. -- Clément B. From ec643696bd0bae8221eb5483cecebacc19e8db57 Mon Sep 17 00:00:00

Re: [libav-devel] patch signoff policy

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote: > On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun wrote: > > On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote: > >> > >> On Tue, Apr 26, 2011 at 2:56 PM, Luca Barbato wrote: > >> > On 4/26/11 4:47 PM, Diego Biurrun w

Re: [libav-devel] [PATCH] lavf: inspect more frames for fps when container time base is coarse

2011-04-28 Thread Luca Barbato
On 4/28/11 10:20 AM, Reinhard Tartler wrote: From: Anssi Hannula As per issue2629, most 23.976fps matroska H.264 files are incorrectly detected as 24fps, as the matroska timestamps usually have only millisecond precision. Fix that by doubling the amount of timestamps inspected for frame rate fo

Re: [libav-devel] patch signoff policy

2011-04-28 Thread Felipe Contreras
On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun wrote: > On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote: >> >> On Tue, Apr 26, 2011 at 2:56 PM, Luca Barbato wrote: >> > On 4/26/11 4:47 PM, Diego Biurrun wrote: >> >> I am confused whether or not I should signoff patches and/or sig

Re: [libav-devel] [PATCH 1/4] indeo3: Eliminate use of long.

2011-04-28 Thread Felipe Contreras
2011/4/28 Aℓex Converse : Why don't you use 'git send-email'? Or at least put the patches line. -- Felipe Contreras ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] discard cropping values in a consistent way

2011-04-28 Thread Luca Barbato
On 4/22/11 5:17 PM, Vittorio Giovara wrote: /As you know in h264 videos you can specify any crop values in any direction; normally only the bottom part is used because 1080 is not multiple of 16, however Libav supports cropping only partially. Currently it ignores the left and top values but com

Re: [libav-devel] [PATCH] avio: Fix the deprecated fallback URL-prefixed open flags

2011-04-28 Thread Luca Barbato
On 4/28/11 9:41 AM, Martin Storsjö wrote: These should be removed at some point, but they aren't removed yet. The intent is to be able to recompile an old application against the new ABI without modifying the code, and this doesn't work currently. Ok. ___

Re: [libav-devel] [PATCH] lavf: inspect more frames for fps when container time base is coarse

2011-04-28 Thread Luca Barbato
On 4/28/11 10:20 AM, Reinhard Tartler wrote: From: Anssi Hannula As per issue2629, most 23.976fps matroska H.264 files are incorrectly detected as 24fps, as the matroska timestamps usually have only millisecond precision. Fix that by doubling the amount of timestamps inspected for frame rate fo

Re: [libav-devel] [PATCH] vorbisdec: Replace some sizeof(type) by sizeof(variable).

2011-04-28 Thread Martin Storsjö
On Thu, 28 Apr 2011, Diego Biurrun wrote: > --- > libavcodec/vorbisdec.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c > index a9ddc7d..4bd842e 100644 > --- a/libavcodec/vorbisdec.c > +++ b/libavcodec/vorbisdec.

[libav-devel] [PATCH] vorbisdec: Replace some sizeof(type) by sizeof(variable).

2011-04-28 Thread Diego Biurrun
--- libavcodec/vorbisdec.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index a9ddc7d..4bd842e 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -735,8 +735,8 @@ static int vorbis_parse_setup_hdr_map

Re: [libav-devel] [PATCH] Port s302m decoder from FFmbc 0.3.

2011-04-28 Thread Diego Biurrun
On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote: > It's a little ugly but without chain demux it isn't something we can > do particularly cleanly. This is similar to how we do LATM. > > Let me know if you think the git metadata should be different. > Ported-by: Alex Converse > ---

Re: [libav-devel] [PATCH 3/6] vorbisdec: Rename silly "class_" variable to plain "class".

2011-04-28 Thread Diego Biurrun
On Thu, Apr 28, 2011 at 08:35:46AM +0400, Kirill Gavrilov wrote: > Just notice. I don't think that usage of "class_" name is stupid. > "class" is a keyword in C++ and you can not use it as a name for variables. > However while this name appear in source file (.c, not a header, because > appearing i

[libav-devel] [PATCH] lavf: inspect more frames for fps when container time base is coarse

2011-04-28 Thread Reinhard Tartler
From: Anssi Hannula As per issue2629, most 23.976fps matroska H.264 files are incorrectly detected as 24fps, as the matroska timestamps usually have only millisecond precision. Fix that by doubling the amount of timestamps inspected for frame rate for streams that have coarse time base. This als

[libav-devel] [PATCH] avio: Fix the deprecated fallback URL-prefixed open flags

2011-04-28 Thread Martin Storsjö
While deprecated, they're totally useless as long as their values are different from the AVIO_FLAG values that are used internally. Currently, this leads to old libav applications still compiling correctly (since we haven't removed the fallback wrappers), but failing since the functions internally

Re: [libav-devel] [PATCH] no infinite wait on remote host disconnect

2011-04-28 Thread Martin Storsjö
On Tue, 26 Apr 2011, Martin Storsjö wrote: > On Tue, 26 Apr 2011, Gil Pedersen wrote: > > > Attached patch will allow ff_network_wait_fd() to return when the fd > > encounters an error or disconnection (HUP). Once returned, the next > > read/write call on the fd will result in an error and poss