Re: [libav-devel] [PATCH 2/2] h264: convert 8-bit qpel inlined assembly to yasm

Hi, On Wed, Aug 1, 2012 at 10:29 PM, Daniel Kang wrote: > On Wed, Aug 1, 2012 at 5:22 AM, Måns Rullgård wrote: >> >> Daniel Kang writes: >> >> > Can I have access to a setup that doesn't have inlined assembly? >> >> --extra-cflags=-D__asm__=error should make it fail nicely. > > > This gives me

Re: [libav-devel] [PATCH 2/2] H.264: Convert 8-bit qpel inlined assembly to yasm

On Thu, Aug 2, 2012 at 1:30 AM, wrote: > From: Daniel Kang > > --- > libavcodec/x86/Makefile |3 +- > libavcodec/x86/dsputil_mmx.c| 81 +--- > libavcodec/x86/dsputil_yasm.asm | 42 ++ > libavcodec/x86/h264_qpel.asm| 850 +++ > libavcodec/

[libav-devel] [PATCH 1/2] H264: Remove 3dnow qpel code.

From: Daniel Kang The only CPUs that have 3dnow and don't have mmxext are 12 years old. --- libavcodec/x86/dsputil_mmx.c | 11 ++- libavcodec/x86/dsputil_mmx_avg_template.c |8 ++-- libavcodec/x86/h264_qpel_mmx.c|4 3 files changed, 8 insertion

Re: [libav-devel] [PATCH 2/2] h264: convert 8-bit qpel inlined assembly to yasm

On Wed, Aug 1, 2012 at 5:22 AM, Måns Rullgård wrote: > Daniel Kang writes: > > > Can I have access to a setup that doesn't have inlined assembly? > > --extra-cflags=-D__asm__=error should make it fail nicely. This gives me bizarre errors like: /usr/include/x86_64-linux-gnu/asm/posix_types_64.

Re: [libav-devel] [PATCH] wmapro: prevent division by zero when sample rate is unspecified

On Wed, Aug 01, 2012 at 11:23:52PM -0400, Sean McGovern wrote: > This fixes Bugzilla #327: > --- > libavcodec/wmaprodec.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c > index 30a43c8..88c33c3 100644 > --- a/libav

[libav-devel] [PATCH] wmapro: prevent division by zero when sample rate is unspecified

This fixes Bugzilla #327: --- libavcodec/wmaprodec.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 30a43c8..88c33c3 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -335,6 +335,11 @@ static av_c

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

On 01/08/12 22:44, Luca Barbato wrote: > On 01/08/12 12:13, Samuel Pitoiset wrote: >> --- >> libavformat/rtmpproto.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c >> index 6044425..8c0ecb2 100644 >> --- a/libavfor

Re: [libav-devel] [PATCH] fate: Only test enabled filters

Diego Biurrun writes: > This fixes running FATE without --enable-gpl. > --- > tests/Makefile|3 ++- > tests/fate/filter.mak | 18 +- > 2 files changed, 11 insertions(+), 10 deletions(-) Your patch makes me notice that that file needs a rather different overhaul. I

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

Hi, On Wed, Aug 1, 2012 at 5:38 PM, Loren Merritt wrote: > On Thu, 2 Aug 2012, Diego Biurrun wrote: >> On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: >>> On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: --- a/libavcodec/x86/fft_mmx.asm +++ b/libavcodec/x86/fft_mm

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

On Thu, 2 Aug 2012, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: >> On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: >>> --- a/libavcodec/x86/fft_mmx.asm >>> +++ b/libavcodec/x86/fft_mmx.asm >>> @@ -105,7 +105,8 @@ SECTION_TEXT >>> pxor %3,

Re: [libav-devel] [PATCH 04/10] idcin: set channel_layout

On Wed, Aug 1, 2012 at 2:36 PM, Justin Ruggles wrote: > --- > libavformat/idcin.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/libavformat/idcin.c b/libavformat/idcin.c > index 113c66e..c8b8225 100644 > --- a/libavformat/idcin.c > +++ b/libavformat/idcin.c > @@

Re: [libav-devel] [PATCH 01/10] idcinvideo: correctly set AVFrame defaults

On 01/08/12 23:36, Justin Ruggles wrote: > --- > libavcodec/idcinvideo.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/idcinvideo.c b/libavcodec/idcinvideo.c > index c936ebb..65414ee 100644 > --- a/libavcodec/idcinvideo.c > +++ b/libavcodec/idcinvideo.c

Re: [libav-devel] [PATCH] fate: Only test enabled filters

On 02/08/12 00:39, Diego Biurrun wrote: > This fixes running FATE without --enable-gpl. > --- > tests/Makefile|3 ++- > tests/fate/filter.mak | 18 +- > 2 files changed, 11 insertions(+), 10 deletions(-) Looks ok. ___ li

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

Hi, On Wed, Aug 1, 2012 at 3:55 PM, Diego Biurrun wrote: > +%macro PSWAPD 2 > +%if cpuflag(mmxext) > +pshufw %1, %2, 0x4e If you change 0x4e to q1032, patch is OK with me. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.lib

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

--- libavcodec/x86/fft_mmx.asm| 16 ++-- libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 16 insertions(+), 29 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index 7746c

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

On Wed, Aug 01, 2012 at 10:57:47AM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun wrote: > > +%macro PSWAPD 2 > > +%if cpuflag(sse) > > +pshufw %1, %2, 0x4e > > As Loren said earlier, this is mmx2, not sse. Rebase screwup, I had this fixed at some point... D

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: > > --- a/libavcodec/x86/fft_mmx.asm > > +++ b/libavcodec/x86/fft_mmx.asm > > @@ -105,7 +105,8 @@ SECTION_TEXT > > pxor %3, [ps_m1p1] ; {t8,t7} > > mova %6, %1

[libav-devel] [PATCH] fate: Only test enabled filters

This fixes running FATE without --enable-gpl. --- tests/Makefile|3 ++- tests/fate/filter.mak | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 0b11102..2ab529e 100644 --- a/tests/Makefile +++ b/tests/Makef

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Wed, 2012-08-01 at 14:36 -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 2:31 PM, Uoti Urpala wrote: > > On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote: > >> If you insist on arguing, I politely request that you at least be right. > > > > If you get to that level of completely l

Re: [libav-devel] [PATCH] msvc: check for snprintf

Uoti Urpala writes: > On Wed, 2012-08-01 at 21:49 +0100, Måns Rullgård wrote: >> Uoti Urpala writes: >> >> > On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote: >> >> >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) >> > >> >> >>> +if ((int)bufsize <= 0) return -1;

Re: [libav-devel] [PATCH] msvc: check for snprintf

Hi, On Wed, Aug 1, 2012 at 2:31 PM, Uoti Urpala wrote: > On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote: >> Uoti Urpala writes: >> > On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote: >> >> It is not possible to get those semantics using the regular Windows >> >> functions. >> > >>

[libav-devel] [PATCH 10/10] idcin: return 0 from idcin_read_packet() on success.

This matches the AVInputFormat.read_packet() API. --- libavformat/idcin.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index bffa2f4..dea4f91 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -321,7 +321,7 @@ static

[libav-devel] [PATCH 09/10] idcin: check for EOF before reading video chunk size

--- libavformat/idcin.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 2d506ff..bffa2f4 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -278,6 +278,8 @@ static int idcin_read_packet(AVFormatContext *s,

[libav-devel] [PATCH 08/10] idcin: check for integer overflow when calling av_get_packet()

chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the packet size. --- libavformat/idcin.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 67915e6..2d506ff 100644 --- a/libavformat/idcin.c +++ b/liba

[libav-devel] [PATCH 07/10] idcin: allow seeking back to the first packet

--- libavformat/idcin.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 638377c..67915e6 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -89,7 +89,7 @@ typedef struct IdcinDemuxContext {

[libav-devel] [PATCH 06/10] idcin: set AV_PKT_FLAG_KEY for video packets with a palette

--- libavformat/idcin.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 0e93a59..638377c 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -292,6 +292,7 @@ static int idcin_read_packet(AVFormatContext *s,

[libav-devel] [PATCH 05/10] idcin: set start_time and packet duration instead of manually tracking pts.

Also, use 1 / sample_rate for audio stream time_base. --- libavformat/idcin.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index c8b8225..0e93a59 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -82,6 +8

[libav-devel] [PATCH 04/10] idcin: set channel_layout

--- libavformat/idcin.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 113c66e..c8b8225 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -68,6 +68,7 @@ * transmitting them to the video decoder */ +

[libav-devel] [PATCH 03/10] idcin: fix check for presence of an audio stream

--- libavformat/idcin.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index f278f42..113c66e 100644 --- a/libavformat/idcin.c +++ b/libavformat/idcin.c @@ -170,6 +170,10 @@ static int idcin_read_header(AVFormatContext *s

[libav-devel] [PATCH 02/10] idcin: validate header parameters

Avoids using unsupported parameters and signed integer overflows. --- libavformat/idcin.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 6a9b0ca..f278f42 100644 --- a/libavformat/idcin.c +++ b/libavformat/

[libav-devel] [PATCH 01/10] idcinvideo: correctly set AVFrame defaults

--- libavcodec/idcinvideo.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/idcinvideo.c b/libavcodec/idcinvideo.c index c936ebb..65414ee 100644 --- a/libavcodec/idcinvideo.c +++ b/libavcodec/idcinvideo.c @@ -166,7 +166,7 @@ static av_cold int idcin_decode_init

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Wed, 2012-08-01 at 21:55 +0100, Måns Rullgård wrote: > Uoti Urpala writes: > > On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote: > >> It is not possible to get those semantics using the regular Windows > >> functions. > > > > Of course it is, with enough workarounds (this is already an at

Re: [libav-devel] [PATCH] eamad: Use dsputils instead of its own bswap16_buf

On 08/01/2012 04:22 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/eamad.c |9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c > index ca74393..d7e65db 100644 > --- a/libavcodec/eamad.c > ++

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Wed, 2012-08-01 at 21:49 +0100, Måns Rullgård wrote: > Uoti Urpala writes: > > > On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote: > >> >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) > > > >> >>> +if ((int)bufsize <= 0) return -1; > > > >> If bufsize > INT_MAX,

Re: [libav-devel] [PATCH] rtmp: add functions for reading AMF values

On 01/08/12 11:25, Jordi Ortiz wrote: > --- > libavformat/rtmppkt.c | 45 + > libavformat/rtmppkt.h | 42 ++ > 2 files changed, 87 insertions(+) > Seems fine to me. I'd commit it tomorrow. lu __

Re: [libav-devel] [PATCH 1/2] (WIP) rtmp: Add message tracking

On 01/08/12 12:12, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 278 > > 1 file changed, 161 insertions(+), 117 deletions(-) Seems better. Let me try it. ___ libav-devel mailing list libav-de

Re: [libav-devel] [PATCH] msvc: check for snprintf

Uoti Urpala writes: > On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote: >> Uoti Urpala writes: >> >> +ret = vsnprintf(buffer, bufsize-1, fmt, ap); >> > >> > IIRC MSVC (or the C library) does not support all standard format >> > modifiers, so unless this vsnprintf comes from elsewhere,

Re: [libav-devel] [PATCH 1/3] api-example: update to new audio encoding API.

On Wed, 1 Aug 2012 20:39:36 +0100, Kieran Kunhya wrote: > > +/* the codec gives us the frame size, in samples, > > + * we calculate the size of the samples buffer in bytes */ > > +buffer_size = av_samples_get_buffer_size(NULL, c->channels, > > c->frame_size, > > +

Re: [libav-devel] [PATCH] msvc: check for snprintf

Uoti Urpala writes: > On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote: >> >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) > >> >>> +if ((int)bufsize <= 0) return -1; > >> If bufsize > INT_MAX, that cast has unspecified behaviour. > > No, it's implementation-define

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Wed, 2012-08-01 at 21:34 +0100, Måns Rullgård wrote: > Uoti Urpala writes: > >> +ret = vsnprintf(buffer, bufsize-1, fmt, ap); > > > > IIRC MSVC (or the C library) does not support all standard format > > modifiers, so unless this vsnprintf comes from elsewhere, you need more > > to get full

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

On 01/08/12 12:13, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c > index 6044425..8c0ecb2 100644 > --- a/libavformat/rtmpproto.c > +++ b/libavformat/rtmpproto.c

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Wed, 2012-08-01 at 21:22 +0100, Måns Rullgård wrote: > >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) > >>> +if ((int)bufsize <= 0) return -1; > If bufsize > INT_MAX, that cast has unspecified behaviour. No, it's implementation-defined (you're probably confusing it

Re: [libav-devel] [PATCH] msvc: check for snprintf

Uoti Urpala writes: > On Thu, 2012-07-26 at 07:32 +0200, Luca Barbato wrote: >> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) >> +{ >> +va_list ap; >> +int ret; >> + >> +if ((int)bufsize <= 0) return -1; > > bufsize == 0 is valid. Of course zero is a perfectly val

Re: [libav-devel] [PATCH] msvc: check for snprintf

"Ronald S. Bultje" writes: > Hi, > > On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård wrote: >> Luca Barbato writes: >> >>> +#if !HAVE_SNPRINTF >>> +#ifdef _MSC_VER >>> +#define vsnprintf _vsnprintf >>> +#endif >>> + >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) >>> +{ >>>

[libav-devel] [PATCH] eamad: Use dsputils instead of its own bswap16_buf

Signed-off-by: Derek Buitenhuis --- libavcodec/eamad.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c index ca74393..d7e65db 100644 --- a/libavcodec/eamad.c +++ b/libavcodec/eamad.c @@ -57,13 +57,6 @@ typedef struct MadContex

Re: [libav-devel] [PATCH] msvc: check for snprintf

"Ronald S. Bultje" writes: > Hi, > > On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård wrote: >> Luca Barbato writes: >> >>> +#if !HAVE_SNPRINTF >>> +#ifdef _MSC_VER >>> +#define vsnprintf _vsnprintf >>> +#endif >>> + >>> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) >>> +{ >>>

Re: [libav-devel] [PATCH] msvc: check for snprintf

On Thu, 2012-07-26 at 07:32 +0200, Luca Barbato wrote: > +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) > +{ > +va_list ap; > +int ret; > + > +if ((int)bufsize <= 0) return -1; bufsize == 0 is valid. > +ret = vsnprintf(buffer, bufsize-1, fmt, ap); IIRC MSVC (or

Re: [libav-devel] [PATCH 1/3] api-example: update to new audio encoding API.

> +/* the codec gives us the frame size, in samples, > + * we calculate the size of the samples buffer in bytes */ > +buffer_size = av_samples_get_buffer_size(NULL, c->channels, > c->frame_size, > + c->sample_fmt, 0); > +samples = av_mall

Re: [libav-devel] [PATCH] msvc: check for snprintf

Hi, On Wed, Aug 1, 2012 at 11:58 AM, Måns Rullgård wrote: > Luca Barbato writes: > >> +#if !HAVE_SNPRINTF >> +#ifdef _MSC_VER >> +#define vsnprintf _vsnprintf >> +#endif >> + >> +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) >> +{ >> +va_list ap; >> +int ret; >> + >> +

Re: [libav-devel] [PATCH v4] Canopus Lossless decoder

On Wed, Aug 01, 2012 at 02:46:53PM -0400, Derek Buitenhuis wrote: > At the moment it only does BGR24, but I plan to add the rest after. > > Signed-off-by: Derek Buitenhuis > --- > Changelog |1 + > doc/general.texi |1 + > libavcodec/Makefile|1 + > libavcodec/

Re: [libav-devel] [PATCH] msvc: check for snprintf

Luca Barbato writes: > +#if !HAVE_SNPRINTF > +#ifdef _MSC_VER > +#define vsnprintf _vsnprintf > +#endif > + > +int snprintf(char *buffer, size_t bufsize, const char *fmt, ...) > +{ > +va_list ap; > +int ret; > + > +if ((int)bufsize <= 0) return -1; > +va_start(ap, fmt); > +ret

[libav-devel] [PATCH v4] Canopus Lossless decoder

At the moment it only does BGR24, but I plan to add the rest after. Signed-off-by: Derek Buitenhuis --- Changelog |1 + doc/general.texi |1 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 + libavcodec/cllc.c | 2

Re: [libav-devel] [PATCH v3] Canopus Lossless decoder

On Wed, Aug 01, 2012 at 01:50:32PM -0400, Derek Buitenhuis wrote: > diff --git a/libavcodec/version.h b/libavcodec/version.h > index acad4d4..a74b0ad 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -27,7 +27,7 @@ > */ > > #define LIBAVCODEC_VERSION_MAJOR 54 > -#define LIB

Re: [libav-devel] [PATCH v3] Canopus Lossless decoder

On Wed, Aug 01, 2012 at 01:50:32PM -0400, Derek Buitenhuis wrote: > At the moment it only does BGR24, but I plan to add the rest after. > > Signed-off-by: Derek Buitenhuis > --- > Changelog |1 + > doc/general.texi |1 + > libavcodec/Makefile|1 + > libavcodec/

Re: [libav-devel] [PATCH] msvc: check for snprintf

Hi, On Wed, Jul 25, 2012 at 10:35 PM, Måns Rullgård wrote: > Luca Barbato writes: > >> From: "Ronald S. Bultje" >> >> --- >> >> Here my initial twist about it, ideally I'd consider moving os_support >> in libavu and include it automagically from config.h >> >> configure |2 ++

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

Hi, On Wed, Aug 1, 2012 at 10:53 AM, Diego Biurrun wrote: > --- a/libavcodec/x86/fft_mmx.asm [..] > -%elifidn %1, %2 > -movd [r0+12], %1 > -punpckhdq %1, [r0+8] > -%else If you remove this macro from this file, the callers with %1==%2 need to use the code directly, or call a different ma

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

--- libavcodec/x86/fft_mmx.asm| 13 - libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 14 insertions(+), 28 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index 7746cdd.

[libav-devel] [PATCH v3] Canopus Lossless decoder

At the moment it only does BGR24, but I plan to add the rest after. Signed-off-by: Derek Buitenhuis --- Changelog |1 + doc/general.texi |1 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h |1 + libavcodec/cllc.c | 2

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

On 01/08/2012 12:27 PM, Samuel Pitoiset wrote: > 0x02 is a magic number defined in the rtmp specification which > indicates that data is string. > I don't think a comment is needed here because it's already specified > in the error message. OK. - Derek

Re: [libav-devel] [PATCH] x86: PALIGNR: port to cpuflags

On 08/01/2012 12:18 PM, Diego Biurrun wrote: > --- > libavcodec/x86/h264_intrapred.asm | 27 --- > libavcodec/x86/h264_intrapred_10bit.asm | 16 > libavcodec/x86/h264_qpel_10bit.asm |4 > libavutil/x86/x86util.asm | 1

Re: [libav-devel] [PATCH] api-example: update to new audio encoding API.

On 08/01/2012 02:35 AM, Anton Khirnov wrote: > --- > libavcodec/api-example.c | 137 > -- > 1 file changed, 120 insertions(+), 17 deletions(-) LGTM -Justin ___ libav-devel mailing list libav-devel@libav.or

Re: [libav-devel] [PATCH] Revert "dct-test: allow to compile without HAVE_INLINE_ASM."

On Wed, Aug 01, 2012 at 07:15:13PM +0200, Kostya Shishkov wrote: > On Wed, Aug 01, 2012 at 09:30:33AM -0700, Ronald S. Bultje wrote: > > From: "Ronald S. Bultje" > > > > This reverts commit ddbe71b44fc810cc39b576bf0047f89090cfabcb. > > I forgot to remove it from my tree before pushing another pat

[libav-devel] [PATCH] x86: dct32: port to cpuflags

--- libavcodec/x86/dct32_sse.asm | 74 ++--- 1 files changed, 25 insertions(+), 49 deletions(-) diff --git a/libavcodec/x86/dct32_sse.asm b/libavcodec/x86/dct32_sse.asm index 20a5c7b..65fac09 100644 --- a/libavcodec/x86/dct32_sse.asm +++ b/libavcodec/x86/dct3

Re: [libav-devel] [PATCH] Revert "dct-test: allow to compile without HAVE_INLINE_ASM."

On Wed, Aug 01, 2012 at 09:30:33AM -0700, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > This reverts commit ddbe71b44fc810cc39b576bf0047f89090cfabcb. > I forgot to remove it from my tree before pushing another patch. > --- > libavcodec/dct-test.c |2 +- > 1 file changed, 1 insertion

[libav-devel] [PATCH] Revert "dct-test: allow to compile without HAVE_INLINE_ASM."

From: "Ronald S. Bultje" This reverts commit ddbe71b44fc810cc39b576bf0047f89090cfabcb. I forgot to remove it from my tree before pushing another patch. --- libavcodec/dct-test.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c i

Re: [libav-devel] [PATCH] vc1dec: remove useless #include simple_idct.h

On Wed, Aug 01, 2012 at 05:15:47PM +0100, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/vc1dec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c > index c6cbfc1..e36cc0d 100644 > --- a/libavcodec/vc1dec.c > +++ b/libavcod

Re: [libav-devel] [PATCH] vc1dec: remove useless #include simple_idct.h

On Wed, Aug 01, 2012 at 05:15:47PM +0100, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/vc1dec.c | 1 - > 1 file changed, 1 deletion(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

On Wed, Aug 1, 2012 at 6:09 PM, Derek Buitenhuis wrote: > On 01/08/2012 6:13 AM, Samuel Pitoiset wrote: >> --- >> libavformat/rtmpproto.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) > > Looks OK, but I have no idea where the magic numbers come from > for this or the lines follow

Re: [libav-devel] [PATCH] idcin: check for integer overflow when calling av_get_packet()

On Wed, Aug 01, 2012 at 11:31:23AM -0400, Justin Ruggles wrote: > chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the > packet size. > --- > libavformat/idcin.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/libavformat/idcin.c b/libavfo

[libav-devel] [PATCH] x86: PALIGNR: port to cpuflags

--- libavcodec/x86/h264_intrapred.asm | 27 --- libavcodec/x86/h264_intrapred_10bit.asm | 16 libavcodec/x86/h264_qpel_10bit.asm |4 libavutil/x86/x86util.asm | 16 libswscale/x86/output.asm

[libav-devel] [PATCH] vc1dec: remove useless #include simple_idct.h

Signed-off-by: Mans Rullgard --- libavcodec/vc1dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index c6cbfc1..e36cc0d 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -36,7 +36,6 @@ #include "vc1acdata.h" #include "msmpeg4data.h"

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

On Wed, Aug 01, 2012 at 07:36:09AM -0700, Ronald S. Bultje wrote: > On Wed, Aug 1, 2012 at 6:24 AM, Diego Biurrun wrote: > > On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote: > >> On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: > >> > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns R

Re: [libav-devel] [PATCH 2/2] rtmp: Prevent handling of an incorrect invoke packet

On 01/08/2012 6:13 AM, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Looks OK, but I have no idea where the magic numbers come from for this or the lines following it. Perhaps you can add comments in a separate patch? - Derek

[libav-devel] [PATCH 2/2] rtmp: Add a new option 'rtmp_subscribe'

This option specifies the name of live stream to subscribe. Defaults to rtmp_playpath. --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 9 +++-- libavformat/version.h | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi

[libav-devel] [PATCH 1/2] rtmp: Add support for subscribing live streams

When streaming live streams using the Akamai, Edgecast or Limelight CDN, players cannot simply connect to the live stream. Instead, they have to subscribe to it, by sending an FC Subscribe call to the server. --- libavformat/rtmpproto.c | 28 1 file changed, 28 inserti

[libav-devel] [PATCH] idcin: check for integer overflow when calling av_get_packet()

chunk_size is unsigned 32-bit, but av_get_packet() takes a signed int as the packet size. --- libavformat/idcin.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavformat/idcin.c b/libavformat/idcin.c index 6a9b0ca..3acbc92 100644 --- a/libavformat/idcin.c +++ b/lib

[libav-devel] [PATCH 14/15] lavr: x86: optimized 2-channel flt to fltp conversion

--- libavresample/x86/audio_convert.asm| 33 libavresample/x86/audio_convert_init.c |9 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/libavresample/x86/audio_convert.asm b/libavresample/x86/audio_convert.asm index bc79f65..16cf

[libav-devel] [PATCH 12/15] lavr: x86: optimized 2-channel flt to s16p conversion

--- libavresample/x86/audio_convert.asm| 47 libavresample/x86/audio_convert_init.c |9 ++ 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/libavresample/x86/audio_convert.asm b/libavresample/x86/audio_convert.asm index e1a4cc9..ac6e32

[libav-devel] [PATCH 10/15] lavr: x86: optimized 2-channel s16 to fltp conversion

--- libavresample/x86/audio_convert.asm| 40 libavresample/x86/audio_convert_init.c | 13 ++ 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/libavresample/x86/audio_convert.asm b/libavresample/x86/audio_convert.asm index 8be2f3c..31

[libav-devel] [PATCH 08/15] lavr: x86: optimized 2-channel s16 to s16p conversion

--- libavresample/x86/audio_convert.asm| 51 libavresample/x86/audio_convert_init.c | 15 + libavresample/x86/util.asm |6 3 files changed, 72 insertions(+), 0 deletions(-) diff --git a/libavresample/x86/audio_convert.asm b/li

Re: [libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

Hi, On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun wrote: > --- > libavcodec/x86/fft_mmx.asm| 19 --- > libavcodec/x86/fmtconvert.asm | 17 ++--- > libavutil/x86/x86util.asm | 12 > 3 files changed, 18 insertions(+), 30 deletions(-) > > diff

Re: [libav-devel] [PATCH] x86: vp8dsp: port FILTER_BILINEAR macro to cpuflags

Hi, On Wed, Aug 1, 2012 at 5:08 AM, Diego Biurrun wrote: > +FILTER_BILINEAR 8, 7, m2 > INIT_MMX ssse3 > -FILTER_BILINEAR_SSSE3 4 > +FILTER_BILINEAR 4, 7, m2 > INIT_XMM ssse3 > -FILTER_BILINEAR_SSSE3 8 > +FILTER_BILINEAR 8, 5, m1 So, uhm, we should probably discuss this on IRC before you send m

Re: [libav-devel] [PATCH 34/45] x86: PABSW: port to cpuflags

On 07/31/2012 06:17 PM, Diego Biurrun wrote: > --- > libavcodec/x86/vc1dsp_yasm.asm |3 --- > libavutil/x86/x86util.asm | 22 ++ > 2 files changed, 10 insertions(+), 15 deletions(-) patch looks fine. But I think ideally PABSW should be merged with ABS1. It's quite

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

Hi, On Wed, Aug 1, 2012 at 6:24 AM, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote: >> On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: >> > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote: >> > > "Ronald S. Bultje" writes: >> > > > On Tue, Ju

Re: [libav-devel] [PATCH 33/45] x86: PALIGNR: port to cpuflags

On 07/31/2012 06:17 PM, Diego Biurrun wrote: > --- > libavcodec/x86/h264_intrapred.asm | 27 --- > libavcodec/x86/h264_intrapred_10bit.asm | 16 > libavcodec/x86/h264_qpel_10bit.asm |4 > libavutil/x86/x86util.asm | 1

Re: [libav-devel] [RFC] doxy for internal API

On 08/01/2012 07:48 AM, an...@khirnov.net wrote: > > Hi, > I have a disagreement with Diego about generating doxygen docs. > > Currently we generate doxygen for all files in Libav, which IMO leads to > horribly cluttered output. > See e.g. > https://libav.org/doxygen/master/files.html > https://l

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

On Wed, Aug 01, 2012 at 04:04:50PM +0200, Janne Grunau wrote: > On 2012-08-01 15:24:37 +0200, Diego Biurrun wrote: > > On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote: > > > On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: > > > > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgå

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

On 2012-08-01 15:24:37 +0200, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote: > > On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: > > > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote: > > > > "Ronald S. Bultje" writes: > > > > > On Tue, Jul 31

Re: [libav-devel] [PATCH] dct-test: always link with aandcttab.o

On Wed, Aug 01, 2012 at 02:32:24PM +0100, Mans Rullgard wrote: > This allows building dct-test even if aandcttab.o is not pulled in > by any enabled codec. The DCT with which these tables are used does > not use them directly, so building it without the tables is possible. > --- > libavcodec/Make

Re: [libav-devel] [PATCH] dct-test: always link with aandcttab.o

On Wed, Aug 01, 2012 at 02:32:24PM +0100, Mans Rullgard wrote: > This allows building dct-test even if aandcttab.o is not pulled in > by any enabled codec. The DCT with which these tables are used does > not use them directly, so building it without the tables is possible. > > Signed-off-by: Mans

[libav-devel] [PATCH] dct-test: always link with aandcttab.o

This allows building dct-test even if aandcttab.o is not pulled in by any enabled codec. The DCT with which these tables are used does not use them directly, so building it without the tables is possible. Signed-off-by: Mans Rullgard --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+

[libav-devel] [PATCH] x86: Use consistent 3dnowext function and macro name suffixes

Currently there is a wild mix of 3dn2/3dnow2/3dnowext. Switching to "3dnowext", which is a more common name of the CPU flag, as reported e.g. by the Linux kernel, unifies this. --- libavcodec/x86/dsputil_mmx.c| 14 ++-- libavcodec/x86/fft.c|6 ++-- libavcodec/x86/fft

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

On Wed, Aug 01, 2012 at 02:46:36PM +0200, Janne Grunau wrote: > On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: > > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote: > > > "Ronald S. Bultje" writes: > > > > On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun wrote: > > > > [..] > > > >

Re: [libav-devel] [PATCH] vp8: pack struct VP8ThreadData more efficiently

On 2012-08-01 14:01:11 +0100, Måns Rullgård wrote: > Reordering the members in this struct reduces the holes required > to maintain alignment. With this order, the only remaining, and > unavoidable, hole is 3 bytes following left_nnz. > > Signed-off-by: Mans Rullgard > --- > libavcodec/vp8.h |

Re: [libav-devel] [PATCH] vp8: pack struct VP8ThreadData more efficiently

On Wed, Aug 01, 2012 at 02:01:11PM +0100, Mans Rullgard wrote: > Reordering the members in this struct reduces the holes required > to maintain alignment. With this order, the only remaining, and > unavoidable, hole is 3 bytes following left_nnz. > > Signed-off-by: Mans Rullgard > --- > libavco

Re: [libav-devel] [PATCH 01/45] x86: Use consistent 3dnowext file/function/macro name suffixes

On 2012-08-01 00:17:25 +0200, Diego Biurrun wrote: > Currently there is a wild mix of 3dn2/3dnow2/3dnowext. Switching to > "3dnowext", which is the actual name of the CPU flag unifies this. define "actual name" it is the same name as the linux kernel reports in /proc/cpuinfo which is also just a

[libav-devel] [PATCH] vp8: pack struct VP8ThreadData more efficiently

Reordering the members in this struct reduces the holes required to maintain alignment. With this order, the only remaining, and unavoidable, hole is 3 bytes following left_nnz. Signed-off-by: Mans Rullgard --- libavcodec/vp8.h | 34 +- 1 file changed, 17 inserti

Re: [libav-devel] [PATCH 02/45] x86: build: replace mmx2 by mmxext

On 2012-08-01 01:33:47 +0200, Diego Biurrun wrote: > On Wed, Aug 01, 2012 at 12:00:58AM +0100, Måns Rullgård wrote: > > "Ronald S. Bultje" writes: > > > On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun wrote: > > > [..] > > > > > > The most important thing is missing: why? > > > > mmxext is a some

Re: [libav-devel] [RFC] doxy for internal API

On 8/1/2012 5:48 PM, an...@khirnov.net wrote: [...] If there indeed are people who read generated doxy for non-public API, s/ for non-public API// ;P I'd like them to speak up and prove their existence. Speaking as a user, I just open the header file and read the relevant part. (Also from

[libav-devel] [PATCH] x86: Refactor PSWAPD fallback implementations and port to cpuflags

--- libavcodec/x86/fft_mmx.asm| 19 --- libavcodec/x86/fmtconvert.asm | 17 ++--- libavutil/x86/x86util.asm | 12 3 files changed, 18 insertions(+), 30 deletions(-) diff --git a/libavcodec/x86/fft_mmx.asm b/libavcodec/x86/fft_mmx.asm index cf

  1   2   >